<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][8097] trunk: When demoting a member in a group, delete corresponding promotion notifications</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/8097">8097</a></dd>
<dt>Author</dt> <dd>boonebgorges</dd>
<dt>Date</dt> <dd>2014-03-09 19:37:47 +0000 (Sun, 09 Mar 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>When demoting a member in a group, delete corresponding promotion notifications
See <a href="http://buddypress.trac.wordpress.org/ticket/5289">#5289</a>
Props imath</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpgroupsbpgroupsnotificationsphp">trunk/bp-groups/bp-groups-notifications.php</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkteststestcasesgroupsnotificationsphp">trunk/tests/testcases/groups/notifications.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpgroupsbpgroupsnotificationsphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-groups/bp-groups-notifications.php (8096 => 8097)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-groups/bp-groups-notifications.php 2014-03-09 19:35:16 UTC (rev 8096)
+++ trunk/bp-groups/bp-groups-notifications.php 2014-03-09 19:37:47 UTC (rev 8097)
</span><span class="lines">@@ -555,11 +555,24 @@
</span><span class="cx"> function bp_groups_delete_group_delete_all_notifications( $group_id ) {
</span><span class="cx"> if ( bp_is_active( 'notifications' ) ) {
</span><span class="cx"> bp_notifications_delete_all_notifications_by_type( $group_id, buddypress()->groups->id );
</span><del>- }
</del><ins>+ }
</ins><span class="cx"> }
</span><span class="cx"> add_action( 'groups_delete_group', 'bp_groups_delete_group_delete_all_notifications', 10 );
</span><span class="cx">
</span><span class="cx"> /**
</span><ins>+ * When a demotion takes place, delete any corresponding promotion notifications.
+ *
+ * @since BuddyPress (2.0.0)
+ */
+function bp_groups_delete_promotion_notifications( $user_id = 0, $group_id = 0 ) {
+ if ( bp_is_active( 'notifications' ) && ! empty( $group_id ) && ! empty( $user_id ) ) {
+ bp_notifications_delete_notifications_by_item_id( $user_id, $group_id, buddypress()->groups->id, 'member_promoted_to_admin' );
+ bp_notifications_delete_notifications_by_item_id( $user_id, $group_id, buddypress()->groups->id, 'member_promoted_to_mod' );
+ }
+}
+add_action( 'groups_demoted_member', 'bp_groups_delete_promotion_notifications', 10, 2 );
+
+/**
</ins><span class="cx"> * Mark notifications read when a member accepts a group invitation
</span><span class="cx"> *
</span><span class="cx"> * @since BuddyPress (1.9.0)
</span></span></pre></div>
<a id="trunkteststestcasesgroupsnotificationsphp"></a>
<div class="addfile"><h4>Added: trunk/tests/testcases/groups/notifications.php (0 => 8097)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/tests/testcases/groups/notifications.php (rev 0)
+++ trunk/tests/testcases/groups/notifications.php 2014-03-09 19:37:47 UTC (rev 8097)
</span><span class="lines">@@ -0,0 +1,64 @@
</span><ins>+<?php
+
+/**
+ * @group groups
+ * @group notifications
+ */
+class BP_Tests_Groups_Notifications extends BP_UnitTestCase {
+ /**
+ * @group bp_groups_delete_promotion_notifications
+ */
+ public function test_bp_groups_delete_promotion_notifications() {
+ // Dummy group and user IDs
+ $u = 5;
+ $g = 12;
+
+ // Admin
+ $n = $this->factory->notification->create( array(
+ 'component_name' => 'groups',
+ 'user_id' => $u,
+ 'item_id' => $g,
+ 'component_action' => 'member_promoted_to_admin',
+ ) );
+
+ $notifications = BP_Notifications_Notification::get( array(
+ 'user_id' => $u,
+ ) );
+
+ // Double check it's there
+ $this->assertEquals( array( $n ), wp_list_pluck( $notifications, 'id' ) );
+
+ // fire the hook
+ do_action( 'groups_demoted_member', $u, $g );
+
+ $notifications = BP_Notifications_Notification::get( array(
+ 'user_id' => $u,
+ ) );
+
+ $this->assertEmpty( $notifications );
+
+ // Mod
+ $n = $this->factory->notification->create( array(
+ 'component_name' => 'groups',
+ 'user_id' => $u,
+ 'item_id' => $g,
+ 'component_action' => 'member_promoted_to_mod',
+ ) );
+
+ $notifications = BP_Notifications_Notification::get( array(
+ 'user_id' => $u,
+ ) );
+
+ // Double check it's there
+ $this->assertEquals( array( $n ), wp_list_pluck( $notifications, 'id' ) );
+
+ // fire the hook
+ do_action( 'groups_demoted_member', $u, $g );
+
+ $notifications = BP_Notifications_Notification::get( array(
+ 'user_id' => $u,
+ ) );
+
+ $this->assertEmpty( $notifications );
+ }
+}
</ins></span></pre>
</div>
</div>
</body>
</html>