<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][8047] trunk/bp-core/bp-core-classes.php: Add object caching when fetching a single user's last activity.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/8047">8047</a></dd>
<dt>Author</dt> <dd>r-a-y</dd>
<dt>Date</dt> <dd>2014-03-05 18:11:16 +0000 (Wed, 05 Mar 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add object caching when fetching a single user's last activity.
Previously, BP_Core_User::get_last_activity() was not being cached.
This resulted in an unnecessary query being run on every page load due
to the usage of bp_core_record_activity() on the 'wp_head' action.
This commit caches calls to BP_Core_User::get_last_activity() when a
single user ID is passed and resets the cache when the user's last
activity is updated on BP_Core_User::update_last_activity().
See <a href="http://buddypress.trac.wordpress.org/ticket/5128">#5128</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpcorebpcoreclassesphp">trunk/bp-core/bp-core-classes.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpcorebpcoreclassesphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-core/bp-core-classes.php (8046 => 8047)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-core/bp-core-classes.php 2014-03-05 15:35:17 UTC (rev 8046)
+++ trunk/bp-core/bp-core-classes.php 2014-03-05 18:11:16 UTC (rev 8047)
</span><span class="lines">@@ -1339,6 +1339,15 @@
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ // get cache for single user only
+ if ( ! is_array( $user_id ) ) {
+ $cache = wp_cache_get( $user_id, 'bp_last_activity' );
+
+ if ( false !== $cache ) {
+ return $cache;
+ }
+ }
+
</ins><span class="cx"> $bp = buddypress();
</span><span class="cx">
</span><span class="cx"> $user_ids_sql = implode( ',', $user_ids );
</span><span class="lines">@@ -1376,24 +1385,9 @@
</span><span class="cx">
</span><span class="cx"> $table_name = buddypress()->members->table_name_last_activity;
</span><span class="cx">
</span><del>- $existing = self::get_last_activity( $user_id );
</del><ins>+ $activity = self::get_last_activity( $user_id );
</ins><span class="cx">
</span><del>- if ( ! empty( $existing ) ) {
- $data = array(
- 'date_recorded' => $time,
- );
-
- $data_format = array(
- '%s',
- );
-
- $where = array(
- );
-
- $where_format = array(
- '%d',
- );
-
</del><ins>+ if ( ! empty( $activity ) ) {
</ins><span class="cx"> $updated = $wpdb->update(
</span><span class="cx"> $table_name,
</span><span class="cx">
</span><span class="lines">@@ -1404,7 +1398,7 @@
</span><span class="cx">
</span><span class="cx"> // WHERE
</span><span class="cx"> array(
</span><del>- 'id' => $existing[ $user_id ]['activity_id'],
</del><ins>+ 'id' => $activity[ $user_id ]['activity_id'],
</ins><span class="cx"> ),
</span><span class="cx">
</span><span class="cx"> // Data sanitization format
</span><span class="lines">@@ -1417,6 +1411,10 @@
</span><span class="cx"> '%d',
</span><span class="cx"> )
</span><span class="cx"> );
</span><ins>+
+ // add new date to existing activity entry for caching
+ $activity[ $user_id ]['date_recorded'] = $time;
+
</ins><span class="cx"> } else {
</span><span class="cx"> $updated = $wpdb->insert(
</span><span class="cx"> $table_name,
</span><span class="lines">@@ -1445,8 +1443,20 @@
</span><span class="cx"> '%s',
</span><span class="cx"> )
</span><span class="cx"> );
</span><ins>+
+ // setup activity array for caching
+ // view the foreach loop in the get_last_activity() method for format
+ $activity = array();
+ $activity[ $user_id ] = array(
+ 'user_id' => $user_id,
+ 'date_recorded' => $time,
+ 'activity_id' => $wpdb->insert_id,
+ );
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+ // set cache
+ wp_cache_set( $user_id, $activity, 'bp_last_activity' );
+
</ins><span class="cx"> return $updated;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -1482,6 +1492,8 @@
</span><span class="cx"> )
</span><span class="cx"> );
</span><span class="cx">
</span><ins>+ wp_cache_delete( $user_id, 'bp_last_activity' );
+
</ins><span class="cx"> return $deleted;
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>