<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][8021] trunk: xProfile: change the field visibility JS to show/hide the controls immediately, rather than with a slide/fade transition.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/8021">8021</a></dd>
<dt>Author</dt> <dd>djpaul</dd>
<dt>Date</dt> <dd>2014-03-02 19:32:27 +0000 (Sun, 02 Mar 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>xProfile: change the field visibility JS to show/hide the controls immediately, rather than with a slide/fade transition.
This helps improve the perceived performance of the visibility
controls. The code quality of these parts of the JS has also been
improved.
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/5439">#5439</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbploaderphp">trunk/bp-loader.php</a></li>
<li><a href="#trunkbpmembersadminjsadminjs">trunk/bp-members/admin/js/admin.js</a></li>
<li><a href="#trunkbptemplatesbplegacyjsbuddypressjs">trunk/bp-templates/bp-legacy/js/buddypress.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbploaderphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-loader.php (8020 => 8021)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-loader.php 2014-03-02 16:39:43 UTC (rev 8020)
+++ trunk/bp-loader.php 2014-03-02 19:32:27 UTC (rev 8021)
</span><span class="lines">@@ -303,7 +303,7 @@
</span><span class="cx">
</span><span class="cx"> /** Versions **************************************************/
</span><span class="cx">
</span><del>- $this->version = '2.0-alpha-7752';
</del><ins>+ $this->version = '2.0-alpha-8020';
</ins><span class="cx"> $this->db_version = 7892;
</span><span class="cx">
</span><span class="cx"> /** Loading ***************************************************/
</span></span></pre></div>
<a id="trunkbpmembersadminjsadminjs"></a>
<div class="modfile"><h4>Modified: trunk/bp-members/admin/js/admin.js (8020 => 8021)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-members/admin/js/admin.js 2014-03-02 16:39:43 UTC (rev 8020)
+++ trunk/bp-members/admin/js/admin.js 2014-03-02 19:32:27 UTC (rev 8021)
</span><span class="lines">@@ -1,34 +1,26 @@
</span><del>-(function( $ ) {
</del><ins>+( function( $ ) {
+ // Profile Visibility Settings
</ins><span class="cx">
</span><del>- /** Profile Visibility Settings *********************************/
- $('.visibility-toggle-link').on( 'click', function( event ) {
-
</del><ins>+ $( '.visibility-toggle-link' ).on( 'click', function( event ) {
</ins><span class="cx"> event.preventDefault();
</span><span class="cx">
</span><del>- var toggle_div = $(this).parent();
-
- $(toggle_div).fadeOut( 600, function(){
- $(toggle_div).siblings('.field-visibility-settings').slideDown(400);
- });
-
</del><ins>+ $( this ).parent().hide()
+ .siblings( '.field-visibility-settings' ).show();
</ins><span class="cx"> } );
</span><span class="cx">
</span><del>- $('.field-visibility-settings-close').on( 'click', function( event ) {
-
</del><ins>+ $( '.field-visibility-settings-close' ).on( 'click', function( event ) {
</ins><span class="cx"> event.preventDefault();
</span><span class="cx">
</span><del>- var settings_div = $(this).parent();
- var vis_setting_text = settings_div.find('input:checked').parent().text();
</del><ins>+ var settings_div = $(this).parent(),
+ vis_setting_text = settings_div.find( 'input:checked' ).parent().text();
</ins><span class="cx">
</span><del>- settings_div.slideUp( 400, function() {
- settings_div.siblings('.field-visibility-settings-toggle').fadeIn(800);
- settings_div.siblings('.field-visibility-settings-toggle').children('.current-visibility-level').html(vis_setting_text);
- } );
-
- return false;
</del><ins>+ settings_div.hide()
+ .siblings( '.field-visibility-settings-toggle' )
+ .children( '.current-visibility-level' ).text( vis_setting_text ).end()
+ .show();
</ins><span class="cx"> } );
</span><span class="cx">
</span><del>-})(jQuery);
</del><ins>+} )( jQuery );
</ins><span class="cx">
</span><span class="cx">
</span><span class="cx"> /**
</span></span></pre></div>
<a id="trunkbptemplatesbplegacyjsbuddypressjs"></a>
<div class="modfile"><h4>Modified: trunk/bp-templates/bp-legacy/js/buddypress.js (8020 => 8021)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-templates/bp-legacy/js/buddypress.js 2014-03-02 16:39:43 UTC (rev 8020)
+++ trunk/bp-templates/bp-legacy/js/buddypress.js 2014-03-02 19:32:27 UTC (rev 8021)
</span><span class="lines">@@ -965,27 +965,23 @@
</span><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> /** Profile Visibility Settings *********************************/
</span><del>- jq('.field-visibility-settings').hide();
- jq('.visibility-toggle-link').on( 'click', function() {
- var toggle_div = jq(this).parent();
</del><ins>+ jq( '.visibility-toggle-link' ).on( 'click', function( event ) {
+ event.preventDefault();
</ins><span class="cx">
</span><del>- jq(toggle_div).fadeOut( 600, function(){
- jq(toggle_div).siblings('.field-visibility-settings').slideDown(400);
- });
-
- return false;
</del><ins>+ jq( this ).parent().hide()
+ .siblings( '.field-visibility-settings' ).show();
</ins><span class="cx"> } );
</span><span class="cx">
</span><del>- jq('.field-visibility-settings-close').on( 'click', function() {
- var settings_div = jq(this).parent();
- var vis_setting_text = settings_div.find('input:checked').parent().text();
</del><ins>+ jq( '.field-visibility-settings-close' ).on( 'click', function( event ) {
+ event.preventDefault();
</ins><span class="cx">
</span><del>- settings_div.slideUp( 400, function() {
- settings_div.siblings('.field-visibility-settings-toggle').fadeIn(800);
- settings_div.siblings('.field-visibility-settings-toggle').children('.current-visibility-level').html(vis_setting_text);
- } );
</del><ins>+ var settings_div = jq( this ).parent(),
+ vis_setting_text = settings_div.find( 'input:checked' ).parent().text();
</ins><span class="cx">
</span><del>- return false;
</del><ins>+ settings_div.hide()
+ .siblings( '.field-visibility-settings-toggle' )
+ .children( '.current-visibility-level' ).text( vis_setting_text ).end()
+ .show();
</ins><span class="cx"> } );
</span><span class="cx">
</span><span class="cx"> jq("#profile-edit-form input:not(:submit), #profile-edit-form textarea, #profile-edit-form select, #signup_form input:not(:submit), #signup_form textarea, #signup_form select").change( function() {
</span></span></pre>
</div>
</div>
</body>
</html>