<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][8011] trunk: When updating meta cache for a group of items, make sure empty values are cached</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/8011">8011</a></dd>
<dt>Author</dt> <dd>boonebgorges</dd>
<dt>Date</dt> <dd>2014-03-01 02:30:53 +0000 (Sat, 01 Mar 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>When updating meta cache for a group of items, make sure empty values are cached
When updating the meta cache for, say, a group of activity items, it's possible
that some activity items won't have any metadata associated with them. In these
cases, we follow WP's update_meta_cache() by caching an empty array for that
item, so as to avoid cache misses.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpcorebpcorecachephp">trunk/bp-core/bp-core-cache.php</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkteststestcasescorecachephp">trunk/tests/testcases/core/cache.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpcorebpcorecachephp"></a>
<div class="modfile"><h4>Modified: trunk/bp-core/bp-core-cache.php (8010 => 8011)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-core/bp-core-cache.php 2014-03-01 00:35:18 UTC (rev 8010)
+++ trunk/bp-core/bp-core-cache.php 2014-03-01 02:30:53 UTC (rev 8011)
</span><span class="lines">@@ -231,8 +231,13 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- foreach ( $cache as $object_id => $cache_val ) {
- wp_cache_set( $object_id, $cache_val, $cache_group );
</del><ins>+ foreach ( $uncached_ids as $uncached_id ) {
+ // Cache empty values as well
+ if ( ! isset( $cache[ $uncached_id ] ) ) {
+ $cache[ $uncached_id ] = array();
+ }
+
+ wp_cache_set( $uncached_id, $cache[ $uncached_id ], $cache_group );
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkteststestcasescorecachephp"></a>
<div class="addfile"><h4>Added: trunk/tests/testcases/core/cache.php (0 => 8011)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/tests/testcases/core/cache.php (rev 0)
+++ trunk/tests/testcases/core/cache.php 2014-03-01 02:30:53 UTC (rev 8011)
</span><span class="lines">@@ -0,0 +1,30 @@
</span><ins>+<?php
+
+/**
+ * @group cache
+ * @group core
+ */
+class BP_Tests_Core_Cache extends BP_UnitTestCase {
+ /**
+ * @group bp_update_meta_cache
+ */
+ public function test_bp_update_meta_cache_with_cache_misses() {
+ // Use activity just because
+ $a1 = $this->factory->activity->create();
+
+ // Confirm that all activitymeta is deleted
+ global $wpdb, $bp;
+ $wpdb->query( $wpdb->prepare( "DELETE FROM {$bp->activity->table_name_meta} WHERE activity_id = %d", $a1 ) );
+
+ bp_update_meta_cache( array(
+ 'object_ids' => array( $a1 ),
+ 'object_type' => 'activity',
+ 'cache_group' => 'activity_meta',
+ 'meta_table' => buddypress()->activity->table_name_meta,
+ 'object_column' => 'activity_id',
+ ) );
+
+ $this->assertSame( array(), wp_cache_get( $a1, 'activity_meta' ) );
+ }
+}
+
</ins></span></pre>
</div>
</div>
</body>
</html>