<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][7976] trunk/bp-groups/bp-groups-classes.php: Inline doc, code formatting, and micro-optimizations to `BP_Groups_Group::populate()`.</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/7976">7976</a></dd>
<dt>Author</dt> <dd>johnjamesjacoby</dd>
<dt>Date</dt> <dd>2014-02-24 02:08:24 +0000 (Mon, 24 Feb 2014)</dd>
</dl>

<h3>Log Message</h3>
<pre>Inline doc, code formatting, and micro-optimizations to `BP_Groups_Group::populate()`.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpgroupsbpgroupsclassesphp">trunk/bp-groups/bp-groups-classes.php</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpgroupsbpgroupsclassesphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-groups/bp-groups-classes.php (7975 => 7976)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-groups/bp-groups-classes.php    2014-02-23 23:11:33 UTC (rev 7975)
+++ trunk/bp-groups/bp-groups-classes.php       2014-02-24 02:08:24 UTC (rev 7976)
</span><span class="lines">@@ -174,18 +174,26 @@
</span><span class="cx">   * Set up data about the current group.
</span><span class="cx">   */
</span><span class="cx">  public function populate() {
</span><del>-               global $wpdb, $bp;
</del><ins>+                global $wpdb;
</ins><span class="cx"> 
</span><ins>+               // Get BuddyPress
+               $bp    = buddypress();
+
+               // Check cache for group data
</ins><span class="cx">           $group = wp_cache_get( $this->id, 'bp_groups' );
</span><ins>+
+               // Cache missed, so query the DB
</ins><span class="cx">           if ( false === $group ) {
</span><span class="cx">                  $group = $wpdb->get_row( $wpdb->prepare( "SELECT g.* FROM {$bp->groups->table_name} g WHERE g.id = %d", $this->id ) );
</span><span class="cx">          }
</span><span class="cx"> 
</span><del>-               if ( empty( $group ) ) {
</del><ins>+                // No group found so set the ID and bail
+               if ( empty( $group ) || is_wp_error( $group ) ) {
</ins><span class="cx">                   $this->id = 0;
</span><span class="cx">                  return;
</span><span class="cx">          }
</span><span class="cx"> 
</span><ins>+               // Group found so setup the object variables
</ins><span class="cx">           $this->id           = $group->id;
</span><span class="cx">          $this->creator_id   = $group->creator_id;
</span><span class="cx">          $this->name         = stripslashes( $group->name );
</span><span class="lines">@@ -195,38 +203,44 @@
</span><span class="cx">          $this->enable_forum = $group->enable_forum;
</span><span class="cx">          $this->date_created = $group->date_created;
</span><span class="cx"> 
</span><ins>+               // Are we getting extra group data?
</ins><span class="cx">           if ( ! empty( $this->args['populate_extras'] ) ) {
</span><del>-                       $this->last_activity      = groups_get_groupmeta( $this->id, 'last_activity' );
</del><ins>+
+                       // Set up some specific group vars from meta
+                       $this->last_activity      = groups_get_groupmeta( $this->id, 'last_activity'      );
</ins><span class="cx">                   $this->total_member_count = groups_get_groupmeta( $this->id, 'total_member_count' );
</span><span class="cx"> 
</span><span class="cx">                  // Get group admins and mods
</span><span class="cx">                  $admin_mods = $wpdb->get_results( apply_filters( 'bp_group_admin_mods_user_join_filter', $wpdb->prepare( "SELECT u.ID as user_id, u.user_login, u.user_email, u.user_nicename, m.is_admin, m.is_mod FROM {$wpdb->users} u, {$bp->groups->table_name_members} m WHERE u.ID = m.user_id AND m.group_id = %d AND ( m.is_admin = 1 OR m.is_mod = 1 )", $this->id ) ) );
</span><span class="cx"> 
</span><ins>+                       // Add admins and moderators to their respective arrays
</ins><span class="cx">                   foreach ( (array) $admin_mods as $user ) {
</span><del>-                               if ( (int) $user->is_admin ) {
</del><ins>+                                if ( !empty( $user->is_admin ) ) {
</ins><span class="cx">                                   $this->admins[] = $user;
</span><span class="cx">                          } else {
</span><span class="cx">                                  $this->mods[] = $user;
</span><span class="cx">                          }
</span><span class="cx">                  }
</span><span class="cx"> 
</span><del>-                       // Cache general (non-user-specific)
-                       // information about the group
</del><ins>+                        // Cache the group object before user-specific data is added
</ins><span class="cx">                   wp_cache_set( $this->id, $this, 'bp_groups' );
</span><del>-               }
</del><span class="cx"> 
</span><del>-               // Set user-specific data
-               if ( ! empty( $this->args['populate_extras'] ) ) {
-                       $this->is_member  = BP_Groups_Member::check_is_member( bp_loggedin_user_id(), $this->id );
-                       $this->is_invited = BP_Groups_Member::check_has_invite( bp_loggedin_user_id(), $this->id );
-                       $this->is_pending = BP_Groups_Member::check_for_membership_request( bp_loggedin_user_id(), $this->id );
</del><ins>+                        // Set user-specific data
+                       $user_id          = bp_loggedin_user_id();
+                       $this->is_member  = BP_Groups_Member::check_is_member( $user_id, $this->id );
+                       $this->is_invited = BP_Groups_Member::check_has_invite( $user_id, $this->id );
+                       $this->is_pending = BP_Groups_Member::check_for_membership_request( $user_id, $this->id );
</ins><span class="cx"> 
</span><span class="cx">                  // If this is a private or hidden group, does the current user have access?
</span><del>-                       if ( 'private' == $this->status || 'hidden' == $this->status ) {
-                               if ( $this->is_member && is_user_logged_in() || bp_current_user_can( 'bp_moderate' ) )
</del><ins>+                        if ( ( 'private' === $this->status ) || ( 'hidden' === $this->status ) ) {
+
+                               // Assume user does not have access to hidden/private groups
+                               $this->user_has_access = false;
+
+                               // Group members or community moderators have access
+                               if ( ( $this->is_member && is_user_logged_in() ) || bp_current_user_can( 'bp_moderate' ) ) {
</ins><span class="cx">                                   $this->user_has_access = true;
</span><del>-                               else
-                                       $this->user_has_access = false;
</del><ins>+                                }
</ins><span class="cx">                   } else {
</span><span class="cx">                          $this->user_has_access = true;
</span><span class="cx">                  }
</span></span></pre>
</div>
</div>

</body>
</html>