<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][7911] trunk/bp-members/bp-members-functions.php: Remove object cache for bp_core_get_user_domain() function.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/7911">7911</a></dd>
<dt>Author</dt> <dd>r-a-y</dd>
<dt>Date</dt> <dd>2014-02-17 08:27:26 +0000 (Mon, 17 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove object cache for bp_core_get_user_domain() function.
This caused issues when using a persistent object cache and when the
members directory page slug was changed in the admin area.
Because bp_core_get_user_domain() has its own object cache that is
keyed to each individual user, cache invalidation becomes troublesome.
Since we are already caching the username, this makes caching the
user domain redundant. Thus, this commit removes the object
cache associated with the bp_core_get_user_domain() function, while
leaving the 'bp_core_get_user_domain_pre_cache' filter in place for
backwards compatibility.
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/5402">#5402</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpmembersbpmembersfunctionsphp">trunk/bp-members/bp-members-functions.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpmembersbpmembersfunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-members/bp-members-functions.php (7910 => 7911)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-members/bp-members-functions.php 2014-02-17 08:10:44 UTC (rev 7910)
+++ trunk/bp-members/bp-members-functions.php 2014-02-17 08:27:26 UTC (rev 7911)
</span><span class="lines">@@ -124,24 +124,22 @@
</span><span class="cx"> */
</span><span class="cx"> function bp_core_get_user_domain( $user_id, $user_nicename = false, $user_login = false ) {
</span><span class="cx">
</span><del>- if ( empty( $user_id ) )
</del><ins>+ if ( empty( $user_id ) ) {
</ins><span class="cx"> return;
</span><ins>+ }
</ins><span class="cx">
</span><del>- if ( !$domain = wp_cache_get( 'bp_user_domain_' . $user_id, 'bp' ) ) {
- $username = bp_core_get_username( $user_id, $user_nicename, $user_login );
</del><ins>+ $username = bp_core_get_username( $user_id, $user_nicename, $user_login );
</ins><span class="cx">
</span><del>- if ( bp_is_username_compatibility_mode() )
- $username = rawurlencode( $username );
</del><ins>+ if ( bp_is_username_compatibility_mode() ) {
+ $username = rawurlencode( $username );
+ }
</ins><span class="cx">
</span><del>- $after_domain = bp_core_enable_root_profiles() ? $username : bp_get_members_root_slug() . '/' . $username;
- $domain = trailingslashit( bp_get_root_domain() . '/' . $after_domain );
- $domain = apply_filters( 'bp_core_get_user_domain_pre_cache', $domain, $user_id, $user_nicename, $user_login );
</del><ins>+ $after_domain = bp_core_enable_root_profiles() ? $username : bp_get_members_root_slug() . '/' . $username;
+ $domain = trailingslashit( bp_get_root_domain() . '/' . $after_domain );
</ins><span class="cx">
</span><del>- // Cache the link
- if ( !empty( $domain ) ) {
- wp_cache_set( 'bp_user_domain_' . $user_id, $domain, 'bp' );
- }
- }
</del><ins>+ // Don't use this filter. Subject to removal in a future release.
+ // Use the 'bp_core_get_user_domain' filter instead.
+ $domain = apply_filters( 'bp_core_get_user_domain_pre_cache', $domain, $user_id, $user_nicename, $user_login );
</ins><span class="cx">
</span><span class="cx"> return apply_filters( 'bp_core_get_user_domain', $domain, $user_id, $user_nicename, $user_login );
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>