<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][7903] trunk: Don't prime groupmeta cache in BP_Groups_Group::__construct()</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/7903">7903</a></dd>
<dt>Author</dt> <dd>boonebgorges</dd>
<dt>Date</dt> <dd>2014-02-17 00:35:26 +0000 (Mon, 17 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Don't prime groupmeta cache in BP_Groups_Group::__construct()
groups_get_groupmeta() now uses the core API functions. get_metadata() works by
priming the cache with *all* object metadata when requesting any piece of
metadata for that object. This means that, instead of pre-fetching groupmeta
when instantiating BP_Groups_Group, we wait until it happens in get_metadata().
At best, this can help us to avoid pre-fetching a meta cache that will not be
used.
See <a href="http://buddypress.trac.wordpress.org/ticket/5398">#5398</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpgroupsbpgroupsclassesphp">trunk/bp-groups/bp-groups-classes.php</a></li>
<li><a href="#trunkbpgroupsbpgroupsfunctionsphp">trunk/bp-groups/bp-groups-functions.php</a></li>
<li><a href="#trunkteststestcasesgroupsfunctionsphp">trunk/tests/testcases/groups/functions.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpgroupsbpgroupsclassesphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-groups/bp-groups-classes.php (7902 => 7903)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-groups/bp-groups-classes.php 2014-02-17 00:35:24 UTC (rev 7902)
+++ trunk/bp-groups/bp-groups-classes.php 2014-02-17 00:35:26 UTC (rev 7903)
</span><span class="lines">@@ -175,10 +175,6 @@
</span><span class="cx"> global $wpdb, $bp;
</span><span class="cx">
</span><span class="cx"> if ( $group = $wpdb->get_row( $wpdb->prepare( "SELECT g.* FROM {$bp->groups->table_name} g WHERE g.id = %d", $this->id ) ) ) {
</span><del>- if ( ! empty( $this->args['update_meta_cache'] ) ) {
- bp_groups_update_meta_cache( $this->id );
- }
-
</del><span class="cx"> $this->id = $group->id;
</span><span class="cx"> $this->creator_id = $group->creator_id;
</span><span class="cx"> $this->name = stripslashes($group->name);
</span></span></pre></div>
<a id="trunkbpgroupsbpgroupsfunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-groups/bp-groups-functions.php (7902 => 7903)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-groups/bp-groups-functions.php 2014-02-17 00:35:24 UTC (rev 7902)
+++ trunk/bp-groups/bp-groups-functions.php 2014-02-17 00:35:26 UTC (rev 7903)
</span><span class="lines">@@ -44,7 +44,6 @@
</span><span class="cx"> 'group_id' => false,
</span><span class="cx"> 'load_users' => false,
</span><span class="cx"> 'populate_extras' => true,
</span><del>- 'update_meta_cache' => true,
</del><span class="cx"> );
</span><span class="cx">
</span><span class="cx"> $args = wp_parse_args( $args, $defaults );
</span><span class="lines">@@ -55,7 +54,6 @@
</span><span class="cx"> if ( !$group = wp_cache_get( $cache_key, 'bp' ) ) {
</span><span class="cx"> $group_args = array(
</span><span class="cx"> 'populate_extras' => $populate_extras,
</span><del>- 'update_meta_cache' => $update_meta_cache,
</del><span class="cx"> );
</span><span class="cx">
</span><span class="cx"> $group = new BP_Groups_Group( $group_id, $group_args );
</span></span></pre></div>
<a id="trunkteststestcasesgroupsfunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/tests/testcases/groups/functions.php (7902 => 7903)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/tests/testcases/groups/functions.php 2014-02-17 00:35:24 UTC (rev 7902)
+++ trunk/tests/testcases/groups/functions.php 2014-02-17 00:35:26 UTC (rev 7903)
</span><span class="lines">@@ -437,7 +437,25 @@
</span><span class="cx">
</span><span class="cx"> /**
</span><span class="cx"> * @group groupmeta
</span><ins>+ * @group groups_get_groupmeta
+ * @group cache
</ins><span class="cx"> */
</span><ins>+ public function test_groups_get_groupmeta_cache_all_on_get() {
+ $g = $this->factory->group->create();
+ groups_add_groupmeta( $g, 'foo', 'bar' );
+ groups_add_groupmeta( $g, 'foo1', 'baz' );
+ $this->assertFalse( wp_cache_get( $g, 'group_meta' ) );
+
+ // A single query should prime the whole meta cache
+ groups_get_groupmeta( $g, 'foo' );
+
+ $c = wp_cache_get( $g, 'group_meta' );
+ $this->assertNotEmpty( $c['foo1'] );
+ }
+
+ /**
+ * @group groupmeta
+ */
</ins><span class="cx"> public function test_groups_delete_groupmeta_non_numeric_id() {
</span><span class="cx"> $this->assertFalse( groups_delete_groupmeta( 'foo', 'bar' ) );
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>