<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][7894] trunk/bp-groups: Add update_meta_cache param for BP_Groups_Group stack</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/7894">7894</a></dd>
<dt>Author</dt> <dd>boonebgorges</dd>
<dt>Date</dt> <dd>2014-02-16 21:33:01 +0000 (Sun, 16 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add update_meta_cache param for BP_Groups_Group stack
This allows us to avoid unneeded meta cache pre-fetching, following WP_Query.
See <a href="http://buddypress.trac.wordpress.org/ticket/5398">#5398</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpgroupsbpgroupsclassesphp">trunk/bp-groups/bp-groups-classes.php</a></li>
<li><a href="#trunkbpgroupsbpgroupsfunctionsphp">trunk/bp-groups/bp-groups-functions.php</a></li>
<li><a href="#trunkbpgroupsbpgroupstemplatephp">trunk/bp-groups/bp-groups-template.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpgroupsbpgroupsclassesphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-groups/bp-groups-classes.php (7893 => 7894)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-groups/bp-groups-classes.php 2014-02-16 21:25:05 UTC (rev 7893)
+++ trunk/bp-groups/bp-groups-classes.php 2014-02-16 21:33:01 UTC (rev 7894)
</span><span class="lines">@@ -609,6 +609,7 @@
</span><span class="cx"> 'meta_query' => false,
</span><span class="cx"> 'include' => false,
</span><span class="cx"> 'populate_extras' => true,
</span><ins>+ 'update_meta_cache' => true,
</ins><span class="cx"> 'exclude' => false,
</span><span class="cx"> 'show_hidden' => false,
</span><span class="cx"> );
</span><span class="lines">@@ -773,7 +774,9 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Grab all groupmeta
</span><del>- bp_groups_update_meta_cache( $group_ids );
</del><ins>+ if ( ! empty( $r['update_meta_cache'] ) ) {
+ bp_groups_update_meta_cache( $group_ids );
+ }
</ins><span class="cx">
</span><span class="cx"> unset( $sql, $total_sql );
</span><span class="cx">
</span></span></pre></div>
<a id="trunkbpgroupsbpgroupsfunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-groups/bp-groups-functions.php (7893 => 7894)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-groups/bp-groups-functions.php 2014-02-16 21:25:05 UTC (rev 7893)
+++ trunk/bp-groups/bp-groups-functions.php 2014-02-16 21:33:01 UTC (rev 7894)
</span><span class="lines">@@ -447,6 +447,7 @@
</span><span class="cx"> 'per_page' => 20, // The number of results to return per page
</span><span class="cx"> 'page' => 1, // The page to return if limiting per page
</span><span class="cx"> 'populate_extras' => true, // Fetch meta such as is_banned and is_member
</span><ins>+ 'update_meta_cache' => true, // Pre-fetch groupmeta for queried groups
</ins><span class="cx"> );
</span><span class="cx">
</span><span class="cx"> $r = wp_parse_args( $args, $defaults );
</span><span class="lines">@@ -462,6 +463,7 @@
</span><span class="cx"> 'per_page' => $r['per_page'],
</span><span class="cx"> 'page' => $r['page'],
</span><span class="cx"> 'populate_extras' => $r['populate_extras'],
</span><ins>+ 'update_meta_cache' => $r['update_meta_cache'],
</ins><span class="cx"> 'order' => $r['order'],
</span><span class="cx"> 'orderby' => $r['orderby'],
</span><span class="cx"> ) );
</span></span></pre></div>
<a id="trunkbpgroupsbpgroupstemplatephp"></a>
<div class="modfile"><h4>Modified: trunk/bp-groups/bp-groups-template.php (7893 => 7894)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-groups/bp-groups-template.php 2014-02-16 21:25:05 UTC (rev 7893)
+++ trunk/bp-groups/bp-groups-template.php 2014-02-16 21:33:01 UTC (rev 7894)
</span><span class="lines">@@ -143,7 +143,8 @@
</span><span class="cx"> 'exclude' => false,
</span><span class="cx"> 'search_terms' => '',
</span><span class="cx"> 'meta_query' => false,
</span><del>- 'populate_extras' => true
</del><ins>+ 'populate_extras' => true,
+ 'update_meta_cache' => true,
</ins><span class="cx"> );
</span><span class="cx">
</span><span class="cx"> $r = wp_parse_args( $args, $defaults );
</span><span class="lines">@@ -174,6 +175,7 @@
</span><span class="cx"> 'include' => $include,
</span><span class="cx"> 'exclude' => $exclude,
</span><span class="cx"> 'populate_extras' => $populate_extras,
</span><ins>+ 'update_meta_cache' => $update_meta_cache,
</ins><span class="cx"> 'show_hidden' => $show_hidden
</span><span class="cx"> ) );
</span><span class="cx"> }
</span><span class="lines">@@ -328,6 +330,7 @@
</span><span class="cx"> 'exclude' => false, // Pass comma separated list or array of group ID's to exclude these groups
</span><span class="cx">
</span><span class="cx"> 'populate_extras' => true, // Get extra meta - is_member, is_banned
</span><ins>+ 'update_meta_cache' => true,
</ins><span class="cx"> );
</span><span class="cx">
</span><span class="cx"> $r = wp_parse_args( $args, $defaults );
</span><span class="lines">@@ -356,7 +359,8 @@
</span><span class="cx"> 'meta_query' => $r['meta_query'],
</span><span class="cx"> 'include' => $r['include'],
</span><span class="cx"> 'exclude' => $r['exclude'],
</span><del>- 'populate_extras' => (bool) $r['populate_extras']
</del><ins>+ 'populate_extras' => (bool) $r['populate_extras'],
+ 'update_meta_cache' => (bool) $r['update_meta_cache'],
</ins><span class="cx"> ) );
</span><span class="cx">
</span><span class="cx"> return apply_filters( 'bp_has_groups', $groups_template->has_groups(), $groups_template, $r );
</span></span></pre>
</div>
</div>
</body>
</html>