<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][7885] trunk: Add support for prev_value param to _update_meta() functions</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/7885">7885</a></dd>
<dt>Author</dt> <dd>boonebgorges</dd>
<dt>Date</dt> <dd>2014-02-14 19:21:52 +0000 (Fri, 14 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add support for prev_value param to _update_meta() functions
This parameter, inherited from update_metadata(), allows you to limit your
updates only to rows where the meta_value matches your specified prev_value.
See <a href="http://buddypress.trac.wordpress.org/ticket/5400">#5400</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpactivitybpactivityfunctionsphp">trunk/bp-activity/bp-activity-functions.php</a></li>
<li><a href="#trunkbpblogsbpblogsfunctionsphp">trunk/bp-blogs/bp-blogs-functions.php</a></li>
<li><a href="#trunkbpgroupsbpgroupsfunctionsphp">trunk/bp-groups/bp-groups-functions.php</a></li>
<li><a href="#trunkbpxprofilebpxprofilefunctionsphp">trunk/bp-xprofile/bp-xprofile-functions.php</a></li>
<li><a href="#trunkteststestcasesactivityfunctionsphp">trunk/tests/testcases/activity/functions.php</a></li>
<li><a href="#trunkteststestcasesblogsfunctionsphp">trunk/tests/testcases/blogs/functions.php</a></li>
<li><a href="#trunkteststestcasesgroupsfunctionsphp">trunk/tests/testcases/groups/functions.php</a></li>
<li><a href="#trunkteststestcasesxprofilefunctionsphp">trunk/tests/testcases/xprofile/functions.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpactivitybpactivityfunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-activity/bp-activity-functions.php (7884 => 7885)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-activity/bp-activity-functions.php 2014-02-14 19:03:40 UTC (rev 7884)
+++ trunk/bp-activity/bp-activity-functions.php 2014-02-14 19:21:52 UTC (rev 7885)
</span><span class="lines">@@ -652,12 +652,16 @@
</span><span class="cx"> *
</span><span class="cx"> * @since BuddyPress (1.2)
</span><span class="cx"> *
</span><del>- * @param int $activity_id ID of the activity item whose metadata is being updated.
</del><ins>+ * @param int $activity_id ID of the activity item whose metadata is being
+ * updated.
</ins><span class="cx"> * @param string $meta_key Key of the metadata being updated.
</span><span class="cx"> * @param mixed $meta_value Value to be set.
</span><ins>+ * @param mixed $prev_value Optional. If specified, only update existing
+ * metadata entries with the specified value. Otherwise, update all
+ * entries.
</ins><span class="cx"> * @return bool True on success, false on failure.
</span><span class="cx"> */
</span><del>-function bp_activity_update_meta( $activity_id, $meta_key, $meta_value ) {
</del><ins>+function bp_activity_update_meta( $activity_id, $meta_key, $meta_value, $prev_value = '' ) {
</ins><span class="cx">
</span><span class="cx"> // Legacy - Make sure activity_id is valid
</span><span class="cx"> if ( ! is_numeric( $activity_id ) ) {
</span><span class="lines">@@ -668,7 +672,7 @@
</span><span class="cx"> $meta_key = preg_replace( '|[^a-z0-9_]|i', '', $meta_key );
</span><span class="cx">
</span><span class="cx"> add_filter( 'query', 'bp_filter_metaid_column_name' );
</span><del>- $retval = update_metadata( 'activity', $activity_id, $meta_key, $meta_value );
</del><ins>+ $retval = update_metadata( 'activity', $activity_id, $meta_key, $meta_value, $prev_value );
</ins><span class="cx"> remove_filter( 'query', 'bp_filter_metaid_column_name' );
</span><span class="cx">
</span><span class="cx"> // Legacy - return true if we fall through to add_metadata()
</span></span></pre></div>
<a id="trunkbpblogsbpblogsfunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-blogs/bp-blogs-functions.php (7884 => 7885)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-blogs/bp-blogs-functions.php 2014-02-14 19:03:40 UTC (rev 7884)
+++ trunk/bp-blogs/bp-blogs-functions.php 2014-02-14 19:21:52 UTC (rev 7885)
</span><span class="lines">@@ -921,15 +921,18 @@
</span><span class="cx"> * @param int $blog_id ID of the blog whose metadata is being updated.
</span><span class="cx"> * @param string $meta_key Key of the metadata being updated.
</span><span class="cx"> * @param mixed $meta_value Value to be set.
</span><ins>+ * @param mixed $prev_value Optional. If specified, only update existing
+ * metadata entries with the specified value. Otherwise, update all
+ * entries.
</ins><span class="cx"> * @return bool True on success, false on failure.
</span><span class="cx"> */
</span><del>-function bp_blogs_update_blogmeta( $blog_id, $meta_key, $meta_value ) {
</del><ins>+function bp_blogs_update_blogmeta( $blog_id, $meta_key, $meta_value, $prev_value = '' ) {
</ins><span class="cx">
</span><span class="cx"> // Legacy - Sanitize meta_key
</span><span class="cx"> $meta_key = preg_replace( '|[^a-z0-9_]|i', '', $meta_key );
</span><span class="cx">
</span><span class="cx"> add_filter( 'query', 'bp_filter_metaid_column_name' );
</span><del>- $retval = update_metadata( 'blog', $blog_id, $meta_key, $meta_value );
</del><ins>+ $retval = update_metadata( 'blog', $blog_id, $meta_key, $meta_value, $prev_value );
</ins><span class="cx"> remove_filter( 'query', 'bp_filter_metaid_column_name' );
</span><span class="cx">
</span><span class="cx"> // Legacy - New items fall through to add_metadata(). Return true
</span></span></pre></div>
<a id="trunkbpgroupsbpgroupsfunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-groups/bp-groups-functions.php (7884 => 7885)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-groups/bp-groups-functions.php 2014-02-14 19:03:40 UTC (rev 7884)
+++ trunk/bp-groups/bp-groups-functions.php 2014-02-14 19:21:52 UTC (rev 7885)
</span><span class="lines">@@ -1040,12 +1040,15 @@
</span><span class="cx"> * @param int $group_id ID of the group.
</span><span class="cx"> * @param string $meta_key Metadata key.
</span><span class="cx"> * @param mixed $meta_value Value to store.
</span><ins>+ * @param mixed $prev_value Optional. If specified, only update existing
+ * metadata entries with the specified value. Otherwise, update all
+ * entries.
</ins><span class="cx"> * @return bool True on success, false on failure.
</span><span class="cx"> */
</span><del>-function groups_update_groupmeta( $group_id, $meta_key, $meta_value ) {
</del><ins>+function groups_update_groupmeta( $group_id, $meta_key, $meta_value, $prev_value = '' ) {
</ins><span class="cx">
</span><span class="cx"> add_filter( 'query', 'bp_filter_metaid_column_name' );
</span><del>- $retval = update_metadata( 'group', $group_id, $meta_key, $meta_value );
</del><ins>+ $retval = update_metadata( 'group', $group_id, $meta_key, $meta_value, $prev_value );
</ins><span class="cx"> remove_filter( 'query', 'bp_filter_metaid_column_name' );
</span><span class="cx">
</span><span class="cx"> // Legacy - return true if we fall through to add_metadata()
</span></span></pre></div>
<a id="trunkbpxprofilebpxprofilefunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-xprofile/bp-xprofile-functions.php (7884 => 7885)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-xprofile/bp-xprofile-functions.php 2014-02-14 19:03:40 UTC (rev 7884)
+++ trunk/bp-xprofile/bp-xprofile-functions.php 2014-02-14 19:21:52 UTC (rev 7885)
</span><span class="lines">@@ -633,16 +633,19 @@
</span><span class="cx"> * @param string $object_type Type of object. 'group', 'field', or 'data'.
</span><span class="cx"> * @param string $meta_key Key of the metadata being updated.
</span><span class="cx"> * @param mixed $meta_value Value of the metadata being updated.
</span><ins>+ * @param mixed $prev_value Optional. If specified, only update existing
+ * metadata entries with the specified value. Otherwise, update all
+ * entries.
</ins><span class="cx"> * @return bool True on success, false on failure.
</span><span class="cx"> */
</span><del>-function bp_xprofile_update_meta( $object_id, $object_type, $meta_key, $meta_value ) {
</del><ins>+function bp_xprofile_update_meta( $object_id, $object_type, $meta_key, $meta_value, $prev_value = '' ) {
</ins><span class="cx">
</span><span class="cx"> // Legacy - sanitize meta_key
</span><span class="cx"> $meta_key = preg_replace( '|[^a-z0-9_]|i', '', $meta_key );
</span><span class="cx">
</span><span class="cx"> add_filter( 'query', 'bp_filter_metaid_column_name' );
</span><span class="cx"> add_filter( 'query', 'bp_xprofile_filter_meta_query' );
</span><del>- $retval = update_metadata( 'xprofile_' . $object_type, $object_id, $meta_key, $meta_value );
</del><ins>+ $retval = update_metadata( 'xprofile_' . $object_type, $object_id, $meta_key, $meta_value, $prev_value );
</ins><span class="cx"> remove_filter( 'query', 'bp_xprofile_filter_meta_query' );
</span><span class="cx"> remove_filter( 'query', 'bp_filter_metaid_column_name' );
</span><span class="cx">
</span></span></pre></div>
<a id="trunkteststestcasesactivityfunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/tests/testcases/activity/functions.php (7884 => 7885)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/tests/testcases/activity/functions.php 2014-02-14 19:03:40 UTC (rev 7884)
+++ trunk/tests/testcases/activity/functions.php 2014-02-14 19:21:52 UTC (rev 7885)
</span><span class="lines">@@ -193,6 +193,17 @@
</span><span class="cx">
</span><span class="cx"> /**
</span><span class="cx"> * @group activitymeta
</span><ins>+ * @group bp_activity_update_meta
+ */
+ public function test_bp_activity_update_meta_prev_value() {
+ $a = $this->factory->activity->create();
+ bp_activity_add_meta( $a, 'foo', 'bar' );
+ $this->assertFalse( bp_activity_update_meta( $a, 'foo', 'bar2', 'baz' ) );
+ $this->assertTrue( bp_activity_update_meta( $a, 'foo', 'bar2', 'bar' ) );
+ }
+
+ /**
+ * @group activitymeta
</ins><span class="cx"> * @group bp_activity_get_meta
</span><span class="cx"> */
</span><span class="cx"> public function test_bp_activity_get_meta_empty_activity_id() {
</span></span></pre></div>
<a id="trunkteststestcasesblogsfunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/tests/testcases/blogs/functions.php (7884 => 7885)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/tests/testcases/blogs/functions.php 2014-02-14 19:03:40 UTC (rev 7884)
+++ trunk/tests/testcases/blogs/functions.php 2014-02-14 19:21:52 UTC (rev 7885)
</span><span class="lines">@@ -185,7 +185,7 @@
</span><span class="cx">
</span><span class="cx"> /**
</span><span class="cx"> * @group blogmeta
</span><del>- * @group bp_blogs_update_groupmeta
</del><ins>+ * @group bp_blogs_update_blogmeta
</ins><span class="cx"> */
</span><span class="cx"> public function test_bp_blogs_update_blogmeta_new() {
</span><span class="cx"> $this->assertTrue( bp_blogs_update_blogmeta( 1, 'foo', 'bar' ) );
</span><span class="lines">@@ -194,7 +194,7 @@
</span><span class="cx">
</span><span class="cx"> /**
</span><span class="cx"> * @group blogmeta
</span><del>- * @group bp_blogs_update_groupmeta
</del><ins>+ * @group bp_blogs_update_blogmeta
</ins><span class="cx"> */
</span><span class="cx"> public function test_bp_blogs_update_blogmeta_existing() {
</span><span class="cx"> bp_blogs_update_blogmeta( 1, 'foo', 'bar' );
</span><span class="lines">@@ -205,7 +205,7 @@
</span><span class="cx">
</span><span class="cx"> /**
</span><span class="cx"> * @group blogmeta
</span><del>- * @group bp_blogs_update_groupmeta
</del><ins>+ * @group bp_blogs_update_blogmeta
</ins><span class="cx"> */
</span><span class="cx"> public function test_bp_blogs_update_blogmeta_existing_no_change() {
</span><span class="cx"> bp_blogs_update_blogmeta( 1, 'foo', 'bar' );
</span><span class="lines">@@ -215,6 +215,16 @@
</span><span class="cx">
</span><span class="cx"> /**
</span><span class="cx"> * @group blogmeta
</span><ins>+ * @group bp_blogs_update_blogmeta
+ */
+ public function test_bp_blogs_update_meta_prev_value() {
+ bp_blogs_add_blogmeta( 1, 'foo', 'bar' );
+ $this->assertFalse( bp_blogs_update_blogmeta( 1, 'foo', 'bar2', 'baz' ) );
+ $this->assertTrue( bp_blogs_update_blogmeta( 1, 'foo', 'bar2', 'bar' ) );
+ }
+
+ /**
+ * @group blogmeta
</ins><span class="cx"> * @group bp_blogs_add_blogmeta
</span><span class="cx"> */
</span><span class="cx"> public function test_bp_blogs_add_blogmeta_no_meta_key() {
</span></span></pre></div>
<a id="trunkteststestcasesgroupsfunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/tests/testcases/groups/functions.php (7884 => 7885)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/tests/testcases/groups/functions.php 2014-02-14 19:03:40 UTC (rev 7884)
+++ trunk/tests/testcases/groups/functions.php 2014-02-14 19:21:52 UTC (rev 7885)
</span><span class="lines">@@ -336,6 +336,17 @@
</span><span class="cx">
</span><span class="cx"> /**
</span><span class="cx"> * @group groupmeta
</span><ins>+ * @group groups_update_groupmeta
+ */
+ public function test_groups_update_groupmeta_prev_value() {
+ $g = $this->factory->group->create();
+ groups_add_groupmeta( $g, 'foo', 'bar' );
+ $this->assertFalse( groups_update_groupmeta( $g, 'foo', 'bar2', 'baz' ) );
+ $this->assertTrue( groups_update_groupmeta( $g, 'foo', 'bar2', 'bar' ) );
+ }
+
+ /**
+ * @group groupmeta
</ins><span class="cx"> *
</span><span class="cx"> * @todo Why do we do this?
</span><span class="cx"> */
</span></span></pre></div>
<a id="trunkteststestcasesxprofilefunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/tests/testcases/xprofile/functions.php (7884 => 7885)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/tests/testcases/xprofile/functions.php 2014-02-14 19:03:40 UTC (rev 7884)
+++ trunk/tests/testcases/xprofile/functions.php 2014-02-14 19:21:52 UTC (rev 7885)
</span><span class="lines">@@ -442,6 +442,17 @@
</span><span class="cx">
</span><span class="cx"> /**
</span><span class="cx"> * @group xprofilemeta
</span><ins>+ * @group bp_xprofile_update_meta
+ */
+ public function test_bp_xprofile_update_meta_prev_value() {
+ $g = $this->factory->xprofile_group->create();
+ bp_xprofile_add_meta( $g, 'group', 'foo', 'bar' );
+ $this->assertFalse( bp_xprofile_update_meta( $g, 'group', 'foo', 'bar2', 'baz' ) );
+ $this->assertTrue( bp_xprofile_update_meta( $g, 'group', 'foo', 'bar2', 'bar' ) );
+ }
+
+ /**
+ * @group xprofilemeta
</ins><span class="cx"> * @group bp_xprofile_add_meta
</span><span class="cx"> */
</span><span class="cx"> public function test_bp_xprofile_add_meta_no_meta_key() {
</span></span></pre>
</div>
</div>
</body>
</html>