<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][7887] trunk/tests/testcases: Don't test prev_value return value on WP < 3.7</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/7887">7887</a></dd>
<dt>Author</dt> <dd>boonebgorges</dd>
<dt>Date</dt> <dd>2014-02-14 19:51:11 +0000 (Fri, 14 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Don't test prev_value return value on WP < 3.7
There was a bug prior to WP 3.7 that caused update_metadata() to return true
even when the update failed due to a 'prev_value' parameter not being matched.
Since this is not really a functionality issue, but is more about error
reporting, it doesn't affect end-user functionality in BP, except insofar as
the function will return an unexpected value in those cases. Instead of coming
up with an arcane workaround for these old versions, we'll just skip the tests
for the time being.
See https://core.trac.wordpress.org/ticket/24933 for background on the WP issue</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkteststestcasesactivityfunctionsphp">trunk/tests/testcases/activity/functions.php</a></li>
<li><a href="#trunkteststestcasesblogsfunctionsphp">trunk/tests/testcases/blogs/functions.php</a></li>
<li><a href="#trunkteststestcasesgroupsfunctionsphp">trunk/tests/testcases/groups/functions.php</a></li>
<li><a href="#trunkteststestcasesxprofilefunctionsphp">trunk/tests/testcases/xprofile/functions.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkteststestcasesactivityfunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/tests/testcases/activity/functions.php (7886 => 7887)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/tests/testcases/activity/functions.php 2014-02-14 19:35:15 UTC (rev 7886)
+++ trunk/tests/testcases/activity/functions.php 2014-02-14 19:51:11 UTC (rev 7887)
</span><span class="lines">@@ -198,7 +198,16 @@
</span><span class="cx"> public function test_bp_activity_update_meta_prev_value() {
</span><span class="cx"> $a = $this->factory->activity->create();
</span><span class="cx"> bp_activity_add_meta( $a, 'foo', 'bar' );
</span><del>- $this->assertFalse( bp_activity_update_meta( $a, 'foo', 'bar2', 'baz' ) );
</del><ins>+
+ // In earlier versions of WordPress, bp_activity_update_meta()
+ // returns true even on failure. However, we know that in these
+ // cases the update is failing as expected, so we skip this
+ // assertion just to keep our tests passing
+ // See https://core.trac.wordpress.org/ticket/24933
+ if ( version_compare( $GLOBALS['wp_version'], '3.7', '>=' ) ) {
+ $this->assertFalse( bp_activity_update_meta( $a, 'foo', 'bar2', 'baz' ) );
+ }
+
</ins><span class="cx"> $this->assertTrue( bp_activity_update_meta( $a, 'foo', 'bar2', 'bar' ) );
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkteststestcasesblogsfunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/tests/testcases/blogs/functions.php (7886 => 7887)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/tests/testcases/blogs/functions.php 2014-02-14 19:35:15 UTC (rev 7886)
+++ trunk/tests/testcases/blogs/functions.php 2014-02-14 19:51:11 UTC (rev 7887)
</span><span class="lines">@@ -219,7 +219,16 @@
</span><span class="cx"> */
</span><span class="cx"> public function test_bp_blogs_update_meta_prev_value() {
</span><span class="cx"> bp_blogs_add_blogmeta( 1, 'foo', 'bar' );
</span><del>- $this->assertFalse( bp_blogs_update_blogmeta( 1, 'foo', 'bar2', 'baz' ) );
</del><ins>+
+ // In earlier versions of WordPress, bp_activity_update_meta()
+ // returns true even on failure. However, we know that in these
+ // cases the update is failing as expected, so we skip this
+ // assertion just to keep our tests passing
+ // See https://core.trac.wordpress.org/ticket/24933
+ if ( version_compare( $GLOBALS['wp_version'], '3.7', '>=' ) ) {
+ $this->assertFalse( bp_blogs_update_blogmeta( 1, 'foo', 'bar2', 'baz' ) );
+ }
+
</ins><span class="cx"> $this->assertTrue( bp_blogs_update_blogmeta( 1, 'foo', 'bar2', 'bar' ) );
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkteststestcasesgroupsfunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/tests/testcases/groups/functions.php (7886 => 7887)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/tests/testcases/groups/functions.php 2014-02-14 19:35:15 UTC (rev 7886)
+++ trunk/tests/testcases/groups/functions.php 2014-02-14 19:51:11 UTC (rev 7887)
</span><span class="lines">@@ -341,7 +341,16 @@
</span><span class="cx"> public function test_groups_update_groupmeta_prev_value() {
</span><span class="cx"> $g = $this->factory->group->create();
</span><span class="cx"> groups_add_groupmeta( $g, 'foo', 'bar' );
</span><del>- $this->assertFalse( groups_update_groupmeta( $g, 'foo', 'bar2', 'baz' ) );
</del><ins>+
+ // In earlier versions of WordPress, bp_activity_update_meta()
+ // returns true even on failure. However, we know that in these
+ // cases the update is failing as expected, so we skip this
+ // assertion just to keep our tests passing
+ // See https://core.trac.wordpress.org/ticket/24933
+ if ( version_compare( $GLOBALS['wp_version'], '3.7', '>=' ) ) {
+ $this->assertFalse( groups_update_groupmeta( $g, 'foo', 'bar2', 'baz' ) );
+ }
+
</ins><span class="cx"> $this->assertTrue( groups_update_groupmeta( $g, 'foo', 'bar2', 'bar' ) );
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkteststestcasesxprofilefunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/tests/testcases/xprofile/functions.php (7886 => 7887)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/tests/testcases/xprofile/functions.php 2014-02-14 19:35:15 UTC (rev 7886)
+++ trunk/tests/testcases/xprofile/functions.php 2014-02-14 19:51:11 UTC (rev 7887)
</span><span class="lines">@@ -447,7 +447,16 @@
</span><span class="cx"> public function test_bp_xprofile_update_meta_prev_value() {
</span><span class="cx"> $g = $this->factory->xprofile_group->create();
</span><span class="cx"> bp_xprofile_add_meta( $g, 'group', 'foo', 'bar' );
</span><del>- $this->assertFalse( bp_xprofile_update_meta( $g, 'group', 'foo', 'bar2', 'baz' ) );
</del><ins>+
+ // In earlier versions of WordPress, bp_activity_update_meta()
+ // returns true even on failure. However, we know that in these
+ // cases the update is failing as expected, so we skip this
+ // assertion just to keep our tests passing
+ // See https://core.trac.wordpress.org/ticket/24933
+ if ( version_compare( $GLOBALS['wp_version'], '3.7', '>=' ) ) {
+ $this->assertFalse( bp_xprofile_update_meta( $g, 'group', 'foo', 'bar2', 'baz' ) );
+ }
+
</ins><span class="cx"> $this->assertTrue( bp_xprofile_update_meta( $g, 'group', 'foo', 'bar2', 'bar' ) );
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>