<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][7781] trunk/bp-xprofile: Add caching support for default xprofile field visibility settings</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/7781">7781</a></dd>
<dt>Author</dt> <dd>boonebgorges</dd>
<dt>Date</dt> <dd>2014-02-04 02:19:11 +0000 (Tue, 04 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add caching support for default xprofile field visibility settings
These settings rarely change, and so are good candidates for persistent caching
See <a href="http://buddypress.trac.wordpress.org/ticket/1332">#1332</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpxprofilebpxprofilecachephp">trunk/bp-xprofile/bp-xprofile-cache.php</a></li>
<li><a href="#trunkbpxprofilebpxprofileclassesphp">trunk/bp-xprofile/bp-xprofile-classes.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpxprofilebpxprofilecachephp"></a>
<div class="modfile"><h4>Modified: trunk/bp-xprofile/bp-xprofile-cache.php (7780 => 7781)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-xprofile/bp-xprofile-cache.php 2014-02-04 02:05:24 UTC (rev 7780)
+++ trunk/bp-xprofile/bp-xprofile-cache.php 2014-02-04 02:19:11 UTC (rev 7781)
</span><span class="lines">@@ -17,15 +17,27 @@
</span><span class="cx"> wp_cache_delete( 'xprofile_groups_inc_empty', 'bp' );
</span><span class="cx"> wp_cache_delete( 'xprofile_group_' . $group_obj->id, 'bp' );
</span><span class="cx"> }
</span><ins>+add_action( 'xprofile_groups_deleted_group', 'xprofile_clear_profile_groups_object_cache' );
+add_action( 'xprofile_groups_saved_group', 'xprofile_clear_profile_groups_object_cache' );
</ins><span class="cx">
</span><span class="cx"> function xprofile_clear_profile_data_object_cache( $group_id ) {
</span><span class="cx"> wp_cache_delete( 'bp_user_fullname_' . bp_loggedin_user_id(), 'bp' );
</span><span class="cx"> }
</span><ins>+add_action( 'xprofile_updated_profile', 'xprofile_clear_profile_data_object_cache' );
</ins><span class="cx">
</span><del>-// List actions to clear object caches on
-add_action( 'xprofile_groups_deleted_group', 'xprofile_clear_profile_groups_object_cache' );
-add_action( 'xprofile_groups_saved_group', 'xprofile_clear_profile_groups_object_cache' );
-add_action( 'xprofile_updated_profile', 'xprofile_clear_profile_data_object_cache' );
</del><ins>+/**
+ * Clear caches when a field object is modified.
+ *
+ * @since BuddyPress (2.0.0)
+ *
+ * @param BP_XProfile_Field
+ */
+function xprofile_clear_profile_field_object_cache( $field_obj ) {
+ // Clear default visibility level cache
+ wp_cache_delete( 'xprofile_default_visibility_levels', 'bp' );
+}
+add_action( 'xprofile_fields_saved_field', 'xprofile_clear_profile_field_object_cache' );
+add_aciton( 'xprofile_fields_deleted_field', 'xprofile_clear_profile_field_object_cache' );
</ins><span class="cx">
</span><span class="cx"> // List actions to clear super cached pages on, if super cache is installed
</span><span class="cx"> add_action( 'xprofile_updated_profile', 'bp_core_clear_cache' );
</span></span></pre></div>
<a id="trunkbpxprofilebpxprofileclassesphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-xprofile/bp-xprofile-classes.php (7780 => 7781)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-xprofile/bp-xprofile-classes.php 2014-02-04 02:05:24 UTC (rev 7780)
+++ trunk/bp-xprofile/bp-xprofile-classes.php 2014-02-04 02:19:11 UTC (rev 7781)
</span><span class="lines">@@ -388,26 +388,33 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span><del>- * Fetch the admin-set preferences for all fields
</del><ins>+ * Fetch the admin-set preferences for all fields.
</ins><span class="cx"> *
</span><del>- * @since BuddyPress (1.6)
</del><ins>+ * @since BuddyPress (1.6.0)
</ins><span class="cx"> *
</span><del>- * @return array $default_visibility_levels An array, keyed by field_id, of default
- * visibility level + allow_custom (whether the admin allows this field to be set by user)
</del><ins>+ * @return array $default_visibility_levels An array, keyed by
+ * field_id, of default visibility level + allow_custom
+ * (whether the admin allows this field to be set by user)
</ins><span class="cx"> */
</span><span class="cx"> public static function fetch_default_visibility_levels() {
</span><span class="cx"> global $wpdb, $bp;
</span><span class="cx">
</span><del>- $levels = $wpdb->get_results( "SELECT object_id, meta_key, meta_value FROM {$bp->profile->table_name_meta} WHERE object_type = 'field' AND ( meta_key = 'default_visibility' OR meta_key = 'allow_custom_visibility' )" );
</del><ins>+ $default_visibility_levels = wp_cache_get( 'xprofile_default_visibility_levels', 'bp' );
</ins><span class="cx">
</span><del>- // Arrange so that the field id is the key and the visibility level the value
- $default_visibility_levels = array();
- foreach( $levels as $level ) {
- if ( 'default_visibility' == $level->meta_key ) {
- $default_visibility_levels[$level->object_id]['default'] = $level->meta_value;
- } else if ( 'allow_custom_visibility' == $level->meta_key ) {
- $default_visibility_levels[$level->object_id]['allow_custom'] = $level->meta_value;
</del><ins>+ if ( false === $default_visibility_levels ) {
+ $levels = $wpdb->get_results( "SELECT object_id, meta_key, meta_value FROM {$bp->profile->table_name_meta} WHERE object_type = 'field' AND ( meta_key = 'default_visibility' OR meta_key = 'allow_custom_visibility' )" );
+
+ // Arrange so that the field id is the key and the visibility level the value
+ $default_visibility_levels = array();
+ foreach ( $levels as $level ) {
+ if ( 'default_visibility' == $level->meta_key ) {
+ $default_visibility_levels[ $level->object_id ]['default'] = $level->meta_value;
+ } else if ( 'allow_custom_visibility' == $level->meta_key ) {
+ $default_visibility_levels[ $level->object_id ]['allow_custom'] = $level->meta_value;
+ }
</ins><span class="cx"> }
</span><ins>+
+ wp_cache_set( 'xprofile_default_visibility_levels', $default_visibility_levels, 'bp' );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> return $default_visibility_levels;
</span></span></pre>
</div>
</div>
</body>
</html>