<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][7771] trunk/bp-activity: Use persistent cache for individual activity items</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/7771">7771</a></dd>
<dt>Author</dt> <dd>boonebgorges</dd>
<dt>Date</dt> <dd>2014-02-03 02:05:25 +0000 (Mon, 03 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Use persistent cache for individual activity items
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/5350">#5350</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpactivitybpactivitycachephp">trunk/bp-activity/bp-activity-cache.php</a></li>
<li><a href="#trunkbpactivitybpactivityclassesphp">trunk/bp-activity/bp-activity-classes.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpactivitybpactivitycachephp"></a>
<div class="modfile"><h4>Modified: trunk/bp-activity/bp-activity-cache.php (7770 => 7771)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-activity/bp-activity-cache.php 2014-02-02 19:35:15 UTC (rev 7770)
+++ trunk/bp-activity/bp-activity-cache.php 2014-02-03 02:05:25 UTC (rev 7771)
</span><span class="lines">@@ -53,3 +53,29 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> }
</span><ins>+
+/**
+ * Clear a cached activity item when that item is updated.
+ *
+ * @since 2.0
+ *
+ * @param BP_Activity_Activity $activity
+ */
+function bp_activity_clear_cache_for_activity( $activity ) {
+ wp_cache_delete( 'activity_' . $activity->id, 'bp' );
+}
+add_action( 'bp_activity_after_save', 'bp_activity_clear_cache_for_activity' );
+
+/**
+ * Clear cached data for deleted activity items.
+ *
+ * @since 2.0
+ *
+ * @param array $deleted_ids IDs of deleted activity items.
+ */
+function bp_activity_clear_cache_for_deleted_activity( $deleted_ids ) {
+ foreach ( (array) $deleted_ids as $deleted_id ) {
+ wp_cache_delete( 'activity_' . $deleted_id, 'bp' );
+ }
+}
+add_action( 'bp_activity_deleted_activities', 'bp_activity_clear_cache_for_deleted_activity' );
</ins></span></pre></div>
<a id="trunkbpactivitybpactivityclassesphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-activity/bp-activity-classes.php (7770 => 7771)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-activity/bp-activity-classes.php 2014-02-02 19:35:15 UTC (rev 7770)
+++ trunk/bp-activity/bp-activity-classes.php 2014-02-03 02:05:25 UTC (rev 7771)
</span><span class="lines">@@ -137,7 +137,13 @@
</span><span class="cx"> public function populate() {
</span><span class="cx"> global $wpdb, $bp;
</span><span class="cx">
</span><del>- if ( $row = $wpdb->get_row( $wpdb->prepare( "SELECT * FROM {$bp->activity->table_name} WHERE id = %d", $this->id ) ) ) {
</del><ins>+ $row = wp_cache_get( 'activity_' . $this->id, 'bp' );
+
+ if ( false === $row ) {
+ $row = $wpdb->get_row( $wpdb->prepare( "SELECT * FROM {$bp->activity->table_name} WHERE id = %d", $this->id ) );
+ }
+
+ if ( ! empty( $row ) ) {
</ins><span class="cx"> $this->id = $row->id;
</span><span class="cx"> $this->item_id = $row->item_id;
</span><span class="cx"> $this->secondary_item_id = $row->secondary_item_id;
</span><span class="lines">@@ -476,12 +482,43 @@
</span><span class="cx"> // Get BuddyPress
</span><span class="cx"> $bp = buddypress();
</span><span class="cx">
</span><del>- // Format the activity ID's for use in the query below
- $activity_ids_sql = implode( ',', wp_parse_id_list( $activity_ids ) );
</del><ins>+ $activities = array();
+ $query_aids = array();
</ins><span class="cx">
</span><del>- // First fetch data from activity table, preserving order
- $activities = $wpdb->get_results( "SELECT * FROM {$bp->activity->table_name} WHERE id IN ({$activity_ids_sql}) ORDER BY FIELD( id, {$activity_ids_sql} )");
</del><ins>+ foreach ( $activity_ids as $activity_id ) {
</ins><span class="cx">
</span><ins>+ // If cached data is found, use it
+ if ( $activity_data = wp_cache_get( 'activity_' . $activity_id, 'bp' ) ) {
+ $activities[ $activity_id ] = $activity_data;
+
+ // Otherwise leave a placeholder so we don't lose the order
+ } else {
+ $activities[ $activity_id ] = '';
+
+ // Add to the list to be queried
+ $query_aids[] = $activity_id;
+ }
+ }
+
+ // Fetch activity data from the DB if necessary
+ if ( ! empty( $query_aids ) ) {
+ // Format the activity ID's for use in the query below
+ $query_aids_sql = implode( ',', wp_parse_id_list( $query_aids ) );
+
+ // Fetch data from activity table, preserving order
+ $queried_adata = $wpdb->get_results( "SELECT * FROM {$bp->activity->table_name} WHERE id IN ({$query_aids_sql}) ORDER BY FIELD( id, {$query_aids_sql} )");
+
+ // Put that data into the placeholders created earlier,
+ // and add it to the cache
+ foreach ( (array) $queried_adata as $adata ) {
+ $activities[ $adata->id ] = $adata;
+ wp_cache_set( 'activity_' . $adata->id, $adata, 'bp' );
+ }
+ }
+
+ // Reset indexes
+ $activities = array_values( $activities );
+
</ins><span class="cx"> // Then fetch user data
</span><span class="cx"> $user_query = new BP_User_Query( array(
</span><span class="cx"> 'user_ids' => wp_list_pluck( $activities, 'user_id' ),
</span></span></pre>
</div>
</div>
</body>
</html>