<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][7687] branches/1.9/bp-notifications: Notifications:</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/7687">7687</a></dd>
<dt>Author</dt> <dd>johnjamesjacoby</dd>
<dt>Date</dt> <dd>2013-12-17 17:44:20 +0000 (Tue, 17 Dec 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Notifications:
Make `buddypress()->active_components` the default value for the `component_name` argument.
This is necessary because notifications are persistent in the database, and active components register callbacks for generating output based on the queried results. If notifications exist for components that are inactive, no callback will be registered, and the output will be empty. By only querying for active components, we can be sure no empty notifications will be displayed to the user.
Reverts <a href="http://buddypress.trac.wordpress.org/changeset/7677">r7677</a>. See <a href="http://buddypress.trac.wordpress.org/ticket/5290">#5290</a>. Fixes <a href="http://buddypress.trac.wordpress.org/ticket/5300">#5300</a>. (1.9 branch)</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branches19bpnotificationsbpnotificationsclassesphp">branches/1.9/bp-notifications/bp-notifications-classes.php</a></li>
<li><a href="#branches19bpnotificationsbpnotificationsfunctionsphp">branches/1.9/bp-notifications/bp-notifications-functions.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branches19bpnotificationsbpnotificationsclassesphp"></a>
<div class="modfile"><h4>Modified: branches/1.9/bp-notifications/bp-notifications-classes.php (7686 => 7687)</h4>
<pre class="diff"><span>
<span class="info">--- branches/1.9/bp-notifications/bp-notifications-classes.php 2013-12-17 17:37:08 UTC (rev 7686)
+++ branches/1.9/bp-notifications/bp-notifications-classes.php 2013-12-17 17:44:20 UTC (rev 7687)
</span><span class="lines">@@ -553,7 +553,7 @@
</span><span class="cx"> 'user_id' => false,
</span><span class="cx"> 'item_id' => false,
</span><span class="cx"> 'secondary_item_id' => false,
</span><del>- 'component_name' => false,
</del><ins>+ 'component_name' => array_keys( buddypress()->active_components ),
</ins><span class="cx"> 'component_action' => false,
</span><span class="cx"> 'is_new' => true,
</span><span class="cx"> 'search_terms' => '',
</span></span></pre></div>
<a id="branches19bpnotificationsbpnotificationsfunctionsphp"></a>
<div class="modfile"><h4>Modified: branches/1.9/bp-notifications/bp-notifications-functions.php (7686 => 7687)</h4>
<pre class="diff"><span>
<span class="info">--- branches/1.9/bp-notifications/bp-notifications-functions.php 2013-12-17 17:37:08 UTC (rev 7686)
+++ branches/1.9/bp-notifications/bp-notifications-functions.php 2013-12-17 17:44:20 UTC (rev 7687)
</span><span class="lines">@@ -123,8 +123,7 @@
</span><span class="cx"> // Setup local variables
</span><span class="cx"> $bp = buddypress();
</span><span class="cx"> $notifications = BP_Notifications_Notification::get( array(
</span><del>- 'user_id' => $user_id,
- 'component_name' => array_keys( $bp->active_components ),
</del><ins>+ 'user_id' => $user_id
</ins><span class="cx"> ) );
</span><span class="cx"> $grouped_notifications = array(); // Notification groups
</span><span class="cx"> $renderable = array(); // Renderable notifications
</span></span></pre>
</div>
</div>
</body>
</html>