<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][7569] trunk: Sound the knell for the BuddyPress Default theme</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/7569">7569</a></dd>
<dt>Author</dt> <dd>boonebgorges</dd>
<dt>Date</dt> <dd>2013-11-13 02:47:20 +0000 (Wed, 13 Nov 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Sound the knell for the BuddyPress Default theme
bp-default is being sunsetted as of BP 1.9. The theme will continue to receive
security updates and other critical fixes, but will otherwise no longer be
under active development by the core team.
We maintain backward compatibility with sites currently using bp-default by
continuing to register the bp-themes theme directory when bp-default, or a
child theme thereof, is in use on a given site. Those sites will continue to
be able to use the theme. Installations where bp-default is not already in use
will no longer see it listed on Dashboard > Appearance.
Site administrators or developers who want to override this behavior may do so
with the 'bp_do_register_theme_directory' filter. Please note that bp-themes
will be removed altogether from BuddyPress in a future version, likely migrated
to wordpress.org/extend. See <a href="http://buddypress.trac.wordpress.org/ticket/5212">#5212</a>.
> Now cracks a noble heart. Good-night, sweet prince;
> And flights of angels sing thee to thy rest.
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/5223">#5223</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpcorebpcorefunctionsphp">trunk/bp-core/bp-core-functions.php</a></li>
<li><a href="#trunkbploaderphp">trunk/bp-loader.php</a></li>
<li><a href="#trunkbpthemesbpdefaultstylecss">trunk/bp-themes/bp-default/style.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpcorebpcorefunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-core/bp-core-functions.php (7568 => 7569)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-core/bp-core-functions.php 2013-11-13 02:16:51 UTC (rev 7568)
+++ trunk/bp-core/bp-core-functions.php 2013-11-13 02:47:20 UTC (rev 7569)
</span><span class="lines">@@ -532,6 +532,18 @@
</span><span class="cx"> update_site_option( 'illegal_names', get_site_option( 'illegal_names' ), array() );
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+/**
+ * Determine whether BuddyPress should register the bp-themes directory.
+ *
+ * @since BuddyPress (1.9.0)
+ *
+ * @return bool True if bp-themes should be registered, false otherwise.
+ */
+function bp_do_register_theme_directory() {
+ $register = 'bp-default' === get_stylesheet() || 'bp-default' === get_template();
+ return apply_filters( 'bp_do_register_theme_directory', $register );
+}
+
</ins><span class="cx"> /** URI ***********************************************************************/
</span><span class="cx">
</span><span class="cx"> /**
</span></span></pre></div>
<a id="trunkbploaderphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-loader.php (7568 => 7569)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-loader.php 2013-11-13 02:16:51 UTC (rev 7568)
+++ trunk/bp-loader.php 2013-11-13 02:47:20 UTC (rev 7569)
</span><span class="lines">@@ -524,12 +524,24 @@
</span><span class="cx"> /** Public Methods ********************************************************/
</span><span class="cx">
</span><span class="cx"> /**
</span><del>- * Setup the BuddyPress theme directory
</del><ins>+ * Set up BuddyPress's legacy theme directory.
</ins><span class="cx"> *
</span><del>- * @since BuddyPress (1.5)
- * @todo Move bp-default to wordpress.org/extend/themes and remove this
</del><ins>+ * Starting with version 1.2, and ending with version 1.8, BuddyPress
+ * registered a custom theme directory - bp-themes - which contained
+ * the bp-default theme. Since BuddyPress 1.9, bp-themes is no longer
+ * registered (and bp-default no longer offered) on new installations.
+ * Sites using bp-default (or a child theme of bp-default) will
+ * continue to have bp-themes registered as before.
+ *
+ * @since BuddyPress (1.5.0)
+ *
+ * @todo Move bp-default to wordpress.org/extend/themes and remove this.
</ins><span class="cx"> */
</span><span class="cx"> public function register_theme_directory() {
</span><ins>+ if ( ! bp_do_register_theme_directory() ) {
+ return;
+ }
+
</ins><span class="cx"> register_theme_directory( $this->old_themes_dir );
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkbpthemesbpdefaultstylecss"></a>
<div class="modfile"><h4>Modified: trunk/bp-themes/bp-default/style.css (7568 => 7569)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-themes/bp-default/style.css 2013-11-13 02:16:51 UTC (rev 7568)
+++ trunk/bp-themes/bp-default/style.css 2013-11-13 02:47:20 UTC (rev 7569)
</span><span class="lines">@@ -1,7 +1,7 @@
</span><span class="cx"> /**
</span><span class="cx"> * Theme Name: BuddyPress Default
</span><span class="cx"> * Theme URI: http://buddypress.org/extend/themes/
</span><del>- * Description: Clean and stylish, BuddyPress Default lets you build a social network straight out of the box. Make it yours with a custom menu, header image, and background. Along with five widgetized areas (one in the sidebar, four in the footer), BP-Default supports featured images (as custom header images on posts and pages) and is furnished with an optional one-column page template that removes the sidebar, and a stylesheet for the admin Visual Editor.
</del><ins>+ * Description: [NOTE: except for security issues, BuddyPress Default is no longer being actively maintained by the BuddyPress team.] Clean and stylish, BuddyPress Default lets you build a social network straight out of the box. Make it yours with a custom menu, header image, and background. Along with five widgetized areas (one in the sidebar, four in the footer), BP-Default supports featured images (as custom header images on posts and pages) and is furnished with an optional one-column page template that removes the sidebar, and a stylesheet for the admin Visual Editor.
</ins><span class="cx"> * Version: 1.8
</span><span class="cx"> * Author: the BuddyPress team
</span><span class="cx"> * Author URI: http://buddypress.org
</span><span class="lines">@@ -9,8 +9,10 @@
</span><span class="cx"> * License URI: license.txt
</span><span class="cx"> * Tags: blue, buddypress, custom-background, custom-header, custom-menu, editor-style, featured-image-header, featured-images, fixed-width, light, right-sidebar, rtl-language-support, sticky-post, threaded-comments, translation-ready, two-columns, white
</span><span class="cx"> *
</span><del>- *** IMPORTANT - DO NOT COPY THIS THEME **
</del><ins>+ *** IMPORTANT ***
</ins><span class="cx"> *
</span><ins>+ * BuddyPress Default is no longer being actively developed by the BuddyPress team.
+ *
</ins><span class="cx"> * If you want to make a custom theme based on this theme, DO NOT copy and edit it. By
</span><span class="cx"> * doing this you will make updates and maintainence much harder for yourself.
</span><span class="cx"> * Instead, please read this codex page on how to build a BuddyPress child theme:
</span></span></pre>
</div>
</div>
</body>
</html>