<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][7545] trunk/bp-notifications: No humility.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/7545">7545</a></dd>
<dt>Author</dt> <dd>johnjamesjacoby</dd>
<dt>Date</dt> <dd>2013-11-09 15:16:01 +0000 (Sat, 09 Nov 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>No humility. Bump notifications menu and navigation position to below `Profile`, and ensure that custom notifications toolbar menu now links to new notifications page for logged in user. See <a href="http://buddypress.trac.wordpress.org/ticket/5148">#5148</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpnotificationsbpnotificationsadminbarphp">trunk/bp-notifications/bp-notifications-adminbar.php</a></li>
<li><a href="#trunkbpnotificationsbpnotificationsloaderphp">trunk/bp-notifications/bp-notifications-loader.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpnotificationsbpnotificationsadminbarphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-notifications/bp-notifications-adminbar.php (7544 => 7545)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-notifications/bp-notifications-adminbar.php 2013-11-09 14:59:16 UTC (rev 7544)
+++ trunk/bp-notifications/bp-notifications-adminbar.php 2013-11-09 15:16:01 UTC (rev 7545)
</span><span class="lines">@@ -28,13 +28,14 @@
</span><span class="cx"> $count = ! empty( $notifications ) ? count( $notifications ) : 0;
</span><span class="cx"> $alert_class = (int) $count > 0 ? 'pending-count alert' : 'count no-alert';
</span><span class="cx"> $menu_title = '<span id="ab-pending-notifications" class="' . $alert_class . '">' . $count . '</span>';
</span><ins>+ $menu_link = trailingslashit( bp_loggedin_user_domain() . bp_get_notifications_slug() );
</ins><span class="cx">
</span><span class="cx"> // Add the top-level Notifications button
</span><span class="cx"> $wp_admin_bar->add_menu( array(
</span><span class="cx"> 'parent' => 'top-secondary',
</span><span class="cx"> 'id' => 'bp-notifications',
</span><span class="cx"> 'title' => $menu_title,
</span><del>- 'href' => bp_loggedin_user_domain(),
</del><ins>+ 'href' => $menu_link,
</ins><span class="cx"> ) );
</span><span class="cx">
</span><span class="cx"> if ( ! empty( $notifications ) ) {
</span><span class="lines">@@ -51,7 +52,7 @@
</span><span class="cx"> 'parent' => 'bp-notifications',
</span><span class="cx"> 'id' => 'no-notifications',
</span><span class="cx"> 'title' => __( 'No new notifications', 'buddypress' ),
</span><del>- 'href' => bp_loggedin_user_domain(),
</del><ins>+ 'href' => $menu_link,
</ins><span class="cx"> ) );
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkbpnotificationsbpnotificationsloaderphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-notifications/bp-notifications-loader.php (7544 => 7545)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-notifications/bp-notifications-loader.php 2013-11-09 14:59:16 UTC (rev 7544)
+++ trunk/bp-notifications/bp-notifications-loader.php 2013-11-09 15:16:01 UTC (rev 7545)
</span><span class="lines">@@ -26,7 +26,7 @@
</span><span class="cx"> __( 'Notifications', 'buddypress' ),
</span><span class="cx"> BP_PLUGIN_DIR,
</span><span class="cx"> array(
</span><del>- 'adminbar_myaccount_order' => 100
</del><ins>+ 'adminbar_myaccount_order' => 30
</ins><span class="cx"> )
</span><span class="cx"> );
</span><span class="cx"> }
</span><span class="lines">@@ -108,7 +108,7 @@
</span><span class="cx"> $main_nav = array(
</span><span class="cx"> 'name' => sprintf( __( 'Notifications <span>%d</span>', 'buddypress' ), number_format_i18n( $count ) ),
</span><span class="cx"> 'slug' => $this->slug,
</span><del>- 'position' => 60,
</del><ins>+ 'position' => 30,
</ins><span class="cx"> 'screen_function' => 'bp_notifications_screen_unread',
</span><span class="cx"> 'default_subnav_slug' => 'unread',
</span><span class="cx"> 'item_css_id' => $this->id,
</span></span></pre>
</div>
</div>
</body>
</html>