<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][7536] trunk/bp-notifications: Coding standards compliance in bp-notifications</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/7536">7536</a></dd>
<dt>Author</dt> <dd>boonebgorges</dd>
<dt>Date</dt> <dd>2013-11-08 12:34:27 +0000 (Fri, 08 Nov 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Coding standards compliance in bp-notifications</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpnotificationsbpnotificationsclassesphp">trunk/bp-notifications/bp-notifications-classes.php</a></li>
<li><a href="#trunkbpnotificationsbpnotificationsfunctionsphp">trunk/bp-notifications/bp-notifications-functions.php</a></li>
<li><a href="#trunkbpnotificationsbpnotificationstemplatephp">trunk/bp-notifications/bp-notifications-template.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpnotificationsbpnotificationsclassesphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-notifications/bp-notifications-classes.php (7535 => 7536)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-notifications/bp-notifications-classes.php 2013-11-08 06:15:20 UTC (rev 7535)
+++ trunk/bp-notifications/bp-notifications-classes.php 2013-11-08 12:34:27 UTC (rev 7536)
</span><span class="lines">@@ -722,19 +722,19 @@
</span><span class="cx"> 'user_id' => $user_id,
</span><span class="cx"> );
</span><span class="cx">
</span><del>- if ( !empty( $item_id ) ) {
</del><ins>+ if ( ! empty( $item_id ) ) {
</ins><span class="cx"> $where_args['item_id'] = $item_id;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if ( !empty( $component_name ) ) {
</del><ins>+ if ( ! empty( $component_name ) ) {
</ins><span class="cx"> $where_args['component_name'] = $component_name;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if ( !empty( $component_action ) ) {
</del><ins>+ if ( ! empty( $component_action ) ) {
</ins><span class="cx"> $where_args['component_action'] = $component_action;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if ( !empty( $secondary_item_id ) ) {
</del><ins>+ if ( ! empty( $secondary_item_id ) ) {
</ins><span class="cx"> $where_args['secondary_item_id'] = $secondary_item_id;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -761,15 +761,15 @@
</span><span class="cx"> 'item_id' => $user_id,
</span><span class="cx"> );
</span><span class="cx">
</span><del>- if ( !empty( $component_name ) ) {
</del><ins>+ if ( ! empty( $component_name ) ) {
</ins><span class="cx"> $where_args['component_name'] = $component_name;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if ( !empty( $component_action ) ) {
</del><ins>+ if ( ! empty( $component_action ) ) {
</ins><span class="cx"> $where_args['component_action'] = $component_action;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if ( !empty( $secondary_item_id ) ) {
</del><ins>+ if ( ! empty( $secondary_item_id ) ) {
</ins><span class="cx"> $where_args['secondary_item_id'] = $secondary_item_id;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -803,15 +803,15 @@
</span><span class="cx"> 'item_id' => $item_id,
</span><span class="cx"> );
</span><span class="cx">
</span><del>- if ( !empty( $component_name ) ) {
</del><ins>+ if ( ! empty( $component_name ) ) {
</ins><span class="cx"> $where_args['component_name'] = $component_name;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if ( !empty( $component_action ) ) {
</del><ins>+ if ( ! empty( $component_action ) ) {
</ins><span class="cx"> $where_args['component_action'] = $component_action;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if ( !empty( $secondary_item_id ) ) {
</del><ins>+ if ( ! empty( $secondary_item_id ) ) {
</ins><span class="cx"> $where_args['secondary_item_id'] = $secondary_item_id;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkbpnotificationsbpnotificationsfunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-notifications/bp-notifications-functions.php (7535 => 7536)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-notifications/bp-notifications-functions.php 2013-11-08 06:15:20 UTC (rev 7535)
+++ trunk/bp-notifications/bp-notifications-functions.php 2013-11-08 12:34:27 UTC (rev 7536)
</span><span class="lines">@@ -41,7 +41,7 @@
</span><span class="cx"> 'component_name' => '',
</span><span class="cx"> 'component_action' => '',
</span><span class="cx"> 'date_notified' => bp_core_current_time(),
</span><del>- 'is_new' => 1
</del><ins>+ 'is_new' => 1,
</ins><span class="cx"> ) );
</span><span class="cx">
</span><span class="cx"> // Setup the new notification
</span><span class="lines">@@ -310,7 +310,7 @@
</span><span class="cx"> 'user_id' => $user_id,
</span><span class="cx"> 'component_name' => $component_name,
</span><span class="cx"> 'component_action' => $component_action,
</span><del>- 'is_new' => $is_new
</del><ins>+ 'is_new' => $is_new,
</ins><span class="cx"> ) );
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -337,7 +337,7 @@
</span><span class="cx"> 'secondary_item_id' => $secondary_item_id,
</span><span class="cx"> 'component_name' => $component_name,
</span><span class="cx"> 'component_action' => $component_action,
</span><del>- 'is_new' => $is_new
</del><ins>+ 'is_new' => $is_new,
</ins><span class="cx"> ) );
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -362,7 +362,7 @@
</span><span class="cx"> 'secondary_item_id' => $secondary_item_id,
</span><span class="cx"> 'component_name' => $component_name,
</span><span class="cx"> 'component_action' => $component_action,
</span><del>- 'is_new' => $is_new
</del><ins>+ 'is_new' => $is_new,
</ins><span class="cx"> ) );
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -389,7 +389,7 @@
</span><span class="cx"> 'item_id' => $user_id,
</span><span class="cx"> 'component_name' => $component_name,
</span><span class="cx"> 'component_action' => $component_action,
</span><del>- 'is_new' => $is_new
</del><ins>+ 'is_new' => $is_new,
</ins><span class="cx"> ) );
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkbpnotificationsbpnotificationstemplatephp"></a>
<div class="modfile"><h4>Modified: trunk/bp-notifications/bp-notifications-template.php (7535 => 7536)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-notifications/bp-notifications-template.php 2013-11-08 06:15:20 UTC (rev 7535)
+++ trunk/bp-notifications/bp-notifications-template.php 2013-11-08 12:34:27 UTC (rev 7536)
</span><span class="lines">@@ -185,7 +185,7 @@
</span><span class="cx"> 'is_new' => $this->is_new,
</span><span class="cx"> 'page' => $this->pag_page,
</span><span class="cx"> 'per_page' => $this->pag_num,
</span><del>- 'search_terms' => $this->search_terms
</del><ins>+ 'search_terms' => $this->search_terms,
</ins><span class="cx"> ) );
</span><span class="cx">
</span><span class="cx"> // Setup the notifications to loop through
</span><span class="lines">@@ -362,7 +362,7 @@
</span><span class="cx"> 'per_page' => 25,
</span><span class="cx"> 'max' => false,
</span><span class="cx"> 'search_terms' => isset( $_REQUEST['s'] ) ? stripslashes( $_REQUEST['s'] ) : '',
</span><del>- 'page_arg' => 'npage'
</del><ins>+ 'page_arg' => 'npage',
</ins><span class="cx"> ) );
</span><span class="cx">
</span><span class="cx"> // Get the notifications
</span><span class="lines">@@ -533,7 +533,7 @@
</span><span class="cx"> // Notified date has legitimate data
</span><span class="cx"> if ( '0000-00-00 00:00:00' !== $date_notified ) {
</span><span class="cx"> $retval = bp_core_time_since( $date_notified );
</span><del>-
</del><ins>+
</ins><span class="cx"> // Notified date is empty, so return a fun string
</span><span class="cx"> } else {
</span><span class="cx"> $retval = __( 'Date not found', 'buddypress' );
</span></span></pre>
</div>
</div>
</body>
</html>