<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][7470] trunk: Scroll to top when clicking on bottom pagination links in BP loops.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/7470">7470</a></dd>
<dt>Author</dt> <dd>r-a-y</dd>
<dt>Date</dt> <dd>2013-10-23 19:11:32 +0000 (Wed, 23 Oct 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Scroll to top when clicking on bottom pagination links in BP loops.
If a user clicks on a pagination link located at the bottom of any BP loop
(members, groups), the loop will refresh with AJAX, but will not scroll to
the top of the page. This isn't so great for UX.
This commit adds the ability to scroll to top when a bottom-paginated
link is clicked.
In order for this to work, an additional parameter ('caller') was added to
the bp_filter_request() JS function to determine where the link was called
from.
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/5206">#5206</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbptemplatesbplegacyjsbuddypressjs">trunk/bp-templates/bp-legacy/js/buddypress.js</a></li>
<li><a href="#trunkbpthemesbpdefault_incglobaljs">trunk/bp-themes/bp-default/_inc/global.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbptemplatesbplegacyjsbuddypressjs"></a>
<div class="modfile"><h4>Modified: trunk/bp-templates/bp-legacy/js/buddypress.js (7469 => 7470)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-templates/bp-legacy/js/buddypress.js 2013-10-23 18:47:16 UTC (rev 7469)
+++ trunk/bp-templates/bp-legacy/js/buddypress.js 2013-10-23 19:11:32 UTC (rev 7470)
</span><span class="lines">@@ -749,6 +749,7 @@
</span><span class="cx"> var css_id = el.attr('id').split( '-' );
</span><span class="cx"> var object = css_id[0];
</span><span class="cx"> var search_terms = false;
</span><ins>+ var pagination_id = jq(target).closest('.pagination-links').attr('id');
</ins><span class="cx">
</span><span class="cx"> if ( jq('div.dir-search input').length )
</span><span class="cx"> search_terms = jq('.dir-search input').val();
</span><span class="lines">@@ -759,8 +760,14 @@
</span><span class="cx"> var page_number = Number( jq('.pagination span.current').html() ) - 1;
</span><span class="cx"> else
</span><span class="cx"> var page_number = Number( jq(target).html() );
</span><ins>+
+ if ( pagination_id.indexOf( 'pag-bottom' ) !== -1 ) {
+ var caller = 'pag-bottom';
+ } else {
+ var caller = null;
+ }
</ins><span class="cx">
</span><del>- bp_filter_request( object, jq.cookie('bp-' + object + '-filter'), jq.cookie('bp-' + object + '-scope'), 'div.' + object, search_terms, page_number, jq.cookie('bp-' + object + '-extras') );
</del><ins>+ bp_filter_request( object, jq.cookie('bp-' + object + '-filter'), jq.cookie('bp-' + object + '-scope'), 'div.' + object, search_terms, page_number, jq.cookie('bp-' + object + '-extras'), caller );
</ins><span class="cx">
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="lines">@@ -1376,7 +1383,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /* Filter the current content list (groups/members/blogs/topics) */
</span><del>-function bp_filter_request( object, filter, scope, target, search_terms, page, extras ) {
</del><ins>+function bp_filter_request( object, filter, scope, target, search_terms, page, extras, caller ) {
</ins><span class="cx"> if ( 'activity' == object )
</span><span class="cx"> return false;
</span><span class="cx">
</span><span class="lines">@@ -1423,10 +1430,23 @@
</span><span class="cx"> },
</span><span class="cx"> function(response)
</span><span class="cx"> {
</span><del>- jq(target).fadeOut( 100, function() {
- jq(this).html(response);
- jq(this).fadeIn(100);
- });
</del><ins>+ /* animate to top if called from bottom pagination */
+ if ( caller == 'pag-bottom' && jq('#subnav').length ) {
+ var top = jq('#subnav').parent();
+ jq('html,body').animate({scrollTop: top.offset().top}, 'slow', function() {
+ jq(target).fadeOut( 100, function() {
+ jq(this).html(response);
+ jq(this).fadeIn(100);
+ });
+ });
+
+ } else {
+ jq(target).fadeOut( 100, function() {
+ jq(this).html(response);
+ jq(this).fadeIn(100);
+ });
+ }
+
</ins><span class="cx"> jq('.item-list-tabs li.selected').removeClass('loading');
</span><span class="cx"> });
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkbpthemesbpdefault_incglobaljs"></a>
<div class="modfile"><h4>Modified: trunk/bp-themes/bp-default/_inc/global.js (7469 => 7470)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-themes/bp-default/_inc/global.js 2013-10-23 18:47:16 UTC (rev 7469)
+++ trunk/bp-themes/bp-default/_inc/global.js 2013-10-23 19:11:32 UTC (rev 7470)
</span><span class="lines">@@ -735,6 +735,7 @@
</span><span class="cx"> var css_id = el.attr('id').split( '-' );
</span><span class="cx"> var object = css_id[0];
</span><span class="cx"> var search_terms = false;
</span><ins>+ var pagination_id = jq(target).closest('.pagination-links').attr('id');
</ins><span class="cx">
</span><span class="cx"> if ( jq('div.dir-search input').length )
</span><span class="cx"> search_terms = jq('.dir-search input').val();
</span><span class="lines">@@ -745,8 +746,14 @@
</span><span class="cx"> var page_number = Number( jq('.pagination span.current').html() ) - 1;
</span><span class="cx"> else
</span><span class="cx"> var page_number = Number( jq(target).html() );
</span><ins>+
+ if ( pagination_id.indexOf( 'pag-bottom' ) !== -1 ) {
+ var caller = 'pag-bottom';
+ } else {
+ var caller = null;
+ }
</ins><span class="cx">
</span><del>- bp_filter_request( object, jq.cookie('bp-' + object + '-filter'), jq.cookie('bp-' + object + '-scope'), 'div.' + object, search_terms, page_number, jq.cookie('bp-' + object + '-extras') );
</del><ins>+ bp_filter_request( object, jq.cookie('bp-' + object + '-filter'), jq.cookie('bp-' + object + '-scope'), 'div.' + object, search_terms, page_number, jq.cookie('bp-' + object + '-extras'), caller );
</ins><span class="cx">
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="lines">@@ -1342,7 +1349,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /* Filter the current content list (groups/members/blogs/topics) */
</span><del>-function bp_filter_request( object, filter, scope, target, search_terms, page, extras ) {
</del><ins>+function bp_filter_request( object, filter, scope, target, search_terms, page, extras, caller ) {
</ins><span class="cx"> if ( 'activity' == object )
</span><span class="cx"> return false;
</span><span class="cx">
</span><span class="lines">@@ -1389,10 +1396,23 @@
</span><span class="cx"> },
</span><span class="cx"> function(response)
</span><span class="cx"> {
</span><del>- jq(target).fadeOut( 100, function() {
- jq(this).html(response);
- jq(this).fadeIn(100);
- });
</del><ins>+ /* animate to top if called from bottom pagination */
+ if ( caller == 'pag-bottom' && jq('#subnav').length ) {
+ var top = jq('#subnav').parent();
+ jq('html,body').animate({scrollTop: top.offset().top}, 'slow', function() {
+ jq(target).fadeOut( 100, function() {
+ jq(this).html(response);
+ jq(this).fadeIn(100);
+ });
+ });
+
+ } else {
+ jq(target).fadeOut( 100, function() {
+ jq(this).html(response);
+ jq(this).fadeIn(100);
+ });
+ }
+
</ins><span class="cx"> jq('.item-list-tabs li.selected').removeClass('loading');
</span><span class="cx"> });
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>