<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][7386] trunk: Return contents instead of echoing during theme compat output buffer.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/7386">7386</a></dd>
<dt>Author</dt> <dd>r-a-y</dd>
<dt>Date</dt> <dd>2013-09-17 17:37:21 +0000 (Tue, 17 Sep 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Return contents instead of echoing during theme compat output buffer.
When using the 'bp_replace_the_content' filter, we need to return the
contents instead of echoing.
Thus, this commit changes all bp_buffer_template_part() calls to
return instead of echo.
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/5156">#5156</a>. Props ddean.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpactivitybpactivityscreensphp">trunk/bp-activity/bp-activity-screens.php</a></li>
<li><a href="#trunkbpblogsbpblogsscreensphp">trunk/bp-blogs/bp-blogs-screens.php</a></li>
<li><a href="#trunkbpforumsbpforumsscreensphp">trunk/bp-forums/bp-forums-screens.php</a></li>
<li><a href="#trunkbpgroupsbpgroupsscreensphp">trunk/bp-groups/bp-groups-screens.php</a></li>
<li><a href="#trunkbpmembersbpmembersscreensphp">trunk/bp-members/bp-members-screens.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpactivitybpactivityscreensphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-activity/bp-activity-screens.php (7385 => 7386)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-activity/bp-activity-screens.php 2013-09-17 17:24:20 UTC (rev 7385)
+++ trunk/bp-activity/bp-activity-screens.php 2013-09-17 17:37:21 UTC (rev 7386)
</span><span class="lines">@@ -412,7 +412,7 @@
</span><span class="cx"> * @since BuddyPress (1.7)
</span><span class="cx"> */
</span><span class="cx"> public function directory_content() {
</span><del>- bp_buffer_template_part( 'activity/index' );
</del><ins>+ return bp_buffer_template_part( 'activity/index', null, false );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /** Single ****************************************************************/
</span><span class="lines">@@ -465,7 +465,7 @@
</span><span class="cx"> * @since BuddyPress (1.7)
</span><span class="cx"> */
</span><span class="cx"> public function single_dummy_content() {
</span><del>- bp_buffer_template_part( 'activity/single/home' );
</del><ins>+ return bp_buffer_template_part( 'activity/single/home', null, false );
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> new BP_Activity_Theme_Compat();
</span></span></pre></div>
<a id="trunkbpblogsbpblogsscreensphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-blogs/bp-blogs-screens.php (7385 => 7386)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-blogs/bp-blogs-screens.php 2013-09-17 17:24:20 UTC (rev 7385)
+++ trunk/bp-blogs/bp-blogs-screens.php 2013-09-17 17:37:21 UTC (rev 7386)
</span><span class="lines">@@ -156,7 +156,7 @@
</span><span class="cx"> * @since BuddyPress (1.7)
</span><span class="cx"> */
</span><span class="cx"> public function directory_content() {
</span><del>- bp_buffer_template_part( 'blogs/index' );
</del><ins>+ return bp_buffer_template_part( 'blogs/index', null, false );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /** Create ****************************************************************/
</span><span class="lines">@@ -217,7 +217,7 @@
</span><span class="cx"> * @since BuddyPress (1.7)
</span><span class="cx"> */
</span><span class="cx"> public function create_content() {
</span><del>- bp_buffer_template_part( 'blogs/create' );
</del><ins>+ return bp_buffer_template_part( 'blogs/create', null, false );
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> new BP_Blogs_Theme_Compat();
</span></span></pre></div>
<a id="trunkbpforumsbpforumsscreensphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-forums/bp-forums-screens.php (7385 => 7386)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-forums/bp-forums-screens.php 2013-09-17 17:24:20 UTC (rev 7385)
+++ trunk/bp-forums/bp-forums-screens.php 2013-09-17 17:37:21 UTC (rev 7386)
</span><span class="lines">@@ -216,7 +216,7 @@
</span><span class="cx"> * @since BuddyPress (1.7)
</span><span class="cx"> */
</span><span class="cx"> public function directory_content() {
</span><del>- bp_buffer_template_part( 'forums/index' );
</del><ins>+ return bp_buffer_template_part( 'forums/index', null, false );
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> new BP_Forum_Legacy_Theme_Compat();
</span></span></pre></div>
<a id="trunkbpgroupsbpgroupsscreensphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-groups/bp-groups-screens.php (7385 => 7386)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-groups/bp-groups-screens.php 2013-09-17 17:24:20 UTC (rev 7385)
+++ trunk/bp-groups/bp-groups-screens.php 2013-09-17 17:37:21 UTC (rev 7386)
</span><span class="lines">@@ -1048,7 +1048,7 @@
</span><span class="cx"> * @since BuddyPress (1.7)
</span><span class="cx"> */
</span><span class="cx"> public function directory_content() {
</span><del>- bp_buffer_template_part( 'groups/index' );
</del><ins>+ return bp_buffer_template_part( 'groups/index', null, false );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /** Create ****************************************************************/
</span><span class="lines">@@ -1109,7 +1109,7 @@
</span><span class="cx"> * @since BuddyPress (1.7)
</span><span class="cx"> */
</span><span class="cx"> public function create_content() {
</span><del>- bp_buffer_template_part( 'groups/create' );
</del><ins>+ return bp_buffer_template_part( 'groups/create', null, false );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /** Single ****************************************************************/
</span><span class="lines">@@ -1169,7 +1169,7 @@
</span><span class="cx"> * @since BuddyPress (1.7)
</span><span class="cx"> */
</span><span class="cx"> public function single_content() {
</span><del>- bp_buffer_template_part( 'groups/single/home' );
</del><ins>+ return bp_buffer_template_part( 'groups/single/home', null, false );
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> new BP_Groups_Theme_Compat();
</span></span></pre></div>
<a id="trunkbpmembersbpmembersscreensphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-members/bp-members-screens.php (7385 => 7386)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-members/bp-members-screens.php 2013-09-17 17:24:20 UTC (rev 7385)
+++ trunk/bp-members/bp-members-screens.php 2013-09-17 17:37:21 UTC (rev 7386)
</span><span class="lines">@@ -369,7 +369,7 @@
</span><span class="cx"> * @since BuddyPress (1.7)
</span><span class="cx"> */
</span><span class="cx"> public function directory_content() {
</span><del>- bp_buffer_template_part( 'members/index' );
</del><ins>+ return bp_buffer_template_part( 'members/index', null, false );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /** Single ****************************************************************/
</span><span class="lines">@@ -429,7 +429,7 @@
</span><span class="cx"> * @since BuddyPress (1.7)
</span><span class="cx"> */
</span><span class="cx"> public function single_dummy_content() {
</span><del>- bp_buffer_template_part( 'members/single/home' );
</del><ins>+ return bp_buffer_template_part( 'members/single/home', null, false );
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> new BP_Members_Theme_Compat();
</span><span class="lines">@@ -546,9 +546,9 @@
</span><span class="cx"> */
</span><span class="cx"> public function dummy_content() {
</span><span class="cx"> if ( bp_is_register_page() ) {
</span><del>- bp_buffer_template_part( 'members/register' );
</del><ins>+ return bp_buffer_template_part( 'members/register', null, false );
</ins><span class="cx"> } else {
</span><del>- bp_buffer_template_part( 'members/activate' );
</del><ins>+ return bp_buffer_template_part( 'members/activate', null, false );
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>