<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][7311] trunk: Revert more private method scope breaking changes from r7308.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/7311">7311</a></dd>
<dt>Author</dt> <dd>johnjamesjacoby</dd>
<dt>Date</dt> <dd>2013-07-25 18:26:35 +0000 (Thu, 25 Jul 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Revert more private method scope breaking changes from <a href="http://buddypress.trac.wordpress.org/changeset/7308">r7308</a>. See <a href="http://buddypress.trac.wordpress.org/ticket/5108">#5108</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpcorebpcoreclassesphp">trunk/bp-core/bp-core-classes.php</a></li>
<li><a href="#trunkbpmessagesbpmessagesclassesphp">trunk/bp-messages/bp-messages-classes.php</a></li>
<li><a href="#trunkbpxprofilebpxprofileclassesphp">trunk/bp-xprofile/bp-xprofile-classes.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpcorebpcoreclassesphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-core/bp-core-classes.php (7310 => 7311)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-core/bp-core-classes.php 2013-07-25 10:29:20 UTC (rev 7310)
+++ trunk/bp-core/bp-core-classes.php 2013-07-25 18:26:35 UTC (rev 7311)
</span><span class="lines">@@ -750,7 +750,7 @@
</span><span class="cx"> * @uses bp_core_fetch_avatar() Returns HTML formatted avatar for a user
</span><span class="cx"> * @uses bp_profile_last_updated_date() Returns the last updated date for a user.
</span><span class="cx"> */
</span><del>- private function populate() {
</del><ins>+ public function populate() {
</ins><span class="cx">
</span><span class="cx"> if ( bp_is_active( 'xprofile' ) )
</span><span class="cx"> $this->profile_data = $this->get_profile_data();
</span><span class="lines">@@ -783,7 +783,7 @@
</span><span class="cx"> /**
</span><span class="cx"> * Populates extra fields such as group and friendship counts.
</span><span class="cx"> */
</span><del>- private function populate_extras() {
</del><ins>+ public function populate_extras() {
</ins><span class="cx">
</span><span class="cx"> if ( bp_is_active( 'friends' ) ) {
</span><span class="cx"> $this->total_friends = BP_Friends_Friendship::total_friend_count( $this->id );
</span><span class="lines">@@ -1347,7 +1347,7 @@
</span><span class="cx"> * @global BuddyPress $bp The one true BuddyPress instance
</span><span class="cx"> * @global wpdb $wpdb WordPress database object
</span><span class="cx"> */
</span><del>- private function populate() {
</del><ins>+ public function populate() {
</ins><span class="cx"> global $bp, $wpdb;
</span><span class="cx">
</span><span class="cx"> if ( $notification = $wpdb->get_row( $wpdb->prepare( "SELECT * FROM {$bp->core->table_name_notifications} WHERE id = %d", $this->id ) ) ) {
</span></span></pre></div>
<a id="trunkbpmessagesbpmessagesclassesphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-messages/bp-messages-classes.php (7310 => 7311)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-messages/bp-messages-classes.php 2013-07-25 10:29:20 UTC (rev 7310)
+++ trunk/bp-messages/bp-messages-classes.php 2013-07-25 18:26:35 UTC (rev 7311)
</span><span class="lines">@@ -71,7 +71,7 @@
</span><span class="cx"> $this->populate( $thread_id, $order );
</span><span class="cx"> }
</span><span class="cx">
</span><del>- private function populate( $thread_id, $order ) {
</del><ins>+ public function populate( $thread_id, $order ) {
</ins><span class="cx"> global $wpdb, $bp;
</span><span class="cx">
</span><span class="cx"> if( 'ASC' != $order && 'DESC' != $order )
</span><span class="lines">@@ -325,7 +325,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- private function populate( $id ) {
</del><ins>+ public function populate( $id ) {
</ins><span class="cx"> global $wpdb, $bp;
</span><span class="cx">
</span><span class="cx"> if ( $message = $wpdb->get_row( $wpdb->prepare( "SELECT * FROM {$bp->messages->table_name_messages} WHERE id = %d", $id ) ) ) {
</span><span class="lines">@@ -443,7 +443,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- private function populate() {
</del><ins>+ public function populate() {
</ins><span class="cx"> global $wpdb, $bp;
</span><span class="cx">
</span><span class="cx"> $notice = $wpdb->get_row( $wpdb->prepare( "SELECT * FROM {$bp->messages->table_name_notices} WHERE id = %d", $this->id ) );
</span></span></pre></div>
<a id="trunkbpxprofilebpxprofileclassesphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-xprofile/bp-xprofile-classes.php (7310 => 7311)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-xprofile/bp-xprofile-classes.php 2013-07-25 10:29:20 UTC (rev 7310)
+++ trunk/bp-xprofile/bp-xprofile-classes.php 2013-07-25 18:26:35 UTC (rev 7311)
</span><span class="lines">@@ -23,7 +23,7 @@
</span><span class="cx"> $this->populate( $id );
</span><span class="cx"> }
</span><span class="cx">
</span><del>- private function populate( $id ) {
</del><ins>+ public function populate( $id ) {
</ins><span class="cx"> global $wpdb, $bp;
</span><span class="cx">
</span><span class="cx"> $sql = $wpdb->prepare( "SELECT * FROM {$bp->profile->table_name_groups} WHERE id = %d", $id );
</span><span class="lines">@@ -450,7 +450,7 @@
</span><span class="cx"> $this->populate( $id, $user_id, $get_data );
</span><span class="cx"> }
</span><span class="cx">
</span><del>- private function populate( $id, $user_id, $get_data ) {
</del><ins>+ public function populate( $id, $user_id, $get_data ) {
</ins><span class="cx"> global $wpdb, $userdata, $bp;
</span><span class="cx">
</span><span class="cx"> if ( empty( $user_id ) ) {
</span><span class="lines">@@ -1015,7 +1015,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- private function populate( $field_id, $user_id ) {
</del><ins>+ public function populate( $field_id, $user_id ) {
</ins><span class="cx"> global $wpdb, $bp;
</span><span class="cx">
</span><span class="cx"> $sql = $wpdb->prepare( "SELECT * FROM {$bp->profile->table_name_data} WHERE field_id = %d AND user_id = %d", $field_id, $user_id );
</span></span></pre>
</div>
</div>
</body>
</html>