<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][7168] trunk: Introduces bp_activity_comment_permalink() and implements in comment template</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/7168">7168</a></dd>
<dt>Author</dt> <dd>boonebgorges</dd>
<dt>Date</dt> <dd>2013-06-06 22:46:43 +0000 (Thu, 06 Jun 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Introduces bp_activity_comment_permalink() and implements in comment template
ID anchors have always been available for the purpose of linking directly to
specific activity comments. But these links have never been available directly
in the interface: the timestamp of specific comments lead to the parent thread,
instead of to the specific comment within that thread. This changeset will make
it easier to find the permalink of specific comments.
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/4741">#4741</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpactivitybpactivitytemplatephp">trunk/bp-activity/bp-activity-template.php</a></li>
<li><a href="#trunkbptemplatesbplegacybuddypressactivitycommentphp">trunk/bp-templates/bp-legacy/buddypress/activity/comment.php</a></li>
<li><a href="#trunkbpthemesbpdefaultactivitycommentphp">trunk/bp-themes/bp-default/activity/comment.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpactivitybpactivitytemplatephp"></a>
<div class="modfile"><h4>Modified: trunk/bp-activity/bp-activity-template.php (7167 => 7168)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-activity/bp-activity-template.php 2013-06-05 21:57:17 UTC (rev 7167)
+++ trunk/bp-activity/bp-activity-template.php 2013-06-06 22:46:43 UTC (rev 7168)
</span><span class="lines">@@ -2025,6 +2025,34 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span><ins>+ * Echoes the activity comment permalink
+ *
+ * @since BuddyPress (1.8)
+ *
+ * @uses bp_get_activity_permalink_id()
+ */
+function bp_activity_comment_permalink() {
+ echo bp_get_activity_comment_permalink();
+}
+ /**
+ * Gets the activity comment permalink
+ *
+ * @since BuddyPress (1.8)
+ *
+ * @uses bp_activity_get_permalink()
+ * @uses apply_filters() To call the 'bp_get_activity_comment_permalink' hook
+ *
+ * @return string $link The activity comment permalink
+ */
+ function bp_get_activity_comment_permalink() {
+ global $activities_template;
+
+ $link = bp_activity_get_permalink( $activities_template->activity->id, $activities_template->activity ) . '#acomment-' . $activities_template->activity->current_comment->id;
+
+ return apply_filters( 'bp_get_activity_comment_permalink', $link );
+ }
+
+/**
</ins><span class="cx"> * Echoes the activity favorite link
</span><span class="cx"> *
</span><span class="cx"> * @since BuddyPress (1.2)
</span></span></pre></div>
<a id="trunkbptemplatesbplegacybuddypressactivitycommentphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-templates/bp-legacy/buddypress/activity/comment.php (7167 => 7168)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-templates/bp-legacy/buddypress/activity/comment.php 2013-06-05 21:57:17 UTC (rev 7167)
+++ trunk/bp-templates/bp-legacy/buddypress/activity/comment.php 2013-06-06 22:46:43 UTC (rev 7168)
</span><span class="lines">@@ -24,7 +24,7 @@
</span><span class="cx"> <div class="acomment-meta">
</span><span class="cx"> <?php
</span><span class="cx"> /* translators: 1: user profile link, 2: user name, 3: activity permalink, 4: activity timestamp */
</span><del>- printf( __( '<a href="%1$s">%2$s</a> replied <a href="%3$s" class="activity-time-since"><span class="time-since">%4$s</span></a>', 'buddypress' ), bp_get_activity_comment_user_link(), bp_get_activity_comment_name(), bp_get_activity_thread_permalink(), bp_get_activity_comment_date_recorded() );
</del><ins>+ printf( __( '<a href="%1$s">%2$s</a> replied <a href="%3$s" class="activity-time-since"><span class="time-since">%4$s</span></a>', 'buddypress' ), bp_get_activity_comment_user_link(), bp_get_activity_comment_name(), bp_get_activity_comment_permalink(), bp_get_activity_comment_date_recorded() );
</ins><span class="cx"> ?>
</span><span class="cx"> </div>
</span><span class="cx">
</span></span></pre></div>
<a id="trunkbpthemesbpdefaultactivitycommentphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-themes/bp-default/activity/comment.php (7167 => 7168)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-themes/bp-default/activity/comment.php 2013-06-05 21:57:17 UTC (rev 7167)
+++ trunk/bp-themes/bp-default/activity/comment.php 2013-06-06 22:46:43 UTC (rev 7168)
</span><span class="lines">@@ -27,7 +27,7 @@
</span><span class="cx"> <div class="acomment-meta">
</span><span class="cx"> <?php
</span><span class="cx"> /* translators: 1: user profile link, 2: user name, 3: activity permalink, 4: activity timestamp */
</span><del>- printf( __( '<a href="%1$s">%2$s</a> replied <a href="%3$s" class="activity-time-since"><span class="time-since">%4$s</span></a>', 'buddypress' ), bp_get_activity_comment_user_link(), bp_get_activity_comment_name(), bp_get_activity_thread_permalink(), bp_get_activity_comment_date_recorded() );
</del><ins>+ printf( __( '<a href="%1$s">%2$s</a> replied <a href="%3$s" class="activity-time-since"><span class="time-since">%4$s</span></a>', 'buddypress' ), bp_get_activity_comment_user_link(), bp_get_activity_comment_name(), bp_get_activity_comment_permalink(), bp_get_activity_comment_date_recorded() );
</ins><span class="cx"> ?>
</span><span class="cx"> </div>
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>