<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][7104] trunk: Update tests and documentation for bp_core_time_since() to reflect seconds quirk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/7104">7104</a></dd>
<dt>Author</dt> <dd>boonebgorges</dd>
<dt>Date</dt> <dd>2013-05-24 17:45:22 +0000 (Fri, 24 May 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Update tests and documentation for bp_core_time_since() to reflect seconds quirk
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/5017">#5017</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpcorebpcorefunctionsphp">trunk/bp-core/bp-core-functions.php</a></li>
<li><a href="#trunkteststestcasescorefunctionsphp">trunk/tests/testcases/core/functions.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpcorebpcorefunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-core/bp-core-functions.php (7103 => 7104)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-core/bp-core-functions.php 2013-05-24 13:35:16 UTC (rev 7103)
+++ trunk/bp-core/bp-core-functions.php 2013-05-24 17:45:22 UTC (rev 7104)
</span><span class="lines">@@ -570,6 +570,10 @@
</span><span class="cx"> * eg: 4 days
</span><span class="cx"> * eg: 4 weeks and 6 days
</span><span class="cx"> *
</span><ins>+ * Note that fractions of minutes are not represented in the return string. So
+ * an interval of 3 minutes will be represented by "3 minutes ago", as will an
+ * interval of 3 minutes 59 seconds.
+ *
</ins><span class="cx"> * @package BuddyPress Core
</span><span class="cx"> * @uses apply_filters() Filter 'bp_core_time_since_pre' to bypass BP's calculations
</span><span class="cx"> * @uses apply_filters() Filter 'bp_core_time_since' to modify BP's calculations
</span><span class="lines">@@ -670,6 +674,11 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Step two: the second chunk
</span><ins>+ // A quirk in the implementation means that this
+ // condition fails in the case of minutes and seconds.
+ // We've left the quirk in place, since fractions of a
+ // minute are not a useful piece of information for our
+ // purposes
</ins><span class="cx"> if ( $i + 2 < $j ) {
</span><span class="cx"> $seconds2 = $chunks[$i + 1];
</span><span class="cx"> $count2 = floor( ( $since - ( $seconds * $count ) ) / $seconds2 );
</span></span></pre></div>
<a id="trunkteststestcasescorefunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/tests/testcases/core/functions.php (7103 => 7104)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/tests/testcases/core/functions.php 2013-05-24 13:35:16 UTC (rev 7103)
+++ trunk/tests/testcases/core/functions.php 2013-05-24 17:45:22 UTC (rev 7104)
</span><span class="lines">@@ -137,7 +137,7 @@
</span><span class="cx"> public function test_bp_core_time_since_minutes_seconds() {
</span><span class="cx"> $now = time();
</span><span class="cx"> $then = $now - ( 3 * MINUTE_IN_SECONDS ) - 3;
</span><del>- $this->assertEquals( '3 minutes, 3 seconds ago', bp_core_time_since( $then, $now ) );
</del><ins>+ $this->assertEquals( '3 minutes ago', bp_core_time_since( $then, $now ) );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span></span></pre>
</div>
</div>
</body>
</html>