<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][7095] trunk: In the AJAX object_template_loader() functions of bp-default and bp-legacy, use sanitize_title() instead of esc_attr() to properly sanitize the requested object.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/7095">7095</a></dd>
<dt>Author</dt> <dd>johnjamesjacoby</dd>
<dt>Date</dt> <dd>2013-05-22 04:38:44 +0000 (Wed, 22 May 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>In the AJAX object_template_loader() functions of bp-default and bp-legacy, use sanitize_title() instead of esc_attr() to properly sanitize the requested object.
Then, do a bp_is_active() against that object to ensure the object being requested is for an active component, to prevent potential arbitrary file inclusion. (Note: this needs testing with third party components that tap into this functionality, as it was originally intended only to be used by bundled components.)</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbptemplatesbplegacybuddypressfunctionsphp">trunk/bp-templates/bp-legacy/buddypress-functions.php</a></li>
<li><a href="#trunkbpthemesbpdefault_incajaxphp">trunk/bp-themes/bp-default/_inc/ajax.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbptemplatesbplegacybuddypressfunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-templates/bp-legacy/buddypress-functions.php (7094 => 7095)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-templates/bp-legacy/buddypress-functions.php 2013-05-20 21:35:17 UTC (rev 7094)
+++ trunk/bp-templates/bp-legacy/buddypress-functions.php 2013-05-22 04:38:44 UTC (rev 7095)
</span><span class="lines">@@ -458,19 +458,26 @@
</span><span class="cx"> if ( 'POST' !== strtoupper( $_SERVER['REQUEST_METHOD'] ) )
</span><span class="cx"> return;
</span><span class="cx">
</span><ins>+ // Bail if no object passed
+ if ( empty( $_POST['object'] ) )
+ return;
+
+ // Sanitize the object
+ $object = sanitize_title( $_POST['object'] );
+
+ // Bail if object is not an active component to prevent arbitrary file inclusion
+ if ( ! bp_is_active( $object ) )
+ return;
+
</ins><span class="cx"> /**
</span><span class="cx"> * AJAX requests happen too early to be seen by bp_update_is_directory()
</span><span class="cx"> * so we do it manually here to ensure templates load with the correct
</span><span class="cx"> * context. Without this check, templates will load the 'single' version
</span><span class="cx"> * of themselves rather than the directory version.
</span><span class="cx"> */
</span><del>-
</del><span class="cx"> if ( ! bp_current_action() )
</span><span class="cx"> bp_update_is_directory( true, bp_current_component() );
</span><span class="cx">
</span><del>- // Sanitize the post object
- $object = esc_attr( $_POST['object'] );
-
</del><span class="cx"> // Locate the object template
</span><span class="cx"> bp_get_template_part( "$object/$object-loop" );
</span><span class="cx"> exit();
</span></span></pre></div>
<a id="trunkbpthemesbpdefault_incajaxphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-themes/bp-default/_inc/ajax.php (7094 => 7095)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-themes/bp-default/_inc/ajax.php 2013-05-20 21:35:17 UTC (rev 7094)
+++ trunk/bp-themes/bp-default/_inc/ajax.php 2013-05-22 04:38:44 UTC (rev 7095)
</span><span class="lines">@@ -168,19 +168,26 @@
</span><span class="cx"> if ( 'POST' !== strtoupper( $_SERVER['REQUEST_METHOD'] ) )
</span><span class="cx"> return;
</span><span class="cx">
</span><ins>+ // Bail if no object passed
+ if ( empty( $_POST['object'] ) )
+ return;
+
+ // Sanitize the object
+ $object = sanitize_title( $_POST['object'] );
+
+ // Bail if object is not an active component
+ if ( ! bp_is_active( $object ) )
+ return;
+
</ins><span class="cx"> /**
</span><span class="cx"> * AJAX requests happen too early to be seen by bp_update_is_directory()
</span><span class="cx"> * so we do it manually here to ensure templates load with the correct
</span><span class="cx"> * context. Without this check, templates will load the 'single' version
</span><span class="cx"> * of themselves rather than the directory version.
</span><span class="cx"> */
</span><del>-
</del><span class="cx"> if ( ! bp_current_action() )
</span><span class="cx"> bp_update_is_directory( true, bp_current_component() );
</span><span class="cx">
</span><del>- // Sanitize the post object
- $object = esc_attr( $_POST['object'] );
-
</del><span class="cx"> // Locate the object template
</span><span class="cx"> locate_template( array( "$object/$object-loop.php" ), true );
</span><span class="cx"> exit;
</span></span></pre>
</div>
</div>
</body>
</html>