<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][6912] trunk/bp-groups/bp-groups-admin.php: Don't redirect immediately after attempting to remove all admins from a group</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/6912">6912</a></dd>
<dt>Author</dt> <dd>boonebgorges</dd>
<dt>Date</dt> <dd>2013-04-15 23:56:38 +0000 (Mon, 15 Apr 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Don't redirect immediately after attempting to remove all admins from a group
On the original implementation, when you attempted to remove all admins from a
group via the Dashboard panel, you were immediately redirected away from the
screen, without the rest of the script being processed. This meant, in
particular, that the bp_group_admin_edit_after action was not run, with the
result that plugins weren't able to save their options properly in this
scenario.
This changeset modifies the process so that, in the case of this kind of error,
the redirection doesn't happen until the end of the form handler, allowing
plugins to hook into the save routine correctly.
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/4930">#4930</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpgroupsbpgroupsadminphp">trunk/bp-groups/bp-groups-admin.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpgroupsbpgroupsadminphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-groups/bp-groups-admin.php (6911 => 6912)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-groups/bp-groups-admin.php 2013-04-15 15:43:07 UTC (rev 6911)
+++ trunk/bp-groups/bp-groups-admin.php 2013-04-15 23:56:38 UTC (rev 6912)
</span><span class="lines">@@ -259,66 +259,69 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if ( ! $admin_count ) {
</span><ins>+
</ins><span class="cx"> $redirect_to = add_query_arg( 'no_admins', 1, $redirect_to );
</span><del>- bp_core_redirect( $redirect_to );
- }
</del><ins>+ $error = $group_id;
</ins><span class="cx">
</span><del>- // Process only those users who have had their roles changed
- foreach ( (array) $_POST['bp-groups-role'] as $user_id => $new_role ) {
</del><ins>+ } else {
</ins><span class="cx">
</span><del>- $existing_role = isset( $_POST['bp-groups-existing-role'][$user_id] ) ? $_POST['bp-groups-existing-role'][$user_id] : '';
</del><ins>+ // Process only those users who have had their roles changed
+ foreach ( (array) $_POST['bp-groups-role'] as $user_id => $new_role ) {
</ins><span class="cx">
</span><del>- if ( $existing_role != $new_role ) {
</del><ins>+ $existing_role = isset( $_POST['bp-groups-existing-role'][$user_id] ) ? $_POST['bp-groups-existing-role'][$user_id] : '';
</ins><span class="cx">
</span><del>- switch ( $new_role ) {
- case 'mod' :
- // Admin to mod is a demotion. Demote to
- // member, then fall through
- if ( 'admin' == $existing_role ) {
- groups_demote_member( $user_id, $group_id );
- }
</del><ins>+ if ( $existing_role != $new_role ) {
</ins><span class="cx">
</span><del>- case 'admin' :
- // If the user was banned, we must
- // unban first
- if ( 'banned' == $existing_role ) {
- groups_unban_member( $user_id, $group_id );
- }
</del><ins>+ switch ( $new_role ) {
+ case 'mod' :
+ // Admin to mod is a demotion. Demote to
+ // member, then fall through
+ if ( 'admin' == $existing_role ) {
+ groups_demote_member( $user_id, $group_id );
+ }
</ins><span class="cx">
</span><del>- // At this point, each existing_role
- // is a member, so promote
- $result = groups_promote_member( $user_id, $group_id, $new_role );
</del><ins>+ case 'admin' :
+ // If the user was banned, we must
+ // unban first
+ if ( 'banned' == $existing_role ) {
+ groups_unban_member( $user_id, $group_id );
+ }
</ins><span class="cx">
</span><del>- break;
</del><ins>+ // At this point, each existing_role
+ // is a member, so promote
+ $result = groups_promote_member( $user_id, $group_id, $new_role );
</ins><span class="cx">
</span><del>- case 'member' :
</del><ins>+ break;
</ins><span class="cx">
</span><del>- if ( 'admin' == $existing_role || 'mod' == $existing_role ) {
- $result = groups_demote_member( $user_id, $group_id );
- } else if ( 'banned' == $existing_role ) {
- $result = groups_unban_member( $user_id, $group_id );
- }
</del><ins>+ case 'member' :
</ins><span class="cx">
</span><del>- break;
</del><ins>+ if ( 'admin' == $existing_role || 'mod' == $existing_role ) {
+ $result = groups_demote_member( $user_id, $group_id );
+ } else if ( 'banned' == $existing_role ) {
+ $result = groups_unban_member( $user_id, $group_id );
+ }
</ins><span class="cx">
</span><del>- case 'banned' :
</del><ins>+ break;
</ins><span class="cx">
</span><del>- $result = groups_ban_member( $user_id, $group_id );
</del><ins>+ case 'banned' :
</ins><span class="cx">
</span><del>- break;
</del><ins>+ $result = groups_ban_member( $user_id, $group_id );
</ins><span class="cx">
</span><del>- case 'remove' :
</del><ins>+ break;
</ins><span class="cx">
</span><del>- $result = groups_remove_member( $user_id, $group_id );
</del><ins>+ case 'remove' :
</ins><span class="cx">
</span><del>- break;
- }
</del><ins>+ $result = groups_remove_member( $user_id, $group_id );
</ins><span class="cx">
</span><del>- // Store the success or failure
- if ( $result ) {
- $success_modified[] = $user_id;
- } else {
- $error_modified[] = $user_id;
</del><ins>+ break;
+ }
+
+ // Store the success or failure
+ if ( $result ) {
+ $success_modified[] = $user_id;
+ } else {
+ $error_modified[] = $user_id;
+ }
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>