<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][6832] trunk: Introduces bp_admin_list_table_current_bulk_action() and applies to group and activity admin pages</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/6832">6832</a></dd>
<dt>Author</dt> <dd>boonebgorges</dd>
<dt>Date</dt> <dd>2013-03-03 20:45:16 +0000 (Sun, 03 Mar 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Introduces bp_admin_list_table_current_bulk_action() and applies to group and activity admin pages
WP_List_Table pages have top and bottom bulk action dropdowns: 'action' and
'action2'. This changeset reconciles these two dropdowns on form submit.
See <a href="http://buddypress.trac.wordpress.org/ticket/4861">#4861</a>
Hat tip to imath for original patch</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpactivitybpactivityadminphp">trunk/bp-activity/bp-activity-admin.php</a></li>
<li><a href="#trunkbpcoreadminbpcorefunctionsphp">trunk/bp-core/admin/bp-core-functions.php</a></li>
<li><a href="#trunkbpgroupsbpgroupsadminphp">trunk/bp-groups/bp-groups-admin.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpactivitybpactivityadminphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-activity/bp-activity-admin.php (6831 => 6832)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-activity/bp-activity-admin.php 2013-03-03 20:36:35 UTC (rev 6831)
+++ trunk/bp-activity/bp-activity-admin.php 2013-03-03 20:45:16 UTC (rev 6832)
</span><span class="lines">@@ -182,15 +182,8 @@
</span><span class="cx"> // Decide whether to load the dev version of the CSS and JavaScript
</span><span class="cx"> $min = ( defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ) ? '' : 'min.';
</span><span class="cx">
</span><del>- // Bottom bulk action hack
- if ( !empty( $_REQUEST['action2'] ) ) {
- $_REQUEST['action'] = $_REQUEST['action2'];
- unset( $_REQUEST['action2'] );
- }
</del><ins>+ $doaction = bp_admin_list_table_current_bulk_action();
</ins><span class="cx">
</span><del>- // Decide whether to load the index or edit screen
- $doaction = ! empty( $_REQUEST['action'] ) ? $_REQUEST['action'] : '';
-
</del><span class="cx"> // Call an action for plugins to hook in early
</span><span class="cx"> do_action( 'bp_activity_admin_load', $doaction );
</span><span class="cx">
</span></span></pre></div>
<a id="trunkbpcoreadminbpcorefunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-core/admin/bp-core-functions.php (6831 => 6832)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-core/admin/bp-core-functions.php 2013-03-03 20:36:35 UTC (rev 6831)
+++ trunk/bp-core/admin/bp-core-functions.php 2013-03-03 20:45:16 UTC (rev 6832)
</span><span class="lines">@@ -603,3 +603,27 @@
</span><span class="cx"> // Return our custom order
</span><span class="cx"> return $bp_menu_order;
</span><span class="cx"> }
</span><ins>+
+/** Utility *****************************************************************/
+
+/**
+ * When using a WP_List_Table, get the currently selected bulk action
+ *
+ * WP_List_Tables have bulk actions at the top and at the bottom of the tables,
+ * and the inputs have different keys in the $_REQUEST array. This function
+ * reconciles the two values and returns a single action being performed.
+ *
+ * @since BuddyPress (1.7)
+ * @return string
+ */
+function bp_admin_list_table_current_bulk_action() {
+
+ $action = ! empty( $_REQUEST['action'] ) ? $_REQUEST['action'] : '';
+
+ // If the bottom is set, let it override the action
+ if ( ! empty( $_REQUEST['action2'] ) && $_REQUEST['action2'] != "-1" ) {
+ $action = $_REQUEST['action2'];
+ }
+
+ return $action;
+}
</ins></span></pre></div>
<a id="trunkbpgroupsbpgroupsadminphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-groups/bp-groups-admin.php (6831 => 6832)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-groups/bp-groups-admin.php 2013-03-03 20:36:35 UTC (rev 6831)
+++ trunk/bp-groups/bp-groups-admin.php 2013-03-03 20:45:16 UTC (rev 6832)
</span><span class="lines">@@ -75,15 +75,8 @@
</span><span class="cx"> // Decide whether to load the dev version of the CSS and JavaScript
</span><span class="cx"> $min = defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ? '' : 'min.';
</span><span class="cx">
</span><del>- // Bottom bulk action hack
- if ( !empty( $_REQUEST['action2'] ) ) {
- $_REQUEST['action'] = $_REQUEST['action2'];
- unset( $_REQUEST['action2'] );
- }
</del><ins>+ $doaction = bp_admin_list_table_current_bulk_action();
</ins><span class="cx">
</span><del>- // Decide whether to load the index or edit screen
- $doaction = ! empty( $_REQUEST['action'] ) ? $_REQUEST['action'] : '';
-
</del><span class="cx"> // Call an action for plugins to hook in early
</span><span class="cx"> do_action( 'bp_groups_admin_load', $doaction );
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>