<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][6100] trunk/bp-groups: When a group is created or deleted, clear each group member's "total groups count" cache.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/6100">6100</a></dd>
<dt>Author</dt> <dd>djpaul</dd>
<dt>Date</dt> <dd>2012-06-14 20:12:59 +0000 (Thu, 14 Jun 2012)</dd>
</dl>
<h3>Log Message</h3>
<pre>When a group is created or deleted, clear each group member's "total groups count" cache.
Addresses a bug where the counts never changed in an environment with a persistent object cache.
* See <a href="http://buddypress.trac.wordpress.org/ticket/4226">#4226</a>
* Specify cache group for to wp_cache_delete() in groups_clear_group_user_object_cache().
* Add $user_ids parameter to the 'bp_groups_delete_group' action to save a repeat DB query later.
* Add $group object parameter to the 'groups_created_group' action.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpgroupsbpgroupscachephp">trunk/bp-groups/bp-groups-cache.php</a></li>
<li><a href="#trunkbpgroupsbpgroupsclassesphp">trunk/bp-groups/bp-groups-classes.php</a></li>
<li><a href="#trunkbpgroupsbpgroupsfunctionsphp">trunk/bp-groups/bp-groups-functions.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpgroupsbpgroupscachephp"></a>
<div class="modfile"><h4>Modified: trunk/bp-groups/bp-groups-cache.php (6099 => 6100)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-groups/bp-groups-cache.php 2012-06-14 18:42:45 UTC (rev 6099)
+++ trunk/bp-groups/bp-groups-cache.php 2012-06-14 20:12:59 UTC (rev 6100)
</span><span class="lines">@@ -49,8 +49,35 @@
</span><span class="cx"> add_action( 'groups_group_avatar_updated', 'groups_clear_group_object_cache' );
</span><span class="cx"> add_action( 'groups_create_group_step_complete', 'groups_clear_group_object_cache' );
</span><span class="cx">
</span><ins>+/**
+ * Clears caches for the group creator when a group is created
+ *
+ * @param int $group_id
+ * @param BP_Groups_Group $group_obj
+ * @since BuddyPress (1.6)
+ */
+function bp_groups_clear_group_creator_cache( $group_id, $group_obj ) {
+ // Clears the 'total groups' for this user
+ groups_clear_group_user_object_cache( $group_obj->id, $group_obj->creator_id );
+}
+add_action( 'groups_created_group', 'bp_groups_clear_group_creator_cache', 10, 2 );
+
+/**
+ * Clears caches for all members in a group when a group is deleted
+ *
+ * @param BP_Groups_Group $group_obj
+ * @param array User IDs who were in this group
+ * @since BuddyPress (1.6)
+ */
+function bp_groups_clear_group_members_caches( $group_obj, $user_ids ) {
+ // Clears the 'total groups' cache for each member in a group
+ foreach ( (array) $user_ids as $user_id )
+ groups_clear_group_user_object_cache( $group_obj->id, $user_id );
+}
+add_action( 'bp_groups_delete_group', 'bp_groups_clear_group_members_caches', 10, 2 );
+
</ins><span class="cx"> function groups_clear_group_user_object_cache( $group_id, $user_id ) {
</span><del>- wp_cache_delete( 'bp_total_groups_for_user_' . $user_id );
</del><ins>+ wp_cache_delete( 'bp_total_groups_for_user_' . $user_id, 'bp' );
</ins><span class="cx"> }
</span><span class="cx"> add_action( 'groups_join_group', 'groups_clear_group_user_object_cache', 10, 2 );
</span><span class="cx"> add_action( 'groups_leave_group', 'groups_clear_group_user_object_cache', 10, 2 );
</span></span></pre></div>
<a id="trunkbpgroupsbpgroupsclassesphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-groups/bp-groups-classes.php (6099 => 6100)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-groups/bp-groups-classes.php 2012-06-14 18:42:45 UTC (rev 6099)
+++ trunk/bp-groups/bp-groups-classes.php 2012-06-14 20:12:59 UTC (rev 6100)
</span><span class="lines">@@ -172,16 +172,16 @@
</span><span class="cx"> groups_delete_groupmeta( $this->id );
</span><span class="cx">
</span><span class="cx"> // Fetch the user IDs of all the members of the group
</span><del>- $user_ids = BP_Groups_Member::get_group_member_ids( $this->id );
- $user_ids = implode( ',', (array) $user_ids );
</del><ins>+ $user_ids = BP_Groups_Member::get_group_member_ids( $this->id );
+ $user_id_str = implode( ',', (array) $user_ids );
</ins><span class="cx">
</span><span class="cx"> // Modify group count usermeta for members
</span><del>- $wpdb->query( $wpdb->prepare( "UPDATE {$wpdb->usermeta} SET meta_value = meta_value - 1 WHERE meta_key = 'total_group_count' AND user_id IN ( {$user_ids} )" ) );
</del><ins>+ $wpdb->query( $wpdb->prepare( "UPDATE {$wpdb->usermeta} SET meta_value = meta_value - 1 WHERE meta_key = 'total_group_count' AND user_id IN ( {$user_id_str} )" ) );
</ins><span class="cx">
</span><span class="cx"> // Now delete all group member entries
</span><span class="cx"> BP_Groups_Member::delete_all( $this->id );
</span><span class="cx">
</span><del>- do_action_ref_array( 'bp_groups_delete_group', array( &$this ) );
</del><ins>+ do_action_ref_array( 'bp_groups_delete_group', array( &$this, $user_ids ) );
</ins><span class="cx">
</span><span class="cx"> wp_cache_delete( 'bp_groups_group_' . $this->id, 'bp' );
</span><span class="cx">
</span></span></pre></div>
<a id="trunkbpgroupsbpgroupsfunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-groups/bp-groups-functions.php (6099 => 6100)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-groups/bp-groups-functions.php 2012-06-14 18:42:45 UTC (rev 6099)
+++ trunk/bp-groups/bp-groups-functions.php 2012-06-14 20:12:59 UTC (rev 6100)
</span><span class="lines">@@ -129,7 +129,7 @@
</span><span class="cx"> do_action( 'groups_update_group', $group->id, $group );
</span><span class="cx"> }
</span><span class="cx">
</span><del>- do_action( 'groups_created_group', $group->id );
</del><ins>+ do_action( 'groups_created_group', $group->id, $group );
</ins><span class="cx">
</span><span class="cx"> return $group->id;
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>