<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][6051] trunk: Markup enhancements for profile visibility</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/6051">6051</a></dd>
<dt>Author</dt> <dd>boonebgorges</dd>
<dt>Date</dt> <dd>2012-05-31 20:42:53 +0000 (Thu, 31 May 2012)</dd>
</dl>
<h3>Log Message</h3>
<pre>Markup enhancements for profile visibility
- Removes an orphaned 'label' element
- Replaces some 'label' elements with 'fieldset' and 'legend' for greater
accuracy
- Changes some div elements into paragraphs, so that text does not appear
outside the context of semantic elements
- Modifications to the visibility options toggle JavaScript, for better
differentiation and smoothness
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/4224">#4224</a>
Props hnla</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpthemesbpdefault_incglobaljs">trunk/bp-themes/bp-default/_inc/global.js</a></li>
<li><a href="#trunkbpthemesbpdefaultmemberssingleprofileeditphp">trunk/bp-themes/bp-default/members/single/profile/edit.php</a></li>
<li><a href="#trunkbpthemesbpdefaultregistrationregisterphp">trunk/bp-themes/bp-default/registration/register.php</a></li>
<li><a href="#trunkbpxprofilebpxprofiletemplatephp">trunk/bp-xprofile/bp-xprofile-template.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpthemesbpdefault_incglobaljs"></a>
<div class="modfile"><h4>Modified: trunk/bp-themes/bp-default/_inc/global.js (6050 => 6051)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-themes/bp-default/_inc/global.js 2012-05-27 16:36:16 UTC (rev 6050)
+++ trunk/bp-themes/bp-default/_inc/global.js 2012-05-31 20:42:53 UTC (rev 6051)
</span><span class="lines">@@ -808,12 +808,12 @@
</span><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> /** Profile Visibility Settings *********************************/
</span><del>-
</del><ins>+ jq('.field-visibility-settings').hide();
</ins><span class="cx"> jq('.visibility-toggle-link').on( 'click', function() {
</span><span class="cx"> var toggle_div = jq(this).parent();
</span><span class="cx">
</span><del>- jq(toggle_div).slideUp( 200, function(){
- jq(toggle_div).siblings('.field-visibility-settings').slideDown(200);
</del><ins>+ jq(toggle_div).fadeOut( 600, function(){
+ jq(toggle_div).siblings('.field-visibility-settings').slideDown(400);
</ins><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> return false;
</span><span class="lines">@@ -822,8 +822,8 @@
</span><span class="cx"> jq('.field-visibility-settings-close').on( 'click', function() {
</span><span class="cx"> var settings_div = jq(this).parent();
</span><span class="cx">
</span><del>- jq(settings_div).slideUp( 200, function(){
- jq(settings_div).siblings('.field-visibility-settings-toggle').slideDown(200);
</del><ins>+ jq(settings_div).slideUp( 400, function(){
+ jq(settings_div).siblings('.field-visibility-settings-toggle').fadeIn(800);
</ins><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> return false;
</span></span></pre></div>
<a id="trunkbpthemesbpdefaultmemberssingleprofileeditphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-themes/bp-default/members/single/profile/edit.php (6050 => 6051)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-themes/bp-default/members/single/profile/edit.php 2012-05-27 16:36:16 UTC (rev 6050)
+++ trunk/bp-themes/bp-default/members/single/profile/edit.php 2012-05-31 20:42:53 UTC (rev 6051)
</span><span class="lines">@@ -114,15 +114,17 @@
</span><span class="cx"> <?php endif; ?>
</span><span class="cx">
</span><span class="cx"> <?php if ( bp_current_user_can( 'bp_xprofile_change_field_visibility' ) ) : ?>
</span><del>- <div class="field-visibility-settings-toggle" id="field-visibility-settings-toggle-<?php bp_the_profile_field_id() ?>">
</del><ins>+ <p class="field-visibility-settings-toggle" id="field-visibility-settings-toggle-<?php bp_the_profile_field_id() ?>">
</ins><span class="cx"> <?php printf( __( 'This field can be seen by: <span class="current-visibility-level">%s</span>', 'buddypress' ), bp_get_the_profile_field_visibility_level_label() ) ?> <a href="#" class="visibility-toggle-link"><?php _e( 'Change', 'buddypress' ); ?></a>
</span><del>- </div>
</del><ins>+ </p>
</ins><span class="cx">
</span><span class="cx"> <div class="field-visibility-settings" id="field-visibility-settings-<?php bp_the_profile_field_id() ?>">
</span><del>- <label for="field-visibility"><?php _e( 'Who can see this field?', 'buddypress' ) ?></label>
</del><ins>+ <fieldset>
+ <legend><?php _e( 'Who can see this field?', 'buddypress' ) ?></legend>
</ins><span class="cx">
</span><del>- <?php bp_profile_visibility_radio_buttons() ?>
</del><ins>+ <?php bp_profile_visibility_radio_buttons() ?>
</ins><span class="cx">
</span><ins>+ </fieldset>
</ins><span class="cx"> <a class="field-visibility-settings-close" href="#"><?php _e( 'Close', 'buddypress' ) ?></a>
</span><span class="cx"> </div>
</span><span class="cx"> <?php else : ?>
</span></span></pre></div>
<a id="trunkbpthemesbpdefaultregistrationregisterphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-themes/bp-default/registration/register.php (6050 => 6051)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-themes/bp-default/registration/register.php 2012-05-27 16:36:16 UTC (rev 6050)
+++ trunk/bp-themes/bp-default/registration/register.php 2012-05-31 20:42:53 UTC (rev 6051)
</span><span class="lines">@@ -155,21 +155,24 @@
</span><span class="cx"> <?php endif; ?>
</span><span class="cx">
</span><span class="cx"> <?php if ( bp_current_user_can( 'bp_xprofile_change_field_visibility' ) ) : ?>
</span><del>- <div class="field-visibility-settings-toggle" id="field-visibility-settings-toggle-<?php bp_the_profile_field_id() ?>">
</del><ins>+ <p class="field-visibility-settings-toggle" id="field-visibility-settings-toggle-<?php bp_the_profile_field_id() ?>">
</ins><span class="cx"> <?php printf( __( 'This field can be seen by: <span class="current-visibility-level">%s</span>', 'buddypress' ), bp_get_the_profile_field_visibility_level_label() ) ?> <a href="#" class="visibility-toggle-link">Change</a>
</span><del>- </div>
</del><ins>+ </p>
</ins><span class="cx">
</span><span class="cx"> <div class="field-visibility-settings" id="field-visibility-settings-<?php bp_the_profile_field_id() ?>">
</span><del>- <label for="field-visibility"><?php _e( 'Who can see this field?', 'buddypress' ) ?></label>
</del><ins>+ <fieldset>
+ <legend><?php _e( 'Who can see this field?', 'buddypress' ) ?></legend>
</ins><span class="cx">
</span><del>- <?php bp_profile_visibility_radio_buttons() ?>
</del><ins>+ <?php bp_profile_visibility_radio_buttons() ?>
</ins><span class="cx">
</span><ins>+ </fieldset>
</ins><span class="cx"> <a class="field-visibility-settings-close" href="#"><?php _e( 'Close', 'buddypress' ) ?></a>
</span><ins>+
</ins><span class="cx"> </div>
</span><span class="cx"> <?php else : ?>
</span><del>- <div class="field-visibility-settings-notoggle" id="field-visibility-settings-toggle-<?php bp_the_profile_field_id() ?>">
</del><ins>+ <p class="field-visibility-settings-notoggle" id="field-visibility-settings-toggle-<?php bp_the_profile_field_id() ?>">
</ins><span class="cx"> <?php printf( __( 'This field can be seen by: <span class="current-visibility-level">%s</span>', 'buddypress' ), bp_get_the_profile_field_visibility_level_label() ) ?>
</span><del>- </div>
</del><ins>+ </p>
</ins><span class="cx"> <?php endif ?>
</span><span class="cx">
</span><span class="cx">
</span></span></pre></div>
<a id="trunkbpxprofilebpxprofiletemplatephp"></a>
<div class="modfile"><h4>Modified: trunk/bp-xprofile/bp-xprofile-template.php (6050 => 6051)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-xprofile/bp-xprofile-template.php 2012-05-27 16:36:16 UTC (rev 6050)
+++ trunk/bp-xprofile/bp-xprofile-template.php 2012-05-31 20:42:53 UTC (rev 6051)
</span><span class="lines">@@ -899,7 +899,7 @@
</span><span class="cx"> foreach( bp_xprofile_get_visibility_levels() as $level ) {
</span><span class="cx"> $checked = $level['id'] == bp_get_the_profile_field_visibility_level() ? ' checked="checked" ' : '';
</span><span class="cx">
</span><del>- $html .= '<li><input type="radio" name="field_' . bp_get_the_profile_field_id() . '_visibility" value="' . esc_attr( $level['id'] ) . '"' . $checked . '> ' . esc_html( $level['label'] ) . '</li>';
</del><ins>+ $html .= '<li><label for="see-field_' . esc_attr( $level['id'] ) . '"><input type="radio" id="see-field_' . esc_attr( $level['id'] ) . '" name="field_' . bp_get_the_profile_field_id() . '_visibility" value="' . esc_attr( $level['id'] ) . '"' . $checked . ' /> ' . esc_html( $level['label'] ) . '</label></li>';
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> $html .= '</ul>';
</span></span></pre>
</div>
</div>
</body>
</html>