<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][5622] trunk/bp-activity/bp-activity-akismet.php: Activity Akismet now tidies up old meta.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/5622">5622</a></dd>
<dt>Author</dt> <dd>djpaul</dd>
<dt>Date</dt> <dd>2012-01-07 17:23:24 +0000 (Sat, 07 Jan 2012)</dd>
</dl>
<h3>Log Message</h3>
<pre>Activity Akismet now tidies up old meta. Fixes <a href="http://buddypress.trac.wordpress.org/ticket/3906">#3906</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpactivitybpactivityakismetphp">trunk/bp-activity/bp-activity-akismet.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpactivitybpactivityakismetphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-activity/bp-activity-akismet.php (5621 => 5622)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-activity/bp-activity-akismet.php 2012-01-07 00:36:24 UTC (rev 5621)
+++ trunk/bp-activity/bp-activity-akismet.php 2012-01-07 17:23:24 UTC (rev 5622)
</span><span class="lines">@@ -463,8 +463,13 @@
</span><span class="cx"> $response = akismet_http_post( $query_string, $akismet_api_host, $path, $akismet_api_port );
</span><span class="cx"> remove_filter( 'akismet_ua', array( $this, 'buddypress_ua' ) );
</span><span class="cx">
</span><ins>+ // Get the response
</ins><span class="cx"> $activity_data['bp_as_result'] = $response[1];
</span><span class="cx">
</span><ins>+ // Perform a daily tidy up
+ if ( ! wp_next_scheduled( 'bp_activity_akismet_delete_old_metadata' ) )
+ wp_schedule_event( time(), 'daily', 'bp_activity_akismet_delete_old_metadata' );
+
</ins><span class="cx"> return $activity_data;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -472,7 +477,7 @@
</span><span class="cx"> * Filters user agent when sending to Akismet.
</span><span class="cx"> *
</span><span class="cx"> * @param string $user_agent
</span><del>- * @since 1.0
</del><ins>+ * @since 1.6
</ins><span class="cx"> */
</span><span class="cx"> public function buddypress_ua( $user_agent ) {
</span><span class="cx"> return 'BuddyPress/' . bp_get_version() . ' | Akismet/'. constant( 'AKISMET_VERSION' );
</span><span class="lines">@@ -514,4 +519,29 @@
</span><span class="cx"> return $history;
</span><span class="cx"> }
</span><span class="cx"> }
</span><ins>+
+/**
+ * Deletes old spam activity meta data, as _bp_akismet_submission meta can be large.
+ *
+ * @global object $bp BuddyPress global settings
+ * @global wpdb $wpdb WordPress database object
+ * @since 1.6
+ */
+function bp_activity_akismet_delete_old_metadata() {
+ global $bp, $wpdb;
+
+ $interval = apply_filters( 'bp_activity_akismet_delete_meta_interval', 15 );
+
+ // Enforce a minimum of 1 day
+ $interval = max( 1, absint( $interval ) );
+
+ // _bp_akismet_submission meta values are large, so expire them after $interval days regardless of the activity status
+ $sql = $wpdb->prepare( "SELECT a.id FROM {$bp->activity->table_name} a LEFT JOIN {$bp->activity->table_name_meta} m ON a.id = m.activity_id WHERE m.meta_key = %s AND DATE_SUB(%s, INTERVAL {$interval} DAY) > a.date_recorded LIMIT 10000", '_bp_akismet_submission', current_time( 'mysql', 1 ) );
+ $activity_ids = $wpdb->get_col( $sql );
+
+ if ( ! empty( $activity_ids ) ) {
+ foreach ( $activity_ids as $activity_id )
+ bp_activity_delete_meta( $activity_id, '_bp_akismet_submission' );
+ }
+}
</ins><span class="cx"> ?>
</span><span class="cx">\ No newline at end of file
</span></span></pre>
</div>
</div>
</body>
</html>