<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][4966] trunk/bp-core/deprecated/1.5.php: Revert bp_core_add_admin_menu_page() back to BP 1.2.9 version to fix third-party plugins' menu problems.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/4966">4966</a></dd>
<dt>Author</dt> <dd>djpaul</dd>
<dt>Date</dt> <dd>2011-08-11 20:52:01 +0000 (Thu, 11 Aug 2011)</dd>
</dl>
<h3>Log Message</h3>
<pre>Revert bp_core_add_admin_menu_page() back to BP 1.2.9 version to fix third-party plugins' menu problems. Fixes <a href="http://buddypress.trac.wordpress.org/ticket/3454">#3454</a>, props johnjamesjacoby</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpcoredeprecated15php">trunk/bp-core/deprecated/1.5.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpcoredeprecated15php"></a>
<div class="modfile"><h4>Modified: trunk/bp-core/deprecated/1.5.php (4965 => 4966)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-core/deprecated/1.5.php 2011-08-11 20:44:20 UTC (rev 4965)
+++ trunk/bp-core/deprecated/1.5.php 2011-08-11 20:52:01 UTC (rev 4966)
</span><span class="lines">@@ -61,23 +61,45 @@
</span><span class="cx"> * @since 1.1
</span><span class="cx"> */
</span><span class="cx"> function bp_core_add_admin_menu_page( $args = '' ) {
</span><ins>+ global $_registered_pages, $admin_page_hooks, $menu;
+
+ _deprecated_function( __FUNCTION__, '1.5', 'Use add_menu_page()' );
+
</ins><span class="cx"> $defaults = array(
</span><ins>+ 'access_level' => 2,
+ 'file' => false,
+ 'function' => false,
+ 'icon_url' => false,
+ 'menu_title' => '',
</ins><span class="cx"> 'page_title' => '',
</span><del>- 'menu_title' => '',
- 'capability' => 'manage_options',
- 'file' => '',
- 'function' => '',
- 'icon_url' => '',
</del><span class="cx"> 'position' => 100
</span><span class="cx"> );
</span><span class="cx">
</span><span class="cx"> $r = wp_parse_args( $args, $defaults );
</span><span class="cx"> extract( $r, EXTR_SKIP );
</span><span class="cx">
</span><del>- _deprecated_function( __FUNCTION__, '1.5', 'Use add_menu_page()' );
- return add_menu_page( $page_title, $menu_title, $capability, $file, $function, $icon_url, $position );
</del><ins>+ $file = plugin_basename( $file );
+ $hookname = get_plugin_page_hookname( $file, '' );
+
+ $admin_page_hooks[$file] = sanitize_title( $menu_title );
+
+ if ( !empty( $function ) && !empty ( $hookname ) )
+ add_action( $hookname, $function );
+
+ if ( empty( $icon_url ) )
+ $icon_url = 'images/generic.png';
+ elseif ( is_ssl() && 0 === strpos( $icon_url, 'http://' ) )
+ $icon_url = 'https://' . substr( $icon_url, 7 );
+
+ do {
+ $position++;
+ } while ( !empty( $menu[$position] ) );
+
+ $menu[$position] = array ( $menu_title, $access_level, $file, $page_title, 'menu-top ' . $hookname, $hookname, $icon_url );
+ $_registered_pages[$hookname] = true;
+
+ return $hookname;
</ins><span class="cx"> }
</span><del>-
</del><span class="cx"> /** Activity ******************************************************************/
</span><span class="cx">
</span><span class="cx"> function bp_is_activity_permalink() {
</span></span></pre>
</div>
</div>
</body>
</html>