<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][4902] trunk/bp-messages: Removes null recipients from recipient_ids array before attempting to send private message.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/4902">4902</a></dd>
<dt>Author</dt> <dd>boonebgorges</dd>
<dt>Date</dt> <dd>2011-07-30 11:25:01 +0000 (Sat, 30 Jul 2011)</dd>
</dl>
<h3>Log Message</h3>
<pre>Removes null recipients from recipient_ids array before attempting to send private message. Fixes <a href="http://buddypress.trac.wordpress.org/ticket/3411">#3411</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpmessagesbpmessagesactionsphp">trunk/bp-messages/bp-messages-actions.php</a></li>
<li><a href="#trunkbpmessagesbpmessagesfunctionsphp">trunk/bp-messages/bp-messages-functions.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpmessagesbpmessagesactionsphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-messages/bp-messages-actions.php (4901 => 4902)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-messages/bp-messages-actions.php 2011-07-30 10:39:46 UTC (rev 4901)
+++ trunk/bp-messages/bp-messages-actions.php 2011-07-30 11:25:01 UTC (rev 4902)
</span><span class="lines">@@ -9,7 +9,7 @@
</span><span class="cx"> if ( !defined( 'ABSPATH' ) ) exit;
</span><span class="cx">
</span><span class="cx"> function messages_action_view_message() {
</span><del>- global $thread_id;
</del><ins>+ global $thread_id, $bp;
</ins><span class="cx">
</span><span class="cx"> if ( !bp_is_messages_component() || !bp_is_current_action( 'view' ) )
</span><span class="cx"> return false;
</span></span></pre></div>
<a id="trunkbpmessagesbpmessagesfunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-messages/bp-messages-functions.php (4901 => 4902)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-messages/bp-messages-functions.php 2011-07-30 10:39:46 UTC (rev 4901)
+++ trunk/bp-messages/bp-messages-functions.php 2011-07-30 11:25:01 UTC (rev 4902)
</span><span class="lines">@@ -55,7 +55,10 @@
</span><span class="cx"> if ( empty( $message->subject ) )
</span><span class="cx"> $message->subject = __( 'No Subject', 'buddypress' );
</span><span class="cx">
</span><del>- $recipient_ids = array();
</del><ins>+ $recipient_ids = array();
+
+ // Invalid recipients are added to an array, for future enhancements
+ $invalid_recipients = array();
</ins><span class="cx">
</span><span class="cx"> // Loop the recipients and convert all usernames to user_ids where needed
</span><span class="cx"> foreach( (array) $recipients as $recipient ) {
</span><span class="lines">@@ -65,16 +68,19 @@
</span><span class="cx">
</span><span class="cx"> if ( is_numeric( $recipient ) ) {
</span><span class="cx"> if ( bp_core_get_core_userdata( (int) $recipient ) )
</span><del>- $recipient_ids[] = (int) $recipient;
</del><ins>+ $recipient_id = (int) $recipient;
</ins><span class="cx">
</span><span class="cx"> } else {
</span><span class="cx"> if ( bp_is_username_compatibility_mode() )
</span><span class="cx"> $recipient_id = bp_core_get_userid( $recipient );
</span><span class="cx"> else
</span><span class="cx"> $recipient_id = bp_core_get_userid_from_nicename( $recipient );
</span><del>-
</del><ins>+ }
+
+ if ( !$recipient_id )
+ $invalid_recipients[] = $recipient;
+ else
</ins><span class="cx"> $recipient_ids[] = (int) $recipient_id;
</span><del>- }
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Strip the sender from the recipient list if they exist
</span></span></pre>
</div>
</div>
</body>
</html>