<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][4814] trunk/bp-themes/bp-default/_inc: Remove hidden delay from posting to the activity stream, and tweak behaviour of the &quot;what's up&quot; form when posting.</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/4814">4814</a></dd>
<dt>Author</dt> <dd>djpaul</dd>
<dt>Date</dt> <dd>2011-07-23 14:17:43 +0000 (Sat, 23 Jul 2011)</dd>
</dl>

<h3>Log Message</h3>
<pre>Remove hidden delay from posting to the activity stream, and tweak behaviour of the &quot;what's up&quot; form when posting. Fixes <a href="http://buddypress.trac.wordpress.org/ticket/3165">#3165</a>. See also <a href="http://buddypress.trac.wordpress.org/ticket/3360">#3360</a></pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpthemesbpdefault_inccssdefaultcss">trunk/bp-themes/bp-default/_inc/css/default.css</a></li>
<li><a href="#trunkbpthemesbpdefault_incglobaljs">trunk/bp-themes/bp-default/_inc/global.js</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpthemesbpdefault_inccssdefaultcss"></a>
<div class="modfile"><h4>Modified: trunk/bp-themes/bp-default/_inc/css/default.css (4813 => 4814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-themes/bp-default/_inc/css/default.css        2011-07-23 10:18:22 UTC (rev 4813)
+++ trunk/bp-themes/bp-default/_inc/css/default.css        2011-07-23 14:17:43 UTC (rev 4814)
</span><span class="lines">@@ -1089,8 +1089,17 @@
</span><span class="cx">         margin-bottom: 18px;
</span><span class="cx">         overflow: auto;
</span><span class="cx"> }
</span><ins>+#aw-whats-new-submit {
+        display: none;
+}
+#whats-new:focus {
+        border-color: rgba(31, 179, 221, 0.9) !important;
+        outline-color: rgba(31, 179, 221, 0.9);
+        box-shadow: 0 0 7px         rgba(31, 179, 221, 0.7);
+        -moz-box-shadow: 0 0 7px    rgba(31, 179, 221, 0.7);
+        -webkit-box-shadow: 0 0 7px rgba(31, 179, 221, 0.7);
+}
</ins><span class="cx"> 
</span><del>-
</del><span class="cx"> /*--------------------------------------------------------------
</span><span class="cx"> 6.1.1 - Activity Listing
</span><span class="cx"> --------------------------------------------------------------*/
</span><span class="lines">@@ -1539,6 +1548,12 @@
</span><span class="cx">         padding: 6px;
</span><span class="cx">         width: 90%;
</span><span class="cx"> }
</span><ins>+input[type=&quot;submit&quot;].pending,
+input[type=&quot;button&quot;].pending,
+input[type=&quot;reset&quot;].pending,
+input[type=&quot;submit&quot;].disabled,
+input[type=&quot;button&quot;].disabled,
+input[type=&quot;reset&quot;].disabled,
</ins><span class="cx"> button.pending,
</span><span class="cx"> button.disabled,
</span><span class="cx"> div.pending a,
</span><span class="lines">@@ -1547,6 +1562,12 @@
</span><span class="cx">         color: #bbb;
</span><span class="cx">         cursor: default;
</span><span class="cx"> }
</span><ins>+input[type=&quot;submit&quot;]:hover.pending,
+input[type=&quot;button&quot;]:hover.pending,
+input[type=&quot;reset&quot;]:hover.pending,
+input[type=&quot;submit&quot;]:hover.disabled,
+input[type=&quot;button&quot;]:hover.disabled,
+input[type=&quot;reset&quot;]:hover.disabled,
</ins><span class="cx"> button.pending:hover,
</span><span class="cx"> button.disabled:hover,
</span><span class="cx"> div.pending a:hover,
</span></span></pre></div>
<a id="trunkbpthemesbpdefault_incglobaljs"></a>
<div class="modfile"><h4>Modified: trunk/bp-themes/bp-default/_inc/global.js (4813 => 4814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-themes/bp-default/_inc/global.js        2011-07-23 10:18:22 UTC (rev 4813)
+++ trunk/bp-themes/bp-default/_inc/global.js        2011-07-23 14:17:43 UTC (rev 4814)
</span><span class="lines">@@ -21,15 +21,16 @@
</span><span class="cx">         bp_init_objects( objects );
</span><span class="cx"> 
</span><span class="cx">         /* @mention Compose Scrolling */
</span><del>-        if ( jq.query.get('r') ) {
-                if ( jq('textarea#whats-new').length ) {
-                        jq.scrollTo( jq('textarea#whats-new'), 500, { offset:-125, easing:'easeOutQuad' } );
-                        jq('textarea#whats-new').focus();
-                }
</del><ins>+        if ( jq.query.get('r') &amp;&amp; jq('textarea#whats-new').length ) {
+                jq.scrollTo( jq('textarea#whats-new'), 500, { offset:-125, easing:'easeOutQuad' } );
+                jq('textarea#whats-new').focus();
</ins><span class="cx">         }
</span><span class="cx"> 
</span><span class="cx">         /**** Activity Posting ********************************************************/
</span><span class="cx"> 
</span><ins>+        /* Textarea focus */
+        jq('#whats-new').focus( function(){ jq(&quot;#aw-whats-new-submit&quot;).fadeIn(300); });
+
</ins><span class="cx">         /* New posts */
</span><span class="cx">         jq(&quot;input#aw-whats-new-submit&quot;).click( function() {
</span><span class="cx">                 var button = jq(this);
</span><span class="lines">@@ -76,7 +77,6 @@
</span><span class="cx">                         if ( response[0] + response[1] == '-1' ) {
</span><span class="cx">                                 form.prepend( response.substr( 2, response.length ) );
</span><span class="cx">                                 jq( 'form#' + form.attr('id') + ' div.error').hide().fadeIn( 200 );
</span><del>-                                button.prop(&quot;disabled&quot;, false);
</del><span class="cx">                         } else {
</span><span class="cx">                                 if ( 0 == jq(&quot;ul.activity-list&quot;).length ) {
</span><span class="cx">                                         jq(&quot;div.error&quot;).slideUp(100).remove();
</span><span class="lines">@@ -108,10 +108,9 @@
</span><span class="cx">                                 jq(&quot;li.new-update&quot;).hide().slideDown( 300 );
</span><span class="cx">                                 jq(&quot;li.new-update&quot;).removeClass( 'new-update' );
</span><span class="cx">                                 jq(&quot;textarea#whats-new&quot;).val('');
</span><del>-
-                                /* Re-enable the submit button after 8 seconds. */
-                                setTimeout( function() { button.prop(&quot;disabled&quot;, false); }, 8000 );
</del><span class="cx">                         }
</span><ins>+
+                        button.fadeOut(100, function(){ button.prop(&quot;disabled&quot;, false); });
</ins><span class="cx">                 });
</span><span class="cx"> 
</span><span class="cx">                 return false;
</span><span class="lines">@@ -359,8 +358,7 @@
</span><span class="cx"> 
</span><span class="cx">                         /* Hide any error messages */
</span><span class="cx">                         jq( 'form#' + form + ' div.error').hide();
</span><del>-                        target.addClass('loading');
-                        target.prop('disabled', true);
</del><ins>+                        target.addClass('loading').prop('disabled', true);
</ins><span class="cx"> 
</span><span class="cx">                         jq.post( ajaxurl, {
</span><span class="cx">                                 action: 'new_activity_comment',
</span><span class="lines">@@ -397,10 +395,9 @@
</span><span class="cx"> 
</span><span class="cx">                                         /* Increase the &quot;Reply (X)&quot; button count */
</span><span class="cx">                                         jq('li#activity-' + form_id[2] + ' a.acomment-reply span').html( Number( jq('li#activity-' + form_id[2] + ' a.acomment-reply span').html() ) + 1 );
</span><del>-
-                                        /* Re-enable the submit button after 5 seconds. */
-                                        setTimeout( function() { target.prop(&quot;disabled&quot;, false); }, 5000 );
</del><span class="cx">                                 }
</span><ins>+
+                                target.fadeOut(100, function(){ target.prop(&quot;disabled&quot;, false); });
</ins><span class="cx">                         });
</span><span class="cx"> 
</span><span class="cx">                         return false;
</span></span></pre>
</div>
</div>

</body>
</html>