<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][4650] trunk: Audit the usage of $bp-&gt;members-&gt;slug and $bp-&gt;members-&gt;root_slug.</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd>4650</dd>
<dt>Author</dt> <dd>johnjamesjacoby</dd>
<dt>Date</dt> <dd>2011-07-12 02:58:25 +0000 (Tue, 12 Jul 2011)</dd>
</dl>

<h3>Log Message</h3>
<pre>Audit the usage of $bp-&gt;members-&gt;slug and $bp-&gt;members-&gt;root_slug. See #3325.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpcorebpcorebuddybarphp">trunk/bp-core/bp-core-buddybar.php</a></li>
<li><a href="#trunkbpcorebpcorefiltersphp">trunk/bp-core/bp-core-filters.php</a></li>
<li><a href="#trunkbpcorebpcorefunctionsphp">trunk/bp-core/bp-core-functions.php</a></li>
<li><a href="#trunkbpmembersbpmembersfunctionsphp">trunk/bp-members/bp-members-functions.php</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpcorebpcorebuddybarphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-core/bp-core-buddybar.php (4649 => 4650)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-core/bp-core-buddybar.php        2011-07-12 02:49:17 UTC (rev 4649)
+++ trunk/bp-core/bp-core-buddybar.php        2011-07-12 02:58:25 UTC (rev 4650)
</span><span class="lines">@@ -477,7 +477,7 @@
</span><span class="cx">         &lt;li class=&quot;align-right&quot; id=&quot;bp-adminbar-visitrandom-menu&quot;&gt;
</span><span class="cx">                 &lt;a href=&quot;#&quot;&gt;&lt;?php _e( 'Visit', 'buddypress' ) ?&gt;&lt;/a&gt;
</span><span class="cx">                 &lt;ul class=&quot;random-list&quot;&gt;
</span><del>-                        &lt;li&gt;&lt;a href=&quot;&lt;?php echo trailingslashit( bp_get_root_domain() . '/' . $bp-&gt;members-&gt;root_slug ) . '?random-member' ?&gt;&quot; rel=&quot;nofollow&quot;&gt;&lt;?php _e( 'Random Member', 'buddypress' ) ?&gt;&lt;/a&gt;&lt;/li&gt;
</del><ins>+                        &lt;li&gt;&lt;a href=&quot;&lt;?php echo trailingslashit( bp_get_root_domain() . '/' . bp_get_members_root_slug() ) . '?random-member' ?&gt;&quot; rel=&quot;nofollow&quot;&gt;&lt;?php _e( 'Random Member', 'buddypress' ) ?&gt;&lt;/a&gt;&lt;/li&gt;
</ins><span class="cx"> 
</span><span class="cx">                         &lt;?php if ( bp_is_active( 'groups' ) ) : ?&gt;
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkbpcorebpcorefiltersphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-core/bp-core-filters.php (4649 => 4650)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-core/bp-core-filters.php        2011-07-12 02:49:17 UTC (rev 4649)
+++ trunk/bp-core/bp-core-filters.php        2011-07-12 02:58:25 UTC (rev 4650)
</span><span class="lines">@@ -290,7 +290,7 @@
</span><span class="cx">         // An index or directory
</span><span class="cx">         } elseif ( bp_is_directory() ) {
</span><span class="cx">                 if ( !bp_current_component() )
</span><del>-                        $title = sprintf( __( '%s Directory', 'buddypress' ), bp_get_name_from_root_slug( $bp-&gt;members-&gt;slug ) );
</del><ins>+                        $title = sprintf( __( '%s Directory', 'buddypress' ), bp_get_name_from_root_slug( bp_members_slug() ) );
</ins><span class="cx">                 else
</span><span class="cx">                         $title = sprintf( __( '%s Directory', 'buddypress' ), bp_get_name_from_root_slug() );
</span><span class="cx"> 
</span><span class="lines">@@ -314,7 +314,8 @@
</span><span class="cx">         return apply_filters( 'bp_modify_page_title', $title . &quot; $sep &quot;, $title, $sep, $seplocation );
</span><span class="cx"> }
</span><span class="cx"> add_filter( 'wp_title', 'bp_modify_page_title', 10, 3 );
</span><del>-add_filter( 'bp_modify_page_title', 'wptexturize'   );
-add_filter( 'bp_modify_page_title', 'convert_chars' );
-add_filter( 'bp_modify_page_title', 'esc_html'      );
</del><ins>+add_filter( 'bp_modify_page_title', 'wptexturize'     );
+add_filter( 'bp_modify_page_title', 'convert_chars'   );
+add_filter( 'bp_modify_page_title', 'esc_html'        );
+
</ins><span class="cx"> ?&gt;
</span><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkbpcorebpcorefunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-core/bp-core-functions.php (4649 => 4650)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-core/bp-core-functions.php        2011-07-12 02:49:17 UTC (rev 4649)
+++ trunk/bp-core/bp-core-functions.php        2011-07-12 02:58:25 UTC (rev 4650)
</span><span class="lines">@@ -841,7 +841,7 @@
</span><span class="cx"> 
</span><span class="cx">                         case 'members':
</span><span class="cx">                         default:
</span><del>-                                $slug = $bp-&gt;members-&gt;root_slug;
</del><ins>+                                $slug = bp_get_members_root_slug();
</ins><span class="cx">                                 break;
</span><span class="cx">                 }
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkbpmembersbpmembersfunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-members/bp-members-functions.php (4649 => 4650)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-members/bp-members-functions.php        2011-07-12 02:49:17 UTC (rev 4649)
+++ trunk/bp-members/bp-members-functions.php        2011-07-12 02:58:25 UTC (rev 4650)
</span><span class="lines">@@ -109,7 +109,7 @@
</span><span class="cx"> 
</span><span class="cx">                 // If we are using a members slug, include it.
</span><span class="cx">                 if ( !defined( 'BP_ENABLE_ROOT_PROFILES' ) )
</span><del>-                        $domain = bp_get_root_domain() . '/' . $bp-&gt;members-&gt;root_slug . '/' . $username;
</del><ins>+                        $domain = bp_get_root_domain() . '/' . bp_get_members_root_slug() . '/' . $username;
</ins><span class="cx">                 else
</span><span class="cx">                         $domain = bp_get_root_domain() . '/' . $username;
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>