<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][4628] trunk: Introduces wrapper function bp_is_username_compatibility_mode() and refactors to avoid direct constant checks throughout BP.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd>4628</dd>
<dt>Author</dt> <dd>boonebgorges</dd>
<dt>Date</dt> <dd>2011-07-09 18:58:45 +0000 (Sat, 09 Jul 2011)</dd>
</dl>
<h3>Log Message</h3>
<pre>Introduces wrapper function bp_is_username_compatibility_mode() and refactors to avoid direct constant checks throughout BP. See #3314</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpactivitybpactivityfiltersphp">trunk/bp-activity/bp-activity-filters.php</a></li>
<li><a href="#trunkbpactivitybpactivityfunctionsphp">trunk/bp-activity/bp-activity-functions.php</a></li>
<li><a href="#trunkbpactivitybpactivitynotificationsphp">trunk/bp-activity/bp-activity-notifications.php</a></li>
<li><a href="#trunkbpcorebpcorecatchuriphp">trunk/bp-core/bp-core-catchuri.php</a></li>
<li><a href="#trunkbpcorebpcorefunctionsphp">trunk/bp-core/bp-core-functions.php</a></li>
<li><a href="#trunkbpmembersbpmembersfunctionsphp">trunk/bp-members/bp-members-functions.php</a></li>
<li><a href="#trunkbpmessagesbpmessagesfunctionsphp">trunk/bp-messages/bp-messages-functions.php</a></li>
<li><a href="#trunkbpthemesbpdefault_incajaxphp">trunk/bp-themes/bp-default/_inc/ajax.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpactivitybpactivityfiltersphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-activity/bp-activity-filters.php (4627 => 4628)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-activity/bp-activity-filters.php 2011-07-09 18:50:07 UTC (rev 4627)
+++ trunk/bp-activity/bp-activity-filters.php 2011-07-09 18:58:45 UTC (rev 4628)
</span><span class="lines">@@ -122,7 +122,7 @@
</span><span class="cx"> $usernames = bp_activity_find_mentions( $content );
</span><span class="cx">
</span><span class="cx"> foreach( (array)$usernames as $username ) {
</span><del>- if ( defined( 'BP_ENABLE_USERNAME_COMPATIBILITY_MODE' ) )
</del><ins>+ if ( bp_is_username_compatibility_mode() )
</ins><span class="cx"> $user_id = username_exists( $username );
</span><span class="cx"> else
</span><span class="cx"> $user_id = bp_core_get_userid_from_nicename( $username );
</span></span></pre></div>
<a id="trunkbpactivitybpactivityfunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-activity/bp-activity-functions.php (4627 => 4628)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-activity/bp-activity-functions.php 2011-07-09 18:50:07 UTC (rev 4627)
+++ trunk/bp-activity/bp-activity-functions.php 2011-07-09 18:58:45 UTC (rev 4628)
</span><span class="lines">@@ -69,7 +69,7 @@
</span><span class="cx">
</span><span class="cx"> if ( $usernames = bp_activity_find_mentions( strip_tags( $activity->content ) ) ) {
</span><span class="cx"> foreach( (array)$usernames as $username ) {
</span><del>- if ( defined( 'BP_ENABLE_USERNAME_COMPATIBILITY_MODE' ) )
</del><ins>+ if ( bp_is_username_compatibility_mode() )
</ins><span class="cx"> $user_id = username_exists( $username );
</span><span class="cx"> else
</span><span class="cx"> $user_id = bp_core_get_userid_from_nicename( $username );
</span></span></pre></div>
<a id="trunkbpactivitybpactivitynotificationsphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-activity/bp-activity-notifications.php (4627 => 4628)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-activity/bp-activity-notifications.php 2011-07-09 18:50:07 UTC (rev 4627)
+++ trunk/bp-activity/bp-activity-notifications.php 2011-07-09 18:58:45 UTC (rev 4628)
</span><span class="lines">@@ -20,7 +20,7 @@
</span><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> foreach( (array)$usernames as $username ) {
</span><del>- if ( defined( 'BP_ENABLE_USERNAME_COMPATIBILITY_MODE' ) )
</del><ins>+ if ( bp_is_username_compatibility_mode() )
</ins><span class="cx"> $receiver_user_id = bp_core_get_userid( $username );
</span><span class="cx"> else
</span><span class="cx"> $receiver_user_id = bp_core_get_userid_from_nicename( $username );
</span></span></pre></div>
<a id="trunkbpcorebpcorecatchuriphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-core/bp-core-catchuri.php (4627 => 4628)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-core/bp-core-catchuri.php 2011-07-09 18:50:07 UTC (rev 4627)
+++ trunk/bp-core/bp-core-catchuri.php 2011-07-09 18:58:45 UTC (rev 4628)
</span><span class="lines">@@ -237,7 +237,7 @@
</span><span class="cx"> if ( !empty( $bp_uri[$uri_offset + 1] ) ) {
</span><span class="cx">
</span><span class="cx"> // Switch the displayed_user based on compatbility mode
</span><del>- if ( defined( 'BP_ENABLE_USERNAME_COMPATIBILITY_MODE' ) )
</del><ins>+ if ( bp_is_username_compatibility_mode() )
</ins><span class="cx"> $bp->displayed_user->id = (int) bp_core_get_userid( urldecode( $bp_uri[$uri_offset + 1] ) );
</span><span class="cx"> else
</span><span class="cx"> $bp->displayed_user->id = (int) bp_core_get_userid_from_nicename( urldecode( $bp_uri[$uri_offset + 1] ) );
</span></span></pre></div>
<a id="trunkbpcorebpcorefunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-core/bp-core-functions.php (4627 => 4628)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-core/bp-core-functions.php 2011-07-09 18:50:07 UTC (rev 4627)
+++ trunk/bp-core/bp-core-functions.php 2011-07-09 18:58:45 UTC (rev 4628)
</span><span class="lines">@@ -1199,6 +1199,18 @@
</span><span class="cx"> return delete_user_meta( $user_id, bp_get_user_meta_key( $key ), $value );
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+/**
+ * Are we running username compatibility mode?
+ *
+ * @package BuddyPress
+ * @since 1.3
+ *
+ * @uses apply_filters() Filter 'bp_is_username_compatibility_mode' to alter
+ * @return bool False when compatibility mode is disabled (default); true when enabled
+ */
+function bp_is_username_compatibility_mode() {
+ return apply_filters( 'bp_is_username_compatibility_mode', defined( 'BP_ENABLE_USERNAME_COMPATIBILITY_MODE' ) && BP_ENABLE_USERNAME_COMPATIBILITY_MODE );
+}
</ins><span class="cx">
</span><span class="cx"> /** Global Manipulators *******************************************************/
</span><span class="cx">
</span></span></pre></div>
<a id="trunkbpmembersbpmembersfunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-members/bp-members-functions.php (4627 => 4628)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-members/bp-members-functions.php 2011-07-09 18:50:07 UTC (rev 4627)
+++ trunk/bp-members/bp-members-functions.php 2011-07-09 18:58:45 UTC (rev 4628)
</span><span class="lines">@@ -104,7 +104,7 @@
</span><span class="cx"> if ( !$domain = wp_cache_get( 'bp_user_domain_' . $user_id, 'bp' ) ) {
</span><span class="cx"> $username = bp_core_get_username( $user_id, $user_nicename, $user_login );
</span><span class="cx">
</span><del>- if ( defined( 'BP_ENABLE_USERNAME_COMPATIBILITY_MODE' ) )
</del><ins>+ if ( bp_is_username_compatibility_mode() )
</ins><span class="cx"> $username = rawurlencode( $username );
</span><span class="cx">
</span><span class="cx"> // If we are using a members slug, include it.
</span><span class="lines">@@ -241,7 +241,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Pull an audible and use the login over the nicename
</span><del>- if ( defined( 'BP_ENABLE_USERNAME_COMPATIBILITY_MODE' ) )
</del><ins>+ if ( bp_is_username_compatibility_mode() )
</ins><span class="cx"> $username = $user_login;
</span><span class="cx"> else
</span><span class="cx"> $username = $user_nicename;
</span><span class="lines">@@ -458,7 +458,7 @@
</span><span class="cx"> * @return str The link to the users home base. False on no match.
</span><span class="cx"> */
</span><span class="cx"> function bp_core_get_userlink_by_username( $username ) {
</span><del>- if ( defined( 'BP_ENABLE_USERNAME_COMPATIBILITY_MODE' ) )
</del><ins>+ if ( bp_is_username_compatibility_mode() )
</ins><span class="cx"> $user_id = bp_core_get_userid( $username );
</span><span class="cx"> else
</span><span class="cx"> $user_id = bp_core_get_userid_from_nicename( $username );
</span></span></pre></div>
<a id="trunkbpmessagesbpmessagesfunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-messages/bp-messages-functions.php (4627 => 4628)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-messages/bp-messages-functions.php 2011-07-09 18:50:07 UTC (rev 4627)
+++ trunk/bp-messages/bp-messages-functions.php 2011-07-09 18:58:45 UTC (rev 4628)
</span><span class="lines">@@ -66,7 +66,7 @@
</span><span class="cx"> $recipient_ids[] = (int) $recipient;
</span><span class="cx">
</span><span class="cx"> } else {
</span><del>- if ( defined( 'BP_ENABLE_USERNAME_COMPATIBILITY_MODE' ) )
</del><ins>+ if ( bp_is_username_compatibility_mode() )
</ins><span class="cx"> $recipient_id = bp_core_get_userid( $recipient );
</span><span class="cx"> else
</span><span class="cx"> $recipient_id = bp_core_get_userid_from_nicename( $recipient );
</span></span></pre></div>
<a id="trunkbpthemesbpdefault_incajaxphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-themes/bp-default/_inc/ajax.php (4627 => 4628)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-themes/bp-default/_inc/ajax.php 2011-07-09 18:50:07 UTC (rev 4627)
+++ trunk/bp-themes/bp-default/_inc/ajax.php 2011-07-09 18:58:45 UTC (rev 4628)
</span><span class="lines">@@ -657,7 +657,7 @@
</span><span class="cx"> if ( !$ud )
</span><span class="cx"> continue;
</span><span class="cx">
</span><del>- if ( defined( 'BP_ENABLE_USERNAME_COMPATIBILITY_MODE' ) )
</del><ins>+ if ( bp_is_username_compatibility_mode() )
</ins><span class="cx"> $username = $ud->user_login;
</span><span class="cx"> else
</span><span class="cx"> $username = $ud->user_nicename;
</span></span></pre>
</div>
</div>
</body>
</html>