<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][4373] trunk/bp-activity: Fixes text encoding in RSS titles for better character support.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd>4373</dd>
<dt>Author</dt> <dd>boonebgorges</dd>
<dt>Date</dt> <dd>2011-05-16 21:19:51 +0000 (Mon, 16 May 2011)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fixes text encoding in RSS titles for better character support. Fixes #2194. Props cnorris23</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpactivitybpactivitytemplatephp">trunk/bp-activity/bp-activity-template.php</a></li>
<li><a href="#trunkbpactivityfeedsbpactivityfavoritesfeedphp">trunk/bp-activity/feeds/bp-activity-favorites-feed.php</a></li>
<li><a href="#trunkbpactivityfeedsbpactivityfriendsfeedphp">trunk/bp-activity/feeds/bp-activity-friends-feed.php</a></li>
<li><a href="#trunkbpactivityfeedsbpactivitygroupfeedphp">trunk/bp-activity/feeds/bp-activity-group-feed.php</a></li>
<li><a href="#trunkbpactivityfeedsbpactivitymentionsfeedphp">trunk/bp-activity/feeds/bp-activity-mentions-feed.php</a></li>
<li><a href="#trunkbpactivityfeedsbpactivitymygroupsfeedphp">trunk/bp-activity/feeds/bp-activity-mygroups-feed.php</a></li>
<li><a href="#trunkbpactivityfeedsbpactivitypersonalfeedphp">trunk/bp-activity/feeds/bp-activity-personal-feed.php</a></li>
<li><a href="#trunkbpactivityfeedsbpactivitysitewidefeedphp">trunk/bp-activity/feeds/bp-activity-sitewide-feed.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpactivitybpactivitytemplatephp"></a>
<div class="modfile"><h4>Modified: trunk/bp-activity/bp-activity-template.php (4372 => 4373)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-activity/bp-activity-template.php        2011-05-16 20:54:02 UTC (rev 4372)
+++ trunk/bp-activity/bp-activity-template.php        2011-05-16 21:19:51 UTC (rev 4373)
</span><span class="lines">@@ -1272,7 +1272,7 @@
</span><span class="cx">                         $content = $activities_template->activity->content;
</span><span class="cx">
</span><span class="cx">                 $content = explode( '<span', $content );
</span><del>-                $title = trim( strip_tags( html_entity_decode( utf8_encode( $content[0] ) ) ) );
</del><ins>+                $title = strip_tags( ent2ncr( trim( convert_chars( $content[0] ) ) ) );
</ins><span class="cx">
</span><span class="cx">                 if ( ':' == substr( $title, -1 ) )
</span><span class="cx">                         $title = substr( $title, 0, -1 );
</span><span class="lines">@@ -1312,7 +1312,7 @@
</span><span class="cx">                 else
</span><span class="cx">                         $content = $activities_template->activity->action . ' ' . $activities_template->activity->content;
</span><span class="cx">
</span><del>-                return apply_filters( 'bp_get_activity_feed_item_description', html_entity_decode( str_replace( '%s', '', $content ) ) );
</del><ins>+                return apply_filters( 'bp_get_activity_feed_item_description', ent2ncr( convert_chars( str_replace( '%s', '', $content ) ) ) );
</ins><span class="cx">         }
</span><span class="cx">
</span><span class="cx"> /**
</span></span></pre></div>
<a id="trunkbpactivityfeedsbpactivityfavoritesfeedphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-activity/feeds/bp-activity-favorites-feed.php (4372 => 4373)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-activity/feeds/bp-activity-favorites-feed.php        2011-05-16 20:54:02 UTC (rev 4372)
+++ trunk/bp-activity/feeds/bp-activity-favorites-feed.php        2011-05-16 21:19:51 UTC (rev 4373)
</span><span class="lines">@@ -38,7 +38,7 @@
</span><span class="cx">
</span><span class="cx">                         <item>
</span><span class="cx">                                 <guid><?php bp_activity_thread_permalink() ?></guid>
</span><del>-                                <title><![CDATA[<?php bp_activity_feed_item_title() ?>]]></title>
</del><ins>+                                <title><?php bp_activity_feed_item_title() ?></title>
</ins><span class="cx">                                 <link><?php echo bp_activity_thread_permalink() ?></link>
</span><span class="cx">                                 <pubDate><?php echo mysql2date('D, d M Y H:i:s O', bp_get_activity_feed_item_date(), false); ?></pubDate>
</span><span class="cx">
</span></span></pre></div>
<a id="trunkbpactivityfeedsbpactivityfriendsfeedphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-activity/feeds/bp-activity-friends-feed.php (4372 => 4373)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-activity/feeds/bp-activity-friends-feed.php        2011-05-16 20:54:02 UTC (rev 4372)
+++ trunk/bp-activity/feeds/bp-activity-friends-feed.php        2011-05-16 21:19:51 UTC (rev 4373)
</span><span class="lines">@@ -32,7 +32,7 @@
</span><span class="cx">                 <?php while ( bp_activities() ) : bp_the_activity(); ?>
</span><span class="cx">                         <item>
</span><span class="cx">                                 <guid><?php bp_activity_thread_permalink() ?></guid>
</span><del>-                                <title><![CDATA[<?php bp_activity_feed_item_title() ?>]]></title>
</del><ins>+                                <title><?php bp_activity_feed_item_title() ?></title>
</ins><span class="cx">                                 <link><?php echo bp_activity_thread_permalink() ?></link>
</span><span class="cx">                                 <pubDate><?php echo mysql2date('D, d M Y H:i:s O', bp_get_activity_feed_item_date(), false); ?></pubDate>
</span><span class="cx">
</span></span></pre></div>
<a id="trunkbpactivityfeedsbpactivitygroupfeedphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-activity/feeds/bp-activity-group-feed.php (4372 => 4373)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-activity/feeds/bp-activity-group-feed.php        2011-05-16 20:54:02 UTC (rev 4372)
+++ trunk/bp-activity/feeds/bp-activity-group-feed.php        2011-05-16 21:19:51 UTC (rev 4373)
</span><span class="lines">@@ -31,7 +31,7 @@
</span><span class="cx">                 <?php while ( bp_activities() ) : bp_the_activity(); ?>
</span><span class="cx">                         <item>
</span><span class="cx">                                 <guid><?php bp_activity_thread_permalink() ?></guid>
</span><del>-                                <title><![CDATA[<?php bp_activity_feed_item_title() ?>]]></title>
</del><ins>+                                <title><?php bp_activity_feed_item_title() ?></title>
</ins><span class="cx">                                 <link><?php echo bp_activity_thread_permalink() ?></link>
</span><span class="cx">                                 <pubDate><?php echo mysql2date('D, d M Y H:i:s O', bp_get_activity_feed_item_date(), false); ?></pubDate>
</span><span class="cx">
</span></span></pre></div>
<a id="trunkbpactivityfeedsbpactivitymentionsfeedphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-activity/feeds/bp-activity-mentions-feed.php (4372 => 4373)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-activity/feeds/bp-activity-mentions-feed.php        2011-05-16 20:54:02 UTC (rev 4372)
+++ trunk/bp-activity/feeds/bp-activity-mentions-feed.php        2011-05-16 21:19:51 UTC (rev 4373)
</span><span class="lines">@@ -31,7 +31,7 @@
</span><span class="cx">                 <?php while ( bp_activities() ) : bp_the_activity(); ?>
</span><span class="cx">                         <item>
</span><span class="cx">                                 <guid><?php bp_activity_thread_permalink() ?></guid>
</span><del>-                                <title><![CDATA[<?php bp_activity_feed_item_title() ?>]]></title>
</del><ins>+                                <title><?php bp_activity_feed_item_title() ?></title>
</ins><span class="cx">                                 <link><?php echo bp_activity_thread_permalink() ?></link>
</span><span class="cx">                                 <pubDate><?php echo mysql2date('D, d M Y H:i:s O', bp_get_activity_feed_item_date(), false); ?></pubDate>
</span><span class="cx">
</span></span></pre></div>
<a id="trunkbpactivityfeedsbpactivitymygroupsfeedphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-activity/feeds/bp-activity-mygroups-feed.php (4372 => 4373)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-activity/feeds/bp-activity-mygroups-feed.php        2011-05-16 20:54:02 UTC (rev 4372)
+++ trunk/bp-activity/feeds/bp-activity-mygroups-feed.php        2011-05-16 21:19:51 UTC (rev 4373)
</span><span class="lines">@@ -36,7 +36,7 @@
</span><span class="cx">                 <?php while ( bp_activities() ) : bp_the_activity(); ?>
</span><span class="cx">                         <item>
</span><span class="cx">                                 <guid><?php bp_activity_thread_permalink() ?></guid>
</span><del>-                                <title><![CDATA[<?php bp_activity_feed_item_title() ?>]]></title>
</del><ins>+                                <title><?php bp_activity_feed_item_title() ?></title>
</ins><span class="cx">                                 <link><?php echo bp_activity_thread_permalink() ?></link>
</span><span class="cx">                                 <pubDate><?php echo mysql2date('D, d M Y H:i:s O', bp_get_activity_feed_item_date(), false); ?></pubDate>
</span><span class="cx">
</span></span></pre></div>
<a id="trunkbpactivityfeedsbpactivitypersonalfeedphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-activity/feeds/bp-activity-personal-feed.php (4372 => 4373)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-activity/feeds/bp-activity-personal-feed.php        2011-05-16 20:54:02 UTC (rev 4372)
+++ trunk/bp-activity/feeds/bp-activity-personal-feed.php        2011-05-16 21:19:51 UTC (rev 4373)
</span><span class="lines">@@ -31,7 +31,7 @@
</span><span class="cx">                 <?php while ( bp_activities() ) : bp_the_activity(); ?>
</span><span class="cx">                         <item>
</span><span class="cx">                                 <guid><?php bp_activity_thread_permalink() ?></guid>
</span><del>-                                <title><![CDATA[<?php bp_activity_feed_item_title() ?>]]></title>
</del><ins>+                                <title><?php bp_activity_feed_item_title() ?></title>
</ins><span class="cx">                                 <link><?php echo bp_activity_thread_permalink() ?></link>
</span><span class="cx">                                 <pubDate><?php echo mysql2date('D, d M Y H:i:s O', bp_get_activity_feed_item_date(), false); ?></pubDate>
</span><span class="cx">
</span></span></pre></div>
<a id="trunkbpactivityfeedsbpactivitysitewidefeedphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-activity/feeds/bp-activity-sitewide-feed.php (4372 => 4373)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-activity/feeds/bp-activity-sitewide-feed.php        2011-05-16 20:54:02 UTC (rev 4372)
+++ trunk/bp-activity/feeds/bp-activity-sitewide-feed.php        2011-05-16 21:19:51 UTC (rev 4373)
</span><span class="lines">@@ -32,7 +32,7 @@
</span><span class="cx">                 <?php while ( bp_activities() ) : bp_the_activity(); ?>
</span><span class="cx">                         <item>
</span><span class="cx">                                 <guid><?php bp_activity_thread_permalink() ?></guid>
</span><del>-                                <title><![CDATA[<?php bp_activity_feed_item_title() ?>]]></title>
</del><ins>+                                <title><?php bp_activity_feed_item_title() ?></title>
</ins><span class="cx">                                 <link><?php bp_activity_thread_permalink() ?></link>
</span><span class="cx">                                 <pubDate><?php echo mysql2date('D, d M Y H:i:s O', bp_get_activity_feed_item_date(), false); ?></pubDate>
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>