<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][4083] trunk/bp-xprofile: Ensure esc_html and force_balance_tags are called in the correct order when editing your profile.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd>4083</dd>
<dt>Author</dt> <dd>johnjamesjacoby</dd>
<dt>Date</dt> <dd>2011-03-08 00:55:09 +0000 (Tue, 08 Mar 2011)</dd>
</dl>
<h3>Log Message</h3>
<pre>Ensure esc_html and force_balance_tags are called in the correct order when editing your profile. (1.3 trunk)</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpxprofilebpxprofilefiltersphp">trunk/bp-xprofile/bp-xprofile-filters.php</a></li>
<li><a href="#trunkbpxprofilebpxprofiletemplatephp">trunk/bp-xprofile/bp-xprofile-template.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpxprofilebpxprofilefiltersphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-xprofile/bp-xprofile-filters.php (4082 => 4083)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-xprofile/bp-xprofile-filters.php        2011-03-08 00:34:43 UTC (rev 4082)
+++ trunk/bp-xprofile/bp-xprofile-filters.php        2011-03-08 00:55:09 UTC (rev 4083)
</span><span class="lines">@@ -2,9 +2,10 @@
</span><span class="cx">
</span><span class="cx"> /* Apply WordPress defined filters */
</span><span class="cx">
</span><del>-add_filter( 'bp_get_the_profile_field_name', 'wp_filter_kses', 1 );
-add_filter( 'bp_get_the_profile_field_edit_value', 'wp_filter_kses', 1 );
-add_filter( 'bp_get_the_profile_field_description', 'wp_filter_kses', 1 );
</del><ins>+add_filter( 'bp_get_the_profile_field_value', 'xprofile_filter_kses', 1 );
+add_filter( 'bp_get_the_profile_field_name', 'wp_filter_kses', 1 );
+add_filter( 'bp_get_the_profile_field_edit_value', 'wp_filter_kses', 1 );
+add_filter( 'bp_get_the_profile_field_description', 'wp_filter_kses', 1 );
</ins><span class="cx">
</span><span class="cx"> add_filter( 'bp_get_the_profile_field_value', 'wptexturize' );
</span><span class="cx"> add_filter( 'bp_get_the_profile_field_value', 'convert_smilies', 2 );
</span><span class="lines">@@ -13,6 +14,9 @@
</span><span class="cx"> add_filter( 'bp_get_the_profile_field_value', 'make_clickable' );
</span><span class="cx"> add_filter( 'bp_get_the_profile_field_value', 'force_balance_tags' );
</span><span class="cx">
</span><ins>+add_filter( 'bp_get_the_profile_field_edit_value', 'force_balance_tags' );
+add_filter( 'bp_get_the_profile_field_edit_value', 'esc_html' );
+
</ins><span class="cx"> add_filter( 'bp_get_the_profile_field_value', 'stripslashes' );
</span><span class="cx"> add_filter( 'bp_get_the_profile_field_edit_value', 'stripslashes' );
</span><span class="cx"> add_filter( 'bp_get_the_profile_field_name', 'stripslashes' );
</span><span class="lines">@@ -30,8 +34,6 @@
</span><span class="cx">
</span><span class="cx"> /* Custom BuddyPress filters */
</span><span class="cx">
</span><del>-add_filter( 'bp_get_the_profile_field_value', 'xprofile_filter_kses', 1 );
-
</del><span class="cx"> add_filter( 'bp_get_the_profile_field_value', 'xprofile_filter_format_field_value', 1, 2 );
</span><span class="cx"> add_filter( 'bp_get_the_site_member_profile_data', 'xprofile_filter_format_field_value', 1, 2 );
</span><span class="cx"> add_filter( 'bp_get_the_profile_field_value', 'xprofile_filter_link_profile_data', 50, 2 );
</span><span class="lines">@@ -49,8 +51,8 @@
</span><span class="cx"> function xprofile_filter_kses( $content ) {
</span><span class="cx">         global $allowedtags;
</span><span class="cx">
</span><del>-        $xprofile_allowedtags = $allowedtags;
-        $xprofile_allowedtags['a']['rel'] = array();
</del><ins>+        $xprofile_allowedtags = $allowedtags;
+        $xprofile_allowedtags['a']['rel'] = array();
</ins><span class="cx">
</span><span class="cx">         $xprofile_allowedtags = apply_filters( 'xprofile_allowed_tags', $xprofile_allowedtags );
</span><span class="cx">         return wp_kses( $content, $xprofile_allowedtags );
</span></span></pre></div>
<a id="trunkbpxprofilebpxprofiletemplatephp"></a>
<div class="modfile"><h4>Modified: trunk/bp-xprofile/bp-xprofile-template.php (4082 => 4083)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-xprofile/bp-xprofile-template.php        2011-03-08 00:34:43 UTC (rev 4082)
+++ trunk/bp-xprofile/bp-xprofile-template.php        2011-03-08 00:55:09 UTC (rev 4083)
</span><span class="lines">@@ -323,10 +323,9 @@
</span><span class="cx">                                 $field->data->value = $_POST['field_' . $field->id];
</span><span class="cx">                 }
</span><span class="cx">
</span><del>-                if ( isset( $field->data->value ) )
-                        return apply_filters( 'bp_get_the_profile_field_edit_value', esc_html( bp_unserialize_profile_field( $field->data->value ) ), $field->type, $field->id );
-                else
-                        return apply_filters( 'bp_get_the_profile_field_edit_value', '', $field->type, $field->id );
</del><ins>+                $field_value = isset( $field->data->value ) ? bp_unserialize_profile_field( $field->data->value ) : '';
+
+                return apply_filters( 'bp_get_the_profile_field_edit_value', $field_value, $field->type, $field->id );
</ins><span class="cx">         }
</span><span class="cx">
</span><span class="cx"> function bp_the_profile_field_type() {
</span></span></pre>
</div>
</div>
</body>
</html>