<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][4061] trunk/bp-xprofile: Prevent errors when an xprofile field group does not have any fields in the admin.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd>4061</dd>
<dt>Author</dt> <dd>johnjamesjacoby</dd>
<dt>Date</dt> <dd>2011-02-21 14:23:09 +0000 (Mon, 21 Feb 2011)</dd>
</dl>
<h3>Log Message</h3>
<pre>Prevent errors when an xprofile field group does not have any fields in the admin. Also check POST values for multi-option fields.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpxprofilebpxprofileadminphp">trunk/bp-xprofile/bp-xprofile-admin.php</a></li>
<li><a href="#trunkbpxprofilebpxprofileclassesphp">trunk/bp-xprofile/bp-xprofile-classes.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpxprofilebpxprofileadminphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-xprofile/bp-xprofile-admin.php (4060 => 4061)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-xprofile/bp-xprofile-admin.php 2011-02-21 14:22:31 UTC (rev 4060)
+++ trunk/bp-xprofile/bp-xprofile-admin.php 2011-02-21 14:23:09 UTC (rev 4061)
</span><span class="lines">@@ -109,7 +109,7 @@
</span><span class="cx">
</span><span class="cx"> <?php endif;
</span><span class="cx">
</span><del>- if ( $group->fields ) :
</del><ins>+ if ( !empty( $group->fields ) ) :
</ins><span class="cx"> foreach ( $group->fields as $field ) {
</span><span class="cx">
</span><span class="cx"> // Load the field
</span></span></pre></div>
<a id="trunkbpxprofilebpxprofileclassesphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-xprofile/bp-xprofile-classes.php (4060 => 4061)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-xprofile/bp-xprofile-classes.php 2011-02-21 14:22:31 UTC (rev 4060)
+++ trunk/bp-xprofile/bp-xprofile-classes.php 2011-02-21 14:23:09 UTC (rev 4061)
</span><span class="lines">@@ -384,20 +384,32 @@
</span><span class="cx"> $parent_id = $wpdb->insert_id;
</span><span class="cx">
</span><span class="cx"> if ( 'radio' == $this->type ) {
</span><del>- $options = apply_filters( 'xprofile_field_options_before_save', $_POST['radio_option'], 'radio' );
- $defaults = apply_filters( 'xprofile_field_default_before_save', $_POST['isDefault_radio_option'], 'radio' );
</del><ins>+ $post_option = !empty( $_POST['radio_option'] ) ? $_POST['radio_option'] : '';
+ $post_default = !empty( $_POST['isDefault_radio_option'] ) ? $_POST['isDefault_radio_option'] : '';
</ins><span class="cx">
</span><ins>+ $options = apply_filters( 'xprofile_field_options_before_save', $post_option, 'radio' );
+ $defaults = apply_filters( 'xprofile_field_default_before_save', $post_default, 'radio' );
+
</ins><span class="cx"> } else if ( 'selectbox' == $this->type ) {
</span><del>- $options = apply_filters( 'xprofile_field_options_before_save', $_POST['selectbox_option'], 'selectbox' );
- $defaults = apply_filters( 'xprofile_field_default_before_save', $_POST['isDefault_selectbox_option'], 'selectbox' );
</del><ins>+ $post_option = !empty( $_POST['selectbox_option'] ) ? $_POST['selectbox_option'] : '';
+ $post_default = !empty( $_POST['isDefault_selectbox_option'] ) ? $_POST['isDefault_selectbox_option'] : '';
</ins><span class="cx">
</span><ins>+ $options = apply_filters( 'xprofile_field_options_before_save', $post_option, 'selectbox' );
+ $defaults = apply_filters( 'xprofile_field_default_before_save', $post_default, 'selectbox' );
+
</ins><span class="cx"> } else if ( 'multiselectbox' == $this->type ) {
</span><del>- $options = apply_filters( 'xprofile_field_options_before_save', $_POST['multiselectbox_option'], 'multiselectbox' );
- $defaults = apply_filters( 'xprofile_field_default_before_save', $_POST['isDefault_multiselectbox_option'], 'multiselectbox' );
</del><ins>+ $post_option = !empty( $_POST['multiselectbox_option'] ) ? $_POST['multiselectbox_option'] : '';
+ $post_default = !empty( $_POST['isDefault_multiselectbox_option'] ) ? $_POST['isDefault_multiselectbox_option'] : '';
</ins><span class="cx">
</span><ins>+ $options = apply_filters( 'xprofile_field_options_before_save', $post_option, 'multiselectbox' );
+ $defaults = apply_filters( 'xprofile_field_default_before_save', $post_default, 'multiselectbox' );
+
</ins><span class="cx"> } else if ( 'checkbox' == $this->type ) {
</span><del>- $options = apply_filters( 'xprofile_field_options_before_save', $_POST['checkbox_option'], 'checkbox' );
- $defaults = apply_filters( 'xprofile_field_default_before_save', $_POST['isDefault_checkbox_option'], 'checkbox' );
</del><ins>+ $post_option = !empty( $_POST['checkbox_option'] ) ? $_POST['checkbox_option'] : '';
+ $post_default = !empty( $_POST['isDefault_checkbox_option'] ) ? $_POST['isDefault_checkbox_option'] : '';
+
+ $options = apply_filters( 'xprofile_field_options_before_save', $post_option, 'checkbox' );
+ $defaults = apply_filters( 'xprofile_field_default_before_save', $post_default, 'checkbox' );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> $counter = 1;
</span></span></pre>
</div>
</div>
</body>
</html>