<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][3919] trunk/bp-groups/bp-groups-filters.php: Fix situation where hidden/private groups with forums might not load topics correctly on the forums directory.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd>3919</dd>
<dt>Author</dt> <dd>johnjamesjacoby</dd>
<dt>Date</dt> <dd>2011-01-25 21:29:43 +0000 (Tue, 25 Jan 2011)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fix situation where hidden/private groups with forums might not load topics correctly on the forums directory.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpgroupsbpgroupsfiltersphp">trunk/bp-groups/bp-groups-filters.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpgroupsbpgroupsfiltersphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-groups/bp-groups-filters.php (3918 => 3919)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-groups/bp-groups-filters.php 2011-01-25 21:11:32 UTC (rev 3918)
+++ trunk/bp-groups/bp-groups-filters.php 2011-01-25 21:29:43 UTC (rev 3919)
</span><span class="lines">@@ -64,11 +64,15 @@
</span><span class="cx"> function groups_add_forum_privacy_sql() {
</span><span class="cx"> global $bp;
</span><span class="cx">
</span><del>- /* Only filter the forum SQL on group pages or on the forums directory */
- if ( bp_is_forums_component() || ( !empty( $bp->groups->current_group ) && 'public' == $bp->groups->current_group->status ) ) {
</del><ins>+ // Only filter the forum SQL on group pages or on the forums directory
+ if ( bp_is_forums_component() ||
+ ( !empty( $bp->groups->current_group ) &&
+ ( 'public' == $bp->groups->current_group->status ) ||
+ ( 1 == $bp->groups->current_group->is_member ) ) ) {
+
</ins><span class="cx"> add_filter( 'get_topics_fields', 'groups_add_forum_fields_sql' );
</span><span class="cx"> add_filter( 'get_topics_index_hint', 'groups_add_forum_tables_sql' );
</span><del>- add_filter( 'get_topics_where', 'groups_add_forum_where_sql' );
</del><ins>+ add_filter( 'get_topics_where', 'groups_add_forum_where_sql' );
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> add_filter( 'bbpress_init', 'groups_add_forum_privacy_sql' );
</span><span class="lines">@@ -85,8 +89,14 @@
</span><span class="cx"> function groups_add_forum_where_sql( $sql ) {
</span><span class="cx"> global $bp;
</span><span class="cx">
</span><del>- $bp->groups->filter_sql = ' AND ' . $sql;
- return "(gm.meta_key = 'forum_id' AND gm.meta_value = t.forum_id) AND g.status = 'public' AND " . $sql;
</del><ins>+ if ( !is_super_admin() || !bp_group_is_member( $bp->groups->current_group->id ) )
+ $must_be_public = "AND g.status = 'public'";
+ else
+ $must_be_public = '';
+
+ $bp->groups->filter_sql = $must_be_public . ' AND ' . $sql;
+
+ return "(gm.meta_key = 'forum_id' AND gm.meta_value = t.forum_id) {$must_be_public} AND {$sql}";
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function groups_filter_bbpress_caps( $value, $cap, $args ) {
</span></span></pre>
</div>
</div>
</body>
</html>