<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][3812] trunk/bp-themes/bp-default/_inc/global.js: Improve javascript class checks.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd>3812</dd>
<dt>Author</dt> <dd>djpaul</dd>
<dt>Date</dt> <dd>2011-01-22 10:42:45 +0000 (Sat, 22 Jan 2011)</dd>
</dl>
<h3>Log Message</h3>
<pre>Improve javascript class checks. Fixes #3013</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpthemesbpdefault_incglobaljs">trunk/bp-themes/bp-default/_inc/global.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpthemesbpdefault_incglobaljs"></a>
<div class="modfile"><h4>Modified: trunk/bp-themes/bp-default/_inc/global.js (3811 => 3812)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-themes/bp-default/_inc/global.js 2011-01-22 10:30:23 UTC (rev 3811)
+++ trunk/bp-themes/bp-default/_inc/global.js 2011-01-22 10:42:45 UTC (rev 3812)
</span><span class="lines">@@ -157,7 +157,7 @@
</span><span class="cx"> var target = jq(event.target);
</span><span class="cx">
</span><span class="cx"> /* Favoriting activity stream items */
</span><del>- if ( target.attr('class') == 'fav' || target.attr('class') == 'unfav' ) {
</del><ins>+ if ( target.hasClass('fav') || target.hasClass('unfav') ) {
</ins><span class="cx"> var type = target.attr('class')
</span><span class="cx"> var parent = target.parent().parent().parent();
</span><span class="cx"> var parent_id = parent.attr('id').substr( 9, parent.attr('id').length );
</span><span class="lines">@@ -238,7 +238,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /* Load more updates at the end of the page */
</span><del>- if ( target.parent().attr('class') == 'load-more' ) {
</del><ins>+ if ( target.parent().hasClass('load-more') ) {
</ins><span class="cx"> jq("#content li.load-more").addClass('loading');
</span><span class="cx">
</span><span class="cx"> if ( null == jq.cookie('bp-activity-oldestpage') )
</span><span class="lines">@@ -278,8 +278,8 @@
</span><span class="cx"> var target = jq(event.target);
</span><span class="cx">
</span><span class="cx"> /* Comment / comment reply links */
</span><del>- if ( target.attr('class') == 'acomment-reply' || target.parent().attr('class') == 'acomment-reply' ) {
- if ( target.parent().attr('class') == 'acomment-reply' )
</del><ins>+ if ( target.hasClass('acomment-reply') || target.parent().hasClass('acomment-reply') ) {
+ if ( target.parent().hasClass('acomment-reply') )
</ins><span class="cx"> target = target.parent();
</span><span class="cx">
</span><span class="cx"> var id = target.attr('id');
</span><span class="lines">@@ -307,7 +307,7 @@
</span><span class="cx"> jq('li#activity-' + a_id + ' div.activity-comments').append( form );
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if ( form.parent().attr( 'class' ) == 'activity-comments' )
</del><ins>+ if ( form.parent().hasClass( 'activity-comments' ) )
</ins><span class="cx"> form.addClass('root');
</span><span class="cx">
</span><span class="cx"> form.slideDown( 200 );
</span><span class="lines">@@ -323,7 +323,7 @@
</span><span class="cx"> var form_parent = form.parent();
</span><span class="cx"> var form_id = form.attr('id').split('-');
</span><span class="cx">
</span><del>- if ( 'activity-comments' !== form_parent.attr('class') ) {
</del><ins>+ if ( !form_parent.hasClass('activity-comments') ) {
</ins><span class="cx"> var tmp_id = form_parent.attr('id').split('-');
</span><span class="cx"> var comment_id = tmp_id[1];
</span><span class="cx"> } else {
</span><span class="lines">@@ -355,7 +355,7 @@
</span><span class="cx"> form.fadeOut( 200,
</span><span class="cx"> function() {
</span><span class="cx"> if ( 0 == form.parent().children('ul').length ) {
</span><del>- if ( form.parent().attr('class') == 'activity-comments' )
</del><ins>+ if ( form.parent().hasClass('activity-comments') )
</ins><span class="cx"> form.parent().prepend('<ul></ul>');
</span><span class="cx"> else
</span><span class="cx"> form.parent().append('<ul></ul>');
</span><span class="lines">@@ -461,7 +461,7 @@
</span><span class="cx">
</span><span class="cx"> if ( keyCode == 27 ) {
</span><span class="cx"> if (element.tagName == 'TEXTAREA') {
</span><del>- if ( jq(element).attr('class') == 'ac-input' )
</del><ins>+ if ( jq(element).hasClass('ac-input') )
</ins><span class="cx"> jq(element).parent().parent().parent().slideUp( 200 );
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>