<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][3660] trunk: Speed up forum directory's "last active" bbPress SQL query to stop it fetching information we aren't using.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd>3660</dd>
<dt>Author</dt> <dd>djpaul</dd>
<dt>Date</dt> <dd>2011-01-05 22:03:41 +0000 (Wed, 05 Jan 2011)</dd>
</dl>
<h3>Log Message</h3>
<pre>Speed up forum directory's "last active" bbPress SQL query to stop it fetching information we aren't using. Helps fix #2421</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpforumsbpforumsfiltersphp">trunk/bp-forums/bp-forums-filters.php</a></li>
<li><a href="#trunkbpforumsphp">trunk/bp-forums.php</a></li>
<li><a href="#trunkbpgroupsbpgroupsfiltersphp">trunk/bp-groups/bp-groups-filters.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpforumsbpforumsfiltersphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-forums/bp-forums-filters.php (3659 => 3660)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-forums/bp-forums-filters.php 2011-01-04 22:54:44 UTC (rev 3659)
+++ trunk/bp-forums/bp-forums-filters.php 2011-01-05 22:03:41 UTC (rev 3660)
</span><span class="lines">@@ -131,5 +131,4 @@
</span><span class="cx"> }
</span><span class="cx"> add_filter( 'bp_get_the_topic_post_edit_text', 'bp_forums_strip_mentions_on_post_edit' );
</span><span class="cx"> add_filter( 'bp_get_the_topic_text', 'bp_forums_strip_mentions_on_post_edit' );
</span><del>-
-?>
</del><ins>+?>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkbpforumsphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-forums.php (3659 => 3660)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-forums.php 2011-01-04 22:54:44 UTC (rev 3659)
+++ trunk/bp-forums.php 2011-01-05 22:03:41 UTC (rev 3660)
</span><span class="lines">@@ -372,7 +372,7 @@
</span><span class="cx">
</span><span class="cx"> do_action( 'bbpress_init' );
</span><span class="cx">
</span><del>- $count = $bbdb->get_results( $bbdb->prepare( "SELECT t.topic_id FROM {$bbdb->topics} AS t". groups_add_forum_tables_sql( '' ) . " WHERE " . groups_add_forum_where_sql( "t.topic_status = '0'" ) ) );
</del><ins>+ $count = $bbdb->get_results( $bbdb->prepare( "SELECT t.topic_id FROM {$bbdb->topics} AS t". groups_add_forum_tables_sql( '' ) . " WHERE " . groups_add_forum_where_sql( "t.topic_status = 0" ) ) );
</ins><span class="cx"> return apply_filters( 'bp_forums_total_topic_count', count( (array)$count ) );
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -546,7 +546,6 @@
</span><span class="cx"> return $posts;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-
</del><span class="cx"> function bp_forums_get_forum_topicpost_count( $forum_id ) {
</span><span class="cx"> global $wpdb, $bbdb;
</span><span class="cx">
</span><span class="lines">@@ -556,7 +555,6 @@
</span><span class="cx"> return $wpdb->get_results( $wpdb->prepare( "SELECT topics, posts from {$bbdb->forums} WHERE forum_id = %d", $forum_id ) );
</span><span class="cx"> }
</span><span class="cx">
</span><del>-
</del><span class="cx"> function bp_forums_filter_caps( $allcaps ) {
</span><span class="cx"> global $bp, $wp_roles, $bb_table_prefix;
</span><span class="cx">
</span><span class="lines">@@ -588,5 +586,4 @@
</span><span class="cx"> add_action( 'bp_forums_new_forum', 'bp_core_clear_cache' );
</span><span class="cx"> add_action( 'bp_forums_new_topic', 'bp_core_clear_cache' );
</span><span class="cx"> add_action( 'bp_forums_new_post', 'bp_core_clear_cache' );
</span><del>-
</del><span class="cx"> ?>
</span><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkbpgroupsbpgroupsfiltersphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-groups/bp-groups-filters.php (3659 => 3660)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-groups/bp-groups-filters.php 2011-01-04 22:54:44 UTC (rev 3659)
+++ trunk/bp-groups/bp-groups-filters.php 2011-01-05 22:03:41 UTC (rev 3660)
</span><span class="lines">@@ -105,4 +105,15 @@
</span><span class="cx"> }
</span><span class="cx"> add_filter( 'bb_current_user_can', 'groups_filter_bbpress_caps', 10, 3 );
</span><span class="cx">
</span><ins>+/**
+ * Amends the forum directory's "last active" bbPress SQL query to stop it fetching
+ * information we aren't going to use. This speeds up the query.
+ *
+ * @see BB_Query::_filter_sql()
+ * @since 1.3
+ */
+function groups_filter_forums_root_page_sql( $sql ) {
+ return apply_filters( 'groups_filter_bbpress_root_page_sql', 't.topic_id' );
+}
+add_filter( 'get_latest_topics_fields', 'groups_filter_forums_root_page_sql' );
</ins><span class="cx"> ?>
</span><span class="cx">\ No newline at end of file
</span></span></pre>
</div>
</div>
</body>
</html>