<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][3541] trunk/bp-groups: Always set is_member/is_banned in get_group_extras(), also updates bp_group_is_user_banned() for these changes.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd>3541</dd>
<dt>Author</dt> <dd>djpaul</dd>
<dt>Date</dt> <dd>2010-12-19 12:29:04 +0000 (Sun, 19 Dec 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre>Always set is_member/is_banned in get_group_extras(), also updates bp_group_is_user_banned() for these changes. Fixes #2960</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpgroupsbpgroupsclassesphp">trunk/bp-groups/bp-groups-classes.php</a></li>
<li><a href="#trunkbpgroupsbpgroupstemplatetagsphp">trunk/bp-groups/bp-groups-templatetags.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpgroupsbpgroupsclassesphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-groups/bp-groups-classes.php (3540 => 3541)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-groups/bp-groups-classes.php 2010-12-19 11:10:20 UTC (rev 3540)
+++ trunk/bp-groups/bp-groups-classes.php 2010-12-19 12:29:04 UTC (rev 3541)
</span><span class="lines">@@ -526,6 +526,8 @@
</span><span class="cx"> /* Fetch the logged in users status within each group */
</span><span class="cx"> $user_status = $wpdb->get_col( $wpdb->prepare( "SELECT group_id FROM {$bp->groups->table_name_members} WHERE user_id = %d AND group_id IN ( {$group_ids} ) AND is_confirmed = 1 AND is_banned = 0", $bp->loggedin_user->id ) );
</span><span class="cx"> for ( $i = 0; $i < count( $paged_groups ); $i++ ) {
</span><ins>+ $paged_groups[$i]->is_member = false;
+
</ins><span class="cx"> foreach ( (array)$user_status as $group_id ) {
</span><span class="cx"> if ( $group_id == $paged_groups[$i]->id )
</span><span class="cx"> $paged_groups[$i]->is_member = true;
</span><span class="lines">@@ -534,6 +536,8 @@
</span><span class="cx">
</span><span class="cx"> $user_banned = $wpdb->get_col( $wpdb->prepare( "SELECT group_id FROM {$bp->groups->table_name_members} WHERE is_banned = 1 AND user_id = %d AND group_id IN ( {$group_ids} )", $bp->loggedin_user->id ) );
</span><span class="cx"> for ( $i = 0; $i < count( $paged_groups ); $i++ ) {
</span><ins>+ $paged_groups[$i]->is_banned = false;
+
</ins><span class="cx"> foreach ( (array)$user_banned as $group_id ) {
</span><span class="cx"> if ( $group_id == $paged_groups[$i]->id )
</span><span class="cx"> $paged_groups[$i]->is_banned = true;
</span></span></pre></div>
<a id="trunkbpgroupsbpgroupstemplatetagsphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-groups/bp-groups-templatetags.php (3540 => 3541)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-groups/bp-groups-templatetags.php 2010-12-19 11:10:20 UTC (rev 3540)
+++ trunk/bp-groups/bp-groups-templatetags.php 2010-12-19 12:29:04 UTC (rev 3541)
</span><span class="lines">@@ -1023,8 +1023,8 @@
</span><span class="cx"> * Checks if a user is banned from a group.
</span><span class="cx"> *
</span><span class="cx"> * If this function is invoked inside the groups template loop (e.g. the group directory), then
</span><del>- * $groups_template->group->is_banned is set if the user is banned, so use that instead of making
- * another SQL query.
</del><ins>+ * check $groups_template->group->is_banned instead of making another SQL query.
+ * However, if used in a single group's pages, we must use groups_is_user_banned().
</ins><span class="cx"> *
</span><span class="cx"> * @global object $bp BuddyPress global settings
</span><span class="cx"> * @global BP_Groups_Template $groups_template Group template loop object
</span><span class="lines">@@ -1033,7 +1033,7 @@
</span><span class="cx"> * @return bool If user is banned from the group or not
</span><span class="cx"> * @since 1.3
</span><span class="cx"> */
</span><del>-function bp_group_is_user_banned( $group = false, $user_id = false ) {
</del><ins>+function bp_group_is_user_banned( $group = false, $user_id = 0 ) {
</ins><span class="cx"> global $bp, $groups_template;
</span><span class="cx">
</span><span class="cx"> // Site admins always have access
</span><span class="lines">@@ -1043,8 +1043,8 @@
</span><span class="cx"> if ( !$group ) {
</span><span class="cx"> $group =& $groups_template->group;
</span><span class="cx">
</span><del>- if ( !$user_id && !empty( $group->is_banned ) )
- return apply_filters( 'bp_group_is_member_banned', true );
</del><ins>+ if ( !$user_id && isset( $group->is_banned ) )
+ return apply_filters( 'bp_group_is_user_banned', $group->is_banned );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if ( !$user_id )
</span></span></pre>
</div>
</div>
</body>
</html>