<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[BuddyPress] [3317] trunk:
  Adds default state selector for Members and Groups widgets.</title>
</head>
<body>

<div id="msg">
<dl>
<dt>Revision</dt> <dd>3317</dd>
<dt>Author</dt> <dd>boonebgorges</dd>
<dt>Date</dt> <dd>2010-10-27 15:48:30 +0000 (Wed, 27 Oct 2010)</dd>
</dl>

<h3>Log Message</h3>
<pre>Adds default state selector for Members and Groups widgets. Fixes #1177</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpcorebpcorewidgetsphp">trunk/bp-core/bp-core-widgets.php</a></li>
<li><a href="#trunkbpgroupsbpgroupswidgetsphp">trunk/bp-groups/bp-groups-widgets.php</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpcorebpcorewidgetsphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-core/bp-core-widgets.php (3316 => 3317)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-core/bp-core-widgets.php        2010-10-27 13:13:35 UTC (rev 3316)
+++ trunk/bp-core/bp-core-widgets.php        2010-10-27 15:48:30 UTC (rev 3317)
</span><span class="lines">@@ -18,25 +18,28 @@
</span><span class="cx">                         wp_enqueue_script( 'bp_core_widget_members-js', BP_PLUGIN_URL . '/bp-core/js/widget-members.js', array('jquery') );
</span><span class="cx">         }
</span><span class="cx"> 
</span><del>-        function widget($args, $instance) {
</del><ins>+        function widget( $args, $instance ) {
</ins><span class="cx">                 global $bp;
</span><span class="cx"> 
</span><span class="cx">                 extract( $args );
</span><span class="cx"> 
</span><ins>+                if ( !$instance['member_default'] )
+                        $instance['member_default'] = 'active';
+
</ins><span class="cx">                 echo $before_widget;
</span><span class="cx">                 echo $before_title
</span><span class="cx">                    . $widget_name
</span><span class="cx">                    . $after_title; ?&gt;
</span><span class="cx"> 
</span><del>-                &lt;?php if ( bp_has_members( 'user_id=0&amp;type=newest&amp;max=' . $instance['max_members'] . '&amp;populate_extras=0' ) ) : ?&gt;
</del><ins>+                &lt;?php if ( bp_has_members( 'user_id=0&amp;type=' . $instance['member_default'] . '&amp;max=' . $instance['max_members'] . '&amp;populate_extras=0' ) ) : ?&gt;
</ins><span class="cx">                         &lt;div class=&quot;item-options&quot; id=&quot;members-list-options&quot;&gt;
</span><span class="cx">                                 &lt;span class=&quot;ajax-loader&quot; id=&quot;ajax-loader-members&quot;&gt;&lt;/span&gt;
</span><del>-                                &lt;a href=&quot;&lt;?php echo site_url() . '/' . BP_MEMBERS_SLUG ?&gt;&quot; id=&quot;newest-members&quot; class=&quot;selected&quot;&gt;&lt;?php _e( 'Newest', 'buddypress' ) ?&gt;&lt;/a&gt;
-                                |  &lt;a href=&quot;&lt;?php echo site_url() . '/' . BP_MEMBERS_SLUG ?&gt;&quot; id=&quot;recently-active-members&quot;&gt;&lt;?php _e( 'Active', 'buddypress' ) ?&gt;&lt;/a&gt;
</del><ins>+                                &lt;a href=&quot;&lt;?php echo site_url() . '/' . $bp-&gt;members-&gt;slug ?&gt;&quot; id=&quot;newest-members&quot; &lt;?php if ( $instance['member_default'] == 'newest' ) : ?&gt;class=&quot;selected&quot;&lt;?php endif; ?&gt;&gt;&lt;?php _e( 'Newest', 'buddypress' ) ?&gt;&lt;/a&gt;
+                                |  &lt;a href=&quot;&lt;?php echo site_url() . '/' . $bp-&gt;members-&gt;slug ?&gt;&quot; id=&quot;recently-active-members&quot; &lt;?php if ( $instance['member_default'] == 'active' ) : ?&gt;class=&quot;selected&quot;&lt;?php endif; ?&gt;&gt;&lt;?php _e( 'Active', 'buddypress' ) ?&gt;&lt;/a&gt;
</ins><span class="cx"> 
</span><span class="cx">                                 &lt;?php if ( bp_is_active( 'friends' ) ) : ?&gt;
</span><span class="cx"> 
</span><del>-                                        | &lt;a href=&quot;&lt;?php echo site_url() . '/' . BP_MEMBERS_SLUG ?&gt;&quot; id=&quot;popular-members&quot;&gt;&lt;?php _e( 'Popular', 'buddypress' ) ?&gt;&lt;/a&gt;
</del><ins>+                                        | &lt;a href=&quot;&lt;?php echo site_url() . '/' . $bp-&gt;members-&gt;slug ?&gt;&quot; id=&quot;popular-members&quot; &lt;?php if ( $instance['member_default'] == 'popular' ) : ?&gt;class=&quot;selected&quot;&lt;?php endif; ?&gt;&gt;&lt;?php _e( 'Popular', 'buddypress' ) ?&gt;&lt;/a&gt;
</ins><span class="cx"> 
</span><span class="cx">                                 &lt;?php endif; ?&gt;
</span><span class="cx"> 
</span><span class="lines">@@ -51,7 +54,18 @@
</span><span class="cx"> 
</span><span class="cx">                                                 &lt;div class=&quot;item&quot;&gt;
</span><span class="cx">                                                         &lt;div class=&quot;item-title fn&quot;&gt;&lt;a href=&quot;&lt;?php bp_member_permalink() ?&gt;&quot; title=&quot;&lt;?php bp_member_name() ?&gt;&quot;&gt;&lt;?php bp_member_name() ?&gt;&lt;/a&gt;&lt;/div&gt;
</span><del>-                                                        &lt;div class=&quot;item-meta&quot;&gt;&lt;span class=&quot;activity&quot;&gt;&lt;?php bp_member_registered() ?&gt;&lt;/span&gt;&lt;/div&gt;
</del><ins>+                                                        &lt;div class=&quot;item-meta&quot;&gt;
+                                                                &lt;span class=&quot;activity&quot;&gt;
+                                                                &lt;?php
+                                                                        if ( 'newest' == $instance['member_default'] )
+                                                                                bp_member_registered();                                                                
+                                                                        if ( 'active' == $instance['member_default'] )
+                                                                                bp_member_last_active();
+                                                                        if ( 'popular' == $instance['member_default'] )
+                                                                                bp_member_total_friend_count();
+                                                                ?&gt;
+                                                                &lt;/span&gt;
+                                                        &lt;/div&gt;
</ins><span class="cx">                                                 &lt;/div&gt;
</span><span class="cx">                                         &lt;/li&gt;
</span><span class="cx"> 
</span><span class="lines">@@ -75,16 +89,29 @@
</span><span class="cx">         function update( $new_instance, $old_instance ) {
</span><span class="cx">                 $instance = $old_instance;
</span><span class="cx">                 $instance['max_members'] = strip_tags( $new_instance['max_members'] );
</span><ins>+                $instance['member_default'] = strip_tags( $new_instance['member_default'] );
</ins><span class="cx"> 
</span><span class="cx">                 return $instance;
</span><span class="cx">         }
</span><span class="cx"> 
</span><span class="cx">         function form( $instance ) {
</span><del>-                $instance = wp_parse_args( (array) $instance, array( 'max_members' =&gt; 5 ) );
</del><ins>+                $instance = wp_parse_args( (array) $instance, array( 'max_members' =&gt; 5, 'member_default' =&gt; 'active' ) );
</ins><span class="cx">                 $max_members = strip_tags( $instance['max_members'] );
</span><ins>+                $member_default = strip_tags( $instance['member_default'] );
</ins><span class="cx">                 ?&gt;
</span><span class="cx"> 
</span><del>-                &lt;p&gt;&lt;label for=&quot;bp-core-widget-members-max&quot;&gt;&lt;?php _e('Max Members to show:', 'buddypress'); ?&gt; &lt;input class=&quot;widefat&quot; id=&quot;&lt;?php echo $this-&gt;get_field_id( 'max_members' ); ?&gt;&quot; name=&quot;&lt;?php echo $this-&gt;get_field_name( 'max_members' ); ?&gt;&quot; type=&quot;text&quot; value=&quot;&lt;?php echo esc_attr( $max_members ); ?&gt;&quot; style=&quot;width: 30%&quot; /&gt;&lt;/label&gt;&lt;/p&gt;
</del><ins>+                &lt;p&gt;&lt;label for=&quot;bp-core-widget-members-max&quot;&gt;&lt;?php _e('Max members to show:', 'buddypress'); ?&gt; &lt;input class=&quot;widefat&quot; id=&quot;&lt;?php echo $this-&gt;get_field_id( 'max_members' ); ?&gt;&quot; name=&quot;&lt;?php echo $this-&gt;get_field_name( 'max_members' ); ?&gt;&quot; type=&quot;text&quot; value=&quot;&lt;?php echo esc_attr( $max_members ); ?&gt;&quot; style=&quot;width: 30%&quot; /&gt;&lt;/label&gt;&lt;/p&gt;
+                                
+                &lt;p&gt;
+                        &lt;label for=&quot;bp-core-widget-groups-default&quot;&gt;&lt;?php _e('Default members to show:', 'buddypress'); ?&gt; 
+                        &lt;select name=&quot;&lt;?php echo $this-&gt;get_field_name( 'member_default' ) ?&gt;&quot;&gt;
+                                &lt;option value=&quot;newest&quot; &lt;?php if ( $member_default == 'newest' ) : ?&gt;selected=&quot;selected&quot;&lt;?php endif; ?&gt;&gt;&lt;?php _e( 'Newest', 'buddypress' ) ?&gt;&lt;/option&gt;
+                                &lt;option value=&quot;active&quot; &lt;?php if ( $member_default == 'active' ) : ?&gt;selected=&quot;selected&quot;&lt;?php endif; ?&gt;&gt;&lt;?php _e( 'Active', 'buddypress' ) ?&gt;&lt;/option&gt;
+                                &lt;option value=&quot;popular&quot;  &lt;?php if ( $member_default == 'popular' ) : ?&gt;selected=&quot;selected&quot;&lt;?php endif; ?&gt;&gt;&lt;?php _e( 'Popular', 'buddypress' ) ?&gt;&lt;/option&gt;
+                        &lt;/select&gt;                        
+                        &lt;/label&gt;
+                &lt;/p&gt;
+        
</ins><span class="cx">         &lt;?php
</span><span class="cx">         }
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkbpgroupsbpgroupswidgetsphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-groups/bp-groups-widgets.php (3316 => 3317)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-groups/bp-groups-widgets.php        2010-10-27 13:13:35 UTC (rev 3316)
+++ trunk/bp-groups/bp-groups-widgets.php        2010-10-27 15:48:30 UTC (rev 3317)
</span><span class="lines">@@ -16,22 +16,25 @@
</span><span class="cx">                         wp_enqueue_script( 'groups_widget_groups_list-js', BP_PLUGIN_URL . '/bp-groups/js/widget-groups.js', array('jquery') );
</span><span class="cx">         }
</span><span class="cx"> 
</span><del>-        function widget($args, $instance) {
</del><ins>+        function widget( $args, $instance ) {
</ins><span class="cx">                 global $bp;
</span><span class="cx"> 
</span><span class="cx">             extract( $args );
</span><span class="cx"> 
</span><ins>+                if ( !$instance['group_default'] )
+                        $instance['group_default'] = 'popular';
+
</ins><span class="cx">                 echo $before_widget;
</span><span class="cx">                 echo $before_title
</span><span class="cx">                    . $widget_name
</span><span class="cx">                    . $after_title; ?&gt;
</span><span class="cx"> 
</span><del>-                &lt;?php if ( bp_has_groups( 'type=popular&amp;per_page=' . $instance['max_groups'] . '&amp;max=' . $instance['max_groups'] ) ) : ?&gt;
</del><ins>+                &lt;?php if ( bp_has_groups( 'type=' . $instance['group_default'] . '&amp;max=' . $instance['max_groups'] ) ) : ?&gt;
</ins><span class="cx">                         &lt;div class=&quot;item-options&quot; id=&quot;groups-list-options&quot;&gt;
</span><span class="cx">                                 &lt;span class=&quot;ajax-loader&quot; id=&quot;ajax-loader-groups&quot;&gt;&lt;/span&gt;
</span><del>-                                &lt;a href=&quot;&lt;?php echo site_url() . '/' . $bp-&gt;groups-&gt;slug ?&gt;&quot; id=&quot;newest-groups&quot;&gt;&lt;?php _e(&quot;Newest&quot;, 'buddypress') ?&gt;&lt;/a&gt; |
-                                &lt;a href=&quot;&lt;?php echo site_url() . '/' . $bp-&gt;groups-&gt;slug ?&gt;&quot; id=&quot;recently-active-groups&quot;&gt;&lt;?php _e(&quot;Active&quot;, 'buddypress') ?&gt;&lt;/a&gt; |
-                                &lt;a href=&quot;&lt;?php echo site_url() . '/' . $bp-&gt;groups-&gt;slug ?&gt;&quot; id=&quot;popular-groups&quot; class=&quot;selected&quot;&gt;&lt;?php _e(&quot;Popular&quot;, 'buddypress') ?&gt;&lt;/a&gt;
</del><ins>+                                &lt;a href=&quot;&lt;?php echo site_url() . '/' . $bp-&gt;groups-&gt;slug ?&gt;&quot; id=&quot;newest-groups&quot;&lt;?php if ( $instance['group_default'] == 'newest' ) : ?&gt; class=&quot;selected&quot;&lt;?php endif; ?&gt;&gt;&lt;?php _e(&quot;Newest&quot;, 'buddypress') ?&gt;&lt;/a&gt; |
+                                &lt;a href=&quot;&lt;?php echo site_url() . '/' . $bp-&gt;groups-&gt;slug ?&gt;&quot; id=&quot;recently-active-groups&quot;&lt;?php if ( $instance['group_default'] == 'active' ) : ?&gt; class=&quot;selected&quot;&lt;?php endif; ?&gt;&gt;&lt;?php _e(&quot;Active&quot;, 'buddypress') ?&gt;&lt;/a&gt; |
+                                &lt;a href=&quot;&lt;?php echo site_url() . '/' . $bp-&gt;groups-&gt;slug ?&gt;&quot; id=&quot;popular-groups&quot; &lt;?php if ( $instance['group_default'] == 'popular' ) : ?&gt; class=&quot;selected&quot;&lt;?php endif; ?&gt;&gt;&lt;?php _e(&quot;Popular&quot;, 'buddypress') ?&gt;&lt;/a&gt;
</ins><span class="cx">                         &lt;/div&gt;
</span><span class="cx"> 
</span><span class="cx">                         &lt;ul id=&quot;groups-list&quot; class=&quot;item-list&quot;&gt;
</span><span class="lines">@@ -43,7 +46,18 @@
</span><span class="cx"> 
</span><span class="cx">                                                 &lt;div class=&quot;item&quot;&gt;
</span><span class="cx">                                                         &lt;div class=&quot;item-title&quot;&gt;&lt;a href=&quot;&lt;?php bp_group_permalink() ?&gt;&quot; title=&quot;&lt;?php bp_group_name() ?&gt;&quot;&gt;&lt;?php bp_group_name() ?&gt;&lt;/a&gt;&lt;/div&gt;
</span><del>-                                                        &lt;div class=&quot;item-meta&quot;&gt;&lt;span class=&quot;activity&quot;&gt;&lt;?php bp_group_member_count() ?&gt;&lt;/span&gt;&lt;/div&gt;
</del><ins>+                                                        &lt;div class=&quot;item-meta&quot;&gt;
+                                                                &lt;span class=&quot;activity&quot;&gt;
+                                                                &lt;?php
+                                                                        if ( 'newest' == $instance['group_default'] )
+                                                                                printf( __( 'created %s ago', 'buddypress' ), bp_get_group_date_created() );
+                                                                        if ( 'active' == $instance['group_default'] )
+                                                                                printf( __( 'active %s ago', 'buddypress' ), bp_get_group_last_active() );
+                                                                        else if ( 'popular' == $instance['group_default'] )
+                                                                                bp_group_member_count();
+                                                                ?&gt;
+                                                                &lt;/span&gt;
+                                                        &lt;/div&gt;
</ins><span class="cx">                                                 &lt;/div&gt;
</span><span class="cx">                                         &lt;/li&gt;
</span><span class="cx"> 
</span><span class="lines">@@ -67,16 +81,28 @@
</span><span class="cx">         function update( $new_instance, $old_instance ) {
</span><span class="cx">                 $instance = $old_instance;
</span><span class="cx">                 $instance['max_groups'] = strip_tags( $new_instance['max_groups'] );
</span><ins>+                $instance['group_default'] = strip_tags( $new_instance['group_default'] );
</ins><span class="cx"> 
</span><span class="cx">                 return $instance;
</span><span class="cx">         }
</span><span class="cx"> 
</span><span class="cx">         function form( $instance ) {
</span><del>-                $instance = wp_parse_args( (array) $instance, array( 'max_groups' =&gt; 5 ) );
</del><ins>+                $instance = wp_parse_args( (array) $instance, array( 'max_groups' =&gt; 5, 'group_default' =&gt; 'active' ) );
</ins><span class="cx">                 $max_groups = strip_tags( $instance['max_groups'] );
</span><ins>+                $group_default = strip_tags( $instance['group_default'] );
</ins><span class="cx">                 ?&gt;
</span><span class="cx"> 
</span><span class="cx">                 &lt;p&gt;&lt;label for=&quot;bp-groups-widget-groups-max&quot;&gt;&lt;?php _e('Max groups to show:', 'buddypress'); ?&gt; &lt;input class=&quot;widefat&quot; id=&quot;&lt;?php echo $this-&gt;get_field_id( 'max_groups' ); ?&gt;&quot; name=&quot;&lt;?php echo $this-&gt;get_field_name( 'max_groups' ); ?&gt;&quot; type=&quot;text&quot; value=&quot;&lt;?php echo esc_attr( $max_groups ); ?&gt;&quot; style=&quot;width: 30%&quot; /&gt;&lt;/label&gt;&lt;/p&gt;
</span><ins>+                
+                &lt;p&gt;
+                        &lt;label for=&quot;bp-groups-widget-groups-default&quot;&gt;&lt;?php _e('Default groups to show:', 'buddypress'); ?&gt; 
+                        &lt;select name=&quot;&lt;?php echo $this-&gt;get_field_name( 'group_default' ); ?&gt;&quot;&gt;
+                                &lt;option value=&quot;newest&quot; &lt;?php if ( $group_default == 'newest' ) : ?&gt;selected=&quot;selected&quot;&lt;?php endif; ?&gt;&gt;&lt;?php _e( 'Newest', 'buddypress' ) ?&gt;&lt;/option&gt;
+                                &lt;option value=&quot;active&quot; &lt;?php if ( $group_default == 'active' ) : ?&gt;selected=&quot;selected&quot;&lt;?php endif; ?&gt;&gt;&lt;?php _e( 'Active', 'buddypress' ) ?&gt;&lt;/option&gt;
+                                &lt;option value=&quot;popular&quot;  &lt;?php if ( $group_default == 'popular' ) : ?&gt;selected=&quot;selected&quot;&lt;?php endif; ?&gt;&gt;&lt;?php _e( 'Popular', 'buddypress' ) ?&gt;&lt;/option&gt;
+                        &lt;/select&gt;                        
+                        &lt;/label&gt;
+                &lt;/p&gt;
</ins><span class="cx">         &lt;?php
</span><span class="cx">         }
</span><span class="cx"> }
</span></span></pre>
</div>
</div>

</body>
</html>