<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[BuddyPress] [2932] branches/1.2/bp-core/bp-core-signup.php: Fixes #2290</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd>2932</dd>
<dt>Author</dt> <dd>johnjamesjacoby</dd>
<dt>Date</dt> <dd>2010-04-19 02:31:29 +0000 (Mon, 19 Apr 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fixes #2290</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branches12bpcorebpcoresignupphp">branches/1.2/bp-core/bp-core-signup.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branches12bpcorebpcoresignupphp"></a>
<div class="modfile"><h4>Modified: branches/1.2/bp-core/bp-core-signup.php (2931 => 2932)</h4>
<pre class="diff"><span>
<span class="info">--- branches/1.2/bp-core/bp-core-signup.php        2010-04-19 00:58:26 UTC (rev 2931)
+++ branches/1.2/bp-core/bp-core-signup.php        2010-04-19 02:31:29 UTC (rev 2932)
</span><span class="lines">@@ -53,19 +53,30 @@
</span><span class="cx">                 $bp->signup->username = $_POST['signup_username'];
</span><span class="cx">                 $bp->signup->email = $_POST['signup_email'];
</span><span class="cx">
</span><del>-                if ( !empty( $_POST['signup_profile_field_ids'] ) && function_exists( 'xprofile_check_is_required_field' ) ) {
-                        /* Now we've checked account details, we can check profile information */
-                        $profile_field_ids = explode( ',', $_POST['signup_profile_field_ids'] );
</del><ins>+                /* Now we've checked account details, we can check profile information */
+                if ( function_exists( 'xprofile_check_is_required_field' ) ) {
</ins><span class="cx">
</span><del>-                        /* Loop through the posted fields formatting any datebox values then validate the field */
-                        foreach ( (array) $profile_field_ids as $field_id ) {
-                                if ( !isset( $_POST['field_' . $field_id] ) ) {
-                                        if ( isset( $_POST['field_' . $field_id . '_day'] ) )
-                                                $_POST['field_' . $field_id] = strtotime( $_POST['field_' . $field_id . '_day'] . $_POST['field_' . $field_id . '_month'] . $_POST['field_' . $field_id . '_year'] );
</del><ins>+                        /* Make sure hidden field is passed and populated */
+                        if ( isset( $_POST['signup_profile_field_ids'] ) && !empty( $_POST['signup_profile_field_ids'] ) ) {
+
+                                /* Let's compact any profile field info into an array */
+                                $profile_field_ids = explode( ',', $_POST['signup_profile_field_ids'] );
+
+                                /* Loop through the posted fields formatting any datebox values then validate the field */
+                                foreach ( (array) $profile_field_ids as $field_id ) {
+                                        if ( !isset( $_POST['field_' . $field_id] ) ) {
+                                                if ( isset( $_POST['field_' . $field_id . '_day'] ) )
+                                                        $_POST['field_' . $field_id] = strtotime( $_POST['field_' . $field_id . '_day'] . $_POST['field_' . $field_id . '_month'] . $_POST['field_' . $field_id . '_year'] );
+                                        }
+
+                                        /* Create errors for required fields without values */
+                                        if ( xprofile_check_is_required_field( $field_id ) && empty( $_POST['field_' . $field_id] ) )
+                                                $bp->signup->errors['field_' . $field_id] = __( 'This is a required field', 'buddypress' );
</ins><span class="cx">                                 }
</span><span class="cx">
</span><del>-                                if ( xprofile_check_is_required_field( $field_id ) && empty( $_POST['field_' . $field_id] ) )
-                                        $bp->signup->errors['field_' . $field_id] = __( 'This is a required field', 'buddypress' );
</del><ins>+                        /* This situation doesn't naturally occur so bounce to website root */
+                        } else {
+                                bp_core_redirect( $bp->root_domain );
</ins><span class="cx">                         }
</span><span class="cx">                 }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>