<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[BuddyPress] [2824] branches/1.2/bp-xprofile.php:
Fixed issue with non required fields not saving values correctly.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd>2824</dd>
<dt>Author</dt> <dd>apeatling</dd>
<dt>Date</dt> <dd>2010-03-10 11:11:55 +0000 (Wed, 10 Mar 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fixed issue with non required fields not saving values correctly.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branches12bpxprofilephp">branches/1.2/bp-xprofile.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branches12bpxprofilephp"></a>
<div class="modfile"><h4>Modified: branches/1.2/bp-xprofile.php (2823 => 2824)</h4>
<pre class="diff"><span>
<span class="info">--- branches/1.2/bp-xprofile.php 2010-03-09 14:11:08 UTC (rev 2823)
+++ branches/1.2/bp-xprofile.php 2010-03-10 11:11:55 UTC (rev 2824)
</span><span class="lines">@@ -321,7 +321,7 @@
</span><span class="cx"> $errors = true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if ( $errors )
</del><ins>+ if ( !empty( $errors ) )
</ins><span class="cx"> bp_core_add_message( __( 'Please make sure you fill in all required fields in this profile field group before saving.', 'buddypress' ), 'error' );
</span><span class="cx"> else {
</span><span class="cx"> /* Reset the errors var */
</span><span class="lines">@@ -724,6 +724,12 @@
</span><span class="cx"> if ( $is_required && ( empty( $value ) || !strlen( trim( $value ) ) ) )
</span><span class="cx"> return false;
</span><span class="cx">
</span><ins>+ /* If the value is empty, then delete any field data that exists */
+ if ( empty( $value ) ) {
+ xprofile_delete_field_data( $field_id, $user_id );
+ return true;
+ }
+
</ins><span class="cx"> $field = new BP_XProfile_Field( $field_id );
</span><span class="cx">
</span><span class="cx"> /* Check the value is an acceptable value */
</span><span class="lines">@@ -764,10 +770,10 @@
</span><span class="cx"> else
</span><span class="cx"> $field_id = xprofile_get_field_id_from_name( $field );
</span><span class="cx">
</span><del>- if ( !$field_id )
</del><ins>+ if ( empty( $field_id ) || empty( $user_id ) )
</ins><span class="cx"> return false;
</span><span class="cx">
</span><del>- $field = new BP_XProfile_ProfileData( $field_id );
</del><ins>+ $field = new BP_XProfile_ProfileData( $field_id, $user_id );
</ins><span class="cx"> return $field->delete();
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>