<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[BuddyPress] [2797] trunk/bp-xprofile.php:
All field types should only return false if they are required and are empty
.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd>2797</dd>
<dt>Author</dt> <dd>johnjamesjacoby</dd>
<dt>Date</dt> <dd>2010-03-02 23:18:53 +0000 (Tue, 02 Mar 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre>All field types should only return false if they are required and are empty.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpxprofilephp">trunk/bp-xprofile.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpxprofilephp"></a>
<div class="modfile"><h4>Modified: trunk/bp-xprofile.php (2796 => 2797)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-xprofile.php 2010-03-02 12:16:29 UTC (rev 2796)
+++ trunk/bp-xprofile.php 2010-03-02 23:18:53 UTC (rev 2797)
</span><span class="lines">@@ -726,10 +726,14 @@
</span><span class="cx">
</span><span class="cx"> $field = new BP_XProfile_Field( $field_id );
</span><span class="cx">
</span><del>- /* Check the value is an acceptable value */
</del><ins>+ /* Check that value is acceptable */
</ins><span class="cx"> if ( 'checkbox' == $field->type || 'radio' == $field->type || 'selectbox' == $field->type || 'multiselectbox' == $field->type ) {
</span><span class="cx"> $options = $field->get_children();
</span><span class="cx">
</span><ins>+ /* Not required fields can have empty value */
+ if ( !$is_required )
+ $possible_values[] = '';
+
</ins><span class="cx"> foreach( $options as $option )
</span><span class="cx"> $possible_values[] = $option->name;
</span><span class="cx">
</span><span class="lines">@@ -739,7 +743,8 @@
</span><span class="cx"> unset( $value[$i] );
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if ( empty( $value ) )
</del><ins>+ /* Field must be required to trigger error */
+ if ( $is_required && empty( $value ) )
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> /* Reset the keys by merging with an empty array */
</span></span></pre>
</div>
</div>
</body>
</html>