<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[BuddyPress] [2547] trunk: Fixing checks for spaces in values.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd>2547</dd>
<dt>Author</dt> <dd>apeatling</dd>
<dt>Date</dt> <dd>2010-02-02 21:42:06 +0000 (Tue, 02 Feb 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fixing checks for spaces in values.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpactivityphp">trunk/bp-activity.php</a></li>
<li><a href="#trunkbpforumsphp">trunk/bp-forums.php</a></li>
<li><a href="#trunkbpgroupsphp">trunk/bp-groups.php</a></li>
<li><a href="#trunkbpxprofilebpxprofileclassesphp">trunk/bp-xprofile/bp-xprofile-classes.php</a></li>
<li><a href="#trunkbpxprofilephp">trunk/bp-xprofile.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpactivityphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-activity.php (2546 => 2547)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-activity.php 2010-02-02 21:22:22 UTC (rev 2546)
+++ trunk/bp-activity.php 2010-02-02 21:42:06 UTC (rev 2547)
</span><span class="lines">@@ -561,7 +561,7 @@
</span><span class="cx"> $r = wp_parse_args( $args, $defaults );
</span><span class="cx"> extract( $r, EXTR_SKIP );
</span><span class="cx">
</span><del>- if ( empty( $content ) )
</del><ins>+ if ( empty( $content ) || !strlen( trim( $content ) ) )
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> /* Record this on the user's profile */
</span></span></pre></div>
<a id="trunkbpforumsphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-forums.php (2546 => 2547)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-forums.php 2010-02-02 21:22:22 UTC (rev 2546)
+++ trunk/bp-forums.php 2010-02-02 21:42:06 UTC (rev 2547)
</span><span class="lines">@@ -442,7 +442,7 @@
</span><span class="cx"> if ( !isset( $post_position ) )
</span><span class="cx"> $post_position = $post->post_position;
</span><span class="cx">
</span><del>- $post = bb_insert_post( array( 'post_id' => $post_id, 'topic_id' => $topic_id, 'post_text' => stripslashes( $post_text ), 'post_time' => $post_time, 'poster_id' => $poster_id, 'poster_ip' => $poster_ip, 'post_status' => $post_status, 'post_position' => $post_position ) );
</del><ins>+ $post = bb_insert_post( array( 'post_id' => $post_id, 'topic_id' => $topic_id, 'post_text' => stripslashes( trim( $post_text ) ), 'post_time' => $post_time, 'poster_id' => $poster_id, 'poster_ip' => $poster_ip, 'post_status' => $post_status, 'post_position' => $post_position ) );
</ins><span class="cx">
</span><span class="cx"> if ( $post )
</span><span class="cx"> do_action( 'bp_forums_new_post', $post_id );
</span></span></pre></div>
<a id="trunkbpgroupsphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-groups.php (2546 => 2547)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-groups.php 2010-02-02 21:22:22 UTC (rev 2546)
+++ trunk/bp-groups.php 2010-02-02 21:42:06 UTC (rev 2547)
</span><span class="lines">@@ -1051,7 +1051,7 @@
</span><span class="cx"> check_admin_referer( 'groups_create_save_' . $bp->groups->current_create_step );
</span><span class="cx">
</span><span class="cx"> if ( 'group-details' == $bp->groups->current_create_step ) {
</span><del>- if ( empty( $_POST['group-name'] ) || empty( $_POST['group-desc'] ) ) {
</del><ins>+ if ( empty( $_POST['group-name'] ) || empty( $_POST['group-desc'] ) || !strlen( trim( $_POST['group-name'] ) ) || !strlen( trim( $_POST['group-desc'] ) ) ) {
</ins><span class="cx"> bp_core_add_message( __( 'Please fill in all of the required fields', 'buddypress' ), 'error' );
</span><span class="cx"> bp_core_redirect( $bp->root_domain . '/' . $bp->groups->slug . '/create/step/' . $bp->groups->current_create_step . '/' );
</span><span class="cx"> }
</span><span class="lines">@@ -1855,7 +1855,7 @@
</span><span class="cx"> $r = wp_parse_args( $args, $defaults );
</span><span class="cx"> extract( $r, EXTR_SKIP );
</span><span class="cx">
</span><del>- if ( empty($content) || empty($user_id) || empty($group_id) )
</del><ins>+ if ( empty($content) || !strlen( trim( $content ) ) || empty($user_id) || empty($group_id) )
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> $bp->groups->current_group = new BP_Groups_Group( $group_id );
</span></span></pre></div>
<a id="trunkbpxprofilebpxprofileclassesphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-xprofile/bp-xprofile-classes.php (2546 => 2547)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-xprofile/bp-xprofile-classes.php 2010-02-02 21:22:22 UTC (rev 2546)
+++ trunk/bp-xprofile/bp-xprofile-classes.php 2010-02-02 21:42:06 UTC (rev 2547)
</span><span class="lines">@@ -727,7 +727,7 @@
</span><span class="cx"> do_action( 'xprofile_data_before_save', $this );
</span><span class="cx">
</span><span class="cx"> if ( $this->is_valid_field() ) {
</span><del>- if ( $this->exists() && $this->value != '' ) {
</del><ins>+ if ( $this->exists() && !empty( $this->value ) && strlen( trim( $this->value ) ) ) {
</ins><span class="cx"> $result = $wpdb->query( $wpdb->prepare( "UPDATE {$bp->profile->table_name_data} SET value = %s, last_updated = %s WHERE user_id = %d AND field_id = %d", $this->value, $this->last_updated, $this->user_id, $this->field_id ) );
</span><span class="cx"> } else if ( $this->exists() && empty( $this->value ) ) {
</span><span class="cx"> // Data removed, delete the entry.
</span></span></pre></div>
<a id="trunkbpxprofilephp"></a>
<div class="modfile"><h4>Modified: trunk/bp-xprofile.php (2546 => 2547)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-xprofile.php 2010-02-02 21:22:22 UTC (rev 2546)
+++ trunk/bp-xprofile.php 2010-02-02 21:42:06 UTC (rev 2547)
</span><span class="lines">@@ -718,6 +718,9 @@
</span><span class="cx"> if ( !$field_id )
</span><span class="cx"> return false;
</span><span class="cx">
</span><ins>+ if ( empty( $value ) || !strlen( trim( $value ) ) )
+ return false;
+
</ins><span class="cx"> $field = new BP_XProfile_ProfileData();
</span><span class="cx"> $field->field_id = $field_id;
</span><span class="cx"> $field->user_id = $user_id;
</span></span></pre>
</div>
</div>
</body>
</html>