<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[BuddyPress] [2534] trunk/bp-groups/bp-groups-classes.php:
  Adding missing join calls on fetch group functions.</title>
</head>
<body>

<div id="msg">
<dl>
<dt>Revision</dt> <dd>2534</dd>
<dt>Author</dt> <dd>apeatling</dd>
<dt>Date</dt> <dd>2010-02-02 12:45:00 +0000 (Tue, 02 Feb 2010)</dd>
</dl>

<h3>Log Message</h3>
<pre>Adding missing join calls on fetch group functions.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpgroupsbpgroupsclassesphp">trunk/bp-groups/bp-groups-classes.php</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpgroupsbpgroupsclassesphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-groups/bp-groups-classes.php (2533 => 2534)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-groups/bp-groups-classes.php        2010-02-02 12:40:49 UTC (rev 2533)
+++ trunk/bp-groups/bp-groups-classes.php        2010-02-02 12:45:00 UTC (rev 2534)
</span><span class="lines">@@ -336,6 +336,7 @@
</span><span class="cx">                         $total_groups = $wpdb-&gt;get_var( $wpdb-&gt;prepare( &quot;SELECT COUNT(DISTINCT g.id) FROM {$bp-&gt;groups-&gt;table_name_groupmeta} gm INNER JOIN {$bp-&gt;groups-&gt;table_name} g ON gm.group_id = g.id WHERE gm.meta_key = 'last_activity'{$hidden_sql} {$search_sql}&quot; ) );
</span><span class="cx">                 }
</span><span class="cx"> 
</span><ins>+                foreach ( $paged_groups as $group ) $group_ids[] = $group-&gt;id;
</ins><span class="cx">                 $group_ids = $wpdb-&gt;escape( join( ',', (array)$group_ids ) );
</span><span class="cx">                 $paged_groups = BP_Groups_Group::get_group_extras( &amp;$paged_groups, $group_ids, 'newest' );
</span><span class="cx"> 
</span><span class="lines">@@ -394,6 +395,7 @@
</span><span class="cx">                         $total_groups = $wpdb-&gt;get_var( $wpdb-&gt;prepare( &quot;SELECT COUNT(DISTINCT g.id) FROM {$bp-&gt;groups-&gt;table_name_groupmeta} gm1, {$bp-&gt;groups-&gt;table_name_groupmeta} gm2, {$bp-&gt;groups-&gt;table_name} g WHERE g.id = gm1.group_id AND g.id = gm2.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' {$hidden_sql} {$search_sql}&quot; ) );
</span><span class="cx">                 }
</span><span class="cx"> 
</span><ins>+                foreach ( $paged_groups as $group ) $group_ids[] = $group-&gt;id;
</ins><span class="cx">                 $group_ids = $wpdb-&gt;escape( join( ',', (array)$group_ids ) );
</span><span class="cx">                 $paged_groups = BP_Groups_Group::get_group_extras( &amp;$paged_groups, $group_ids, 'popular' );
</span><span class="cx"> 
</span><span class="lines">@@ -422,6 +424,7 @@
</span><span class="cx">                         $total_groups = $wpdb-&gt;get_var( $wpdb-&gt;prepare( &quot;SELECT COUNT(DISTINCT g.id) FROM {$bp-&gt;groups-&gt;table_name_groupmeta} gm1, {$bp-&gt;groups-&gt;table_name_groupmeta} gm2, {$bp-&gt;groups-&gt;table_name} g WHERE g.id = gm1.group_id AND g.id = gm2.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' {$hidden_sql} {$search_sql}&quot; ) );
</span><span class="cx">                 }
</span><span class="cx"> 
</span><ins>+                foreach ( $paged_groups as $group ) $group_ids[] = $group-&gt;id;
</ins><span class="cx">                 $group_ids = $wpdb-&gt;escape( join( ',', (array)$group_ids ) );
</span><span class="cx">                 $paged_groups = BP_Groups_Group::get_group_extras( &amp;$paged_groups, $group_ids, 'alphabetical' );
</span><span class="cx"> 
</span><span class="lines">@@ -454,6 +457,7 @@
</span><span class="cx">                         $total_groups = $wpdb-&gt;get_var( $wpdb-&gt;prepare( &quot;SELECT COUNT(DISTINCT g.id) FROM {$bp-&gt;groups-&gt;table_name_groupmeta} gm1, {$bp-&gt;groups-&gt;table_name_groupmeta} gm2, {$bp-&gt;groups-&gt;table_name_groupmeta} gm3, {$bbdb-&gt;forums} f, {$bp-&gt;groups-&gt;table_name} g WHERE g.id = gm1.group_id AND g.id = gm2.group_id AND g.id = gm3.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' AND (gm3.meta_key = 'forum_id' AND gm3.meta_value = f.forum_id) AND f.topics &gt; 0 {$hidden_sql} {$search_sql}&quot; ) );
</span><span class="cx">                 }
</span><span class="cx"> 
</span><ins>+                foreach ( $paged_groups as $group ) $group_ids[] = $group-&gt;id;
</ins><span class="cx">                 $group_ids = $wpdb-&gt;escape( join( ',', (array)$group_ids ) );
</span><span class="cx">                 $paged_groups = BP_Groups_Group::get_group_extras( &amp;$paged_groups, $group_ids, 'most_forum_topics' );
</span><span class="cx"> 
</span><span class="lines">@@ -486,6 +490,7 @@
</span><span class="cx">                         $total_groups = $wpdb-&gt;get_var( $wpdb-&gt;prepare( &quot;SELECT COUNT(DISTINCT g.id) FROM {$bp-&gt;groups-&gt;table_name_groupmeta} gm1, {$bp-&gt;groups-&gt;table_name_groupmeta} gm2, {$bp-&gt;groups-&gt;table_name_groupmeta} gm3, {$bbdb-&gt;forums} f, {$bp-&gt;groups-&gt;table_name} g WHERE g.id = gm1.group_id AND g.id = gm2.group_id AND g.id = gm3.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' AND (gm3.meta_key = 'forum_id' AND gm3.meta_value = f.forum_id) {$hidden_sql} {$search_sql}&quot; ) );
</span><span class="cx">                 }
</span><span class="cx"> 
</span><ins>+                foreach ( $paged_groups as $group ) $group_ids[] = $group-&gt;id;
</ins><span class="cx">                 $group_ids = $wpdb-&gt;escape( join( ',', (array)$group_ids ) );
</span><span class="cx">                 $paged_groups = BP_Groups_Group::get_group_extras( &amp;$paged_groups, $group_ids, 'most_forum_posts' );
</span><span class="cx"> 
</span><span class="lines">@@ -554,6 +559,7 @@
</span><span class="cx"> 
</span><span class="cx">                 $paged_groups = $wpdb-&gt;get_results( $wpdb-&gt;prepare( &quot;SELECT g.*, gm1.meta_value as total_member_count, gm2.meta_value as last_activity FROM {$bp-&gt;groups-&gt;table_name_groupmeta} gm1, {$bp-&gt;groups-&gt;table_name_groupmeta} gm2, {$bp-&gt;groups-&gt;table_name} g WHERE g.id = gm1.group_id AND g.id = gm2.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' AND g.name LIKE '$letter%%' {$hidden_sql} {$search_sql} ORDER BY g.name ASC {$pag_sql}&quot;  ) );
</span><span class="cx"> 
</span><ins>+                foreach ( $paged_groups as $group ) $group_ids[] = $group-&gt;id;
</ins><span class="cx">                 $group_ids = $wpdb-&gt;escape( join( ',', (array)$group_ids ) );
</span><span class="cx">                 $paged_groups = BP_Groups_Group::get_group_extras( &amp;$paged_groups, $group_ids, 'letter' );
</span><span class="cx"> 
</span><span class="lines">@@ -582,6 +588,7 @@
</span><span class="cx">                         $total_groups = $wpdb-&gt;get_var( $wpdb-&gt;prepare( &quot;SELECT COUNT(DISTINCT g.id) FROM {$bp-&gt;groups-&gt;table_name_groupmeta} gm INNER JOIN {$bp-&gt;groups-&gt;table_name} g ON gm.group_id = g.id WHERE gm.meta_key = 'last_activity'{$hidden_sql} {$search_sql}&quot; ) );
</span><span class="cx">                 }
</span><span class="cx"> 
</span><ins>+                foreach ( $paged_groups as $group ) $group_ids[] = $group-&gt;id;
</ins><span class="cx">                 $group_ids = $wpdb-&gt;escape( join( ',', (array)$group_ids ) );
</span><span class="cx">                 $paged_groups = BP_Groups_Group::get_group_extras( &amp;$paged_groups, $group_ids, 'random' );
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>