<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[BuddyPress] [2451] trunk/bp-core.php: There'
s nothing I like better than spending an afternoon weaving my way around inconsistencies between PHP4 and PHP5 date
/time handling.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd>2451</dd>
<dt>Author</dt> <dd>apeatling</dd>
<dt>Date</dt> <dd>2010-01-25 15:58:46 +0000 (Mon, 25 Jan 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre>There's nothing I like better than spending an afternoon weaving my way around inconsistencies between PHP4 and PHP5 date/time handling. Fixes #1641</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpcorephp">trunk/bp-core.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpcorephp"></a>
<div class="modfile"><h4>Modified: trunk/bp-core.php (2450 => 2451)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-core.php 2010-01-25 14:48:13 UTC (rev 2450)
+++ trunk/bp-core.php 2010-01-25 15:58:46 UTC (rev 2451)
</span><span class="lines">@@ -1364,12 +1364,16 @@
</span><span class="cx"> array( 1, __( 'second', 'buddypress' ), __( 'seconds', 'buddypress' ) )
</span><span class="cx"> );
</span><span class="cx">
</span><del>- if ( !is_numeric( $older_date ) )
- $older_date = strtotime( $older_date . ' GMT' );
</del><ins>+ if ( !is_numeric( $older_date ) ) {
+ $time_chunks = explode( ':', str_replace( ' ', ':', $older_date ) );
+ $date_chunks = explode( '-', str_replace( ' ', '-', $older_date ) );
</ins><span class="cx">
</span><ins>+ $older_date = gmmktime( (int)$time_chunks[1], (int)$time_chunks[2], (int)$time_chunks[3], (int)$date_chunks[1], (int)$date_chunks[2], (int)$date_chunks[0] );
+ }
+
</ins><span class="cx"> /* $newer_date will equal false if we want to know the time elapsed between a date and the current time */
</span><span class="cx"> /* $newer_date will have a value if we want to work out time elapsed between two known dates */
</span><del>- $newer_date = ( !$newer_date ) ? gmmktime() : $newer_date;
</del><ins>+ $newer_date = ( !$newer_date ) ? gmmktime( gmdate( 'H' ), gmdate( 'i' ), gmdate( 's' ), gmdate( 'n' ), gmdate( 'j' ), gmdate( 'Y' ) ) : $newer_date;
</ins><span class="cx">
</span><span class="cx"> /* Difference in seconds */
</span><span class="cx"> $since = $newer_date - $older_date;
</span></span></pre>
</div>
</div>
</body>
</html>