<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[BuddyPress] [2150] trunk: Fixing JS event delegation</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd>2150</dd>
<dt>Author</dt> <dd>apeatling</dd>
<dt>Date</dt> <dd>2009-11-27 16:15:13 +0000 (Fri, 27 Nov 2009)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fixing JS event delegation</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpactivitybpactivitywidgetsphp">trunk/bp-activity/bp-activity-widgets.php</a></li>
<li><a href="#trunkbpactivityjswidgetactivityjs">trunk/bp-activity/js/widget-activity.js</a></li>
<li><a href="#trunkbpthemesbpsnparent_incjsajaxjs">trunk/bp-themes/bp-sn-parent/_inc/js/ajax.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpactivitybpactivitywidgetsphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-activity/bp-activity-widgets.php (2149 => 2150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-activity/bp-activity-widgets.php 2009-11-27 16:10:24 UTC (rev 2149)
+++ trunk/bp-activity/bp-activity-widgets.php 2009-11-27 16:15:13 UTC (rev 2150)
</span><span class="lines">@@ -49,7 +49,7 @@
</span><span class="cx"> </div>
</span><span class="cx"> <?php endif; ?>
</span><span class="cx">
</span><del>- <div class="astream">
</del><ins>+ <div class="activity">
</ins><span class="cx"> <?php // The loop will be loaded here via AJAX on page load to retain settings. ?>
</span><span class="cx"> </div>
</span><span class="cx">
</span></span></pre></div>
<a id="trunkbpactivityjswidgetactivityjs"></a>
<div class="modfile"><h4>Modified: trunk/bp-activity/js/widget-activity.js (2149 => 2150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-activity/js/widget-activity.js 2009-11-27 16:10:24 UTC (rev 2149)
+++ trunk/bp-activity/js/widget-activity.js 2009-11-27 16:15:13 UTC (rev 2150)
</span><span class="lines">@@ -66,12 +66,12 @@
</span><span class="cx">
</span><span class="cx"> /* Check for errors and append if found. */
</span><span class="cx"> if ( response[0] + response[1] == '-1' ) {
</span><del>- j('div.astream').fadeOut( 100, function() {
</del><ins>+ j('div.activity').fadeOut( 100, function() {
</ins><span class="cx"> j(this).html( response.substr( 2, response.length ) ).hide().fadeIn( 200 );
</span><span class="cx"> j(this).fadeIn(100);
</span><span class="cx"> });
</span><span class="cx"> } else {
</span><del>- j('div.astream').fadeOut( 100, function() {
</del><ins>+ j('div.activity').fadeOut( 100, function() {
</ins><span class="cx"> j(this).html(response);
</span><span class="cx"> j(this).fadeIn(100);
</span><span class="cx"> });
</span></span></pre></div>
<a id="trunkbpthemesbpsnparent_incjsajaxjs"></a>
<div class="modfile"><h4>Modified: trunk/bp-themes/bp-sn-parent/_inc/js/ajax.js (2149 => 2150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-themes/bp-sn-parent/_inc/js/ajax.js 2009-11-27 16:10:24 UTC (rev 2149)
+++ trunk/bp-themes/bp-sn-parent/_inc/js/ajax.js 2009-11-27 16:15:13 UTC (rev 2150)
</span><span class="lines">@@ -7,7 +7,7 @@
</span><span class="cx"> j('form.ac-form').hide();
</span><span class="cx">
</span><span class="cx"> /* Delegate events instead of binding on every element */
</span><del>- j('ul.activity-list').click( function(event) {
</del><ins>+ j('div.activity').click( function(event) {
</ins><span class="cx"> var target = j(event.target);
</span><span class="cx">
</span><span class="cx"> /* Comment / comment reply links */
</span></span></pre>
</div>
</div>
</body>
</html>