<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[BuddyPress] [2119] branches/1.1/bp-groups/bp-groups-classes.php:
Fixes #1284 props MrMaz.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd>2119</dd>
<dt>Author</dt> <dd>apeatling</dd>
<dt>Date</dt> <dd>2009-11-25 10:26:14 +0000 (Wed, 25 Nov 2009)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fixes #1284 props MrMaz.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branches11bpgroupsbpgroupsclassesphp">branches/1.1/bp-groups/bp-groups-classes.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branches11bpgroupsbpgroupsclassesphp"></a>
<div class="modfile"><h4>Modified: branches/1.1/bp-groups/bp-groups-classes.php (2118 => 2119)</h4>
<pre class="diff"><span>
<span class="info">--- branches/1.1/bp-groups/bp-groups-classes.php 2009-11-25 10:19:26 UTC (rev 2118)
+++ branches/1.1/bp-groups/bp-groups-classes.php 2009-11-25 10:26:14 UTC (rev 2119)
</span><span class="lines">@@ -421,12 +421,21 @@
</span><span class="cx"> function get_all( $limit = null, $page = null, $only_public = true, $sort_by = false, $order = false ) {
</span><span class="cx"> global $wpdb, $bp;
</span><span class="cx">
</span><ins>+ // Default sql WHERE conditions are blank. TODO: generic handler function.
+ $where_sql = null;
+ $where_conditions = array();
+
+ // Limit results to public status
</ins><span class="cx"> if ( $only_public )
</span><del>- $public_sql = $wpdb->prepare( " AND g.status = 'public'" );
</del><ins>+ $where_conditions[] = $wpdb->prepare( "g.status = 'public'" );
</ins><span class="cx">
</span><span class="cx"> if ( !is_site_admin() )
</span><del>- $hidden_sql = $wpdb->prepare( " AND g.status != 'hidden'");
</del><ins>+ $where_conditions[] = $wpdb->prepare( "g.status != 'hidden'");
</ins><span class="cx">
</span><ins>+ // Build where sql statement if necessary
+ if ( !empty( $where_conditions ) )
+ $where_sql = 'WHERE ' . join( ' AND ', $where_conditions );
+
</ins><span class="cx"> if ( $limit && $page )
</span><span class="cx"> $pag_sql = $wpdb->prepare( " LIMIT %d, %d", intval( ( $page - 1 ) * $limit), intval( $limit ) );
</span><span class="cx">
</span><span class="lines">@@ -437,7 +446,7 @@
</span><span class="cx">
</span><span class="cx"> switch ( $sort_by ) {
</span><span class="cx"> default:
</span><del>- $sql = $wpdb->prepare( "SELECT * FROM {$bp->groups->table_name} g WHERE 1=1 {$public_sql} {$hidden_sql} {$order_sql} {$pag_sql}" );
</del><ins>+ $sql = $wpdb->prepare( "SELECT * FROM {$bp->groups->table_name} g {$where_sql} {$order_sql} {$pag_sql}" );
</ins><span class="cx"> break;
</span><span class="cx"> case 'members':
</span><span class="cx"> $sql = $wpdb->prepare( "SELECT * FROM {$bp->groups->table_name} g, {$bp->groups->table_name_groupmeta} gm WHERE g.id = gm.group_id AND gm.meta_key = 'total_member_count' {$hidden_sql} {$public_sql} ORDER BY CONVERT(gm.meta_value, SIGNED) {$order} {$pag_sql}" );
</span><span class="lines">@@ -447,7 +456,7 @@
</span><span class="cx"> break;
</span><span class="cx"> }
</span><span class="cx"> } else {
</span><del>- $sql = $wpdb->prepare( "SELECT * FROM {$bp->groups->table_name} g {$public_sql} {$hidden_sql} {$order_sql} {$pag_sql}" );
</del><ins>+ $sql = $wpdb->prepare( "SELECT * FROM {$bp->groups->table_name} g {$where_sql} {$order_sql} {$pag_sql}" );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> return $wpdb->get_results($sql);
</span></span></pre>
</div>
</div>
</body>
</html>