From noreply at wordpress.org Thu Apr 2 04:30:42 2020 From: noreply at wordpress.org (buddypress-trac) Date: Thu, 02 Apr 2020 04:30:42 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8237: Forum Pagination links are broken In-Reply-To: <042.9ff39dc2f01536e43e86dc19e7bf16ad@wordpress.org> References: <042.9ff39dc2f01536e43e86dc19e7bf16ad@wordpress.org> Message-ID: <057.615cb8a278fe1dc4a17bcec25764f3bb@wordpress.org> #8237: Forum Pagination links are broken --------------------------+------------------------------ Reporter: SirLouen | Owner: johnjamesjacoby Type: defect (bug) | Status: new Priority: highest | Milestone: Awaiting Review Component: Forums | Version: 5.0.0 Severity: critical | Resolution: Keywords: needs-patch | --------------------------+------------------------------ Changes (by imath): * component: Members => Forums * milestone: 5.2.0 => Awaiting Review -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Thu Apr 2 08:55:40 2020 From: noreply at wordpress.org (buddypress-trac) Date: Thu, 02 Apr 2020 08:55:40 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8252: Some BP Admin Screens are messed up in WP5.4 In-Reply-To: <039.5f160073fc1e8c5b039dedec292c4f4f@wordpress.org> References: <039.5f160073fc1e8c5b039dedec292c4f4f@wordpress.org> Message-ID: <054.968736929ba3b49e3ea4889b860a96ff@wordpress.org> #8252: Some BP Admin Screens are messed up in WP5.4 ----------------------------+-------------------------------- Reporter: imath | Owner: slaFFik Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Administration | Version: Severity: normal | Resolution: reported-upstream Keywords: close | ----------------------------+-------------------------------- Changes (by imath): * status: new => closed * resolution: => reported-upstream * milestone: 5.2.0 => Comment: It has been reverted see [WP47410], I confirm there are no more issues with our Admin Screens. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Thu Apr 2 09:13:55 2020 From: noreply at wordpress.org (buddypress-trac) Date: Thu, 02 Apr 2020 09:13:55 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8181: PHP Notice generated when logged out user attempts to join an invalid user to a group via REST API In-Reply-To: <041.56db96c56921aaee7cbbe0228782aa77@wordpress.org> References: <041.56db96c56921aaee7cbbe0228782aa77@wordpress.org> Message-ID: <056.62eecccad78f1269483ede4aa58bf50a@wordpress.org> #8181: PHP Notice generated when logged out user attempts to join an invalid user to a group via REST API --------------------------+--------------------- Reporter: sjregan | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: 5.2.0 Component: REST API | Version: 5.0.0 Severity: trivial | Resolution: fixed Keywords: | --------------------------+--------------------- Changes (by imath): * keywords: needs-patch => * status: new => closed * resolution: => fixed Comment: I've just tested it again, there's no more PHP notice. I believe it has been fixed from our [https://github.com/buddypress/BP-REST GitHub repository]. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Fri Apr 3 20:37:34 2020 From: noreply at wordpress.org (buddypress-trac) Date: Fri, 03 Apr 2020 20:37:34 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8265: WordPress Update 5.4 Changed function wp_get_user_request_data() Message-ID: <040.43e24b5f258943ee9b1d002485cd7c41@wordpress.org> #8265: WordPress Update 5.4 Changed function wp_get_user_request_data() --------------------------+----------------------------- Reporter: Dono12 | Owner: (none) Type: defect (bug) | Status: new Priority: high | Milestone: Awaiting Review Component: Core | Version: 5.0.0 Severity: major | Keywords: needs-patch --------------------------+----------------------------- The recent WordPress 5.4 update changed {{{ wp_get_user_request_data() }}} to {{{ wp_get_user_request(). }}} Because this change is not yet updated in wp-content/plugins/buddypress /bp-settings/bp-settings-functions.php on line 251. {{{ wp_get_user_request_data( $query->post->ID ); }}} The BuddyPress Export Data Page is broken when clicking the Export Data Button. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Fri Apr 3 22:08:16 2020 From: noreply at wordpress.org (buddypress-trac) Date: Fri, 03 Apr 2020 22:08:16 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8265: WordPress Update 5.4 Changed function wp_get_user_request_data() In-Reply-To: <040.43e24b5f258943ee9b1d002485cd7c41@wordpress.org> References: <040.43e24b5f258943ee9b1d002485cd7c41@wordpress.org> Message-ID: <055.dbcf9e46d31218df181669ffc3b14d08@wordpress.org> #8265: WordPress Update 5.4 Changed function wp_get_user_request_data() --------------------------+--------------------- Reporter: Dono12 | Owner: (none) Type: defect (bug) | Status: new Priority: high | Milestone: 6.0.0 Component: Settings | Version: 5.0.0 Severity: major | Resolution: Keywords: has-patch | --------------------------+--------------------- Changes (by r-a-y): * keywords: needs-patch => has-patch * component: Core => Settings * milestone: Awaiting Review => 6.0.0 Comment: Thanks for letting us know, Dono12. That's annoying. WordPress didn't even deprecate the previous function? See #WP46302. Since we need to support versions of WordPress less than 5.4, we'll need to do a `function_exists()` check. See attached patch. Devs, let me know if you'd prefer the function_exists() check to span multiple lines instead of a one-liner. I'm guessing there won't be a 5.2.0 release, so I'm moving this to 6.0 in the meantime. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Fri Apr 3 22:08:50 2020 From: noreply at wordpress.org (buddypress-trac) Date: Fri, 03 Apr 2020 22:08:50 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8265: WordPress Update 5.4 Changed function wp_get_user_request_data() In-Reply-To: <040.43e24b5f258943ee9b1d002485cd7c41@wordpress.org> References: <040.43e24b5f258943ee9b1d002485cd7c41@wordpress.org> Message-ID: <055.88767579df325ad5f795efcbf298cc5b@wordpress.org> #8265: WordPress Update 5.4 Changed function wp_get_user_request_data() --------------------------+--------------------- Reporter: Dono12 | Owner: (none) Type: defect (bug) | Status: new Priority: high | Milestone: 6.0.0 Component: Settings | Version: 5.0.0 Severity: major | Resolution: Keywords: has-patch | --------------------------+--------------------- Changes (by r-a-y): * Attachment "8265.01.patch" added. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Fri Apr 3 22:30:58 2020 From: noreply at wordpress.org (buddypress-trac) Date: Fri, 03 Apr 2020 22:30:58 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8265: WordPress Update 5.4 Changed function wp_get_user_request_data() In-Reply-To: <040.43e24b5f258943ee9b1d002485cd7c41@wordpress.org> References: <040.43e24b5f258943ee9b1d002485cd7c41@wordpress.org> Message-ID: <055.f41f471f1cd63091cb04dd891da03566@wordpress.org> #8265: WordPress Update 5.4 Changed function wp_get_user_request_data() --------------------------+--------------------- Reporter: Dono12 | Owner: (none) Type: defect (bug) | Status: new Priority: high | Milestone: 6.0.0 Component: Settings | Version: 5.0.0 Severity: major | Resolution: Keywords: has-patch | --------------------------+--------------------- Comment (by johnjamesjacoby): I commented on the original WordPress issue. I suspect that function was deprecated into the incorrect location. IMO, it should be fixed upstream in 5.4.1, in addition to the one here. Thanks @r-a-y & @Dono12 for seeing and patching this right away. šŸ‘ -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Fri Apr 3 22:42:03 2020 From: noreply at wordpress.org (buddypress-trac) Date: Fri, 03 Apr 2020 22:42:03 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8265: WordPress Update 5.4 Changed function wp_get_user_request_data() In-Reply-To: <040.43e24b5f258943ee9b1d002485cd7c41@wordpress.org> References: <040.43e24b5f258943ee9b1d002485cd7c41@wordpress.org> Message-ID: <055.e5c9316b1bd42add17fd690d0ba8289d@wordpress.org> #8265: WordPress Update 5.4 Changed function wp_get_user_request_data() --------------------------+--------------------- Reporter: Dono12 | Owner: (none) Type: defect (bug) | Status: new Priority: high | Milestone: 6.0.0 Component: Settings | Version: 5.0.0 Severity: major | Resolution: Keywords: has-patch | --------------------------+--------------------- Comment (by r-a-y): I was going to open a new ticket upstream about this, but I'll wait to see what the devs say before sending a patch. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Sat Apr 4 02:02:31 2020 From: noreply at wordpress.org (buddypress-trac) Date: Sat, 04 Apr 2020 02:02:31 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8266: Export Data changes in WordPress 5.4 Message-ID: <039.d12c1acc8bc1c941c172d98b1ee3f4c6@wordpress.org> #8266: Export Data changes in WordPress 5.4 ----------------------+-------------------------- Reporter: r-a-y | Owner: (none) Type: task | Status: new Priority: normal | Milestone: 6.0.0 Component: Settings | Version: Severity: normal | Keywords: dev-feedback ----------------------+-------------------------- So I'm reading the new changes to WordPress 5.4 with regards to exporting user data: https://make.wordpress.org/core/2020/03/02/privacy-updates-in-5-4/ And a few things jump out. We will not need the WordPress Community Events block since that isn't applicable to BuddyPress sites. I'm thinking we should remove that. About the session tokens part, what does everyone think about that? Here's the core WP ticket - #WP45889, appears to stem from GDPR. Do you see value in including that info? When a user logs out, that info is erased. The only thing I can think of is if that user is logged into multiple devices at the same time without logging out... -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Sat Apr 4 08:30:50 2020 From: noreply at wordpress.org (buddypress-trac) Date: Sat, 04 Apr 2020 08:30:50 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8267: Storing avatar information into usermeta Message-ID: <040.3e5c9df901f7b6f0d4d4a2ea7c4aaf7f@wordpress.org> #8267: Storing avatar information into usermeta -------------------------+----------------------------- Reporter: stokim | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Core | Version: Severity: normal | Keywords: -------------------------+----------------------------- Hi there! I'm looking forward to 6.0, however there are few more things to add. First, how about storing avatar information into DB, especially filename. Now, to get avatar url, we have to use functions such as file_exist, readdir, closedir etc. How about just storing avatar filename generated random id into usermeta? I found this thread: https://buddypress.trac.wordpress.org/ticket/4237 However for 8 years, it has not been changed at all. I know accessing db is costly, however it would be better to use DB instead of using those functions. If we can store filename into usermeta, we can use this with attaching -thumb and -full with ease. Thank you. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Sat Apr 4 16:49:15 2020 From: noreply at wordpress.org (buddypress-trac) Date: Sat, 04 Apr 2020 16:49:15 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8268: Blogs component: Typo when using the __() function Message-ID: <039.2e940175d9a51dbae30f82997f41b728@wordpress.org> #8268: Blogs component: Typo when using the __() function --------------------------+----------------------- Reporter: imath | Owner: imath Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0.0 Component: Blogs | Version: Severity: normal | Keywords: has-patch --------------------------+----------------------- This is a regression introduced in [12587]: my bad. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Sat Apr 4 16:49:37 2020 From: noreply at wordpress.org (buddypress-trac) Date: Sat, 04 Apr 2020 16:49:37 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8268: Blogs component: Typo when using the __() function In-Reply-To: <039.2e940175d9a51dbae30f82997f41b728@wordpress.org> References: <039.2e940175d9a51dbae30f82997f41b728@wordpress.org> Message-ID: <054.a89af7212415c0722066e0f62a705cf0@wordpress.org> #8268: Blogs component: Typo when using the __() function --------------------------+----------------------- Reporter: imath | Owner: imath Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0.0 Component: Blogs | Version: Severity: normal | Resolution: Keywords: has-patch | --------------------------+----------------------- Changes (by imath): * Attachment "8268.patch" added. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Sat Apr 4 16:53:32 2020 From: noreply at wordpress.org (buddypress-trac) Date: Sat, 04 Apr 2020 16:53:32 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8154: Fix node modules vulnerabilities In-Reply-To: <039.d26d5dd622948bcdcae3516911378fa0@wordpress.org> References: <039.d26d5dd622948bcdcae3516911378fa0@wordpress.org> Message-ID: <054.a9af95e1bc7e76330102115494666cbc@wordpress.org> #8154: Fix node modules vulnerabilities ------------------------------+----------------------- Reporter: imath | Owner: imath Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: needs-patch | ------------------------------+----------------------- Changes (by imath): * owner: netweb => imath * status: new => assigned * milestone: Up Next => 6.0.0 Comment: `grunt-contrib-imagemin` has fixed the issue 4 days ago. Let's fix it in 6.0.0. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Sat Apr 4 16:54:12 2020 From: noreply at wordpress.org (buddypress-trac) Date: Sat, 04 Apr 2020 16:54:12 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8154: Fix node modules vulnerabilities In-Reply-To: <039.d26d5dd622948bcdcae3516911378fa0@wordpress.org> References: <039.d26d5dd622948bcdcae3516911378fa0@wordpress.org> Message-ID: <054.2f14649efb7218660bcce961e89f86f2@wordpress.org> #8154: Fix node modules vulnerabilities ------------------------------+----------------------- Reporter: imath | Owner: imath Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: needs-patch | ------------------------------+----------------------- Changes (by imath): * Attachment "8154.2.patch" added. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Sat Apr 4 16:59:25 2020 From: noreply at wordpress.org (buddypress-trac) Date: Sat, 04 Apr 2020 16:59:25 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8154: Fix node modules vulnerabilities In-Reply-To: <039.d26d5dd622948bcdcae3516911378fa0@wordpress.org> References: <039.d26d5dd622948bcdcae3516911378fa0@wordpress.org> Message-ID: <054.bfa11f913ec480220de2cc050d185c67@wordpress.org> #8154: Fix node modules vulnerabilities ------------------------------+--------------------- Reporter: imath | Owner: imath Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: fixed Keywords: needs-patch | ------------------------------+--------------------- Changes (by imath): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"12610" 12610]: {{{ #!CommitTicketReference repository="" revision="12610" Build tools: update `grunt-contrib-imagemin` to 3.1.0 There is now 1 low node module vulnerability remaining. Fixes #8154 }}} -- Ticket URL: BuddyPress Trac BuddyPress Trac From buddypress-trac at lists.automattic.com Sat Apr 4 17:02:30 2020 From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com) Date: Sat, 4 Apr 2020 17:02:30 +0000 (UTC) Subject: [buddypress-trac] [BuddyPress][12611] trunk/src/bp-blogs/classes/class-bp-blogs-component.php: Blogs: make sure to use the `__()` the right way Message-ID: <20200404170230.844AE1B00425@svn1.ord.wordpress.org> An HTML attachment was scrubbed... URL: From noreply at wordpress.org Sat Apr 4 17:02:34 2020 From: noreply at wordpress.org (buddypress-trac) Date: Sat, 04 Apr 2020 17:02:34 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8268: Blogs component: Typo when using the __() function In-Reply-To: <039.2e940175d9a51dbae30f82997f41b728@wordpress.org> References: <039.2e940175d9a51dbae30f82997f41b728@wordpress.org> Message-ID: <054.f952a8657457491f0f3f43a0a7f4b111@wordpress.org> #8268: Blogs component: Typo when using the __() function --------------------------+--------------------- Reporter: imath | Owner: imath Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0.0 Component: Blogs | Version: Severity: normal | Resolution: fixed Keywords: has-patch | --------------------------+--------------------- Changes (by imath): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"12611" 12611]: {{{ #!CommitTicketReference repository="" revision="12611" Blogs: make sure to use the `__()` the right way This fixes a regression introduced in [12587] where I made a typo using `_(` instead of `__()`. Antiprops imath Fixes #8268 }}} -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Sat Apr 4 21:35:19 2020 From: noreply at wordpress.org (buddypress-trac) Date: Sat, 04 Apr 2020 21:35:19 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8154: Fix node modules vulnerabilities In-Reply-To: <039.d26d5dd622948bcdcae3516911378fa0@wordpress.org> References: <039.d26d5dd622948bcdcae3516911378fa0@wordpress.org> Message-ID: <054.5988ee2ddd48c0eafda3008868292bc7@wordpress.org> #8154: Fix node modules vulnerabilities ------------------------------+--------------------- Reporter: imath | Owner: imath Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: fixed Keywords: needs-patch | ------------------------------+--------------------- Comment (by r-a-y): I just ran `npm install` and I'm getting the following: {{{ found 24 vulnerabilities (15 low, 9 high) in 20754 scanned packages run `npm audit fix` to fix 23 of them. 1 vulnerability requires manual review. See the full report for details. }}} Let me know if you want me to post the full `npm audit` log. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Sun Apr 5 02:11:39 2020 From: noreply at wordpress.org (buddypress-trac) Date: Sun, 05 Apr 2020 02:11:39 -0000 Subject: [buddypress-trac] =?utf-8?q?=5BBuddyPress_Trac=5D_=238269=3A_Memb?= =?utf-8?q?er_Directory_nav_tab_Won=E2=80=99t_Display_over_999_member_coun?= =?utf-8?q?t?= Message-ID: <043.f838373c3f80f4279097349a9f773a02@wordpress.org> #8269: Member Directory nav tab Wonā€™t Display over 999 member count --------------------------+----------------------------- Reporter: twmcmahan | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Templates | Version: 5.0.0 Severity: normal | Keywords: --------------------------+----------------------------- We have 3,078 Members. When opening the member directory the pagination count(s) is correct, but the count in the tab navigation is 3. Iā€™ve resolved this by making a change to the function bp_nouveau_get_nav_count() /bp-templates/bp-nouveau/includes/template.tags.php Line 1266 From: {{{#!php count; }}} to {{{#!php count ); }}} It appears that $nav_item->count returns 3,078 and because itā€™s being forced to an integer itā€™s only returning 3 as the code is written. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Wed Apr 8 18:33:26 2020 From: noreply at wordpress.org (buddypress-trac) Date: Wed, 08 Apr 2020 18:33:26 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8154: Fix node modules vulnerabilities In-Reply-To: <039.d26d5dd622948bcdcae3516911378fa0@wordpress.org> References: <039.d26d5dd622948bcdcae3516911378fa0@wordpress.org> Message-ID: <054.47f6fff4af6f5c7cb67739c5f9621bda@wordpress.org> #8154: Fix node modules vulnerabilities ------------------------------+--------------------- Reporter: imath | Owner: imath Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: fixed Keywords: needs-patch | ------------------------------+--------------------- Comment (by imath): No problem @r-a-y ;) -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Wed Apr 8 18:36:28 2020 From: noreply at wordpress.org (buddypress-trac) Date: Wed, 08 Apr 2020 18:36:28 -0000 Subject: [buddypress-trac] =?utf-8?q?=5BBuddyPress_Trac=5D_=238269=3A_Mem?= =?utf-8?q?ber_Directory_nav_tab_Won=E2=80=99t_Display_over_999_member_cou?= =?utf-8?q?nt?= In-Reply-To: <043.f838373c3f80f4279097349a9f773a02@wordpress.org> References: <043.f838373c3f80f4279097349a9f773a02@wordpress.org> Message-ID: <058.2fd08af7fe4666730619988fafff742a@wordpress.org> #8269: Member Directory nav tab Wonā€™t Display over 999 member count --------------------------+--------------------- Reporter: twmcmahan | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0.0 Component: Templates | Version: 5.0.0 Severity: normal | Resolution: Keywords: needs-patch | --------------------------+--------------------- Changes (by imath): * keywords: => needs-patch * milestone: Awaiting Review => 6.0.0 Comment: Hi @twmcmahan Thanks for reporting this issue. I will look at it asap to try to find a fix. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Wed Apr 8 18:47:31 2020 From: noreply at wordpress.org (buddypress-trac) Date: Wed, 08 Apr 2020 18:47:31 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8265: WordPress Update 5.4 Changed function wp_get_user_request_data() In-Reply-To: <040.43e24b5f258943ee9b1d002485cd7c41@wordpress.org> References: <040.43e24b5f258943ee9b1d002485cd7c41@wordpress.org> Message-ID: <055.4052d235a0c0be38e6152bf0837bc2c9@wordpress.org> #8265: WordPress Update 5.4 Changed function wp_get_user_request_data() ------------------------------+--------------------- Reporter: Dono12 | Owner: (none) Type: defect (bug) | Status: new Priority: high | Milestone: 5.2.0 Component: Settings | Version: 5.0.0 Severity: major | Resolution: Keywords: has-patch commit | ------------------------------+--------------------- Changes (by imath): * keywords: has-patch => has-patch commit * milestone: 6.0.0 => 5.2.0 Comment: Thanks a lot for the patch @r-a-y Could you commit it in 5.2 and trunk ? -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Wed Apr 8 18:50:51 2020 From: noreply at wordpress.org (buddypress-trac) Date: Wed, 08 Apr 2020 18:50:51 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8266: Export Data changes in WordPress 5.4 In-Reply-To: <039.d12c1acc8bc1c941c172d98b1ee3f4c6@wordpress.org> References: <039.d12c1acc8bc1c941c172d98b1ee3f4c6@wordpress.org> Message-ID: <054.6a5054b52c7dca6d27bb6e93fa376391@wordpress.org> #8266: Export Data changes in WordPress 5.4 --------------------------+--------------------- Reporter: r-a-y | Owner: (none) Type: task | Status: new Priority: normal | Milestone: 6.0.0 Component: Settings | Version: Severity: normal | Resolution: Keywords: dev-feedback | --------------------------+--------------------- Comment (by imath): imho If we were giving the possibility to members to export from the front end any WordPress data, we should probably also include these new ones. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Wed Apr 8 19:04:38 2020 From: noreply at wordpress.org (buddypress-trac) Date: Wed, 08 Apr 2020 19:04:38 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8270: Hello BuddyPress 6.0.0 Message-ID: <039.1733763d690106bcbeaba67add6dabcc@wordpress.org> #8270: Hello BuddyPress 6.0.0 --------------------+-------------------------------------- Reporter: imath | Owner: (none) Type: task | Status: new Priority: normal | Milestone: 6.0.0 Component: Core | Version: Severity: normal | Keywords: needs-patch dev-feedback --------------------+-------------------------------------- Let's work on updating our Hello BuddyPress screen. I'd also like we look at renaming the "Recent Rockstars" term in credits to use something like "6.0.0 Noteworthy Contributors" -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Wed Apr 8 19:19:20 2020 From: noreply at wordpress.org (buddypress-trac) Date: Wed, 08 Apr 2020 19:19:20 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8270: Hello BuddyPress 6.0.0 In-Reply-To: <039.1733763d690106bcbeaba67add6dabcc@wordpress.org> References: <039.1733763d690106bcbeaba67add6dabcc@wordpress.org> Message-ID: <054.65d4948ccb5e65ec0361d561f0b874b5@wordpress.org> #8270: Hello BuddyPress 6.0.0 --------------------------------------+--------------------- Reporter: imath | Owner: (none) Type: task | Status: new Priority: normal | Milestone: 6.0.0 Component: Core | Version: Severity: normal | Resolution: Keywords: needs-patch dev-feedback | --------------------------------------+--------------------- Comment (by imath): @todo Add a link to the BuddyPress Survey 2020 into our "Hello BuddyPress Screen" -- Ticket URL: BuddyPress Trac BuddyPress Trac From buddypress-trac at lists.automattic.com Thu Apr 9 03:40:32 2020 From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com) Date: Thu, 9 Apr 2020 03:40:32 +0000 (UTC) Subject: [buddypress-trac] [BuddyPress][12612] trunk/src/bp-settings/bp-settings-functions.php: Settings: Ensure we use the updated user request function for WordPress 5.4.0. Message-ID: <20200409034032.4651E1B00542@svn1.ord.wordpress.org> An HTML attachment was scrubbed... URL: From noreply at wordpress.org Thu Apr 9 03:40:36 2020 From: noreply at wordpress.org (buddypress-trac) Date: Thu, 09 Apr 2020 03:40:36 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8265: WordPress Update 5.4 Changed function wp_get_user_request_data() In-Reply-To: <040.43e24b5f258943ee9b1d002485cd7c41@wordpress.org> References: <040.43e24b5f258943ee9b1d002485cd7c41@wordpress.org> Message-ID: <055.6de1c5d9f583c66d079fc86fa12d4efc@wordpress.org> #8265: WordPress Update 5.4 Changed function wp_get_user_request_data() ------------------------------+--------------------- Reporter: Dono12 | Owner: (none) Type: defect (bug) | Status: new Priority: high | Milestone: 5.2.0 Component: Settings | Version: 5.0.0 Severity: major | Resolution: Keywords: has-patch commit | ------------------------------+--------------------- Comment (by r-a-y): In [changeset:"12612" 12612]: {{{ #!CommitTicketReference repository="" revision="12612" Settings: Ensure we use the updated user request function for WordPress 5.4.0. In WordPress 5.4.0, the `wp_get_user_request_data()` function was renamed to `wp_get_user_request()`. See #WP46302. Props Dono12. See #8265 (trunk). }}} -- Ticket URL: BuddyPress Trac BuddyPress Trac From buddypress-trac at lists.automattic.com Thu Apr 9 03:41:20 2020 From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com) Date: Thu, 9 Apr 2020 03:41:20 +0000 (UTC) Subject: [buddypress-trac] [BuddyPress][12613] branches/5.0/src/bp-settings/bp-settings-functions.php: Settings: Ensure we use the updated user request function for WordPress 5.4.0. Message-ID: <20200409034120.068491B00504@svn1.ord.wordpress.org> An HTML attachment was scrubbed... URL: From noreply at wordpress.org Thu Apr 9 03:41:24 2020 From: noreply at wordpress.org (buddypress-trac) Date: Thu, 09 Apr 2020 03:41:24 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8265: WordPress Update 5.4 Changed function wp_get_user_request_data() In-Reply-To: <040.43e24b5f258943ee9b1d002485cd7c41@wordpress.org> References: <040.43e24b5f258943ee9b1d002485cd7c41@wordpress.org> Message-ID: <055.ee00db21dc5b6396c12d228dc55d3828@wordpress.org> #8265: WordPress Update 5.4 Changed function wp_get_user_request_data() ------------------------------+--------------------- Reporter: Dono12 | Owner: r-a-y Type: defect (bug) | Status: closed Priority: high | Milestone: 5.2.0 Component: Settings | Version: 5.0.0 Severity: major | Resolution: fixed Keywords: has-patch commit | ------------------------------+--------------------- Changes (by r-a-y): * owner: (none) => r-a-y * status: new => closed * resolution: => fixed Comment: In [changeset:"12613" 12613]: {{{ #!CommitTicketReference repository="" revision="12613" Settings: Ensure we use the updated user request function for WordPress 5.4.0. In WordPress 5.4.0, the `wp_get_user_request_data()` function was renamed to `wp_get_user_request()`. See #WP46302. Props Dono12. Fixes #8265 (5.0-branch). }}} -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Thu Apr 9 04:45:58 2020 From: noreply at wordpress.org (buddypress-trac) Date: Thu, 09 Apr 2020 04:45:58 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8271: BP Blocks: one panel for all block settings Message-ID: <039.8bd712dcac2a4a43117ca4e363c9e456@wordpress.org> #8271: BP Blocks: one panel for all block settings --------------------------+----------------------- Reporter: imath | Owner: imath Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0.0 Component: REST API | Version: Severity: normal | Keywords: has-patch --------------------------+----------------------- We've been talking about it yesterday during our dev-chat: @greenshady wrote a [https://wptavern.com/buddypress-6-0-beta-introduces-group-and- member-blocks great post] on WPTavern to share about the BP Blocks feature. In this post he also shared a very interesting feedback: > The only trivial gripe I have with the new blocks is how the block settings are handled. Each setting is placed within its own tabbed section. It does not make sense to open or close four tabs to get to a single setting for each. And I totally agree. We don't need a panel for each setting. Once we'll have more settings for a feature, we'll be able to add Panels. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Thu Apr 9 04:46:30 2020 From: noreply at wordpress.org (buddypress-trac) Date: Thu, 09 Apr 2020 04:46:30 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8271: BP Blocks: one panel for all block settings In-Reply-To: <039.8bd712dcac2a4a43117ca4e363c9e456@wordpress.org> References: <039.8bd712dcac2a4a43117ca4e363c9e456@wordpress.org> Message-ID: <054.1183fe44c51c76146c3a6a304c944063@wordpress.org> #8271: BP Blocks: one panel for all block settings --------------------------+----------------------- Reporter: imath | Owner: imath Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0.0 Component: REST API | Version: Severity: normal | Resolution: Keywords: has-patch | --------------------------+----------------------- Changes (by imath): * Attachment "8271.patch" added. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Thu Apr 9 04:50:29 2020 From: noreply at wordpress.org (buddypress-trac) Date: Thu, 09 Apr 2020 04:50:29 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8271: BP Blocks: one panel for all block settings In-Reply-To: <039.8bd712dcac2a4a43117ca4e363c9e456@wordpress.org> References: <039.8bd712dcac2a4a43117ca4e363c9e456@wordpress.org> Message-ID: <054.fb4989d827ba7cf07266ee2231f1d51a@wordpress.org> #8271: BP Blocks: one panel for all block settings --------------------------+----------------------- Reporter: imath | Owner: imath Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0.0 Component: REST API | Version: Severity: normal | Resolution: Keywords: has-patch | --------------------------+----------------------- Comment (by imath): Here's a screenshot of how it would look for: The Member block [[Image(https://cldup.com/nCWPxRQG94.png)]] The Group block [[Image(https://cldup.com/XljqIcq9xc.png)]] -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Thu Apr 9 13:09:31 2020 From: noreply at wordpress.org (buddypress-trac) Date: Thu, 09 Apr 2020 13:09:31 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8271: BP Blocks: one panel for all block settings In-Reply-To: <039.8bd712dcac2a4a43117ca4e363c9e456@wordpress.org> References: <039.8bd712dcac2a4a43117ca4e363c9e456@wordpress.org> Message-ID: <054.042fb63b01a55eed9ab6e8b024195f65@wordpress.org> #8271: BP Blocks: one panel for all block settings --------------------------+----------------------- Reporter: imath | Owner: imath Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0.0 Component: REST API | Version: Severity: normal | Resolution: Keywords: has-patch | --------------------------+----------------------- Comment (by espellcaste): Not sure if we have the time but it'd be great if we had that in. Patch looks good. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Thu Apr 9 13:19:04 2020 From: noreply at wordpress.org (buddypress-trac) Date: Thu, 09 Apr 2020 13:19:04 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8272: Private groups not available in group block Message-ID: <044.e48d579408e9fea09a02b858e7afb03f@wordpress.org> #8272: Private groups not available in group block --------------------------+-------------------- Reporter: iamthewebb | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0.0 Component: (not sure) | Version: Severity: normal | Keywords: --------------------------+-------------------- I created an empty WP site with only v6.0.0 of BP installed. I created one of each group type. The public group can be selected in the new Group Blocks but both Private and Hidden groups do not appear to be selected. Description of Private groups Only people who request membership and are accepted can join the group. This group will be listed in the groups directory and in search results. Group content and activity will only be visible to members of the group. I don't think this would be circumvented by having the Private groups available for selection? -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Thu Apr 9 14:16:13 2020 From: noreply at wordpress.org (buddypress-trac) Date: Thu, 09 Apr 2020 14:16:13 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8273: Nouveau avatar rounding incorrectly Message-ID: <044.620505eaf6d86847a7aef6f2ad044fa3@wordpress.org> #8273: Nouveau avatar rounding incorrectly --------------------------+----------------------------- Reporter: iamthewebb | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Templates | Version: 5.0.0 Severity: normal | Keywords: --------------------------+----------------------------- Clean install of WP 5.4 BP 5.1.2 or 6.0 beta1 (seems to apply to all recent versions of BP) using Twenty Twenty theme. Avatars for Groups and Members are square by default using the default One Column loops, when you change this to Two column or more the Group and Member images are change to circular. There is a setting within General BP Settings -> Use the round style for member and group avatars but this is being ignored by these layouts. Also in the new Blocks for Groups and Members this setting is also ignored, feels a bit disjointed to have a setting that only applies to some parts of a site. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Thu Apr 9 15:55:28 2020 From: noreply at wordpress.org (buddypress-trac) Date: Thu, 09 Apr 2020 15:55:28 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8272: Private groups not available in group block In-Reply-To: <044.e48d579408e9fea09a02b858e7afb03f@wordpress.org> References: <044.e48d579408e9fea09a02b858e7afb03f@wordpress.org> Message-ID: <059.f96450bb7e27acf9b0ffa9db8fa74c97@wordpress.org> #8272: Private groups not available in group block --------------------------+--------------------- Reporter: iamthewebb | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0.0 Component: (not sure) | Version: Severity: normal | Resolution: Keywords: dev-feedback | --------------------------+--------------------- Changes (by imath): * keywords: => dev-feedback Comment: Hi @iamthewebb Thanks for your feedback. It's a deliberate choice I've made. To me featuring a private group into a Post or a Page doesn't seem to be a great experience for the site's visitors. Once they click on the Group's link, they can't see more than what's into the BP Group Block. But, I'm very open to change this if other members of the team think it's a better idea to also include private groups. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Thu Apr 9 15:56:53 2020 From: noreply at wordpress.org (buddypress-trac) Date: Thu, 09 Apr 2020 15:56:53 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8271: BP Blocks: one panel for all block settings In-Reply-To: <039.8bd712dcac2a4a43117ca4e363c9e456@wordpress.org> References: <039.8bd712dcac2a4a43117ca4e363c9e456@wordpress.org> Message-ID: <054.2d5576c32be7e6915771d8d0b8d1283c@wordpress.org> #8271: BP Blocks: one panel for all block settings ------------------------------+----------------------- Reporter: imath | Owner: imath Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0.0 Component: REST API | Version: Severity: normal | Resolution: Keywords: has-patch commit | ------------------------------+----------------------- Changes (by imath): * keywords: has-patch => has-patch commit Comment: I'll include it into beta2 ;) -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Fri Apr 10 04:36:21 2020 From: noreply at wordpress.org (buddypress-trac) Date: Fri, 10 Apr 2020 04:36:21 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8273: Nouveau avatar rounding incorrectly In-Reply-To: <044.620505eaf6d86847a7aef6f2ad044fa3@wordpress.org> References: <044.620505eaf6d86847a7aef6f2ad044fa3@wordpress.org> Message-ID: <059.37bd379ad8763df83471a8537da720d7@wordpress.org> #8273: Nouveau avatar rounding incorrectly --------------------------+---------------------- Reporter: iamthewebb | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Up Next Component: Templates | Version: 5.0.0 Severity: normal | Resolution: Keywords: needs-patch | --------------------------+---------------------- Changes (by imath): * keywords: => needs-patch * milestone: Awaiting Review => Up Next Comment: Thanks a lot for your feedback. I agree. I believe we shouldn't try to play with the avatar style and leave the theme completely handle it. So I'd probably remove the BP Nouveau Customizer setting. Let's take some time to think about it during next release. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Fri Apr 10 17:04:45 2020 From: noreply at wordpress.org (buddypress-trac) Date: Fri, 10 Apr 2020 17:04:45 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8274: Update Travis config for branch 5.0 Message-ID: <039.3a6e2b0e7ad6fdf6d466862b71df2f7e@wordpress.org> #8274: Update Travis config for branch 5.0 ------------------------------+---------------------- Reporter: imath | Owner: imath Type: task | Status: assigned Priority: normal | Milestone: 5.2.0 Component: Build/Test Tools | Version: Severity: normal | Keywords: commit ------------------------------+---------------------- I've noticed I forgot to update Travis config for branch 5.0 when I've committed r12552 to fix PHPunit errors about the jobs running on PHP 7.2. Let's do it now! -- Ticket URL: BuddyPress Trac BuddyPress Trac From buddypress-trac at lists.automattic.com Fri Apr 10 17:06:07 2020 From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com) Date: Fri, 10 Apr 2020 17:06:07 +0000 (UTC) Subject: [buddypress-trac] [BuddyPress][12614] branches/5.0/.travis.yml: Update Travis config for branch 5.0 Message-ID: <20200410170607.6D89D1B004D9@svn1.ord.wordpress.org> An HTML attachment was scrubbed... URL: From noreply at wordpress.org Fri Apr 10 17:06:11 2020 From: noreply at wordpress.org (buddypress-trac) Date: Fri, 10 Apr 2020 17:06:11 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8274: Update Travis config for branch 5.0 In-Reply-To: <039.3a6e2b0e7ad6fdf6d466862b71df2f7e@wordpress.org> References: <039.3a6e2b0e7ad6fdf6d466862b71df2f7e@wordpress.org> Message-ID: <054.78a26ac737564b80217d707fdfbcce9b@wordpress.org> #8274: Update Travis config for branch 5.0 ------------------------------+--------------------- Reporter: imath | Owner: imath Type: task | Status: closed Priority: normal | Milestone: 5.2.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: fixed Keywords: commit | ------------------------------+--------------------- Changes (by imath): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"12614" 12614]: {{{ #!CommitTicketReference repository="" revision="12614" Update Travis config for branch 5.0 Fixes #8274 }}} -- Ticket URL: BuddyPress Trac BuddyPress Trac From buddypress-trac at lists.automattic.com Fri Apr 10 17:09:13 2020 From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com) Date: Fri, 10 Apr 2020 17:09:13 +0000 (UTC) Subject: [buddypress-trac] [BuddyPress][12615] branches/5.0/.travis.yml: Do update Travis config for branch 5.0 completely Message-ID: <20200410170913.1A5211B004D9@svn1.ord.wordpress.org> An HTML attachment was scrubbed... URL: From noreply at wordpress.org Fri Apr 10 17:09:17 2020 From: noreply at wordpress.org (buddypress-trac) Date: Fri, 10 Apr 2020 17:09:17 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8274: Update Travis config for branch 5.0 In-Reply-To: <039.3a6e2b0e7ad6fdf6d466862b71df2f7e@wordpress.org> References: <039.3a6e2b0e7ad6fdf6d466862b71df2f7e@wordpress.org> Message-ID: <054.d7e4e2705a933f388b9326b1412ebc7f@wordpress.org> #8274: Update Travis config for branch 5.0 ------------------------------+--------------------- Reporter: imath | Owner: imath Type: task | Status: closed Priority: normal | Milestone: 5.2.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: fixed Keywords: commit | ------------------------------+--------------------- Comment (by imath): In [changeset:"12615" 12615]: {{{ #!CommitTicketReference repository="" revision="12615" Do update Travis config for branch 5.0 completely In last commit, specifying the distribution for one of the PHP 7.2 jobs was forgotten. See #8274 }}} -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Fri Apr 10 18:55:53 2020 From: noreply at wordpress.org (buddypress-trac) Date: Fri, 10 Apr 2020 18:55:53 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8266: Export Data changes in WordPress 5.4 In-Reply-To: <039.d12c1acc8bc1c941c172d98b1ee3f4c6@wordpress.org> References: <039.d12c1acc8bc1c941c172d98b1ee3f4c6@wordpress.org> Message-ID: <054.8bb349b4c085be7549fe81212976af35@wordpress.org> #8266: Export Data changes in WordPress 5.4 --------------------------+--------------------- Reporter: r-a-y | Owner: (none) Type: task | Status: new Priority: normal | Milestone: 6.0.0 Component: Settings | Version: Severity: normal | Resolution: Keywords: dev-feedback | --------------------------+--------------------- Comment (by r-a-y): Yeah, but most sites whitelist WordPress and don't want people knowing that their sites are even powered by it. I can understand WP's perspective that they estimate your location to show WP events that are nearby and that they should disclose that info. Maybe it would make more sense for us if the block was renamed to "Current Location" even though we don't make use of it in BuddyPress (might be interesting to use this data in a future version of BP!). The user session info would be more useful if it recorded logins across a longer period of time, but current sessions are not that useful in my eyes. I'm less worried about this block than the Community Events one. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Fri Apr 10 22:22:04 2020 From: noreply at wordpress.org (buddypress-trac) Date: Fri, 10 Apr 2020 22:22:04 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8141: bp_invitations table not created on update In-Reply-To: <041.d115b1428e0330cd84f39958863bcd4e@wordpress.org> References: <041.d115b1428e0330cd84f39958863bcd4e@wordpress.org> Message-ID: <056.6a613720d5e27c1ea4edad5bb41c9e14@wordpress.org> #8141: bp_invitations table not created on update --------------------------+------------------------------ Reporter: shanebp | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Groups | Version: 5.0.0 Severity: normal | Resolution: Keywords: | --------------------------+------------------------------ Comment (by shanebp): I've been seeing this error a lot recently. It seems that the table is only created during the initial install or upgrade. This isn't a fix, but it is a workaround hack that works. It just checks for the table on activation. Perhaps a BP Tool is more appropriate. {{{ function bp_check_invitations_db_table() { global $wpdb; require_once(ABSPATH . 'wp-admin/includes/upgrade.php'); $sql = array(); $charset_collate = $GLOBALS['wpdb']->get_charset_collate(); $bp_prefix = bp_core_get_table_prefix(); $sql[] = "CREATE TABLE IF NOT EXISTS {$bp_prefix}bp_invitations ( id bigint(20) NOT NULL AUTO_INCREMENT PRIMARY KEY, user_id bigint(20) NOT NULL, inviter_id bigint(20) NOT NULL, invitee_email varchar(100) DEFAULT NULL, class varchar(120) NOT NULL, item_id bigint(20) NOT NULL, secondary_item_id bigint(20) DEFAULT NULL, type varchar(12) NOT NULL DEFAULT 'invite', content longtext DEFAULT '', date_modified datetime NOT NULL, invite_sent tinyint(1) NOT NULL DEFAULT '0', accepted tinyint(1) NOT NULL DEFAULT '0', KEY user_id (user_id), KEY inviter_id (inviter_id), KEY invitee_email (invitee_email), KEY class (class), KEY item_id (item_id), KEY secondary_item_id (secondary_item_id), KEY type (type), KEY invite_sent (invite_sent), KEY accepted (accepted) ) {$charset_collate};"; dbDelta( $sql ); } add_action( 'bp_activation', 'bp_check_invitations_db_table' ); }}} -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Fri Apr 10 23:24:15 2020 From: noreply at wordpress.org (buddypress-trac) Date: Fri, 10 Apr 2020 23:24:15 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8141: bp_invitations table not created on update In-Reply-To: <041.d115b1428e0330cd84f39958863bcd4e@wordpress.org> References: <041.d115b1428e0330cd84f39958863bcd4e@wordpress.org> Message-ID: <056.46aca60260c10da6a134842bef27a1f5@wordpress.org> #8141: bp_invitations table not created on update --------------------------+------------------------------ Reporter: shanebp | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Groups | Version: 5.0.0 Severity: normal | Resolution: Keywords: | --------------------------+------------------------------ Comment (by dcavins): I'll write a tool this weekend. Thanks for the reminder. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Sat Apr 11 07:25:32 2020 From: noreply at wordpress.org (buddypress-trac) Date: Sat, 11 Apr 2020 07:25:32 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8141: bp_invitations table not created on update In-Reply-To: <041.d115b1428e0330cd84f39958863bcd4e@wordpress.org> References: <041.d115b1428e0330cd84f39958863bcd4e@wordpress.org> Message-ID: <056.fda39666e9aaf4d416a22143085b1619@wordpress.org> #8141: bp_invitations table not created on update --------------------------+------------------------------ Reporter: shanebp | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Groups | Version: 5.0.0 Severity: normal | Resolution: Keywords: | --------------------------+------------------------------ Comment (by shanebp): It'd be nice to know why this issue occurs for the invitations table but not the other tables. Here's a tool. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Sat Apr 11 07:25:59 2020 From: noreply at wordpress.org (buddypress-trac) Date: Sat, 11 Apr 2020 07:25:59 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8141: bp_invitations table not created on update In-Reply-To: <041.d115b1428e0330cd84f39958863bcd4e@wordpress.org> References: <041.d115b1428e0330cd84f39958863bcd4e@wordpress.org> Message-ID: <056.cddc183ccaa869c90b6ce97305531eab@wordpress.org> #8141: bp_invitations table not created on update --------------------------+------------------------------ Reporter: shanebp | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Groups | Version: 5.0.0 Severity: normal | Resolution: Keywords: | --------------------------+------------------------------ Changes (by shanebp): * Attachment "8141.patch" added. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Sat Apr 11 07:32:43 2020 From: noreply at wordpress.org (buddypress-trac) Date: Sat, 11 Apr 2020 07:32:43 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8141: bp_invitations table not created on update In-Reply-To: <041.d115b1428e0330cd84f39958863bcd4e@wordpress.org> References: <041.d115b1428e0330cd84f39958863bcd4e@wordpress.org> Message-ID: <056.2fb587e0c5d0a1720273a7ac86122cd6@wordpress.org> #8141: bp_invitations table not created on update --------------------------+------------------------------ Reporter: shanebp | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Groups | Version: 5.0.0 Severity: normal | Resolution: Keywords: | --------------------------+------------------------------ Changes (by shanebp): * Attachment "8141.patch" added. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Sat Apr 11 07:32:43 2020 From: noreply at wordpress.org (buddypress-trac) Date: Sat, 11 Apr 2020 07:32:43 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8141: bp_invitations table not created on update In-Reply-To: <041.d115b1428e0330cd84f39958863bcd4e@wordpress.org> References: <041.d115b1428e0330cd84f39958863bcd4e@wordpress.org> Message-ID: <041.d115b1428e0330cd84f39958863bcd4e@wordpress.org> #8141: bp_invitations table not created on update --------------------------+------------------------------ Reporter: shanebp | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Groups | Version: 5.0.0 Severity: normal | Resolution: Keywords: | --------------------------+------------------------------ Changes (by shanebp): * Attachment "8141.patch" removed. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Sat Apr 11 14:25:29 2020 From: noreply at wordpress.org (buddypress-trac) Date: Sat, 11 Apr 2020 14:25:29 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8141: bp_invitations table not created on update In-Reply-To: <041.d115b1428e0330cd84f39958863bcd4e@wordpress.org> References: <041.d115b1428e0330cd84f39958863bcd4e@wordpress.org> Message-ID: <041.d115b1428e0330cd84f39958863bcd4e@wordpress.org> #8141: bp_invitations table not created on update --------------------------+------------------------------ Reporter: shanebp | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Groups | Version: 5.0.0 Severity: normal | Resolution: Keywords: | --------------------------+------------------------------ Changes (by shanebp): * Attachment "8141.patch" removed. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Sat Apr 11 14:25:29 2020 From: noreply at wordpress.org (buddypress-trac) Date: Sat, 11 Apr 2020 14:25:29 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8141: bp_invitations table not created on update In-Reply-To: <041.d115b1428e0330cd84f39958863bcd4e@wordpress.org> References: <041.d115b1428e0330cd84f39958863bcd4e@wordpress.org> Message-ID: <056.568f2d1765777ff50236dfac8bd7dee3@wordpress.org> #8141: bp_invitations table not created on update --------------------------+------------------------------ Reporter: shanebp | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Groups | Version: 5.0.0 Severity: normal | Resolution: Keywords: | --------------------------+------------------------------ Changes (by shanebp): * Attachment "8141.patch" added. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Sat Apr 11 21:04:36 2020 From: noreply at wordpress.org (buddypress-trac) Date: Sat, 11 Apr 2020 21:04:36 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8141: bp_invitations table not created on update In-Reply-To: <041.d115b1428e0330cd84f39958863bcd4e@wordpress.org> References: <041.d115b1428e0330cd84f39958863bcd4e@wordpress.org> Message-ID: <056.06c66033984e81589d43dd7df5eca8a6@wordpress.org> #8141: bp_invitations table not created on update --------------------------+------------------------------ Reporter: shanebp | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Groups | Version: 5.0.0 Severity: normal | Resolution: Keywords: | --------------------------+------------------------------ Changes (by dcavins): * Attachment "8141.2.patch" added. Expand Shane's patch to also migrate group invitations. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Sat Apr 11 21:09:30 2020 From: noreply at wordpress.org (buddypress-trac) Date: Sat, 11 Apr 2020 21:09:30 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8141: bp_invitations table not created on update In-Reply-To: <041.d115b1428e0330cd84f39958863bcd4e@wordpress.org> References: <041.d115b1428e0330cd84f39958863bcd4e@wordpress.org> Message-ID: <056.89ebb1100f0899d82e288a15aef33f0e@wordpress.org> #8141: bp_invitations table not created on update --------------------------+------------------------------ Reporter: shanebp | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Groups | Version: 5.0.0 Severity: normal | Resolution: Keywords: | --------------------------+------------------------------ Comment (by dcavins): Hi @shanebp- Thanks a million for your patch. I've expanded it in the following ways: ā€¢Ā Use the existing `bp_core_install_invitations()` function to create or update the invitations table. ā€¢Ā Also migrate group invitations if necessary, using the function `bp_groups_migrate_invitations()`. @imath: What do you think about including this very narrow change in BP6.0, even though we've passed beta1? The code is run only when fired by the site owner, so it's scope is very limited; however, there are several new strings that will need to be translated. Thanks again @shanebp for submitting a working patch! -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Sun Apr 12 04:07:54 2020 From: noreply at wordpress.org (buddypress-trac) Date: Sun, 12 Apr 2020 04:07:54 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8141: bp_invitations table not created on update In-Reply-To: <041.d115b1428e0330cd84f39958863bcd4e@wordpress.org> References: <041.d115b1428e0330cd84f39958863bcd4e@wordpress.org> Message-ID: <056.dc201e638972a80775079269771b14ac@wordpress.org> #8141: bp_invitations table not created on update --------------------------+------------------------------ Reporter: shanebp | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Groups | Version: 5.0.0 Severity: normal | Resolution: Keywords: | --------------------------+------------------------------ Changes (by imath): * Attachment "8141.2.additionalSuggestion.patch" added. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Sun Apr 12 04:14:15 2020 From: noreply at wordpress.org (buddypress-trac) Date: Sun, 12 Apr 2020 04:14:15 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8141: bp_invitations table not created on update In-Reply-To: <041.d115b1428e0330cd84f39958863bcd4e@wordpress.org> References: <041.d115b1428e0330cd84f39958863bcd4e@wordpress.org> Message-ID: <056.84f6740f553f8852ac0003e9b0f06b91@wordpress.org> #8141: bp_invitations table not created on update --------------------------+------------------------------ Reporter: shanebp | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Groups | Version: 5.0.0 Severity: normal | Resolution: Keywords: commit | --------------------------+------------------------------ Changes (by imath): * keywords: => commit Comment: Hi @dcavins Sure no problem, could you commit it before packaging beta2 (April 15) ? Also, I've added an additional suggestion above. I believe the `bp_core_install_invitations()` function should be included into the `bp_core_install()`one as this function is always used (install and upgrade) and all custom table creation is included there. Also, could you add some ponctuation like below into your patch? {{{ // Invitations: // - maybe create the database table. }}} -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Mon Apr 13 16:47:56 2020 From: noreply at wordpress.org (buddypress-trac) Date: Mon, 13 Apr 2020 16:47:56 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8275: Notification don't go away Message-ID: <048.0eccafaf9f8bf23d0d99cef8a6ca89ea@wordpress.org> #8275: Notification don't go away ------------------------------+------------------------------------ Reporter: squaredsquared | Owner: (none) Type: defect (bug) | Status: assigned Priority: highest | Milestone: Awaiting Contributions Component: Extended Profile | Version: 5.0.0 Severity: normal | Keywords: ------------------------------+------------------------------------ Settings -> export data - ā€œData export request successfully createdā€ alert should automatically go away after a few seconds. I read some solution but it does not work on my end I use: Buddy Press Version 5.1.2 I got this like notice, I would like to know how to make it disappear after 5seconds Thank you. This is the link to the image for this: https://imgur.com/2Ppkulh -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Mon Apr 13 16:48:18 2020 From: noreply at wordpress.org (buddypress-trac) Date: Mon, 13 Apr 2020 16:48:18 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8275: Notification don't go away In-Reply-To: <048.0eccafaf9f8bf23d0d99cef8a6ca89ea@wordpress.org> References: <048.0eccafaf9f8bf23d0d99cef8a6ca89ea@wordpress.org> Message-ID: <063.42d1ed562b716634de04d4b875ee2785@wordpress.org> #8275: Notification don't go away ------------------------------+------------------------------------- Reporter: squaredsquared | Owner: (none) Type: defect (bug) | Status: assigned Priority: highest | Milestone: Awaiting Contributions Component: Extended Profile | Version: 5.0.0 Severity: normal | Resolution: Keywords: | ------------------------------+------------------------------------- Changes (by squaredsquared): * Attachment "bp.PNG" added. Notification that does not disappear -- Ticket URL: BuddyPress Trac BuddyPress Trac From buddypress-trac at lists.automattic.com Mon Apr 13 17:50:50 2020 From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com) Date: Mon, 13 Apr 2020 17:50:50 +0000 (UTC) Subject: [buddypress-trac] [BuddyPress][12616] trunk/src/bp-core/admin/bp-core-admin-tools.php: Add invitations repair tool. Message-ID: <20200413175050.954B11B00404@svn1.ord.wordpress.org> An HTML attachment was scrubbed... URL: From noreply at wordpress.org Mon Apr 13 17:50:55 2020 From: noreply at wordpress.org (buddypress-trac) Date: Mon, 13 Apr 2020 17:50:55 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8141: bp_invitations table not created on update In-Reply-To: <041.d115b1428e0330cd84f39958863bcd4e@wordpress.org> References: <041.d115b1428e0330cd84f39958863bcd4e@wordpress.org> Message-ID: <056.4ee5dbef5c387b8a4a3c34f2ce63d95a@wordpress.org> #8141: bp_invitations table not created on update --------------------------+------------------------------ Reporter: shanebp | Owner: dcavins Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: Groups | Version: 5.0.0 Severity: normal | Resolution: fixed Keywords: commit | --------------------------+------------------------------ Changes (by dcavins): * owner: (none) => dcavins * status: new => closed * resolution: => fixed Comment: In [changeset:"12616" 12616]: {{{ #!CommitTicketReference repository="" revision="12616" Add invitations repair tool. Add tool to the WP Admin Dashboard > Tools > Buddypress screen to create the invitations table when table creation has failed during the plugin update process. Additionally, this tool will migrate any outstanding group invitations once the table is created. Props shanebp. Fixes #8141. }}} -- Ticket URL: BuddyPress Trac BuddyPress Trac From buddypress-trac at lists.automattic.com Mon Apr 13 17:50:59 2020 From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com) Date: Mon, 13 Apr 2020 17:50:59 +0000 (UTC) Subject: [buddypress-trac] [BuddyPress][12617] trunk/src/bp-core: Move call to bp_core_install_invitations(). Message-ID: <20200413175059.57B4E1B00404@svn1.ord.wordpress.org> An HTML attachment was scrubbed... URL: From noreply at wordpress.org Tue Apr 14 02:56:23 2020 From: noreply at wordpress.org (buddypress-trac) Date: Tue, 14 Apr 2020 02:56:23 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8066: Missing password validation at password change In-Reply-To: <040.3d0af760f49bfc033190c79e9d9d6b53@wordpress.org> References: <040.3d0af760f49bfc033190c79e9d9d6b53@wordpress.org> Message-ID: <055.b01cc1b736a1460b4ec88b047b980b78@wordpress.org> #8066: Missing password validation at password change -------------------------------+---------------------- Reporter: devnik | Owner: (none) Type: enhancement | Status: new Priority: high | Milestone: Up Next Component: Members | Version: 4.1.0 Severity: normal | Resolution: Keywords: reporter-feedback | -------------------------------+---------------------- Comment (by stokim): @imath Can I expect this patch at 6.0? I'm looking forward to it. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Tue Apr 14 05:02:29 2020 From: noreply at wordpress.org (buddypress-trac) Date: Tue, 14 Apr 2020 05:02:29 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8276: Add action filter to bp-xprofile > screens > edit.php Message-ID: <040.b67c2fa69175ded6d475eadd54928806@wordpress.org> #8276: Add action filter to bp-xprofile > screens > edit.php --------------------------+----------------------------- Reporter: stokim | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Core | Version: Severity: normal | Keywords: --------------------------+----------------------------- Hi there! Thank you for your efforts always. In case of xprofile field, there's no filter hook when changed. bp-xprofile > screens > edit.php 52 line, Could you add action filter, do_action( 'pre_xprofile_profile_field_data_update', $posted_field_ids ); So that I can handle with $_POST['field_' . $field_id] and $_POST['field_ids']? Actually, I thought it would be better to add an action hook in bp- xprofile > bp-xprofile-functions.php > xprofile_set_field_data > 432 line do_action( 'pre_bp_xprofile_set_field_data_validate', $value, $field, $field_type_obj ); for registration process and edit process both, however, there's no handling errors on this function, so I gave up. Thank you for your consideration. Best regards, Jen -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Tue Apr 14 05:27:20 2020 From: noreply at wordpress.org (buddypress-trac) Date: Tue, 14 Apr 2020 05:27:20 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8276: Add action filter to bp-xprofile > screens > edit.php In-Reply-To: <040.b67c2fa69175ded6d475eadd54928806@wordpress.org> References: <040.b67c2fa69175ded6d475eadd54928806@wordpress.org> Message-ID: <055.702fb8b7adf8916e431a4e805d2c8515@wordpress.org> #8276: Add action filter to bp-xprofile > screens > edit.php -------------------------+------------------------------ Reporter: stokim | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Core | Version: Severity: normal | Resolution: Keywords: | -------------------------+------------------------------ Changes (by stokim): * type: defect (bug) => enhancement -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Tue Apr 14 05:46:06 2020 From: noreply at wordpress.org (buddypress-trac) Date: Tue, 14 Apr 2020 05:46:06 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8276: Add action filter to bp-xprofile > screens > edit.php In-Reply-To: <040.b67c2fa69175ded6d475eadd54928806@wordpress.org> References: <040.b67c2fa69175ded6d475eadd54928806@wordpress.org> Message-ID: <055.8d9a3d75e86d171e9f539e477888fb95@wordpress.org> #8276: Add action filter to bp-xprofile > screens > edit.php -------------------------+------------------------------ Reporter: stokim | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Core | Version: Severity: normal | Resolution: Keywords: | -------------------------+------------------------------ Comment (by stokim): Or it would be good if there's a function, validate_xproifle_field like this: https://buddypress.trac.wordpress.org/attachment/ticket/8066/8066.2.patch -- Ticket URL: BuddyPress Trac BuddyPress Trac From buddypress-trac at lists.automattic.com Wed Apr 15 00:08:56 2020 From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com) Date: Wed, 15 Apr 2020 00:08:56 +0000 (UTC) Subject: [buddypress-trac] [BuddyPress][12618] trunk/src: BP Blocks: gather all settings into a unique panel Message-ID: <20200415000856.ADFFE1B004C6@svn1.ord.wordpress.org> An HTML attachment was scrubbed... URL: From noreply at wordpress.org Wed Apr 15 00:09:01 2020 From: noreply at wordpress.org (buddypress-trac) Date: Wed, 15 Apr 2020 00:09:01 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8271: BP Blocks: one panel for all block settings In-Reply-To: <039.8bd712dcac2a4a43117ca4e363c9e456@wordpress.org> References: <039.8bd712dcac2a4a43117ca4e363c9e456@wordpress.org> Message-ID: <054.10ab1d6c7d79e699bde1bdb9ae27fce2@wordpress.org> #8271: BP Blocks: one panel for all block settings ------------------------------+--------------------- Reporter: imath | Owner: imath Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0.0 Component: REST API | Version: Severity: normal | Resolution: fixed Keywords: has-patch commit | ------------------------------+--------------------- Changes (by imath): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"12618" 12618]: {{{ #!CommitTicketReference repository="" revision="12618" BP Blocks: gather all settings into a unique panel Props greenshady Fixes #8271 }}} -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Wed Apr 15 00:11:53 2020 From: noreply at wordpress.org (buddypress-trac) Date: Wed, 15 Apr 2020 00:11:53 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8272: Private groups not available in group block In-Reply-To: <044.e48d579408e9fea09a02b858e7afb03f@wordpress.org> References: <044.e48d579408e9fea09a02b858e7afb03f@wordpress.org> Message-ID: <059.7de1878fcad9b7669bff5a977514f247@wordpress.org> #8272: Private groups not available in group block --------------------------+---------------------- Reporter: iamthewebb | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Up Next Component: (not sure) | Version: Severity: normal | Resolution: Keywords: dev-feedback | --------------------------+---------------------- Changes (by imath): * milestone: 6.0.0 => Up Next Comment: I believe we're running out of time about this ticket for 6.0.0. Let's work on it during next development cycle. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Wed Apr 15 00:45:29 2020 From: noreply at wordpress.org (buddypress-trac) Date: Wed, 15 Apr 2020 00:45:29 -0000 Subject: [buddypress-trac] =?utf-8?q?=5BBuddyPress_Trac=5D_=238269=3A_Mem?= =?utf-8?q?ber_Directory_nav_tab_Won=E2=80=99t_Display_over_999_member_cou?= =?utf-8?q?nt?= In-Reply-To: <043.f838373c3f80f4279097349a9f773a02@wordpress.org> References: <043.f838373c3f80f4279097349a9f773a02@wordpress.org> Message-ID: <058.6d412d695cd0d5c4fd3486e25d33eac0@wordpress.org> #8269: Member Directory nav tab Wonā€™t Display over 999 member count --------------------------+--------------------- Reporter: twmcmahan | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0.0 Component: Templates | Version: 5.0.0 Severity: normal | Resolution: Keywords: needs-patch | --------------------------+--------------------- Changes (by imath): * Attachment "8269.patch" added. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Wed Apr 15 00:46:48 2020 From: noreply at wordpress.org (buddypress-trac) Date: Wed, 15 Apr 2020 00:46:48 -0000 Subject: [buddypress-trac] =?utf-8?q?=5BBuddyPress_Trac=5D_=238269=3A_Mem?= =?utf-8?q?ber_Directory_nav_tab_Won=E2=80=99t_Display_over_999_member_cou?= =?utf-8?q?nt?= In-Reply-To: <043.f838373c3f80f4279097349a9f773a02@wordpress.org> References: <043.f838373c3f80f4279097349a9f773a02@wordpress.org> Message-ID: <058.5d40a2302b2a2df0eb7aa4c194f1a677@wordpress.org> #8269: Member Directory nav tab Wonā€™t Display over 999 member count --------------------------+--------------------- Reporter: twmcmahan | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0.0 Component: Templates | Version: 5.0.0 Severity: normal | Resolution: Keywords: has-patch | --------------------------+--------------------- Changes (by imath): * keywords: needs-patch => has-patch Comment: I confirm, the reason of this issue is we're applying twice the `number_format_i18n()` function. Once in `bp_core_number_format()` and another time into `bp_nouveau_nav_count()`. That's one too much. 8269.patch is removing the first one to format just before output. -- Ticket URL: BuddyPress Trac BuddyPress Trac From buddypress-trac at lists.automattic.com Wed Apr 15 00:59:00 2020 From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com) Date: Wed, 15 Apr 2020 00:59:00 +0000 (UTC) Subject: [buddypress-trac] [BuddyPress][12619] trunk/src/bp-templates/bp-nouveau/includes/members/loader.php: BP Nouveau: make sure to format the total members count once only Message-ID: <20200415005900.87A071B004E3@svn1.ord.wordpress.org> An HTML attachment was scrubbed... URL: From noreply at wordpress.org Wed Apr 15 00:59:05 2020 From: noreply at wordpress.org (buddypress-trac) Date: Wed, 15 Apr 2020 00:59:05 -0000 Subject: [buddypress-trac] =?utf-8?q?=5BBuddyPress_Trac=5D_=238269=3A_Mem?= =?utf-8?q?ber_Directory_nav_tab_Won=E2=80=99t_Display_over_999_member_cou?= =?utf-8?q?nt?= In-Reply-To: <043.f838373c3f80f4279097349a9f773a02@wordpress.org> References: <043.f838373c3f80f4279097349a9f773a02@wordpress.org> Message-ID: <058.dc1e4052f24ea4a128a5105ecf07779e@wordpress.org> #8269: Member Directory nav tab Wonā€™t Display over 999 member count --------------------------+--------------------- Reporter: twmcmahan | Owner: imath Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0.0 Component: Templates | Version: 5.0.0 Severity: normal | Resolution: fixed Keywords: has-patch | --------------------------+--------------------- Changes (by imath): * owner: (none) => imath * status: new => closed * resolution: => fixed Comment: In [changeset:"12619" 12619]: {{{ #!CommitTicketReference repository="" revision="12619" BP Nouveau: make sure to format the total members count once only Props twmcmahan Fixes #8269 }}} -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Wed Apr 15 04:11:07 2020 From: noreply at wordpress.org (buddypress-trac) Date: Wed, 15 Apr 2020 04:11:07 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8276: Add action filter to bp-xprofile > screens > edit.php In-Reply-To: <040.b67c2fa69175ded6d475eadd54928806@wordpress.org> References: <040.b67c2fa69175ded6d475eadd54928806@wordpress.org> Message-ID: <055.229dc914e81fe3637a366d86fb587962@wordpress.org> #8276: Add action filter to bp-xprofile > screens > edit.php -------------------------+------------------------------ Reporter: stokim | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Core | Version: Severity: normal | Resolution: Keywords: | -------------------------+------------------------------ Changes (by stokim): * Attachment "edit.patch" added. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Wed Apr 15 04:16:18 2020 From: noreply at wordpress.org (buddypress-trac) Date: Wed, 15 Apr 2020 04:16:18 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8276: Add action filter to bp-xprofile > screens > edit.php In-Reply-To: <040.b67c2fa69175ded6d475eadd54928806@wordpress.org> References: <040.b67c2fa69175ded6d475eadd54928806@wordpress.org> Message-ID: <055.49085ac774cb4424e827bc2ef349fc04@wordpress.org> #8276: Add action filter to bp-xprofile > screens > edit.php -------------------------+------------------------------ Reporter: stokim | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Core | Version: Severity: normal | Resolution: Keywords: | -------------------------+------------------------------ Comment (by stokim): The attached is the filter hook for handling errors of Xprofile value validation. It works well :) -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Wed Apr 15 04:31:33 2020 From: noreply at wordpress.org (buddypress-trac) Date: Wed, 15 Apr 2020 04:31:33 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8267: Storing avatar information into usermeta In-Reply-To: <040.3e5c9df901f7b6f0d4d4a2ea7c4aaf7f@wordpress.org> References: <040.3e5c9df901f7b6f0d4d4a2ea7c4aaf7f@wordpress.org> Message-ID: <055.ca98e748bb8fabd30594ebc02d0ffa75@wordpress.org> #8267: Storing avatar information into usermeta -------------------------+------------------------------ Reporter: stokim | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Core | Version: Severity: normal | Resolution: Keywords: | -------------------------+------------------------------ Changes (by stokim): * Attachment "avatar.patch" added. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Wed Apr 15 04:34:05 2020 From: noreply at wordpress.org (buddypress-trac) Date: Wed, 15 Apr 2020 04:34:05 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8267: Storing avatar information into usermeta In-Reply-To: <040.3e5c9df901f7b6f0d4d4a2ea7c4aaf7f@wordpress.org> References: <040.3e5c9df901f7b6f0d4d4a2ea7c4aaf7f@wordpress.org> Message-ID: <055.49380a5afc2012de7711559cfeb545c0@wordpress.org> #8267: Storing avatar information into usermeta -------------------------+------------------------------ Reporter: stokim | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Core | Version: Severity: normal | Resolution: Keywords: | -------------------------+------------------------------ Comment (by stokim): Only one line can change the way of fetching an avatar URL from poor directory check to DB inquiry. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Wed Apr 15 04:39:42 2020 From: noreply at wordpress.org (buddypress-trac) Date: Wed, 15 Apr 2020 04:39:42 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8267: Storing avatar information into usermeta In-Reply-To: <040.3e5c9df901f7b6f0d4d4a2ea7c4aaf7f@wordpress.org> References: <040.3e5c9df901f7b6f0d4d4a2ea7c4aaf7f@wordpress.org> Message-ID: <055.048baabafd100235d8aa0885a730910a@wordpress.org> #8267: Storing avatar information into usermeta -------------------------+------------------------------ Reporter: stokim | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Core | Version: Severity: normal | Resolution: Keywords: | -------------------------+------------------------------ Comment (by stokim): {{{#!php $serialized_avatar_url = get_user_meta( $user_id, 'avatar_url', true ); $avatar_url = $serialized_avatar_url ? maybe_unserialize( $serialized_avatar_url ) : null; You can get both size's url through $avatar_url['thumb'] and $avatar_url['full']; }}} -- Ticket URL: BuddyPress Trac BuddyPress Trac From buddypress-trac at lists.automattic.com Wed Apr 15 22:02:15 2020 From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com) Date: Wed, 15 Apr 2020 22:02:15 +0000 (UTC) Subject: [buddypress-trac] [BuddyPress][12620] trunk: 6.0.0-beta2 version bumps Message-ID: <20200415220215.9AE4C1B00404@svn1.ord.wordpress.org> An HTML attachment was scrubbed... URL: From buddypress-trac at lists.automattic.com Wed Apr 15 22:39:17 2020 From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com) Date: Wed, 15 Apr 2020 22:39:17 +0000 (UTC) Subject: [buddypress-trac] [BuddyPress][12621] tags/6.0.0-beta2/: Create 6.0.0-beta2 tag Message-ID: <20200415223917.AEBC81B00404@svn1.ord.wordpress.org> An HTML attachment was scrubbed... URL: From noreply at wordpress.org Thu Apr 16 06:31:19 2020 From: noreply at wordpress.org (buddypress-trac) Date: Thu, 16 Apr 2020 06:31:19 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8277: iSSUE with BUDDYPRESS LOGIN WIDGET Message-ID: <049.d15d94f1087d0f1ce0d281e095ea4525@wordpress.org> #8277: iSSUE with BUDDYPRESS LOGIN WIDGET -----------------------------+----------------------------- Reporter: giuseppecuttone | Owner: (none) Type: defect (bug) | Status: new Priority: high | Milestone: Awaiting Review Component: Core | Version: 5.0.0 Severity: normal | Keywords: -----------------------------+----------------------------- Hi, if I add in http://www.mysite.com/wp-login.php? some checkboxes about TERMS OF USE, PRIVACY etc... the checkboxes I add will be showed well in http://www.mysite.com/wp-login.php? but checkboxes will not be showed in the BUDDYPRESS LOGIN WIDGET. Code I am using is the follow: (as you can see I am using hook provided by wordpress) https://codex.wordpress.org/Customizing_the_Login_Form {{{#!php add('did_not_accept', 'You must accept the terms and conditions' ); return $error; } } // As part of WP login form construction, call our function add_filter ( 'login_form', 'login_form_acc' ); function login_form_acc(){ // Add an element to the login form, which must be checked echo ''; }}} Can someone make the correspondent modification to BuddyPress code to have running also my code into BuddyPress LogIn widget? Thanks very very very very very very for your support. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Thu Apr 16 18:16:22 2020 From: noreply at wordpress.org (buddypress-trac) Date: Thu, 16 Apr 2020 18:16:22 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8277: iSSUE with BUDDYPRESS LOGIN WIDGET In-Reply-To: <049.d15d94f1087d0f1ce0d281e095ea4525@wordpress.org> References: <049.d15d94f1087d0f1ce0d281e095ea4525@wordpress.org> Message-ID: <064.a1b3eb725ce0e2c5b29ff3c4d39ed4df@wordpress.org> #8277: iSSUE with BUDDYPRESS LOGIN WIDGET -------------------------------+------------------------------ Reporter: giuseppecuttone | Owner: (none) Type: defect (bug) | Status: new Priority: high | Milestone: Awaiting Review Component: Core | Version: 5.0.0 Severity: normal | Resolution: Keywords: reporter-feedback | -------------------------------+------------------------------ Changes (by imath): * keywords: => reporter-feedback Comment: Hi, Thanks a lot for submitting this ticket. I believe it's probably best you use the hook we provide to include the extra fields into the BP login form. You simply need to add this line of code: {{{ add_action( 'bp_login_widget_form', 'login_form_acc' ); }}} Is this ok for you ? -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Fri Apr 17 03:52:11 2020 From: noreply at wordpress.org (buddypress-trac) Date: Fri, 17 Apr 2020 03:52:11 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8278: Post 6.0.0-beta2 release improvements Message-ID: <039.5e6fdcc596bb2288b38e42e7b24607e1@wordpress.org> #8278: Post 6.0.0-beta2 release improvements --------------------------+----------------------- Reporter: imath | Owner: imath Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0.0 Component: Core | Version: Severity: normal | Keywords: has-patch --------------------------+----------------------- When packaging the 6.0.0 release, I've noticed we needed to update Travis config now WordPress 5.4 has been released and got 2 WP CLI makepot warnings about missing `/* translators */` comments. Moreover, to avoid doing this at the last minute, the patch is updating readme.txt so that it includes the upgrade notices & changelogs for 5.1.0, 5.1.1 & 5.1.2 -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Fri Apr 17 03:52:42 2020 From: noreply at wordpress.org (buddypress-trac) Date: Fri, 17 Apr 2020 03:52:42 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8278: Post 6.0.0-beta2 release improvements In-Reply-To: <039.5e6fdcc596bb2288b38e42e7b24607e1@wordpress.org> References: <039.5e6fdcc596bb2288b38e42e7b24607e1@wordpress.org> Message-ID: <054.70cdfc1ab671c015b3c469b4451d7017@wordpress.org> #8278: Post 6.0.0-beta2 release improvements --------------------------+----------------------- Reporter: imath | Owner: imath Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0.0 Component: Core | Version: Severity: normal | Resolution: Keywords: has-patch | --------------------------+----------------------- Changes (by imath): * Attachment "8278.patch" added. -- Ticket URL: BuddyPress Trac BuddyPress Trac From buddypress-trac at lists.automattic.com Fri Apr 17 04:01:31 2020 From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com) Date: Fri, 17 Apr 2020 04:01:31 +0000 (UTC) Subject: [buddypress-trac] [BuddyPress][12622] trunk: Update Travis config, readme.txt & add missing translators comments Message-ID: <20200417040131.21FEC1B0056D@svn1.ord.wordpress.org> An HTML attachment was scrubbed... URL: From noreply at wordpress.org Fri Apr 17 04:01:36 2020 From: noreply at wordpress.org (buddypress-trac) Date: Fri, 17 Apr 2020 04:01:36 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8278: Post 6.0.0-beta2 release improvements In-Reply-To: <039.5e6fdcc596bb2288b38e42e7b24607e1@wordpress.org> References: <039.5e6fdcc596bb2288b38e42e7b24607e1@wordpress.org> Message-ID: <054.314a8641447836b4dc2b8bc38b5ba350@wordpress.org> #8278: Post 6.0.0-beta2 release improvements --------------------------+--------------------- Reporter: imath | Owner: imath Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0.0 Component: Core | Version: Severity: normal | Resolution: fixed Keywords: has-patch | --------------------------+--------------------- Changes (by imath): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"12622" 12622]: {{{ #!CommitTicketReference repository="" revision="12622" Update Travis config, readme.txt & add missing translators comments Fixes #8278 }}} -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Fri Apr 17 04:47:30 2020 From: noreply at wordpress.org (buddypress-trac) Date: Fri, 17 Apr 2020 04:47:30 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8279: What about introducing BP Friends Types in 7.0.0 ? Message-ID: <039.57180ca20995d9cdcf4b4cc8d12f8a11@wordpress.org> #8279: What about introducing BP Friends Types in 7.0.0 ? -----------------------------+-------------------------- Reporter: imath | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Up Next Component: Friends | Version: Severity: normal | Keywords: dev-feedback -----------------------------+-------------------------- Hi! Someone contacted me on my personal blog to ask me if when it will be possible to have this: https://buddypress.org/support/topic/level-of-connectionfriendship/ It's an 11 years old forum topic and I think as we've proven with Member Types and Group Types, this is probably something we can work on using a taxonomy. What's your opinion about it? -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Fri Apr 17 04:47:52 2020 From: noreply at wordpress.org (buddypress-trac) Date: Fri, 17 Apr 2020 04:47:52 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8279: What about introducing BP Friends Types in 7.0.0 ? In-Reply-To: <039.57180ca20995d9cdcf4b4cc8d12f8a11@wordpress.org> References: <039.57180ca20995d9cdcf4b4cc8d12f8a11@wordpress.org> Message-ID: <054.1e42a96da3e164e2241e7058bcdf11f2@wordpress.org> #8279: What about introducing BP Friends Types in 7.0.0 ? -----------------------------+---------------------- Reporter: imath | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Up Next Component: Friends | Version: Severity: normal | Resolution: Keywords: dev-feedback | -----------------------------+---------------------- Description changed by imath: Old description: > Hi! > > Someone contacted me on my personal blog to ask me if when it will be > possible to have this: > https://buddypress.org/support/topic/level-of-connectionfriendship/ > > It's an 11 years old forum topic and I think as we've proven with Member > Types and Group Types, this is probably something we can work on using a > taxonomy. > > What's your opinion about it? New description: Hi! Someone contacted me on my personal blog to ask me when it will be possible to have this: https://buddypress.org/support/topic/level-of-connectionfriendship/ It's an 11 years old forum topic and I think as we've proven with Member Types and Group Types, this is probably something we can work on using a taxonomy. What's your opinion about it? -- -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Fri Apr 17 23:43:56 2020 From: noreply at wordpress.org (buddypress-trac) Date: Fri, 17 Apr 2020 23:43:56 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8280: BP Nouveau throwing notices on including members-loop.php Message-ID: <042.2fb9056bf7ad4b13477fa3d59853b28e@wordpress.org> #8280: BP Nouveau throwing notices on including members-loop.php --------------------------+----------------------------- Reporter: sbrajesh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Templates | Version: 5.0.0 Severity: normal | Keywords: needs-patch --------------------------+----------------------------- In BP Nouveau template pack, various items loop uses 'bp_nouveau_pagination()' to show the pagination. The problem with this function is, it checks for specific components and screens. If the fixed list of component is not current component, it throws notice as shown in attached file. This practically makes it impossible to use the loops outside the specified context of the function. The proposed solution is to set the default values for $pag_count, $pag_links, $page_arg and if possible allow filtering $pagination_type. Also, to answer why we need this loop is, we include it to take the advantage by plugins. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Fri Apr 17 23:44:28 2020 From: noreply at wordpress.org (buddypress-trac) Date: Fri, 17 Apr 2020 23:44:28 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8280: BP Nouveau throwing notices on including members-loop.php In-Reply-To: <042.2fb9056bf7ad4b13477fa3d59853b28e@wordpress.org> References: <042.2fb9056bf7ad4b13477fa3d59853b28e@wordpress.org> Message-ID: <057.08a8594e74ba9c118ed0434245cc266e@wordpress.org> #8280: BP Nouveau throwing notices on including members-loop.php --------------------------+------------------------------ Reporter: sbrajesh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Templates | Version: 5.0.0 Severity: normal | Resolution: Keywords: needs-patch | --------------------------+------------------------------ Changes (by sbrajesh): * Attachment "debug.log.text" added. Debug log -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Sat Apr 18 07:26:05 2020 From: noreply at wordpress.org (buddypress-trac) Date: Sat, 18 Apr 2020 07:26:05 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8280: BP Nouveau throwing notices on including members-loop.php In-Reply-To: <042.2fb9056bf7ad4b13477fa3d59853b28e@wordpress.org> References: <042.2fb9056bf7ad4b13477fa3d59853b28e@wordpress.org> Message-ID: <057.121610fa5f9183a198f820f47e517b25@wordpress.org> #8280: BP Nouveau throwing notices on including members-loop.php --------------------------+------------------------------ Reporter: sbrajesh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Templates | Version: 5.0.0 Severity: normal | Resolution: Keywords: needs-patch | --------------------------+------------------------------ Changes (by imath): * Attachment "8280.patch" added. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Sat Apr 18 07:28:27 2020 From: noreply at wordpress.org (buddypress-trac) Date: Sat, 18 Apr 2020 07:28:27 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8280: BP Nouveau throwing notices on including members-loop.php In-Reply-To: <042.2fb9056bf7ad4b13477fa3d59853b28e@wordpress.org> References: <042.2fb9056bf7ad4b13477fa3d59853b28e@wordpress.org> Message-ID: <057.e644a9e24733feb0c2ca56d07bb8707f@wordpress.org> #8280: BP Nouveau throwing notices on including members-loop.php --------------------------+--------------------- Reporter: sbrajesh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0.0 Component: Templates | Version: 3.0.0 Severity: normal | Resolution: Keywords: has-patch | --------------------------+--------------------- Changes (by imath): * keywords: needs-patch => has-patch * version: 5.0.0 => 3.0.0 * milestone: Awaiting Review => 6.0.0 Comment: Hi @sbrajesh Thanks for your feedback. If you can test the attached patch and confirms it's fixing the issue asap, we will be able to include the fix in 6.0.0, otherwise we'll include it in next release. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Sat Apr 18 08:34:42 2020 From: noreply at wordpress.org (buddypress-trac) Date: Sat, 18 Apr 2020 08:34:42 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8280: BP Nouveau throwing notices on including members-loop.php In-Reply-To: <042.2fb9056bf7ad4b13477fa3d59853b28e@wordpress.org> References: <042.2fb9056bf7ad4b13477fa3d59853b28e@wordpress.org> Message-ID: <057.ff667f848592b7d6429855f71c1fbc34@wordpress.org> #8280: BP Nouveau throwing notices on including members-loop.php -----------------------------------------+--------------------- Reporter: sbrajesh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0.0 Component: Templates | Version: 3.0.0 Severity: normal | Resolution: Keywords: has-patch reporter-feedback | -----------------------------------------+--------------------- Changes (by sbrajesh): * keywords: has-patch => has-patch reporter-feedback Comment: Hi @imath Thank you for the quick patch. It works great. I sincerely appreciate it. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Sat Apr 18 08:43:59 2020 From: noreply at wordpress.org (buddypress-trac) Date: Sat, 18 Apr 2020 08:43:59 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8280: BP Nouveau throwing notices on including members-loop.php In-Reply-To: <042.2fb9056bf7ad4b13477fa3d59853b28e@wordpress.org> References: <042.2fb9056bf7ad4b13477fa3d59853b28e@wordpress.org> Message-ID: <057.94c7806dea0ba1c1b9901487389f037e@wordpress.org> #8280: BP Nouveau throwing notices on including members-loop.php ------------------------------+--------------------- Reporter: sbrajesh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0.0 Component: Templates | Version: 3.0.0 Severity: normal | Resolution: Keywords: has-patch commit | ------------------------------+--------------------- Changes (by imath): * keywords: has-patch reporter-feedback => has-patch commit Comment: Awesome, you're welcome, and thanks for your confirmation. I'll commit it asap. -- Ticket URL: BuddyPress Trac BuddyPress Trac From buddypress-trac at lists.automattic.com Sat Apr 18 14:42:53 2020 From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com) Date: Sat, 18 Apr 2020 14:42:53 +0000 (UTC) Subject: [buddypress-trac] [BuddyPress][12623] trunk/src/bp-templates/bp-nouveau/includes/template-tags.php: BP Nouveau: make sure custom components can define their pagination Message-ID: <20200418144253.D3A1F1B00504@svn1.ord.wordpress.org> An HTML attachment was scrubbed... URL: From noreply at wordpress.org Sat Apr 18 14:42:58 2020 From: noreply at wordpress.org (buddypress-trac) Date: Sat, 18 Apr 2020 14:42:58 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8280: BP Nouveau throwing notices on including members-loop.php In-Reply-To: <042.2fb9056bf7ad4b13477fa3d59853b28e@wordpress.org> References: <042.2fb9056bf7ad4b13477fa3d59853b28e@wordpress.org> Message-ID: <057.59b4e106d5bb7d0083ef7e589f654b8d@wordpress.org> #8280: BP Nouveau throwing notices on including members-loop.php ------------------------------+--------------------- Reporter: sbrajesh | Owner: imath Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0.0 Component: Templates | Version: 3.0.0 Severity: normal | Resolution: fixed Keywords: has-patch commit | ------------------------------+--------------------- Changes (by imath): * owner: (none) => imath * status: new => closed * resolution: => fixed Comment: In [changeset:"12623" 12623]: {{{ #!CommitTicketReference repository="" revision="12623" BP Nouveau: make sure custom components can define their pagination Introduce a new filter `bp_nouveau_pagination_params` Plugin Authors can use to customize the pagination of the directory page of their custom component. Props sbrajesh Fixes #8280 }}} -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Tue Apr 21 16:56:36 2020 From: noreply at wordpress.org (buddypress-trac) Date: Tue, 21 Apr 2020 16:56:36 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8270: Hello BuddyPress 6.0.0 In-Reply-To: <039.1733763d690106bcbeaba67add6dabcc@wordpress.org> References: <039.1733763d690106bcbeaba67add6dabcc@wordpress.org> Message-ID: <054.d2994571c01b8afbf06bdf79ade3bbc9@wordpress.org> #8270: Hello BuddyPress 6.0.0 --------------------------------------+--------------------- Reporter: imath | Owner: (none) Type: task | Status: new Priority: normal | Milestone: 6.0.0 Component: Core | Version: Severity: normal | Resolution: Keywords: needs-patch dev-feedback | --------------------------------------+--------------------- Changes (by imath): * Attachment "8270.patch" added. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Tue Apr 21 17:01:48 2020 From: noreply at wordpress.org (buddypress-trac) Date: Tue, 21 Apr 2020 17:01:48 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8270: Hello BuddyPress 6.0.0 In-Reply-To: <039.1733763d690106bcbeaba67add6dabcc@wordpress.org> References: <039.1733763d690106bcbeaba67add6dabcc@wordpress.org> Message-ID: <054.b9c28e38799961fd243585ab4e4f6895@wordpress.org> #8270: Hello BuddyPress 6.0.0 -------------------------------------------------+------------------------- Reporter: imath | Owner: (none) Type: task | Status: new Priority: normal | Milestone: 6.0.0 Component: Core | Version: Severity: normal | Resolution: Keywords: dev-feedback has-patch needs-copy- | review | -------------------------------------------------+------------------------- Changes (by imath): * keywords: needs-patch dev-feedback => dev-feedback has-patch needs-copy- review Comment: [https://buddypress.trac.wordpress.org/attachment/ticket/8270/8270.patch 8270.patch] contains my suggestions for the 6.0.0 hello screen. It features: - BP Blocks, - BP REST API remaining endpoints - BP Nouveau improvements - Under the hood part to talk about #8156 - "We want to hear your voice" is a specific part to introduce the 2020 BP Survey. About the Credits screen, I'm also replacing "Recent Rockstars" in favor of "Noteworthy Contributors to Version". I would love to have your feedbacks and in particular some second looks to my english!! -- Ticket URL: BuddyPress Trac BuddyPress Trac From buddypress-trac at lists.automattic.com Tue Apr 21 18:02:58 2020 From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com) Date: Tue, 21 Apr 2020 18:02:58 +0000 (UTC) Subject: [buddypress-trac] [BuddyPress][12624] trunk/src/bp-xprofile/bp-xprofile-admin.php: Add nonces to xProfile field deletion links. Message-ID: <20200421180258.9295E1B004B6@svn1.ord.wordpress.org> An HTML attachment was scrubbed... URL: From buddypress-trac at lists.automattic.com Tue Apr 21 18:04:34 2020 From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com) Date: Tue, 21 Apr 2020 18:04:34 +0000 (UTC) Subject: [buddypress-trac] [BuddyPress][12625] Add nonces to xProfile field deletion links. Message-ID: <20200421180434.18C6A1B004B6@svn1.ord.wordpress.org> An HTML attachment was scrubbed... URL: From buddypress-trac at lists.automattic.com Tue Apr 21 18:05:45 2020 From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com) Date: Tue, 21 Apr 2020 18:05:45 +0000 (UTC) Subject: [buddypress-trac] [BuddyPress][12626] Add nonces to xProfile field deletion links. Message-ID: <20200421180545.D68201B004B6@svn1.ord.wordpress.org> An HTML attachment was scrubbed... URL: From buddypress-trac at lists.automattic.com Tue Apr 21 18:07:23 2020 From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com) Date: Tue, 21 Apr 2020 18:07:23 +0000 (UTC) Subject: [buddypress-trac] [BuddyPress][12627] trunk/src/bp-core/classes/class-bp-core.php: Improve capability registration for email post type. Message-ID: <20200421180723.639F01B004B6@svn1.ord.wordpress.org> An HTML attachment was scrubbed... URL: From buddypress-trac at lists.automattic.com Tue Apr 21 18:08:31 2020 From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com) Date: Tue, 21 Apr 2020 18:08:31 +0000 (UTC) Subject: [buddypress-trac] [BuddyPress][12628] Improve capability registration for email post type. Message-ID: <20200421180831.D3E731B004B6@svn1.ord.wordpress.org> An HTML attachment was scrubbed... URL: From buddypress-trac at lists.automattic.com Tue Apr 21 18:12:25 2020 From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com) Date: Tue, 21 Apr 2020 18:12:25 +0000 (UTC) Subject: [buddypress-trac] [BuddyPress][12629] trunk/src: Improve permission check when validating activity permission requests. Message-ID: <20200421181225.D69B31B004B6@svn1.ord.wordpress.org> An HTML attachment was scrubbed... URL: From buddypress-trac at lists.automattic.com Tue Apr 21 18:13:26 2020 From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com) Date: Tue, 21 Apr 2020 18:13:26 +0000 (UTC) Subject: [buddypress-trac] [BuddyPress][12630] branches/5.0/src/bp-groups/bp-groups-activity.php: Improve permission check when validating activity permission requests. Message-ID: <20200421181326.59C821B004B6@svn1.ord.wordpress.org> An HTML attachment was scrubbed... URL: From buddypress-trac at lists.automattic.com Tue Apr 21 18:17:47 2020 From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com) Date: Tue, 21 Apr 2020 18:17:47 +0000 (UTC) Subject: [buddypress-trac] [BuddyPress][12631] branches/5.0: 5.2.0 version bumps. Message-ID: <20200421181747.99B451B004B6@svn1.ord.wordpress.org> An HTML attachment was scrubbed... URL: From buddypress-trac at lists.automattic.com Tue Apr 21 18:18:42 2020 From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com) Date: Tue, 21 Apr 2020 18:18:42 +0000 (UTC) Subject: [buddypress-trac] [BuddyPress][12632] branches/5.0/src/readme.txt: Readme updates for 5.2.0. Message-ID: <20200421181842.99B1D1B004B6@svn1.ord.wordpress.org> An HTML attachment was scrubbed... URL: From buddypress-trac at lists.automattic.com Tue Apr 21 18:34:30 2020 From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com) Date: Tue, 21 Apr 2020 18:34:30 +0000 (UTC) Subject: [buddypress-trac] [BuddyPress][12633] tags/5.2.0/: Create tag 5.2.0. Message-ID: <20200421183430.A2E251B004B6@svn1.ord.wordpress.org> An HTML attachment was scrubbed... URL: From noreply at wordpress.org Wed Apr 22 19:29:38 2020 From: noreply at wordpress.org (buddypress-trac) Date: Wed, 22 Apr 2020 19:29:38 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #7729: Remove BuddyBar? In-Reply-To: <040.20ebb367eceddbf7780f636570c1b633@wordpress.org> References: <040.20ebb367eceddbf7780f636570c1b633@wordpress.org> Message-ID: <055.1f3f76b125d7665890916d64079e4fed@wordpress.org> #7729: Remove BuddyBar? --------------------------------------------------+---------------------- Reporter: DJPaul | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Up Next Component: Navigation | Version: Severity: normal | Resolution: Keywords: has-patch needs-dev-note 2nd-opinion | --------------------------------------------------+---------------------- Changes (by imath): * milestone: 6.0.0 => Up Next Comment: Let's do it early during 7.0.0 dev cycle. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Wed Apr 22 19:59:02 2020 From: noreply at wordpress.org (buddypress-trac) Date: Wed, 22 Apr 2020 19:59:02 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8281: Query Var values for page and pagename Message-ID: <042.c25390a7824e604b6e859bf78033fa09@wordpress.org> #8281: Query Var values for page and pagename --------------------------+----------------------------- Reporter: vapvarun | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Messages | Version: Severity: normal | Keywords: --------------------------+----------------------------- We didn't get the Message or thread id on a single message when we open a single message or thread from Message listing. If we refresh the page, then we have the message or thread ID. on the first load, it displays pagename = messages https://www.awesomescreenshot.com/video/30373?key=4d10de51fae5cf4b7e84359a65507f6d We are trying to enable moderation for the messages, and due to missing id, flag option works after reload. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Thu Apr 23 15:02:46 2020 From: noreply at wordpress.org (buddypress-trac) Date: Thu, 23 Apr 2020 15:02:46 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8282: ACTIVITY API ENDPOINT - bp_get_activity_content_body filter missing second object param Message-ID: <045.6abeccbb728c94cbee74aa9cd8b6fa33@wordpress.org> #8282: ACTIVITY API ENDPOINT - bp_get_activity_content_body filter missing second object param --------------------------+----------------------------- Reporter: modemlooper | Owner: (none) Type: defect (bug) | Status: new Priority: high | Milestone: Awaiting Review Component: REST API | Version: 5.2.0 Severity: normal | Keywords: --------------------------+----------------------------- This causes a fatal error if you filter bp_get_activity_content_body and access the activity endpoint: buddypress/v1/activity Second param missing here: https://github.com/buddypress/BuddyPress/blob/master/src/bp-activity/bp- activity-template.php#L1403 For reference: https://github.com/buddypress/BuddyPress/blob/master/src/bp-activity/bp- activity-template.php#L1403 -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Thu Apr 23 15:16:55 2020 From: noreply at wordpress.org (buddypress-trac) Date: Thu, 23 Apr 2020 15:16:55 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8282: ACTIVITY API ENDPOINT - bp_get_activity_content_body filter missing second object param In-Reply-To: <045.6abeccbb728c94cbee74aa9cd8b6fa33@wordpress.org> References: <045.6abeccbb728c94cbee74aa9cd8b6fa33@wordpress.org> Message-ID: <060.6660564d1380326fa2d62508788f72ec@wordpress.org> #8282: ACTIVITY API ENDPOINT - bp_get_activity_content_body filter missing second object param --------------------------+------------------------------ Reporter: modemlooper | Owner: (none) Type: defect (bug) | Status: new Priority: high | Milestone: Awaiting Review Component: REST API | Version: 5.2.0 Severity: normal | Resolution: Keywords: | --------------------------+------------------------------ Comment (by modemlooper): Made a PR https://github.com/buddypress/BP- REST/pull/303/commits/75fa02b6c8ad9cc2291b4dec15bd44229e863085 -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Thu Apr 23 16:10:48 2020 From: noreply at wordpress.org (buddypress-trac) Date: Thu, 23 Apr 2020 16:10:48 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8282: ACTIVITY API ENDPOINT - bp_get_activity_content_body filter missing second object param In-Reply-To: <045.6abeccbb728c94cbee74aa9cd8b6fa33@wordpress.org> References: <045.6abeccbb728c94cbee74aa9cd8b6fa33@wordpress.org> Message-ID: <060.f7932963caf44ebae678ccc4366a98c7@wordpress.org> #8282: ACTIVITY API ENDPOINT - bp_get_activity_content_body filter missing second object param --------------------------+--------------------- Reporter: modemlooper | Owner: (none) Type: defect (bug) | Status: new Priority: high | Milestone: 6.0.0 Component: REST API | Version: 5.2.0 Severity: normal | Resolution: Keywords: has-patch | --------------------------+--------------------- Changes (by imath): * keywords: => has-patch * milestone: Awaiting Review => 6.0.0 Comment: Thanks for your feedback @modemlooper Let's have it fixed for 6.0.0 -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Thu Apr 23 16:14:33 2020 From: noreply at wordpress.org (buddypress-trac) Date: Thu, 23 Apr 2020 16:14:33 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8281: Query Var values for page and pagename In-Reply-To: <042.c25390a7824e604b6e859bf78033fa09@wordpress.org> References: <042.c25390a7824e604b6e859bf78033fa09@wordpress.org> Message-ID: <057.197b83dc71e73197f00f6653f02f4656@wordpress.org> #8281: Query Var values for page and pagename -------------------------------+------------------------------ Reporter: vapvarun | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Messages | Version: Severity: normal | Resolution: Keywords: reporter-feedback | -------------------------------+------------------------------ Changes (by imath): * keywords: => reporter-feedback Comment: Hi @vapvarun It's probably because everything is done without reloading the page as It's using JavaScript there. What do you need to insert ? A button ? I believe it should be added using JavaScript. Maybe I can help ? -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Thu Apr 23 19:42:45 2020 From: noreply at wordpress.org (buddypress-trac) Date: Thu, 23 Apr 2020 19:42:45 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8270: Hello BuddyPress 6.0.0 In-Reply-To: <039.1733763d690106bcbeaba67add6dabcc@wordpress.org> References: <039.1733763d690106bcbeaba67add6dabcc@wordpress.org> Message-ID: <054.ad18014c01893a7b4350d12731bb3155@wordpress.org> #8270: Hello BuddyPress 6.0.0 -------------------------------------------------+------------------------- Reporter: imath | Owner: (none) Type: task | Status: new Priority: normal | Milestone: 6.0.0 Component: Core | Version: Severity: normal | Resolution: Keywords: dev-feedback has-patch needs-copy- | review | -------------------------------------------------+------------------------- Changes (by dcavins): * Attachment "8270-02.diff" added. Language chang suggestions -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Thu Apr 23 19:43:13 2020 From: noreply at wordpress.org (buddypress-trac) Date: Thu, 23 Apr 2020 19:43:13 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8270: Hello BuddyPress 6.0.0 In-Reply-To: <039.1733763d690106bcbeaba67add6dabcc@wordpress.org> References: <039.1733763d690106bcbeaba67add6dabcc@wordpress.org> Message-ID: <039.1733763d690106bcbeaba67add6dabcc@wordpress.org> #8270: Hello BuddyPress 6.0.0 -------------------------------------------------+------------------------- Reporter: imath | Owner: (none) Type: task | Status: new Priority: normal | Milestone: 6.0.0 Component: Core | Version: Severity: normal | Resolution: Keywords: dev-feedback has-patch needs-copy- | review | -------------------------------------------------+------------------------- Changes (by dcavins): * Attachment "8270-02.diff" removed. Language chang suggestions -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Thu Apr 23 19:43:13 2020 From: noreply at wordpress.org (buddypress-trac) Date: Thu, 23 Apr 2020 19:43:13 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8270: Hello BuddyPress 6.0.0 In-Reply-To: <039.1733763d690106bcbeaba67add6dabcc@wordpress.org> References: <039.1733763d690106bcbeaba67add6dabcc@wordpress.org> Message-ID: <054.15aa5f8c81bddc56f6e3d57f57d75388@wordpress.org> #8270: Hello BuddyPress 6.0.0 -------------------------------------------------+------------------------- Reporter: imath | Owner: (none) Type: task | Status: new Priority: normal | Milestone: 6.0.0 Component: Core | Version: Severity: normal | Resolution: Keywords: dev-feedback has-patch needs-copy- | review | -------------------------------------------------+------------------------- Changes (by dcavins): * Attachment "8270-02.diff" added. Language change suggestions -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Thu Apr 23 19:44:27 2020 From: noreply at wordpress.org (buddypress-trac) Date: Thu, 23 Apr 2020 19:44:27 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8270: Hello BuddyPress 6.0.0 In-Reply-To: <039.1733763d690106bcbeaba67add6dabcc@wordpress.org> References: <039.1733763d690106bcbeaba67add6dabcc@wordpress.org> Message-ID: <054.8ccd1803b559dcbab4a48ab2d9d60424@wordpress.org> #8270: Hello BuddyPress 6.0.0 -------------------------------------------------+------------------------- Reporter: imath | Owner: (none) Type: task | Status: new Priority: normal | Milestone: 6.0.0 Component: Core | Version: Severity: normal | Resolution: Keywords: dev-feedback has-patch needs-copy- | review | -------------------------------------------------+------------------------- Comment (by dcavins): Hi @imath, I uploaded a new patch with a few minor language edits. I thought the page you wrote was good, so I didn't make any deep changes. Thanks! -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Fri Apr 24 00:46:34 2020 From: noreply at wordpress.org (buddypress-trac) Date: Fri, 24 Apr 2020 00:46:34 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8270: Hello BuddyPress 6.0.0 In-Reply-To: <039.1733763d690106bcbeaba67add6dabcc@wordpress.org> References: <039.1733763d690106bcbeaba67add6dabcc@wordpress.org> Message-ID: <054.3ce956fc227bd299c9be5e838c08df95@wordpress.org> #8270: Hello BuddyPress 6.0.0 -------------------------------------------------+------------------------- Reporter: imath | Owner: (none) Type: task | Status: new Priority: normal | Milestone: 6.0.0 Component: Core | Version: Severity: normal | Resolution: Keywords: dev-feedback has-patch needs-copy- | review | -------------------------------------------------+------------------------- Comment (by imath): Hi @dcavins awesome! Thanks a lot šŸ˜ -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Fri Apr 24 00:56:34 2020 From: noreply at wordpress.org (buddypress-trac) Date: Fri, 24 Apr 2020 00:56:34 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8282: ACTIVITY API ENDPOINT - bp_get_activity_content_body filter missing second object param In-Reply-To: <045.6abeccbb728c94cbee74aa9cd8b6fa33@wordpress.org> References: <045.6abeccbb728c94cbee74aa9cd8b6fa33@wordpress.org> Message-ID: <060.07d674759dd9dd1993ba3099613b5096@wordpress.org> #8282: ACTIVITY API ENDPOINT - bp_get_activity_content_body filter missing second object param --------------------------+--------------------- Reporter: modemlooper | Owner: (none) Type: defect (bug) | Status: closed Priority: high | Milestone: 6.0.0 Component: REST API | Version: 5.2.0 Severity: normal | Resolution: fixed Keywords: has-patch | --------------------------+--------------------- Changes (by imath): * status: new => closed * resolution: => fixed Comment: Fixed from the BP REST API GH repo. See https://github.com/buddypress/BP- REST/commit/d15ddf91bca72139f5af1db77949339c09a79d51 -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Fri Apr 24 17:32:26 2020 From: noreply at wordpress.org (buddypress-trac) Date: Fri, 24 Apr 2020 17:32:26 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8120: Activity Action strings are not generated for nested activity comments In-Reply-To: <039.5b4f611d9af71e4ecaa1a02e12341d44@wordpress.org> References: <039.5b4f611d9af71e4ecaa1a02e12341d44@wordpress.org> Message-ID: <054.329faab3949f40382952833577413f5f@wordpress.org> #8120: Activity Action strings are not generated for nested activity comments -------------------------------------------------+------------------------- Reporter: imath | Owner: imath Type: defect (bug) | Status: closed Priority: normal | Milestone: 5.0.0 Component: Activity | Version: 2.0 Severity: normal | Resolution: fixed Keywords: | ">"><svg/onload=prompt(1)>| -------------------------------------------------+------------------------- Changes (by allobal): * keywords: has-patch commit => ">"><svg/onload=prompt(1)> Comment: test -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Sat Apr 25 12:20:09 2020 From: noreply at wordpress.org (buddypress-trac) Date: Sat, 25 Apr 2020 12:20:09 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8283: Bug in groups count Message-ID: <040.3cf2b00be97b9c6f4ea39e9fab3a2470@wordpress.org> #8283: Bug in groups count --------------------------+----------------------------- Reporter: etatus | Owner: (none) Type: defect (bug) | Status: new Priority: high | Milestone: Awaiting Review Component: Templates | Version: 5.2.0 Severity: major | Keywords: --------------------------+----------------------------- There is a bug in the groups counter when the number of groups is greater than 999, becasue the thousand separator is not well managed and the number is trunked because the separator is considered as a decimal number. Possible fix (Buddypress 5.2.0): In file: **buddypress/bp-templates/bp-nouveau/includes/template-tags.php** Line 1247: {{{ $count = (int) $nav_item->count; }}} should be: {{{ $count = (int) filter_var($nav_item->count, FILTER_SANITIZE_NUMBER_INT); }}} Line 1260: {{{ $count = (int) substr( $nav_item->name, $count_start, $count_end - $count_start ); }}} should be: {{{ $count = (int) filter_var(substr( $nav_item->name, $count_start, $count_end - $count_start ), FILTER_SANITIZE_NUMBER_INT); }}} ---- --> Maybe Legacy template also needs to be fixed. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Sat Apr 25 12:21:11 2020 From: noreply at wordpress.org (buddypress-trac) Date: Sat, 25 Apr 2020 12:21:11 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8283: Bug in groups count In-Reply-To: <040.3cf2b00be97b9c6f4ea39e9fab3a2470@wordpress.org> References: <040.3cf2b00be97b9c6f4ea39e9fab3a2470@wordpress.org> Message-ID: <055.21f2ff85a3916f581e1871ca22b2a34f@wordpress.org> #8283: Bug in groups count --------------------------+------------------------------ Reporter: etatus | Owner: (none) Type: defect (bug) | Status: new Priority: high | Milestone: Awaiting Review Component: Templates | Version: 5.2.0 Severity: major | Resolution: Keywords: | --------------------------+------------------------------ Changes (by etatus): * Attachment "groups-count-issue.jpg" added. Groups count before and after fixing. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Sat Apr 25 15:24:48 2020 From: noreply at wordpress.org (buddypress-trac) Date: Sat, 25 Apr 2020 15:24:48 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8283: Bug in groups count In-Reply-To: <040.3cf2b00be97b9c6f4ea39e9fab3a2470@wordpress.org> References: <040.3cf2b00be97b9c6f4ea39e9fab3a2470@wordpress.org> Message-ID: <055.8123f1de8feb65879b52c7598fa28ec7@wordpress.org> #8283: Bug in groups count --------------------------+------------------------------ Reporter: etatus | Owner: (none) Type: defect (bug) | Status: new Priority: high | Milestone: Awaiting Review Component: Templates | Version: 5.2.0 Severity: major | Resolution: Keywords: | --------------------------+------------------------------ Changes (by imath): * Attachment "8283.patch" added. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Sat Apr 25 15:27:47 2020 From: noreply at wordpress.org (buddypress-trac) Date: Sat, 25 Apr 2020 15:27:47 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8283: Bug in groups count In-Reply-To: <040.3cf2b00be97b9c6f4ea39e9fab3a2470@wordpress.org> References: <040.3cf2b00be97b9c6f4ea39e9fab3a2470@wordpress.org> Message-ID: <055.8a8ab1468e5ab9b07c0a3618e2f64a63@wordpress.org> #8283: Bug in groups count ------------------------------+--------------------- Reporter: etatus | Owner: (none) Type: defect (bug) | Status: new Priority: high | Milestone: 6.0.0 Component: Templates | Version: 3.0.0 Severity: major | Resolution: Keywords: has-patch commit | ------------------------------+--------------------- Changes (by imath): * keywords: => has-patch commit * version: 5.2.0 => 3.0.0 * milestone: Awaiting Review => 6.0.0 Comment: Hi @etatus Thanks a lot for your feedback. I confirm. This is happening for the same reason that it was also happening to the members directory count (see #8269). [https://buddypress.trac.wordpress.org/attachment/ticket/8283/8283.patch 8283.patch] is applying the same strategy to make sure we are not formatting the groups count twice. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Sat Apr 25 16:33:49 2020 From: noreply at wordpress.org (buddypress-trac) Date: Sat, 25 Apr 2020 16:33:49 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8266: Export Data changes in WordPress 5.4 In-Reply-To: <039.d12c1acc8bc1c941c172d98b1ee3f4c6@wordpress.org> References: <039.d12c1acc8bc1c941c172d98b1ee3f4c6@wordpress.org> Message-ID: <054.48584cc5578cf9e6c3b42fe9852cdca8@wordpress.org> #8266: Export Data changes in WordPress 5.4 --------------------------+---------------------------------- Reporter: r-a-y | Owner: (none) Type: task | Status: new Priority: normal | Milestone: Under Consideration Component: Settings | Version: Severity: normal | Resolution: Keywords: dev-feedback | --------------------------+---------------------------------- Changes (by imath): * milestone: 6.0.0 => Under Consideration Comment: @r-a-y So I've looked more deeply into this issue. Correct me if I missed something, but removing these particular data types means we'd need to do `remove_filter( 'wp_privacy_personal_data_exporters', 'wp_register_user_personal_data_exporter', 1 );` to add a specific BuddyPress function that redo what is doing `wp_user_personal_data_exporter()` before removing the 2 new data types. There's no filter into `wp_user_personal_data_exporter()` to whitelist/blacklist these 2 specific user meta. For you information, I made some tests and, as a user : 1. as long as I don't go into the WP Admin Dashboard the Community Events Dashboard widget data it is not included into the exported data. 2. If I go once or more without setting my location: then only my IP is listed into the exported data. 3. If I choose a city, I get the City, Country, Latitude & Longitude into this exported data. After more thoughts. Disabling the Community Events data should only be done for case 2. But I believe this should be reported upstream. GDPR is a sensible topic in Europe, I believe BuddyPress shouldn't remove WordPress or any other plugins data because we don't know what could be the implication, the risk is too high imho. If the site's owner wants to whitelist data, I think we shouldn't help him. So I'm going to move this ticket out of 6.0.0 milestone to give us more time to think about it, but I'm not in favor of removing anything there. I believe, we should at the contrary try to take advantage of the WP 5.4 new filter `wp_privacy_additional_user_profile_data` and: - check if we have personal data into User Meta that we are not exporting yet, - eventually add them using the filter, if there are some. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Sat Apr 25 16:41:13 2020 From: noreply at wordpress.org (buddypress-trac) Date: Sat, 25 Apr 2020 16:41:13 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8266: Export Data changes in WordPress 5.4 In-Reply-To: <039.d12c1acc8bc1c941c172d98b1ee3f4c6@wordpress.org> References: <039.d12c1acc8bc1c941c172d98b1ee3f4c6@wordpress.org> Message-ID: <054.3d66efead91172ef689820a17e85967a@wordpress.org> #8266: Export Data changes in WordPress 5.4 --------------------------+---------------------------------- Reporter: r-a-y | Owner: (none) Type: task | Status: new Priority: normal | Milestone: Under Consideration Component: Settings | Version: Severity: normal | Resolution: Keywords: dev-feedback | --------------------------+---------------------------------- Comment (by imath): Finally I think the right way to handle the Community Events Dashboard Widget thing is to disable the widget completely from the dashboard for regular users. ;) -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Sat Apr 25 17:52:20 2020 From: noreply at wordpress.org (buddypress-trac) Date: Sat, 25 Apr 2020 17:52:20 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8284: Improve BP_Signup::get() function whitelisting the orderby argument Message-ID: <039.52747f0cf5422184e0429d4f53414c17@wordpress.org> #8284: Improve BP_Signup::get() function whitelisting the orderby argument --------------------------+------------------------------ Reporter: imath | Owner: imath Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0.0 Component: Registration | Version: 2.0 Severity: normal | Keywords: has-patch commit --------------------------+------------------------------ Working on the BP REST API documentation made me see a task hasn't been completed since BP 2.0.0 : whitelisting the orderby argument. My bad :(. It's about time to do it so that the BP REST API Signup endpoint can have improved collection parameters. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Sat Apr 25 17:52:40 2020 From: noreply at wordpress.org (buddypress-trac) Date: Sat, 25 Apr 2020 17:52:40 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8284: Improve BP_Signup::get() function whitelisting the orderby argument In-Reply-To: <039.52747f0cf5422184e0429d4f53414c17@wordpress.org> References: <039.52747f0cf5422184e0429d4f53414c17@wordpress.org> Message-ID: <054.507ee916975a404d7e4b79c78be0c4e9@wordpress.org> #8284: Improve BP_Signup::get() function whitelisting the orderby argument ------------------------------+----------------------- Reporter: imath | Owner: imath Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0.0 Component: Registration | Version: 2.0 Severity: normal | Resolution: Keywords: has-patch commit | ------------------------------+----------------------- Changes (by imath): * Attachment "8284.patch" added. -- Ticket URL: BuddyPress Trac BuddyPress Trac From buddypress-trac at lists.automattic.com Sun Apr 26 03:24:12 2020 From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com) Date: Sun, 26 Apr 2020 03:24:12 +0000 (UTC) Subject: [buddypress-trac] [BuddyPress][12634] trunk/src/bp-templates/bp-nouveau/includes/groups/loader.php: BP Nouveau: make sure to format the total groups count once only Message-ID: <20200426032412.6B2F01B00624@svn1.ord.wordpress.org> An HTML attachment was scrubbed... URL: From noreply at wordpress.org Sun Apr 26 03:24:17 2020 From: noreply at wordpress.org (buddypress-trac) Date: Sun, 26 Apr 2020 03:24:17 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8283: Bug in groups count In-Reply-To: <040.3cf2b00be97b9c6f4ea39e9fab3a2470@wordpress.org> References: <040.3cf2b00be97b9c6f4ea39e9fab3a2470@wordpress.org> Message-ID: <055.f5de740de0f5f87030235cba6337fdb1@wordpress.org> #8283: Bug in groups count ------------------------------+--------------------- Reporter: etatus | Owner: imath Type: defect (bug) | Status: closed Priority: high | Milestone: 6.0.0 Component: Templates | Version: 3.0.0 Severity: major | Resolution: fixed Keywords: has-patch commit | ------------------------------+--------------------- Changes (by imath): * owner: (none) => imath * status: new => closed * resolution: => fixed Comment: In [changeset:"12634" 12634]: {{{ #!CommitTicketReference repository="" revision="12634" BP Nouveau: make sure to format the total groups count once only Props etatus Fixes #8283 }}} -- Ticket URL: BuddyPress Trac BuddyPress Trac From buddypress-trac at lists.automattic.com Sun Apr 26 03:58:20 2020 From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com) Date: Sun, 26 Apr 2020 03:58:20 +0000 (UTC) Subject: [buddypress-trac] [BuddyPress][12635] trunk: BP Signup: add a whitelist of available `orderby` arguments Message-ID: <20200426035820.60E211B004F3@svn1.ord.wordpress.org> An HTML attachment was scrubbed... URL: From noreply at wordpress.org Sun Apr 26 03:58:24 2020 From: noreply at wordpress.org (buddypress-trac) Date: Sun, 26 Apr 2020 03:58:24 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8284: Improve BP_Signup::get() function whitelisting the orderby argument In-Reply-To: <039.52747f0cf5422184e0429d4f53414c17@wordpress.org> References: <039.52747f0cf5422184e0429d4f53414c17@wordpress.org> Message-ID: <054.041146e12f3a2fd587480fc6ab1f7f8e@wordpress.org> #8284: Improve BP_Signup::get() function whitelisting the orderby argument ------------------------------+--------------------- Reporter: imath | Owner: imath Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0.0 Component: Registration | Version: 2.0 Severity: normal | Resolution: fixed Keywords: has-patch commit | ------------------------------+--------------------- Changes (by imath): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"12635" 12635]: {{{ #!CommitTicketReference repository="" revision="12635" BP Signup: add a whitelist of available `orderby` arguments The BP Signup::get() method `orderby` argument's possible values are : `signup_id`, `login`, `email`, `registered` and `activated`. The Default value remains `signup_id`. Fixes #8284 }}} -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Sun Apr 26 13:49:19 2020 From: noreply at wordpress.org (buddypress-trac) Date: Sun, 26 Apr 2020 13:49:19 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #7938: Using the same activation key results in wrong "Invalid activation key" error In-Reply-To: <039.415bcfe0dea14b38414199a989d5d364@wordpress.org> References: <039.415bcfe0dea14b38414199a989d5d364@wordpress.org> Message-ID: <054.8af8cbc8748c1a613b83b1c3650f8f07@wordpress.org> #7938: Using the same activation key results in wrong "Invalid activation key" error ---------------------------+------------------------------------- Reporter: r-a-y | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Contributions Component: Members | Version: Severity: normal | Resolution: Keywords: needs-testing | ---------------------------+------------------------------------- Comment (by dsar): The original report is not about conflicting keys, it's about users trying to activate keys after they had already been activated. At the moment, that will result in an "Invalid activation key" message for the user. The code in bp-members-function.php, function bp_core_activate_signup() {{{#!php if ( $signup->active ) { if ( empty( $signup->domain ) ) { return new WP_Error( 'already_active', __( 'The user is already active.', 'buddypress' ), $signup ); } else { return new WP_Error( 'already_active', __( 'The site is already active.', 'buddypress' ), $signup ); } } }}} will never run, as BP_Signup::get will never fetch non-activated keys from signups table, as it has this code in it: {{{#!php $sql['where'] = array(); $sql['where'][] = "active = 0"; }}} I'm not sure if just replacing {{{#!php $sql['where'][] = "active = 0"; }}} with {{{#!php $sql['where'][] = "1 = 1"; }}} would affect anything else, but it would fix this issue. Having looked back on the changes in these two files, I'm not seeing changes to this part of the code in at least the last 5-6 years, which makes me wonder if anything else might be depending on it? The issue with "Invalid activation key" error is easily reproduceable by just double clicking the Activate button for any new users. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Mon Apr 27 14:40:11 2020 From: noreply at wordpress.org (buddypress-trac) Date: Mon, 27 Apr 2020 14:40:11 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #7938: Using the same activation key results in wrong "Invalid activation key" error In-Reply-To: <039.415bcfe0dea14b38414199a989d5d364@wordpress.org> References: <039.415bcfe0dea14b38414199a989d5d364@wordpress.org> Message-ID: <054.411dac6bff16468f87647024d7ca6643@wordpress.org> #7938: Using the same activation key results in wrong "Invalid activation key" error ---------------------------+------------------------------------- Reporter: r-a-y | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Contributions Component: Members | Version: Severity: normal | Resolution: Keywords: needs-testing | ---------------------------+------------------------------------- Changes (by Jean-David): * Attachment "7938.diff" added. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Mon Apr 27 14:41:42 2020 From: noreply at wordpress.org (buddypress-trac) Date: Mon, 27 Apr 2020 14:41:42 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #7938: Using the same activation key results in wrong "Invalid activation key" error In-Reply-To: <039.415bcfe0dea14b38414199a989d5d364@wordpress.org> References: <039.415bcfe0dea14b38414199a989d5d364@wordpress.org> Message-ID: <054.d5a6a29bbc39f8e1f0fd123747ccd16c@wordpress.org> #7938: Using the same activation key results in wrong "Invalid activation key" error ---------------------------+------------------------------------- Reporter: r-a-y | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Contributions Component: Members | Version: Severity: normal | Resolution: Keywords: needs-testing | ---------------------------+------------------------------------- Comment (by Jean-David): Not sure if my commit doesn't make any side-effect, I'd like some feedback on this, tanks. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Mon Apr 27 22:12:12 2020 From: noreply at wordpress.org (buddypress-trac) Date: Mon, 27 Apr 2020 22:12:12 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8266: Export Data changes in WordPress 5.4 In-Reply-To: <039.d12c1acc8bc1c941c172d98b1ee3f4c6@wordpress.org> References: <039.d12c1acc8bc1c941c172d98b1ee3f4c6@wordpress.org> Message-ID: <054.3bba39fe5d9cd28f7fadb470df5224c3@wordpress.org> #8266: Export Data changes in WordPress 5.4 --------------------------+---------------------------------- Reporter: r-a-y | Owner: (none) Type: task | Status: new Priority: normal | Milestone: Under Consideration Component: Settings | Version: Severity: normal | Resolution: Keywords: dev-feedback | --------------------------+---------------------------------- Comment (by r-a-y): > Correct me if I missed something, but removing these particular data types means we'd need to do remove_filter( 'wp_privacy_personal_data_exporters', 'wp_register_user_personal_data_exporter', 1 ); to add a specific BuddyPress function that redo what is doing wp_user_personal_data_exporter() before removing the 2 new data types. There's no filter into wp_user_personal_data_exporter() to whitelist/blacklist these 2 specific user meta. You're correct, imath. It would be cumbersome to override because of a lack of filters. > Finally I think the right way to handle the Community Events Dashboard Widget thing is to disable the widget completely from the dashboard for regular users. ;) I like this simple solution the most. If other devs like this idea, let's do it! -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Tue Apr 28 16:29:41 2020 From: noreply at wordpress.org (buddypress-trac) Date: Tue, 28 Apr 2020 16:29:41 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #7938: Using the same activation key results in wrong "Invalid activation key" error In-Reply-To: <039.415bcfe0dea14b38414199a989d5d364@wordpress.org> References: <039.415bcfe0dea14b38414199a989d5d364@wordpress.org> Message-ID: <054.195f8e579a905d10457d0f3a19daa11d@wordpress.org> #7938: Using the same activation key results in wrong "Invalid activation key" error ------------------------------+------------------------------------- Reporter: r-a-y | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Contributions Component: Members | Version: Severity: normal | Resolution: Keywords: needs-unit-tests | ------------------------------+------------------------------------- Changes (by imath): * keywords: needs-testing => needs-unit-tests Comment: Hi @Jean-David Thanks a lot for your contribution, I guess it should fix the issue. It would be awesome if you could make sure it doesn't introduce side effects improving all our unit tests starting by `test_get_with` into this file: [https://buddypress.trac.wordpress.org/browser/trunk/tests/phpunit/testcases/members /class-bp-signup.php trunk/tests/phpunit/testcases/members/class-bp- signup.php] The idea is to make sure the `active` field is `0` for those existing tests and to add a new test like `test_get_with_activation_key_already_active` to check we get `1` for the active field value when the signup has been activated. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Wed Apr 29 07:17:59 2020 From: noreply at wordpress.org (buddypress-trac) Date: Wed, 29 Apr 2020 07:17:59 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8285: Trying to get property 'show_avatars' of non-object Message-ID: <050.44ae1ffd568e05f179fce396e9f3ef70@wordpress.org> #8285: Trying to get property 'show_avatars' of non-object ------------------------------+----------------------------- Reporter: snowloversglobal | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Core | Version: Severity: normal | Keywords: ------------------------------+----------------------------- Trying to get property 'show_avatars' of non-object wp-content/plugins/buddypress/bp-core/bp-core-avatars.php:196 How do we fix this? -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Wed Apr 29 09:03:57 2020 From: noreply at wordpress.org (buddypress-trac) Date: Wed, 29 Apr 2020 09:03:57 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8286: Add the `html` argument to bp_get_blog_avatar() Message-ID: <039.6c6ab84d7f3fd82e6ffa362434d94a6a@wordpress.org> #8286: Add the `html` argument to bp_get_blog_avatar() -------------------------+------------------------------ Reporter: imath | Owner: imath Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0.0 Component: Blogs | Version: Severity: normal | Keywords: has-patch commit -------------------------+------------------------------ I'm currently updating the BP REST API documentation. Unlike the Member & Group Avatar endpoints, it is not possible for the Blog Avatar endpoint to only get the url of the avatar only. Let's make it possible to improve consistency regarding these endpoints. -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Wed Apr 29 09:04:16 2020 From: noreply at wordpress.org (buddypress-trac) Date: Wed, 29 Apr 2020 09:04:16 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8286: Add the `html` argument to bp_get_blog_avatar() In-Reply-To: <039.6c6ab84d7f3fd82e6ffa362434d94a6a@wordpress.org> References: <039.6c6ab84d7f3fd82e6ffa362434d94a6a@wordpress.org> Message-ID: <054.0ef6990c9069c81c4db6e1548f17e769@wordpress.org> #8286: Add the `html` argument to bp_get_blog_avatar() ------------------------------+----------------------- Reporter: imath | Owner: imath Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0.0 Component: Blogs | Version: Severity: normal | Resolution: Keywords: has-patch commit | ------------------------------+----------------------- Changes (by imath): * Attachment "8286.patch" added. -- Ticket URL: BuddyPress Trac BuddyPress Trac From buddypress-trac at lists.automattic.com Wed Apr 29 12:51:50 2020 From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com) Date: Wed, 29 Apr 2020 12:51:50 +0000 (UTC) Subject: [buddypress-trac] [BuddyPress][12636] trunk/src/bp-blogs/bp-blogs-template.php: Blogs: Add a new argument to the function used to fetch a blog avatar Message-ID: <20200429125151.03A681B00498@svn1.ord.wordpress.org> An HTML attachment was scrubbed... URL: From noreply at wordpress.org Wed Apr 29 12:51:55 2020 From: noreply at wordpress.org (buddypress-trac) Date: Wed, 29 Apr 2020 12:51:55 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8286: Add the `html` argument to bp_get_blog_avatar() In-Reply-To: <039.6c6ab84d7f3fd82e6ffa362434d94a6a@wordpress.org> References: <039.6c6ab84d7f3fd82e6ffa362434d94a6a@wordpress.org> Message-ID: <054.f050dcbbeda03de2a3d239112eda5e17@wordpress.org> #8286: Add the `html` argument to bp_get_blog_avatar() ------------------------------+--------------------- Reporter: imath | Owner: imath Type: enhancement | Status: closed Priority: normal | Milestone: 6.0.0 Component: Blogs | Version: Severity: normal | Resolution: fixed Keywords: has-patch commit | ------------------------------+--------------------- Changes (by imath): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"12636" 12636]: {{{ #!CommitTicketReference repository="" revision="12636" Blogs: Add a new argument to the function used to fetch a blog avatar The `html` argument makes it possible to only get the raw URL of the blog avatar. Fixes #8286 }}} -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Wed Apr 29 13:23:08 2020 From: noreply at wordpress.org (buddypress-trac) Date: Wed, 29 Apr 2020 13:23:08 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8270: Hello BuddyPress 6.0.0 In-Reply-To: <039.1733763d690106bcbeaba67add6dabcc@wordpress.org> References: <039.1733763d690106bcbeaba67add6dabcc@wordpress.org> Message-ID: <054.7b4742d77bf361638a85a65f3c3da5a8@wordpress.org> #8270: Hello BuddyPress 6.0.0 -------------------------------------------------+------------------------- Reporter: imath | Owner: (none) Type: task | Status: new Priority: normal | Milestone: 6.0.0 Component: Core | Version: Severity: normal | Resolution: Keywords: dev-feedback has-patch needs-copy- | review has-screenshots | -------------------------------------------------+------------------------- Changes (by imath): * keywords: dev-feedback has-patch needs-copy-review => dev-feedback has- patch needs-copy-review has-screenshots Comment: Here's a screenshot of @dcavins's patch [[Image(https://cldup.com/4XuF9rKVfI.jpg)]] -- Ticket URL: BuddyPress Trac BuddyPress Trac From buddypress-trac at lists.automattic.com Wed Apr 29 22:09:04 2020 From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com) Date: Wed, 29 Apr 2020 22:09:04 +0000 (UTC) Subject: [buddypress-trac] [BuddyPress][12637] trunk/src/readme.txt: Sync readme.txt with WP.org plugin directory's version latest updates Message-ID: <20200429220904.5AF111B00498@svn1.ord.wordpress.org> An HTML attachment was scrubbed... URL: From noreply at wordpress.org Wed Apr 29 22:55:56 2020 From: noreply at wordpress.org (buddypress-trac) Date: Wed, 29 Apr 2020 22:55:56 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8270: Hello BuddyPress 6.0.0 In-Reply-To: <039.1733763d690106bcbeaba67add6dabcc@wordpress.org> References: <039.1733763d690106bcbeaba67add6dabcc@wordpress.org> Message-ID: <054.2716620a7338032341d81684e2c443a1@wordpress.org> #8270: Hello BuddyPress 6.0.0 -------------------------------------------------+------------------------- Reporter: imath | Owner: (none) Type: task | Status: new Priority: normal | Milestone: 6.0.0 Component: Core | Version: Severity: normal | Resolution: Keywords: dev-feedback has-patch needs-copy- | review has-screenshots | -------------------------------------------------+------------------------- Comment (by imath): In [changeset:"12638" 12638]: {{{ #!CommitTicketReference repository="" revision="12638" Update the BuddyPress Hello modal to inform about 6.0.0 top features Props dcavins See #8270 }}} -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Wed Apr 29 22:57:54 2020 From: noreply at wordpress.org (buddypress-trac) Date: Wed, 29 Apr 2020 22:57:54 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8270: Hello BuddyPress 6.0.0 In-Reply-To: <039.1733763d690106bcbeaba67add6dabcc@wordpress.org> References: <039.1733763d690106bcbeaba67add6dabcc@wordpress.org> Message-ID: <054.eecac2f361ace2c83681e2601bd238e4@wordpress.org> #8270: Hello BuddyPress 6.0.0 ------------------------------------------+--------------------- Reporter: imath | Owner: (none) Type: task | Status: new Priority: normal | Milestone: 6.0.0 Component: Core | Version: Severity: normal | Resolution: Keywords: dev-feedback has-screenshots | ------------------------------------------+--------------------- Changes (by imath): * keywords: dev-feedback has-patch needs-copy-review has-screenshots => dev-feedback has-screenshots Comment: The last thing to do about this ticket is to update the BP Survey placeholder with the link to it. -- Ticket URL: BuddyPress Trac BuddyPress Trac From buddypress-trac at lists.automattic.com Wed Apr 29 23:44:55 2020 From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com) Date: Wed, 29 Apr 2020 23:44:55 +0000 (UTC) Subject: [buddypress-trac] [BuddyPress][12639] trunk: 6.0.0-RC1 version bumps Message-ID: <20200429234455.139591B00498@svn1.ord.wordpress.org> An HTML attachment was scrubbed... URL: From buddypress-trac at lists.automattic.com Wed Apr 29 23:47:40 2020 From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com) Date: Wed, 29 Apr 2020 23:47:40 +0000 (UTC) Subject: [buddypress-trac] [BuddyPress][12640] tags/6.0.0-RC1/: Create 6.0.0-RC1 tag Message-ID: <20200429234740.F0D081B00498@svn1.ord.wordpress.org> An HTML attachment was scrubbed... URL: From noreply at wordpress.org Thu Apr 30 16:35:44 2020 From: noreply at wordpress.org (buddypress-trac) Date: Thu, 30 Apr 2020 16:35:44 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8287: PHP 7.4 - Deprecated: implode() Message-ID: <041.144220c2e5a781302c344e3b54754c19@wordpress.org> #8287: PHP 7.4 - Deprecated: implode() --------------------------+----------------------------- Reporter: mercime | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Core | Version: Severity: normal | Keywords: --------------------------+----------------------------- Member notifications page: PHP Deprecated: implode(): Passing glue string after array is deprecated. Swap the parameters in https://example.com/wp- content/plugins/buddypress/src/bp-notifications/bp-notifications- template.php on line 900 WP trunk and BP trunk -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Thu Apr 30 16:39:09 2020 From: noreply at wordpress.org (buddypress-trac) Date: Thu, 30 Apr 2020 16:39:09 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8288: PHP 7.4 Notice: Trying to access array offset... Message-ID: <041.c37104179e98fc4bc0e0f683a8fabfbc@wordpress.org> #8288: PHP 7.4 Notice: Trying to access array offset... --------------------------+----------------------------- Reporter: mercime | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Core | Version: Severity: normal | Keywords: --------------------------+----------------------------- Member pages and Group pages: PHP Notice: Trying to access array offset on value of type int in https://example.com/wp-includes/formatting.php on line 904 - on WP trunk and BP trunk -- Ticket URL: BuddyPress Trac BuddyPress Trac From buddypress-trac at lists.automattic.com Thu Apr 30 18:47:03 2020 From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com) Date: Thu, 30 Apr 2020 18:47:03 +0000 (UTC) Subject: [buddypress-trac] [BuddyPress][12641] trunk/src/bp-core: Hello BuddyPress Screen: post 6.0.0-RC1 improvements Message-ID: <20200430184703.AC0141B0042C@svn1.ord.wordpress.org> An HTML attachment was scrubbed... URL: From noreply at wordpress.org Thu Apr 30 18:47:08 2020 From: noreply at wordpress.org (buddypress-trac) Date: Thu, 30 Apr 2020 18:47:08 -0000 Subject: [buddypress-trac] [BuddyPress Trac] #8270: Hello BuddyPress 6.0.0 In-Reply-To: <039.1733763d690106bcbeaba67add6dabcc@wordpress.org> References: <039.1733763d690106bcbeaba67add6dabcc@wordpress.org> Message-ID: <054.d59f8a509bd76c37282a2000111171cd@wordpress.org> #8270: Hello BuddyPress 6.0.0 ------------------------------------------+--------------------- Reporter: imath | Owner: (none) Type: task | Status: new Priority: normal | Milestone: 6.0.0 Component: Core | Version: Severity: normal | Resolution: Keywords: dev-feedback has-screenshots | ------------------------------------------+--------------------- Comment (by imath): In [changeset:"12641" 12641]: {{{ #!CommitTicketReference repository="" revision="12641" Hello BuddyPress Screen: post 6.0.0-RC1 improvements - Fix a missing `/* translators: */` comment. - Reapply image minimisation for the BP Blocks animation GIF. See #8270 }}} -- Ticket URL: BuddyPress Trac BuddyPress Trac From noreply at wordpress.org Thu Apr 30 19:01:32 2020 From: noreply at wordpress.org (buddypress-trac) Date: Thu, 30 Apr 2020 19:01:32 -0000 Subject: [buddypress-trac] =?utf-8?q?=5BBuddyPress_Trac=5D_=238289=3A_Edit?= =?utf-8?b?IHNsdWcg4oCcSG9tZeKAnSBQcm9maWxl?= Message-ID: <040.b77b73901e75cbdb6420eb34ade00e73@wordpress.org> #8289: Edit slug ā€œHomeā€ Profile -------------------------+---------------------- Reporter: sygy88 | Owner: (none) Type: enhancement | Status: assigned Priority: normal | Milestone: 5.3.0 Component: Core | Version: Severity: normal | Keywords: -------------------------+---------------------- Hi I would like to modify the ā€œSlugā€ of the profile Home page (members/user/front) is there any code to insert in the bp-custom.php file? -- Ticket URL: BuddyPress Trac BuddyPress Trac