[buddypress-trac] [BuddyPress Trac] #7714: BP-Nouveau: Keyboard focus lost in air with Messages bulk actions UI

buddypress-trac noreply at wordpress.org
Mon Mar 26 10:25:15 UTC 2018


#7714: BP-Nouveau: Keyboard focus lost in air with Messages bulk actions UI
---------------------------------------+---------------------
 Reporter:  mercime                    |       Owner:  (none)
     Type:  defect (bug)               |      Status:  new
 Priority:  normal                     |   Milestone:  3.0
Component:  Templates                  |     Version:
 Severity:  normal                     |  Resolution:
 Keywords:  has-screenshots has-patch  |
---------------------------------------+---------------------
Changes (by mercime):

 * keywords:  has-screenshots => has-screenshots has-patch


Comment:

 In attached patch, kept most of the original structure and made the
 following changes to fix the focus jump along with some other
 enhancements:
 - Removed the `bp-screen-reader-text` class from the `label` of the
 `checkbox` for some words
 - Added `.bp-hide` and `.bp-show` classes for `.bulk-actions-wrap` div  in
 buddypress-messages.js
 - Removed the nesting of the `checkbox` within the `label` element for
 both the bulk action and the message threads
 - Moved the `li.user-messages-bulk-actions` to after the `li.user-
 messages-search` so that the bulk actions will be closer to the message
 thread on desktop and especially on mobile view. See attached  messages-
 bulk-action-fix-mobile.gif and  messages-bulk-action-fix-desktop.gif
 attached.
 - Added style support for above-mentioned.

 For review/comments.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7714#comment:4>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list